)]}'
{".zuul.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      - starlingx/config"},{"line_number":22,"context_line":"      - starlingx/fault"},{"line_number":23,"context_line":"      - starlingx/update"},{"line_number":24,"context_line":"      - starlingx/utilities"},{"line_number":25,"context_line":"    files:"},{"line_number":26,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"},{"line_number":27,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f9aafb8_1ff864c2","line":24,"updated":"2023-08-10 18:59:42.000000000","message":"add:\n    - starlingx/root","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      - starlingx/config"},{"line_number":22,"context_line":"      - starlingx/fault"},{"line_number":23,"context_line":"      - starlingx/update"},{"line_number":24,"context_line":"      - starlingx/utilities"},{"line_number":25,"context_line":"    files:"},{"line_number":26,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"},{"line_number":27,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"87052e91_f3ff69c0","line":24,"in_reply_to":"3f9aafb8_1ff864c2","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"},{"line_number":27,"context_line":"    vars:"},{"line_number":28,"context_line":"        tox_envlist: py39"},{"line_number":29,"context_line":"        python_version: 3.9"},{"line_number":30,"context_line":"        tox_extra_args: -c python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/tox.ini"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"edc0c12b_b52a0e35","line":29,"updated":"2023-08-10 18:59:42.000000000","message":"remove, tox.ini should specify py3.9 explicitly","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"},{"line_number":27,"context_line":"    vars:"},{"line_number":28,"context_line":"        tox_envlist: py39"},{"line_number":29,"context_line":"        python_version: 3.9"},{"line_number":30,"context_line":"        tox_extra_args: -c python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/tox.ini"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ea8140ac_5d1cdc98","line":29,"in_reply_to":"edc0c12b_b52a0e35","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        tox_envlist: py39"},{"line_number":29,"context_line":"        python_version: 3.9"},{"line_number":30,"context_line":"        tox_extra_args: -c python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/tox.ini"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- job:"},{"line_number":33,"context_line":"    name: k8sapp-intel-ethernet-operator-tox-pylint"},{"line_number":34,"context_line":"    parent: tox"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"43d836bc_4e901101","line":31,"updated":"2023-08-10 18:59:42.000000000","message":"add:\n\n        tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/starlingx/root/build-tools/requirements/debian/upper-constraints.txt\u0027","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        tox_envlist: py39"},{"line_number":29,"context_line":"        python_version: 3.9"},{"line_number":30,"context_line":"        tox_extra_args: -c python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/tox.ini"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- job:"},{"line_number":33,"context_line":"    name: k8sapp-intel-ethernet-operator-tox-pylint"},{"line_number":34,"context_line":"    parent: tox"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4379389b_11705e64","line":31,"in_reply_to":"43d836bc_4e901101","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      - starlingx/config"},{"line_number":39,"context_line":"      - starlingx/fault"},{"line_number":40,"context_line":"      - starlingx/update"},{"line_number":41,"context_line":"      - starlingx/utilities"},{"line_number":42,"context_line":"    nodeset: ubuntu-focal"},{"line_number":43,"context_line":"    files:"},{"line_number":44,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"03b2acf0_58b6190e","line":41,"updated":"2023-08-10 18:59:42.000000000","message":"add:\n    - starlingx/root","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      - starlingx/config"},{"line_number":39,"context_line":"      - starlingx/fault"},{"line_number":40,"context_line":"      - starlingx/update"},{"line_number":41,"context_line":"      - starlingx/utilities"},{"line_number":42,"context_line":"    nodeset: ubuntu-focal"},{"line_number":43,"context_line":"    files:"},{"line_number":44,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"bdee3f2f_91ed9553","line":41,"in_reply_to":"03b2acf0_58b6190e","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":39,"context_line":"      - starlingx/fault"},{"line_number":40,"context_line":"      - starlingx/update"},{"line_number":41,"context_line":"      - starlingx/utilities"},{"line_number":42,"context_line":"    nodeset: ubuntu-focal"},{"line_number":43,"context_line":"    files:"},{"line_number":44,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"},{"line_number":45,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"d31a0f93_ee351ce6","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":25},"updated":"2023-08-10 18:59:42.000000000","message":"change to: \n    debian-bullseye","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      - starlingx/fault"},{"line_number":40,"context_line":"      - starlingx/update"},{"line_number":41,"context_line":"      - starlingx/utilities"},{"line_number":42,"context_line":"    nodeset: ubuntu-focal"},{"line_number":43,"context_line":"    files:"},{"line_number":44,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"},{"line_number":45,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"75dd2bdb_3e19f96d","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":25},"in_reply_to":"d31a0f93_ee351ce6","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":44,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"},{"line_number":45,"context_line":"    vars:"},{"line_number":46,"context_line":"      tox_envlist: pylint"},{"line_number":47,"context_line":"      tox_extra_args: -c python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/tox.ini"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"f96e4e67_df66856e","line":47,"updated":"2023-08-10 18:59:42.000000000","message":"add \n\n        tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/starlingx/root/build-tools/requirements/debian/upper-constraints.txt\u0027","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      - python3-k8sapp-intel-ethernet-operator/*"},{"line_number":45,"context_line":"    vars:"},{"line_number":46,"context_line":"      tox_envlist: pylint"},{"line_number":47,"context_line":"      tox_extra_args: -c python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/tox.ini"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"050c36a2_3423b349","line":47,"in_reply_to":"f96e4e67_df66856e","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - openstack-tox-linters"},{"line_number":6,"context_line":"        - k8sapp-intel-ethernet-operator-tox-py39"},{"line_number":7,"context_line":"        - k8sapp-intel-ethernet-operator-tox-pylint"},{"line_number":8,"context_line":"    gate:"},{"line_number":9,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3d18b81e_41a585d0","line":6,"updated":"2023-08-25 05:55:58.000000000","message":"add:\n\n    - k8sapp-intel-ethernet-operator-tox-flake8","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - openstack-tox-linters"},{"line_number":6,"context_line":"        - k8sapp-intel-ethernet-operator-tox-py39"},{"line_number":7,"context_line":"        - k8sapp-intel-ethernet-operator-tox-pylint"},{"line_number":8,"context_line":"    gate:"},{"line_number":9,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bc141003_3480b065","line":6,"in_reply_to":"3d18b81e_41a585d0","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    gate:"},{"line_number":9,"context_line":"      jobs:"},{"line_number":10,"context_line":"        - openstack-tox-linters"},{"line_number":11,"context_line":"        - k8sapp-intel-ethernet-operator-tox-py39"},{"line_number":12,"context_line":"        - k8sapp-intel-ethernet-operator-tox-pylint"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"a569a801_5c29bc3c","line":11,"updated":"2023-08-25 05:55:58.000000000","message":"add:\n\n    - k8sapp-intel-ethernet-operator-tox-flake8","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    gate:"},{"line_number":9,"context_line":"      jobs:"},{"line_number":10,"context_line":"        - openstack-tox-linters"},{"line_number":11,"context_line":"        - k8sapp-intel-ethernet-operator-tox-py39"},{"line_number":12,"context_line":"        - k8sapp-intel-ethernet-operator-tox-pylint"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"8e6228e5_af186b34","line":11,"in_reply_to":"a569a801_5c29bc3c","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"        - k8sapp-intel-ethernet-operator-tox-py39"},{"line_number":12,"context_line":"        - k8sapp-intel-ethernet-operator-tox-pylint"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- job:"},{"line_number":15,"context_line":"    name: k8sapp-intel-ethernet-operator-tox-py39"},{"line_number":16,"context_line":"    parent: tox-py39"},{"line_number":17,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"8c962499_a5158cb0","line":14,"updated":"2023-08-25 05:55:58.000000000","message":"add:\n\n    - job:\n        name: k8sapp-intel-ethernet-operator-tox-flake8\n        parent: tox\n        description: |\n            Run flake8 for intel-ethernet-operator\n        nodeset: debian-bullseye\n        files:\n          - python3-k8sapp-intel-ethernet-operator/*\n        vars:\n            tox_envlist: flake8\n            tox_extra_args: -c python3-k8sapp-intel-ethernet-operator/k8sapp-intel-ethernet-operator/tox.ini","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        - k8sapp-intel-ethernet-operator-tox-py39"},{"line_number":12,"context_line":"        - k8sapp-intel-ethernet-operator-tox-pylint"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- job:"},{"line_number":15,"context_line":"    name: k8sapp-intel-ethernet-operator-tox-py39"},{"line_number":16,"context_line":"    parent: tox-py39"},{"line_number":17,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"82b55140_afcb21e3","line":14,"in_reply_to":"8c962499_a5158cb0","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"/COMMIT_MSG":[{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"fcdb1f5728a808ee185bb81bbb64249932ed13f0","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Test Status:"},{"line_number":17,"context_line":"- PASS: Build application .deb, generate tarball, copy to stx active"},{"line_number":18,"context_line":"  controller."},{"line_number":19,"context_line":"- PASS: Build UFT image using included scripts, image is built properly"},{"line_number":20,"context_line":"  with provided patch applied."},{"line_number":21,"context_line":"- PASS: Verify that app is uploaded, applied and ethernet operator as"},{"line_number":22,"context_line":"  well as dependencies pods are created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ef055207_5f7cb596","line":19,"updated":"2023-08-08 18:48:34.000000000","message":"nit: In case the readers doesn\u0027t understand acronyms, define it the first time; UTF, VF, etc..","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"017e3278e0b113dd7cb8d4bfc3dd4dbd9214b8a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Test Status:"},{"line_number":17,"context_line":"- PASS: Build application .deb, generate tarball, copy to stx active"},{"line_number":18,"context_line":"  controller."},{"line_number":19,"context_line":"- PASS: Build UFT image using included scripts, image is built properly"},{"line_number":20,"context_line":"  with provided patch applied."},{"line_number":21,"context_line":"- PASS: Verify that app is uploaded, applied and ethernet operator as"},{"line_number":22,"context_line":"  well as dependencies pods are created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"e2dfb184_2dd7daf4","line":19,"in_reply_to":"ef055207_5f7cb596","updated":"2023-08-09 11:21:23.000000000","message":"Addressed.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":28,"context_line":"  supported by operator versions."},{"line_number":29,"context_line":"- PASS: Place requested DDP (Dynamic Device Personalization) profile"},{"line_number":30,"context_line":"  in correct directory for ice driver to pick up."},{"line_number":31,"context_line":"- PASS: Create VFs (Virtual Function) using sriov-network-operator, create"},{"line_number":32,"context_line":"  FlowConfigNodeAgent deployment, verify that UFT container"},{"line_number":33,"context_line":"  is bound to VF0 of selected VFs pool."},{"line_number":34,"context_line":"- PASS: Create NodeFlowConfig and ClusterFlowConfig rules."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"8bf04fdf_abc4da46","line":31,"updated":"2023-08-25 05:55:58.000000000","message":"nit: long line","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  supported by operator versions."},{"line_number":29,"context_line":"- PASS: Place requested DDP (Dynamic Device Personalization) profile"},{"line_number":30,"context_line":"  in correct directory for ice driver to pick up."},{"line_number":31,"context_line":"- PASS: Create VFs (Virtual Function) using sriov-network-operator, create"},{"line_number":32,"context_line":"  FlowConfigNodeAgent deployment, verify that UFT container"},{"line_number":33,"context_line":"  is bound to VF0 of selected VFs pool."},{"line_number":34,"context_line":"- PASS: Create NodeFlowConfig and ClusterFlowConfig rules."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"c843470e_a175c423","line":31,"in_reply_to":"8bf04fdf_abc4da46","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"fcdb1f5728a808ee185bb81bbb64249932ed13f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"37f83612_f79e08c9","updated":"2023-08-08 18:48:34.000000000","message":"All around comment; If you don\u0027t mind cleaning up all the python files to have arguments line up and long line lengths managed, that would be great.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35446,"name":"Igor Pires Soares","display_name":"Igor Soares","email":"Igor.PiresSoares@windriver.com","username":"ipiresso"},"change_message_id":"6c9527932856eaec8ecf722df4a7707c3d4cfca1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d32bc5e5_79a327d6","updated":"2023-08-08 18:14:23.000000000","message":"This follows the overall application framework standards. Just left a note about the namespace creation. Will +2 when the developer confirms that the namespace has been correctly labeled.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"017e3278e0b113dd7cb8d4bfc3dd4dbd9214b8a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5f76fccd_e41cef46","updated":"2023-08-09 11:21:23.000000000","message":"Thank you for review. Addressed your comments.","commit_id":"735cd9d4d8a2fb1687c9f25262a816ba7884df6c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"02165859ccf3e19813307b16b5f9d23de4b16c79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"cc09ee0b_735a52c1","updated":"2023-08-10 19:31:28.000000000","message":"- Is this a custom chart or a copy of an upstream chart?\n- If this is a copy of an upstream chart, we prefer to create a package pointing to a repo that contains the upstream chart and patch the chart accordingly to fit the StarlingX requirements. See platform-armada-app, app-dell-storage, openstack-armada-app as examples.\n- If this ia a custom chart, where are the crds/resource yamls from? Ideally we would want to be able to track to an upstream version and provide additional context on how these are generated/copied so that the next upversion can be managed/scheduled when the platform dependencies changes (k8s APIs, etc). Please Add a README file that provides the information when \"helm show readme [CHART] [flags]\" is executed against the chart","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9f8c8476967c137251829caa56e280ada389f9cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"84ddf68e_1943f2b5","updated":"2023-08-09 20:20:37.000000000","message":"Need time to review.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"ce58f4ec228a8fd44ddd7c9d4a2ae0b1fc51ee52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"cb70e0fc_d1ee6b68","updated":"2023-08-09 14:32:38.000000000","message":"Thanks for making changes! +2","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ccaba043_dda73b8f","in_reply_to":"7d8539fb_250cd902","updated":"2023-08-25 16:23:12.000000000","message":"I fully understand maintainability argument, but unfortunately we don\u0027t have ethernet-operator chart available upstream as of right now. I will add a brief README with requested content. To answer last question, yes there is a plan to release upstream helm charts so there won\u0027t be any special considerations in the future upgrades.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7d8539fb_250cd902","in_reply_to":"871a0e65_e69f881c","updated":"2023-08-25 05:55:58.000000000","message":"Thanks for integrating the upstream chart. Same question hold for the intel-ethernet-operator chart. \n\nMy requests are coming from the standpoint of maintainability and needing to make future updates as every release we must evaluate if an application needs to be upgraded based on changes in the platform (OS, k8s, container runtime, etc) or changes made upstream to include new features or container CVE fixes. \n\nI\u0027m assuming that this chart is somehow generated from the content in this repo, https://github.com/intel/intel-ethernet-operator, and that there is NOT an upstream helm chart available for integration\n\nIf that\u0027s the case, can you please add a .../stx-intel-ethernet-operator-helm/helm-charts/intel-ethernet-operator/README.md file that has:\n\n - The source of the chart content (directories within the repo if applicable) or if they are generated somehow, how this is accomplished\n - The release tag that this is based on (i.e. https://github.com/intel/intel-ethernet-operator/releases/tag/v23.07)\n - A basic example of a helm install command to use the chart.\n - Any special considerations that need to be considerations when upgrading in the future.\n \nYou can validate the output of the README, by uploading the application and executing:\n\n    helm show readme stx-platform/intel-ethernet-operator\n    \nIf there is not an upstream helm chart are you considering contributing this chart upstream?","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"9f9ecdeac69a3526cad98a495f8e2dbd81d7c314","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e11ca14f_d0689ac8","in_reply_to":"cb70e0fc_d1ee6b68","updated":"2023-08-09 14:38:30.000000000","message":"Sorry for a lot of patchsets. After making changes zuul started to fail and I was looking what particular change that was causing failure. Turns out issue was dead link used by zuul on ubuntu bionic nodeset.\n\nhttps://mirror-int.dfw.rax.opendev.org:443 \"GET /wheel/ubuntu-18.04-x86_64/pip/ HTTP/1.1\" 404 196\nStatus code 404 not in (200, 203, 300, 301)\n\nChanging nodeset for tox-pylint to ubuntu focal resolved issue.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"871a0e65_e69f881c","in_reply_to":"cc09ee0b_735a52c1","updated":"2023-08-16 14:14:10.000000000","message":"Sriov network operator is copy of upstream chart so the second point applies. I\u0027ve managed to create package pointing to upstream repo, applied required patches and integrated this package with intel-ethernet-operator app. Final effect is that sriov-network-operator is installed alongside intel-ethernet-operator in the same namespace.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b4892e51_e8ce8f97","updated":"2023-08-16 14:14:10.000000000","message":"Thank you for the review. Addressed all your comments and changed the way sriov-network-operator is installed according to your instructions.","commit_id":"2ef45a7c06dec59ea0a562f78e3a72532351ca9e"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"0856ed06dfbf275e901ddad4b03fac56e09f0839","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"06b90152_5f7ea1f8","updated":"2023-08-17 15:31:06.000000000","message":"LGTM, pending Bob\u0027s review","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"f4284198_d97e5e8e","updated":"2023-08-25 16:23:12.000000000","message":"Thanks for review again. Update submitted.","commit_id":"fe9ace088f03dea3984d25493460c1dd8fe0f27a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49c65faf56c3945079a42c5711915882d3db2cf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"6bb0bf48_02286b26","updated":"2023-08-28 14:49:41.000000000","message":"The core reviewer group for this repository is empty: https://review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dcc71e,members\n\nNeed to establish this group in order for this to merge. Recommend Scott/Davlet from the build team, myself and Joshua Reed for application related integration, and for networking expertise, Steve, yourself (and any others you deem needed).","commit_id":"fe8b267b30035bb59bf751e961ad37107e91e3d3"},{"author":{"_account_id":28558,"name":"Ghada Khalil","email":"ghada.khalil@windriver.com","username":"gkhalil"},"change_message_id":"ff43f82f584612a79cda15209893ddad36102450","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"b825668b_d5e0d1aa","in_reply_to":"6bb0bf48_02286b26","updated":"2023-08-28 18:25:52.000000000","message":"@Bob, I\u0027m not sure what the group you referenced is. My understanding is that the correct group for this repo is: https://review.opendev.org/admin/groups/3f9f359749b3ac5da5887b421cfe4f95927464f8,members \nwhich has Scott (build), Joshua/Igor (App Framework), Steve (networking). If you\u0027d like to be a core as well, we can have you added.","commit_id":"fe8b267b30035bb59bf751e961ad37107e91e3d3"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"3306965157dd5a06e376dd4e1a8e806a3ad75c3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"25a6f059_3c73b6bf","in_reply_to":"96720c4c_31c2706f","updated":"2023-08-28 18:57:16.000000000","message":"Ahh, right this was the repo that had an mistake when setting up the core group. Sorry, when I searched for the core group, I ended up seeing the original, incorrect, and empty group. All good. Thanks for adding me Steve.","commit_id":"fe8b267b30035bb59bf751e961ad37107e91e3d3"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"43cbb225d5046e98792895fafd753b51d1f75b86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"96720c4c_31c2706f","in_reply_to":"b825668b_d5e0d1aa","updated":"2023-08-28 18:40:46.000000000","message":"I have added Bob to 3f9f359749b3ac5da5887b421cfe4f95927464f8, but am also a bit confused that we have b654c6ae66bdface82b16ac7e4f322f311dcc71e (starlingx-intel-ethernet-operator-core)","commit_id":"fe8b267b30035bb59bf751e961ad37107e91e3d3"}],"CONTRIBUTING.rst":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"95727cee_62cd2114","updated":"2023-08-10 18:59:42.000000000","message":"remove file. Not needed.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"85e75277_ad9e15dd","in_reply_to":"95727cee_62cd2114","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"HACKING.rst":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d34cea44_da476d2b","updated":"2023-08-25 05:55:58.000000000","message":"File not needed. Provides no value.","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"44b09370_12d514d5","in_reply_to":"d34cea44_da476d2b","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"debian_iso_image.inc":[{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"fcdb1f5728a808ee185bb81bbb64249932ed13f0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#stx-intel-ethernet-operator-helm"},{"line_number":2,"context_line":"stx-intel-ethernet-operator-helm"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"0c6c9dbc_9834b6fd","line":1,"updated":"2023-08-08 18:48:34.000000000","message":"Remove comment.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"017e3278e0b113dd7cb8d4bfc3dd4dbd9214b8a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#stx-intel-ethernet-operator-helm"},{"line_number":2,"context_line":"stx-intel-ethernet-operator-helm"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9228f528_febdfd32","line":1,"in_reply_to":"0c6c9dbc_9834b6fd","updated":"2023-08-09 11:21:23.000000000","message":"Done","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"}],"python3-k8sapp-intel-ethernet-operator/debian/deb_folder/copyright":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":3,"context_line":"Source: https://opendev.org/starlingx/app-intel-ethernet-operator/"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Files: *"},{"line_number":6,"context_line":"Copyright: (c) 2022 Intel Corporation"},{"line_number":7,"context_line":"License: Apache-2"},{"line_number":8,"context_line":" Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":9,"context_line":" you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":18,"id":"d13622f8_2648c0d5","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":19},"updated":"2023-08-10 18:59:42.000000000","message":"\"2022\" -\u003e \"2023\"? here and below?","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Source: https://opendev.org/starlingx/app-intel-ethernet-operator/"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Files: *"},{"line_number":6,"context_line":"Copyright: (c) 2022 Intel Corporation"},{"line_number":7,"context_line":"License: Apache-2"},{"line_number":8,"context_line":" Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":9,"context_line":" you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":18,"id":"e7258098_0121a507","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":19},"in_reply_to":"d13622f8_2648c0d5","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"python3-k8sapp-intel-ethernet-operator/debian/deb_folder/rules":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":16,"context_line":"\tdh $@ --with\u003dpython3 --buildsystem\u003dpybuild"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"override_dh_auto_install:"},{"line_number":19,"context_line":"\tenv | sort"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\tpython3 setup.py install \\"},{"line_number":22,"context_line":"\t    --install-layout\u003ddeb \\"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"b7069a01_6bcd3116","line":19,"updated":"2023-08-10 18:59:42.000000000","message":"remove: not needed.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\tdh $@ --with\u003dpython3 --buildsystem\u003dpybuild"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"override_dh_auto_install:"},{"line_number":19,"context_line":"\tenv | sort"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\tpython3 setup.py install \\"},{"line_number":22,"context_line":"\t    --install-layout\u003ddeb \\"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"6b8b1c8d_80b83768","line":19,"in_reply_to":"b7069a01_6bcd3116","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"python3-k8sapp-intel-ethernet-operator/debian/meta_data.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"273a641d_e0f8375a","line":8,"updated":"2023-08-10 18:59:42.000000000","message":"Add so that the packages delivering the app components are auto-incremented with repo changes\n\n    GITREVCOUNT:\n      BASE_SRCREV: 8a65e4b96d2b33ae05c56086ac0a5df3b187ebfd\n      SRC_DIR: ${MY_REPO}/stx/app-intel-ethernet-operator","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"0ba41255_bcb53e57","line":8,"in_reply_to":"273a641d_e0f8375a","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/k8sapp_intel_ethernet_operator/common/constants.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ETHERNET_OPERATOR_PRESENT_LABEL \u003d \"ethernet.intel.com/intel-ethernet-present\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ALT_FW_SEARCH_PATH_DISABLE_JOB \u003d {"},{"line_number":31,"context_line":"    \"apiVersion\": \"batch/v1\","},{"line_number":32,"context_line":"    \"kind\": \"Job\","},{"line_number":33,"context_line":"    \"metadata\": {"}],"source_content_type":"text/x-python","patch_set":18,"id":"12cffa40_907f501e","line":30,"updated":"2023-08-10 18:59:42.000000000","message":"Rather than doing this in the plugins have you considered leveraging: https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ETHERNET_OPERATOR_PRESENT_LABEL \u003d \"ethernet.intel.com/intel-ethernet-present\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ALT_FW_SEARCH_PATH_DISABLE_JOB \u003d {"},{"line_number":31,"context_line":"    \"apiVersion\": \"batch/v1\","},{"line_number":32,"context_line":"    \"kind\": \"Job\","},{"line_number":33,"context_line":"    \"metadata\": {"}],"source_content_type":"text/x-python","patch_set":18,"id":"4b01d086_ddf3f93b","line":30,"in_reply_to":"12cffa40_907f501e","updated":"2023-08-16 14:14:10.000000000","message":"Yes, we considered it. We want to keep our application images as universal as possible without platform specific solutions. initContainers are used as a way to enable customized firmware search path because this way fw path will be persistent across reboots, if there would be any way to enable it using this lifecycle we really would prefer that. This job is created in namespace that will be deleted few seconds later so it won\u0027t leave any residue. Hope that\u0027s ok.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ETHERNET_OPERATOR_PRESENT_LABEL \u003d \"ethernet.intel.com/intel-ethernet-present\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ALT_FW_SEARCH_PATH_DISABLE_JOB \u003d {"},{"line_number":31,"context_line":"    \"apiVersion\": \"batch/v1\","},{"line_number":32,"context_line":"    \"kind\": \"Job\","},{"line_number":33,"context_line":"    \"metadata\": {"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf8db2a2_763c8fcb","line":30,"in_reply_to":"4b01d086_ddf3f93b","updated":"2023-08-25 05:55:58.000000000","message":"This is fine. Just wanted to point out a more standardized way of doing this.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ETHERNET_OPERATOR_PRESENT_LABEL \u003d \"ethernet.intel.com/intel-ethernet-present\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ALT_FW_SEARCH_PATH_DISABLE_JOB \u003d {"},{"line_number":31,"context_line":"    \"apiVersion\": \"batch/v1\","},{"line_number":32,"context_line":"    \"kind\": \"Job\","},{"line_number":33,"context_line":"    \"metadata\": {"}],"source_content_type":"text/x-python","patch_set":18,"id":"4f9a5302_d96bd8ec","line":30,"in_reply_to":"bf8db2a2_763c8fcb","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":40,"context_line":"                \"containers\": ["},{"line_number":41,"context_line":"                    {"},{"line_number":42,"context_line":"                        \"name\": \"alt-fw-search-path-disabler\","},{"line_number":43,"context_line":"                        \"image\": \"registry.access.redhat.com/ubi9/ubi-micro:9.2-5\","},{"line_number":44,"context_line":"                        \"command\": ["},{"line_number":45,"context_line":"                            \"/bin/bash\","},{"line_number":46,"context_line":"                            \"-c\","}],"source_content_type":"text/x-python","patch_set":18,"id":"91ddfd94_ab3747e5","line":43,"updated":"2023-08-10 18:59:42.000000000","message":"This registy is not suported as a docker proxy in the system. Need an update similar to https://opendev.org/starlingx/config/commit/ee9b3e21b9cf721872fc143ac1c23044933f6720 or consider using a different image that is availale from one of the existing supported proxies.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \"containers\": ["},{"line_number":41,"context_line":"                    {"},{"line_number":42,"context_line":"                        \"name\": \"alt-fw-search-path-disabler\","},{"line_number":43,"context_line":"                        \"image\": \"registry.access.redhat.com/ubi9/ubi-micro:9.2-5\","},{"line_number":44,"context_line":"                        \"command\": ["},{"line_number":45,"context_line":"                            \"/bin/bash\","},{"line_number":46,"context_line":"                            \"-c\","}],"source_content_type":"text/x-python","patch_set":18,"id":"70d630a1_6831626e","line":43,"in_reply_to":"91ddfd94_ab3747e5","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/k8sapp_intel_ethernet_operator/helm/intel_ethernet_operator.py":[{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"fcdb1f5728a808ee185bb81bbb64249932ed13f0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        [app_constants.HELM_NS_INTEL_ETHERNET_OPERATOR]"},{"line_number":14,"context_line":"    SUPPORTED_APP_NAMESPACES \u003d {"},{"line_number":15,"context_line":"        app_constants.HELM_APP_INTEL_ETHERNET_OPERATOR:"},{"line_number":16,"context_line":"            base.BaseHelm.SUPPORTED_NAMESPACES + "},{"line_number":17,"context_line":"            [app_constants.HELM_NS_INTEL_ETHERNET_OPERATOR],"},{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"e205d1c2_2b3584d3","line":16,"updated":"2023-08-08 18:48:34.000000000","message":"nit: Trailing whitespace.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"017e3278e0b113dd7cb8d4bfc3dd4dbd9214b8a4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        [app_constants.HELM_NS_INTEL_ETHERNET_OPERATOR]"},{"line_number":14,"context_line":"    SUPPORTED_APP_NAMESPACES \u003d {"},{"line_number":15,"context_line":"        app_constants.HELM_APP_INTEL_ETHERNET_OPERATOR:"},{"line_number":16,"context_line":"            base.BaseHelm.SUPPORTED_NAMESPACES + "},{"line_number":17,"context_line":"            [app_constants.HELM_NS_INTEL_ETHERNET_OPERATOR],"},{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa969803_5856561e","line":16,"in_reply_to":"e205d1c2_2b3584d3","updated":"2023-08-09 11:21:23.000000000","message":"Done","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"from k8sapp_intel_ethernet_operator.common import constants as app_constants"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"class IntelEthernetOperatorHelm(base.BaseHelm):"},{"line_number":11,"context_line":"    \"\"\"Class to encapsulate helm operations for the Intel Ethernet Operator chart\"\"\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    SUPPORTED_NAMESPACES \u003d base.BaseHelm.SUPPORTED_NAMESPACES + ["}],"source_content_type":"text/x-python","patch_set":22,"id":"397d72e0_e7ce88e1","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":45},"updated":"2023-08-25 05:55:58.000000000","message":"base.FluxCDBaseHelm","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":7,"context_line":"from k8sapp_intel_ethernet_operator.common import constants as app_constants"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"class IntelEthernetOperatorHelm(base.BaseHelm):"},{"line_number":11,"context_line":"    \"\"\"Class to encapsulate helm operations for the Intel Ethernet Operator chart\"\"\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    SUPPORTED_NAMESPACES \u003d base.BaseHelm.SUPPORTED_NAMESPACES + ["}],"source_content_type":"text/x-python","patch_set":22,"id":"25233496_6964e965","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":45},"in_reply_to":"397d72e0_e7ce88e1","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/k8sapp_intel_ethernet_operator/tests/test_intel_ethernet_operator.py":[{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"fcdb1f5728a808ee185bb81bbb64249932ed13f0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"from sysinv.tests.helm import base"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"class IntelEthernetOperatorTestCase(test_plugins.K8SAppIntelEthernetOperatorAppMixin,"},{"line_number":13,"context_line":"                    base.HelmTestCaseMixin):"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"82e63158_6d711be5","line":12,"updated":"2023-08-08 18:48:34.000000000","message":"Please clean up this file so the arguments are aligned and lines are not too long.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"017e3278e0b113dd7cb8d4bfc3dd4dbd9214b8a4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"from sysinv.tests.helm import base"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"class IntelEthernetOperatorTestCase(test_plugins.K8SAppIntelEthernetOperatorAppMixin,"},{"line_number":13,"context_line":"                    base.HelmTestCaseMixin):"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"b7ce1d20_0b2d06cc","line":12,"in_reply_to":"82e63158_6d711be5","updated":"2023-08-09 11:21:23.000000000","message":"Done","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"}],"python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/k8sapp_intel_ethernet_operator/tests/test_plugins.py":[{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"fcdb1f5728a808ee185bb81bbb64249932ed13f0","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"class K8SAppIntelEthernetOperatorAppMixin(object):"},{"line_number":10,"context_line":"    app_name \u003d app_constants.HELM_APP_INTEL_ETHERNET_OPERATOR"},{"line_number":11,"context_line":"    path_name \u003d app_name + \u0027.tgz\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"d8c9bead_f19231df","line":10,"updated":"2023-08-08 18:48:34.000000000","message":"If variables are unused, then remove. If used in a child class, then add to class attrs; eg self.foo \u003d bar.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"017e3278e0b113dd7cb8d4bfc3dd4dbd9214b8a4","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"class K8SAppIntelEthernetOperatorAppMixin(object):"},{"line_number":10,"context_line":"    app_name \u003d app_constants.HELM_APP_INTEL_ETHERNET_OPERATOR"},{"line_number":11,"context_line":"    path_name \u003d app_name + \u0027.tgz\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"effe977d_bd25816f","line":10,"in_reply_to":"d8c9bead_f19231df","updated":"2023-08-09 11:21:23.000000000","message":"Done","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"}],"python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/pylint.rc":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"04544f1c_7958ec3e","updated":"2023-08-10 18:59:42.000000000","message":"This should have the same content as https://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/pylint.rc","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b652cf20_6e3db189","in_reply_to":"04544f1c_7958ec3e","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/setup.py":[{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"fcdb1f5728a808ee185bb81bbb64249932ed13f0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"import setuptools"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"setuptools.setup("},{"line_number":7,"context_line":"    setup_requires\u003d[\u0027pbr\u003e\u003d2.0.0\u0027],"},{"line_number":8,"context_line":"    pbr\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"07de564e_7d280e39","line":7,"updated":"2023-08-08 18:48:34.000000000","message":"Make sure this setup.py and the requirements.txt match.  Here it says pvr\u003e2.0.0 but in the requirements file its pbr\u003e\u003d0.5.  Optional - Can feed the requirements file to the setup.py.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"017e3278e0b113dd7cb8d4bfc3dd4dbd9214b8a4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"import setuptools"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"setuptools.setup("},{"line_number":7,"context_line":"    setup_requires\u003d[\u0027pbr\u003e\u003d2.0.0\u0027],"},{"line_number":8,"context_line":"    pbr\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ae3dc358_818791d4","line":7,"in_reply_to":"07de564e_7d280e39","updated":"2023-08-09 11:21:23.000000000","message":"Done","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"}],"python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/test-requirements.txt":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d09b2833_0caf349a","updated":"2023-08-10 18:59:42.000000000","message":"This should have the same contents as: https://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/test-requirements.txt","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b66fe31f_c1f1eff3","in_reply_to":"d09b2833_0caf349a","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"python3-k8sapp-intel-ethernet-operator/k8sapp_intel_ethernet_operator/tox.ini":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"bd691e3c_e97a1b16","updated":"2023-08-10 18:59:42.000000000","message":"This should align very closely to the latest changes here: https://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/tox.ini","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9a9798c6_b731316f","in_reply_to":"bd691e3c_e97a1b16","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"sriov-network-operator-helm/debian/deb_folder/patches/0001-sriov-network-operator-delete-existing-crd.patch":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"4c62341a_f9feef4a","updated":"2023-08-25 05:55:58.000000000","message":"We prefer patches to be generated using \"git format-patch\" containing a proper commit message explaining the change and containing a \"Signed-off-by:\"\n\nIs the plan to upstream this fix to the upstream helm charts so we can drop the\npatch in the future? Ideally, we want to include a helm chart without patches and just use overrides to integrate into StarlingX\n\nPlease include a URL for the opened upstream issue/pull request for tracability so we can track this patch removal in the future","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7a069c5e_40234750","in_reply_to":"4c62341a_f9feef4a","updated":"2023-08-25 16:23:12.000000000","message":"Modified patches as requested.","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"sriov-network-operator-helm/debian/deb_folder/patches/0002-sriov-network-operator-fix-pull-image-error.patch":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"5886cf9c_fd9b052f","updated":"2023-08-25 05:55:58.000000000","message":"We prefer patches to be generated using \"git format-patch\" containing a proper commit message explaining the change and containing a \"Signed-off-by:\"\n\nIs the plan to upstream a fix to the upstream helm charts so we can drop the\npatch in the future? Ideally, we want to include a helm chart without patches and just use overrides to integrate into StarlingX\n\nPlease include a URL for the opened upstream issue/pull request for tracability so we can track this patch removal in the future?","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"160d927c_83c24745","in_reply_to":"5886cf9c_fd9b052f","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"sriov-network-operator-helm/debian/deb_folder/rules":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":8,"context_line":"\tdh $@"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"override_dh_auto_build:"},{"line_number":11,"context_line":"\t"},{"line_number":12,"context_line":"\tmkdir -p sriov-network-operator"},{"line_number":13,"context_line":"\tmv Chart.yaml README.md crds templates values.yaml sriov-network-operator"},{"line_number":14,"context_line":"\tmake sriov-network-operator"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"6008f643_5807ebc0","line":11,"updated":"2023-08-25 05:55:58.000000000","message":"nit: remove unecessary whitespace","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\tdh $@"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"override_dh_auto_build:"},{"line_number":11,"context_line":"\t"},{"line_number":12,"context_line":"\tmkdir -p sriov-network-operator"},{"line_number":13,"context_line":"\tmv Chart.yaml README.md crds templates values.yaml sriov-network-operator"},{"line_number":14,"context_line":"\tmake sriov-network-operator"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"47866bb2_d5341b09","line":11,"in_reply_to":"6008f643_5807ebc0","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"sriov-network-operator-helm/sriov-network-operator-helm/files/Makefile":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"init-%:"},{"line_number":27,"context_line":"\tif [ -f $*/Makefile ]; then make -C $*; fi"},{"line_number":28,"context_line":"\tif [ -f $*/requirements.yaml ]; then helm dep up $*; fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"lint-%: init-%"},{"line_number":31,"context_line":"\tif [ -d $* ]; then helm lint $*; fi"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"b8bedadd_46f81a21","line":28,"updated":"2023-08-25 05:55:58.000000000","message":"remove this and the NFD dependency in Chart.yaml can be included","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49c65faf56c3945079a42c5711915882d3db2cf9","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"init-%:"},{"line_number":27,"context_line":"\tif [ -f $*/Makefile ]; then make -C $*; fi"},{"line_number":28,"context_line":"\tif [ -f $*/requirements.yaml ]; then helm dep up $*; fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"lint-%: init-%"},{"line_number":31,"context_line":"\tif [ -d $* ]; then helm lint $*; fi"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"7235167b_44fa6b9d","line":28,"in_reply_to":"552480a8_f21a0f84","updated":"2023-08-28 14:49:41.000000000","message":"Confirmed in my build env. OK to remove the dependencies from Chart.yaml to allow successful build","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"0a99d0b20713535a1020486e63b1b28199ed6188","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"init-%:"},{"line_number":27,"context_line":"\tif [ -f $*/Makefile ]; then make -C $*; fi"},{"line_number":28,"context_line":"\tif [ -f $*/requirements.yaml ]; then helm dep up $*; fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"lint-%: init-%"},{"line_number":31,"context_line":"\tif [ -d $* ]; then helm lint $*; fi"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"b786437e_09d377b5","line":28,"in_reply_to":"7235167b_44fa6b9d","updated":"2023-08-28 14:53:30.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"init-%:"},{"line_number":27,"context_line":"\tif [ -f $*/Makefile ]; then make -C $*; fi"},{"line_number":28,"context_line":"\tif [ -f $*/requirements.yaml ]; then helm dep up $*; fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"lint-%: init-%"},{"line_number":31,"context_line":"\tif [ -d $* ]; then helm lint $*; fi"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"552480a8_f21a0f84","line":28,"in_reply_to":"b8bedadd_46f81a21","updated":"2023-08-25 16:23:12.000000000","message":"I removed line from this Makefile and also from stx-intel-ethernet-operator-helm Makefile but build issue remains.\n\n```\n\u003d\u003d\u003d\u003d\u003d Processing [intel-ethernet-operator] chart \u003d\u003d\u003d\u003d\u003d\nmake[3]: Entering directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e/helm-charts\u0027\nif [ -d intel-ethernet-operator ]; then helm package intel-ethernet-operator; fi\nError: found in Chart.yaml, but missing in charts/ directory: node-feature-discovery, sriov-fec-operator\nmake[3]: *** [Makefile:33: build-intel-ethernet-operator] Error 1\nmake[3]: Leaving directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e/helm-charts\u0027\nmake[2]: *** [Makefile:20: intel-ethernet-operator] Error 2\nmake[2]: Leaving directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e/helm-charts\u0027\nmake[1]: *** [debian/rules:24: override_dh_auto_build] Error 2\nmake[1]: Leaving directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e\u0027\nmake: *** [debian/rules:19: build] Error 2\ndpkg-buildpackage: error: debian/rules build subprocess returned exit status 2\n```","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"stx-intel-ethernet-operator-helm/debian/deb_folder/control":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":3,"context_line":"Priority: optional"},{"line_number":4,"context_line":"Maintainer: StarlingX Developers \u003cstarlingx-discuss@lists.starlingx.io\u003e"},{"line_number":5,"context_line":"Build-Depends: debhelper-compat (\u003d 13),"},{"line_number":6,"context_line":" chartmuseum,"},{"line_number":7,"context_line":" helm,"},{"line_number":8,"context_line":" procps,"},{"line_number":9,"context_line":" python3-k8sapp-intel-ethernet-operator,"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"ae17dc17_a2104fa3","line":6,"updated":"2023-08-10 18:59:42.000000000","message":"remove. not needed as we aren\u0027t building any dependent charts that need to be staged into a temporary helm repo","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Priority: optional"},{"line_number":4,"context_line":"Maintainer: StarlingX Developers \u003cstarlingx-discuss@lists.starlingx.io\u003e"},{"line_number":5,"context_line":"Build-Depends: debhelper-compat (\u003d 13),"},{"line_number":6,"context_line":" chartmuseum,"},{"line_number":7,"context_line":" helm,"},{"line_number":8,"context_line":" procps,"},{"line_number":9,"context_line":" python3-k8sapp-intel-ethernet-operator,"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"855bde11_eab44a3d","line":6,"in_reply_to":"ae17dc17_a2104fa3","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"stx-intel-ethernet-operator-helm/debian/meta_data.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"fda40323_53daba7c","line":8,"updated":"2023-08-10 18:59:42.000000000","message":"Add so that the packages delivering the app components are auto-incremented with repo changes\n\n    GITREVCOUNT:\n      BASE_SRCREV: 8a65e4b96d2b33ae05c56086ac0a5df3b187ebfd\n      SRC_DIR: ${MY_REPO}/stx/app-intel-ethernet-operator","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4762dd18_c79050f7","line":8,"in_reply_to":"fda40323_53daba7c","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/README":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e1725506_ba7cc9dd","updated":"2023-08-25 05:55:58.000000000","message":"Remove this file","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"85dae645_89584a0a","in_reply_to":"e1725506_ba7cc9dd","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/files/index.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"5d78e89f_fa0a09d7","updated":"2023-08-10 18:59:42.000000000","message":"remove. not needed. related to chartmuseum use","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d495e286_41e90d89","in_reply_to":"5d78e89f_fa0a09d7","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/files/metadata.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"92bc9bc86ea87a084027e08145ce3bf4cabd1e58","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b3d5f3c6_cab38a51","line":9,"updated":"2023-08-09 17:31:24.000000000","message":"This app should be dependent on two other apps being uploaded/applied in the system:\n\n    behavior:\n      evaluate_reapply:\n        after:\n          - node-feature-discovery\n          - sriov-fec-operator","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"dbb700a3_404d6cd6","line":9,"in_reply_to":"508828d7_57b6e7ad","updated":"2023-08-10 18:59:42.000000000","message":"As StarlingX is highly integrated, we need to make sure that the node-feature-discovery app and sriov-fec-operator app are running with this. The application framework should detect these dependencies and not allow this app to be applied unless those are applied prior. AS the app framework currently does not complain about this, I will be opening a LP for this.\n\nBoth of those apps will install the helm charts that will be deployed. You want to make sure that the versions that are packaged there align with what is expected here.\n\nDon\u0027t apply any other apps from this app. If we need a new feature to orchestrate this, then the application framework should do this since we need to handle application updates/applies based on the state of the system. For now, I would upload/apply both apps prior upload/applying this app.\n\nThe current state of inclusion can be seen via their respective repos:\n- https://review.opendev.org/q/project:starlingx/app-sriov-fec-operator\n- https://review.opendev.org/q/project:starlingx/app-node-feature-discovery\n\nWe will need to make sire that these two apps are delivered along with this.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d252af7e_fecc13d9","line":9,"in_reply_to":"8ce67e1f_5fffd0a2","updated":"2023-08-25 05:55:58.000000000","message":"Ah.. Sorry, confused sriov-fec-operator and sriov-netowrk-operator...","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"193e672f667e8a13fe4122da1b8abb3fbea411fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"508828d7_57b6e7ad","line":9,"in_reply_to":"b3d5f3c6_cab38a51","updated":"2023-08-10 10:01:59.000000000","message":"So I should change installation of node feature discovery from helm charts that are being deployed together with ethernet operator to app-node-feature-discovery that\u0027s part of starlingx. So just upload and apply application in lifecycle hook? Should the app be uninstalled when uninstalling ethernet-operator? The second app mentioned here is sriov-fec-operator and ethernet-operator uses sriov-network-operator, as far as I\u0027m aware this operator is not integrated into starlingx.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"8ce67e1f_5fffd0a2","line":9,"in_reply_to":"dbb700a3_404d6cd6","updated":"2023-08-16 14:14:10.000000000","message":"Replied at your comment below.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/files/repositories.yaml":[{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"fcdb1f5728a808ee185bb81bbb64249932ed13f0","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  keyFile: \"\""},{"line_number":8,"context_line":"  name: local"},{"line_number":9,"context_line":"  password: \"\""},{"line_number":10,"context_line":"  url: http://127.0.0.1:8879/charts"},{"line_number":11,"context_line":"  username: \"\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a7e8b8eb_10e06eb1","line":10,"updated":"2023-08-08 18:48:34.000000000","message":"Question: What resource is this pointing to? There is no helm repository at 127.0.0.1:8879 in StarlingX that I\u0027m aware of.  Only the one hosted by lightpd; eg http://192.168.206.1:8080/helm_charts/stx-platform","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"9f9ecdeac69a3526cad98a495f8e2dbd81d7c314","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  keyFile: \"\""},{"line_number":8,"context_line":"  name: local"},{"line_number":9,"context_line":"  password: \"\""},{"line_number":10,"context_line":"  url: http://127.0.0.1:8879/charts"},{"line_number":11,"context_line":"  username: \"\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"297748ef_36442689","line":10,"in_reply_to":"05022fc0_7ed98756","updated":"2023-08-09 14:38:30.000000000","message":"It does install correctly.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":36077,"name":"Joshua Reed","display_name":"Joshua Reed","email":"joshua.reed@windriver.com","username":"jreed","status":"Wind River"},"change_message_id":"ce58f4ec228a8fd44ddd7c9d4a2ae0b1fc51ee52","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  keyFile: \"\""},{"line_number":8,"context_line":"  name: local"},{"line_number":9,"context_line":"  password: \"\""},{"line_number":10,"context_line":"  url: http://127.0.0.1:8879/charts"},{"line_number":11,"context_line":"  username: \"\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"05022fc0_7ed98756","line":10,"in_reply_to":"3c2fa75f_5d8da27f","updated":"2023-08-09 14:32:38.000000000","message":"Thanks for addressing this one. I\u0027m not entirely sure myself, but better to avoid using an address that is known to not exist.  I\u0027d just make sure its installs correctly with this change.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"017e3278e0b113dd7cb8d4bfc3dd4dbd9214b8a4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  keyFile: \"\""},{"line_number":8,"context_line":"  name: local"},{"line_number":9,"context_line":"  password: \"\""},{"line_number":10,"context_line":"  url: http://127.0.0.1:8879/charts"},{"line_number":11,"context_line":"  username: \"\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3c2fa75f_5d8da27f","line":10,"in_reply_to":"a7e8b8eb_10e06eb1","updated":"2023-08-09 11:21:23.000000000","message":"$ helm repo list\n NAME            URL\n stx-platform    http://127.0.0.1:8080/helm_charts/stx-platform\n starlingx       http://127.0.0.1:8080/helm_charts/starlingx\n \nThese are repositories visible on my system. Indeed they are reachable on 8080 and not on 8879. I didn\u0027t make this up though, other app repositories use this address. Example: https://opendev.org/starlingx/app-harbor/src/branch/master/stx-harbor-helm/stx-harbor-helm/files/repositories.yaml.\n\nChanged address to http://192.168.206.1:8080/helm_charts/stx-platform.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"8c2779e9_3d232b58","updated":"2023-08-10 18:59:42.000000000","message":"remove. not needed chartmuseum related","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6bfc6173_f473d837","in_reply_to":"8c2779e9_3d232b58","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/fluxcd-manifests/base/kustomization.yaml":[{"author":{"_account_id":35446,"name":"Igor Pires Soares","display_name":"Igor Soares","email":"Igor.PiresSoares@windriver.com","username":"ipiresso"},"change_message_id":"6c9527932856eaec8ecf722df4a7707c3d4cfca1","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# Copyright (c) 2023 Intel Corporation"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"resources:"},{"line_number":5,"context_line":"  - helmrepository.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"85669619_9dba6340","line":5,"updated":"2023-08-08 18:14:23.000000000","message":"The namespace.yaml is not added to the resource list here. Please, make sure that the namespace manifest is being applied and that the created namespace has been properly labeled. While some apps do not include the namespace manifest here, it may be necessary to do so because of the \"control-plane\" label.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"017e3278e0b113dd7cb8d4bfc3dd4dbd9214b8a4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Copyright (c) 2023 Intel Corporation"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"resources:"},{"line_number":5,"context_line":"  - helmrepository.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4103fddd_24f2469d","line":5,"in_reply_to":"85669619_9dba6340","updated":"2023-08-09 11:21:23.000000000","message":"Namespace label was indeed missing. Added that manifest to resources and now namespace is properly labeled.","commit_id":"bf94a8b96fa46b583bd2ed39f14d17b437462c42"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"resources:"},{"line_number":5,"context_line":"  - helmrepository.yaml"},{"line_number":6,"context_line":"  - namespace.yaml"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0fe545b4_b22d4138","line":6,"updated":"2023-08-10 18:59:42.000000000","message":"remove namespace.yaml from this list. the yaml itself is fine. just remove it from here.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"resources:"},{"line_number":5,"context_line":"  - helmrepository.yaml"},{"line_number":6,"context_line":"  - namespace.yaml"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"78ab5a54_632f5cc6","line":6,"in_reply_to":"0fe545b4_b22d4138","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (c) 2023 Intel Corporation"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"resources:"},{"line_number":5,"context_line":"  - helmrepository.yaml"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"cc42b367_5308b221","line":3,"updated":"2023-08-25 05:55:58.000000000","message":"add:\n\n    apiVersion: kustomize.config.k8s.io/v1beta1\n    kind: Kustomization","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (c) 2023 Intel Corporation"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"resources:"},{"line_number":5,"context_line":"  - helmrepository.yaml"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"141448bb_e28f3266","line":3,"in_reply_to":"cc42b367_5308b221","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/fluxcd-manifests/intel-ethernet-operator/helmrelease.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  chart:"},{"line_number":13,"context_line":"    spec:"},{"line_number":14,"context_line":"      chart: intel-ethernet-operator"},{"line_number":15,"context_line":"      version: 0.1.0"},{"line_number":16,"context_line":"      sourceRef:"},{"line_number":17,"context_line":"        kind: HelmRepository"},{"line_number":18,"context_line":"        name: stx-platform"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"a896a2cf_2f43733d","line":15,"updated":"2023-08-10 18:59:42.000000000","message":"Should be 1.0.0 based on the chart value","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  chart:"},{"line_number":13,"context_line":"    spec:"},{"line_number":14,"context_line":"      chart: intel-ethernet-operator"},{"line_number":15,"context_line":"      version: 0.1.0"},{"line_number":16,"context_line":"      sourceRef:"},{"line_number":17,"context_line":"        kind: HelmRepository"},{"line_number":18,"context_line":"        name: stx-platform"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"d80dc308_3a3d7f4b","line":15,"in_reply_to":"a896a2cf_2f43733d","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/fluxcd-manifests/intel-ethernet-operator/kustomization.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (c) 2023 Intel Corporation"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"namespace: intel-ethernet-operator"},{"line_number":5,"context_line":"resources:"},{"line_number":6,"context_line":"  - helmrelease.yaml"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"61835b29_55dcf62d","line":3,"updated":"2023-08-25 05:55:58.000000000","message":"add:\n\n    apiVersion: kustomize.config.k8s.io/v1beta1\n    kind: Kustomization","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (c) 2023 Intel Corporation"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"namespace: intel-ethernet-operator"},{"line_number":5,"context_line":"resources:"},{"line_number":6,"context_line":"  - helmrelease.yaml"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"b668619e_393102ba","line":3,"in_reply_to":"61835b29_55dcf62d","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/fluxcd-manifests/sriov-network-operator/kustomization.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (c) 2023 Intel Corporation"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"namespace: intel-ethernet-operator"},{"line_number":5,"context_line":"resources:"},{"line_number":6,"context_line":"  - helmrelease.yaml"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"d423ba4d_58da5fcf","line":3,"updated":"2023-08-25 05:55:58.000000000","message":"add:\n\n    apiVersion: kustomize.config.k8s.io/v1beta1\n    kind: Kustomization","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":2,"context_line":"# Copyright (c) 2023 Intel Corporation"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"namespace: intel-ethernet-operator"},{"line_number":5,"context_line":"resources:"},{"line_number":6,"context_line":"  - helmrelease.yaml"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"6529a557_af5c4497","line":3,"in_reply_to":"d423ba4d_58da5fcf","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/helm-charts/Makefile":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright (c) 2022 Intel Corporation"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":7,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"b0bc751b_a7d6b75e","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":20},"updated":"2023-08-10 18:59:42.000000000","message":"2023?","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright (c) 2022 Intel Corporation"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":7,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"6972e0f9_d1814ae2","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":20},"in_reply_to":"b0bc751b_a7d6b75e","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":9,"context_line":"SHELL :\u003d /bin/bash"},{"line_number":10,"context_line":"TASK  :\u003d build"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"EXCLUDES :\u003d helm-toolkit doc tests tools logs tmp"},{"line_number":13,"context_line":"CHARTS :\u003d helm-toolkit $(filter-out $(EXCLUDES), $(patsubst %/.,%,$(wildcard */.)))"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".PHONY: $(EXCLUDES) $(CHARTS)"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"db5d6b2b_769efd87","line":12,"updated":"2023-08-10 18:59:42.000000000","message":"helm-toolkit is not used by this app, remove references.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SHELL :\u003d /bin/bash"},{"line_number":10,"context_line":"TASK  :\u003d build"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"EXCLUDES :\u003d helm-toolkit doc tests tools logs tmp"},{"line_number":13,"context_line":"CHARTS :\u003d helm-toolkit $(filter-out $(EXCLUDES), $(patsubst %/.,%,$(wildcard */.)))"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".PHONY: $(EXCLUDES) $(CHARTS)"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"27ee697c_ba68e970","line":12,"in_reply_to":"db5d6b2b_769efd87","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"init-%:"},{"line_number":27,"context_line":"\tif [ -f $*/Makefile ]; then make -C $*; fi"},{"line_number":28,"context_line":"\tif [ -f $*/requirements.yaml ]; then helm dep up $*; fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"lint-%: init-%"},{"line_number":31,"context_line":"\tif [ -d $* ]; then helm lint $*; fi"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"c2b9d58f_ea5b476e","line":28,"updated":"2023-08-25 05:55:58.000000000","message":"Remove this line so that you can set the required dependencies relative to installed charts in Chart.yaml","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"init-%:"},{"line_number":27,"context_line":"\tif [ -f $*/Makefile ]; then make -C $*; fi"},{"line_number":28,"context_line":"\tif [ -f $*/requirements.yaml ]; then helm dep up $*; fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"lint-%: init-%"},{"line_number":31,"context_line":"\tif [ -d $* ]; then helm lint $*; fi"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"e78eca33_7e75fd25","line":28,"in_reply_to":"c2b9d58f_ea5b476e","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/helm-charts/intel-ethernet-operator/Chart.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":4,"context_line":"type: application"},{"line_number":5,"context_line":"version: 1.0.0"},{"line_number":6,"context_line":"appVersion: \"stx9.0-v2.0.0\""},{"line_number":7,"context_line":"dependencies:"},{"line_number":8,"context_line":"  - name: node-feature-discovery"},{"line_number":9,"context_line":"    version: \"0.12.1\""},{"line_number":10,"context_line":"    repository: https://github.com/kubernetes-sigs/node-feature-discovery/tree/master/deployment/helm/node-feature-discovery"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"988685c1_a5411084","line":7,"updated":"2023-08-10 18:59:42.000000000","message":"Should be the following to point to the charts from the other apps:\n\n    dependencies:\n      - name: node-feature-discovery\n        version: \"\u003e\u003d1.0\"\n        repository: http://127.0.0.1:8080/helm_charts/starlingx\n        condition: node-feature-discovery.enabled\n      - name: sriov-fec-operator\n        version: \"\u003e\u003d1.0\"\n        repository: http://127.0.0.1:8080/helm_charts/starlingx\n        condition: sriov-fec-operator.enabled\n        \n        \nand remove the \u0027charts\u0027 directory and it\u0027s contents","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"type: application"},{"line_number":5,"context_line":"version: 1.0.0"},{"line_number":6,"context_line":"appVersion: \"stx9.0-v2.0.0\""},{"line_number":7,"context_line":"dependencies:"},{"line_number":8,"context_line":"  - name: node-feature-discovery"},{"line_number":9,"context_line":"    version: \"0.12.1\""},{"line_number":10,"context_line":"    repository: https://github.com/kubernetes-sigs/node-feature-discovery/tree/master/deployment/helm/node-feature-discovery"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ef8a3862_6859e969","line":7,"in_reply_to":"988685c1_a5411084","updated":"2023-08-16 14:14:10.000000000","message":"Adding \n``` yaml\n dependencies:\n   - name: node-feature-discovery\n     version: \"\u003e\u003d1.0\"\n     repository: http://127.0.0.1:8080/helm_charts/starlingx\n     condition: node-feature-discovery.enabled\n```\ncauses build to fail with message that this chart is not found in subcharts directory.","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"type: application"},{"line_number":5,"context_line":"version: 1.0.0"},{"line_number":6,"context_line":"appVersion: \"stx9.0-v2.0.0\""},{"line_number":7,"context_line":"dependencies:"},{"line_number":8,"context_line":"  - name: node-feature-discovery"},{"line_number":9,"context_line":"    version: \"0.12.1\""},{"line_number":10,"context_line":"    repository: https://github.com/kubernetes-sigs/node-feature-discovery/tree/master/deployment/helm/node-feature-discovery"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ae182afd_8f11efd7","line":7,"in_reply_to":"ef8a3862_6859e969","updated":"2023-08-25 05:55:58.000000000","message":"If you remove the \u0027helm dep up\u0027 from the Makefile then the build will pass and this will be relevant for the installed systems","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"stx-intel-ethernet-operator-helm/stx-intel-ethernet-operator-helm/helm-charts/intel-ethernet-operator/templates/deployment.yaml":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":34,"context_line":"            - -c"},{"line_number":35,"context_line":"            - echo -n /var/lib/firmware/ \u003e /host/sys/module/firmware_class/parameters/path"},{"line_number":36,"context_line":"          name: alt-fw-search-path-enabler"},{"line_number":37,"context_line":"          image: registry.access.redhat.com/ubi9/ubi-micro:9.2-5"},{"line_number":38,"context_line":"          resources:"},{"line_number":39,"context_line":"            limits:"},{"line_number":40,"context_line":"              cpu: 200m"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"d8af4fab_5e33fceb","line":37,"updated":"2023-08-10 18:59:42.000000000","message":"This registy is not suported as a docker proxy. Need an update similar to https://opendev.org/starlingx/config/commit/ee9b3e21b9cf721872fc143ac1c23044933f6720 or consider using a different image from one of the existing supported registries","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            - -c"},{"line_number":35,"context_line":"            - echo -n /var/lib/firmware/ \u003e /host/sys/module/firmware_class/parameters/path"},{"line_number":36,"context_line":"          name: alt-fw-search-path-enabler"},{"line_number":37,"context_line":"          image: registry.access.redhat.com/ubi9/ubi-micro:9.2-5"},{"line_number":38,"context_line":"          resources:"},{"line_number":39,"context_line":"            limits:"},{"line_number":40,"context_line":"              cpu: 200m"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"f6b784a2_06da694f","line":37,"in_reply_to":"d8af4fab_5e33fceb","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"test-requirements.txt":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# hacking pulls in flake8"},{"line_number":2,"context_line":"hacking!\u003d0.13.0,\u003c0.14,\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":3,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":18,"id":"dd9b22bf_64b40b6c","line":2,"updated":"2023-08-10 18:59:42.000000000","message":"hacking\u003e\u003d1.1.0,\u003c\u003d2.0.0 # Apache-2.0","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# hacking pulls in flake8"},{"line_number":2,"context_line":"hacking!\u003d0.13.0,\u003c0.14,\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":3,"context_line":"bashate \u003e\u003d 0.2"}],"source_content_type":"text/plain","patch_set":18,"id":"f6168b07_814d2be7","line":2,"in_reply_to":"dd9b22bf_64b40b6c","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"tox.ini":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d linters"},{"line_number":3,"context_line":"minversion \u003d 2.3"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"sitepackages\u003dFalse"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-properties","patch_set":18,"id":"87725210_306fe49d","line":3,"updated":"2023-08-10 18:59:42.000000000","message":"2.9","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d linters"},{"line_number":3,"context_line":"minversion \u003d 2.3"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"sitepackages\u003dFalse"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-properties","patch_set":18,"id":"72468b07_b0562612","line":3,"in_reply_to":"87725210_306fe49d","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9e1bf705735c0c8404712422917796ac2d895437","unresolved":true,"context_lines":[{"line_number":5,"context_line":"sitepackages\u003dFalse"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"},{"line_number":8,"context_line":"install_command \u003d pip install -U {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"   OS_STDOUT_CAPTURE\u003d1"}],"source_content_type":"text/x-properties","patch_set":18,"id":"cc32e3e5_acfb698f","line":8,"updated":"2023-08-10 18:59:42.000000000","message":"install_command \u003d pip install -U \\\n        {opts} {packages} \\\n        -c{env:TOX_CONSTRAINTS_FILE:https://opendev.org/starlingx/root/raw/branch/master/build-tools/requirements/debian/upper-constraints.txt}","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"174efb6f271f8dcab1a7f504f9f2798a80d531d6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"sitepackages\u003dFalse"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"},{"line_number":8,"context_line":"install_command \u003d pip install -U {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"   OS_STDOUT_CAPTURE\u003d1"}],"source_content_type":"text/x-properties","patch_set":18,"id":"01a16a98_1680c1b3","line":8,"in_reply_to":"cc32e3e5_acfb698f","updated":"2023-08-16 14:14:10.000000000","message":"Done","commit_id":"1de9a057e62bbfeabe5ef3a56ce269e68523e7dc"}],"uft-image/files/uft-fix.patch":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"14f4d38a30c51e09b5622294ebfe689305a55b5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e68d73bb_a1cd16e8","updated":"2023-08-25 05:55:58.000000000","message":"We prefer patches to be generated using \"git format-patch\" containing a proper commit message explaining the change and containing a \"Signed-off-by:\"\n\nIs the plan to upstream this fix to the upstream project so we can drop the\npatch in the future? Ideally, we want build the image from the upstream source without carrying any patches.","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"},{"author":{"_account_id":35858,"name":"Rafal Lal","display_name":"Rafal Lal","email":"rafalx.lal@intel.com","username":"rafal-lal","status":"Intel"},"change_message_id":"e732a8c6d7fa89c600ab33871a5d9b9f1e6657be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"fe6efe40_c5206228","in_reply_to":"e68d73bb_a1cd16e8","updated":"2023-08-25 16:23:12.000000000","message":"Done","commit_id":"17ec1f7db093f906fc37f4bfd5fe26fd6122829d"}]}