)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35446,"name":"Igor Pires Soares","display_name":"Igor Soares","email":"Igor.PiresSoares@windriver.com","username":"ipiresso"},"change_message_id":"d16cad29f1e680b3286f90e777c2a6316a6ef4fb","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit upgrades the NFD application to the version 0.17.2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"TEST PLAN:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Build all packages generating an application tarball and validate"},{"line_number":14,"context_line":"      the charts\u0027 versions are correct."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8d3c7fad_7c48760e","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"updated":"2025-04-15 14:05:55.000000000","message":"Which k8s versions was this tested against?","commit_id":"93b267448ad8df1651dd11455e9499242ef6ee8e"},{"author":{"_account_id":35139,"name":"Reynaldo P Gomes","email":"Reynaldo.PatroneGomes@windriver.com","username":"reynaldopgomes"},"change_message_id":"b4987542917657c98c16b02fba0977c0afa0d8b3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit upgrades the NFD application to the version 0.17.2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"TEST PLAN:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Build all packages generating an application tarball and validate"},{"line_number":14,"context_line":"      the charts\u0027 versions are correct."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"266cf73e_27f0354b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"in_reply_to":"8d3c7fad_7c48760e","updated":"2025-04-15 18:32:39.000000000","message":"1.29.2 and 1.30.6","commit_id":"93b267448ad8df1651dd11455e9499242ef6ee8e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"13f8cbacdb53eece3072ac708a227d9c3e95d6fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8924fe3_be7edbe8","updated":"2025-04-28 15:33:17.000000000","message":"Just a minor update based on some recent standardization needs.","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"},{"author":{"_account_id":34219,"name":"Guilherme Batista Leite","email":"guilhermebatista.leite@windriver.com"},"change_message_id":"21e2cda9fedfa14cbdf66cc70bc8784af29635e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b29e48c7_09cd77df","updated":"2025-04-22 13:55:04.000000000","message":"LGTM","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"}],"helm-charts/upstream/node-feature-discovery-helm/debian/deb_folder/patches/0001-Add-label-platform-application-to-master-pod.patch":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"13f8cbacdb53eece3072ac708a227d9c3e95d6fb","unresolved":true,"context_lines":[{"line_number":21,"context_line":"     metadata:"},{"line_number":22,"context_line":"       labels:"},{"line_number":23,"context_line":"         {{- include \"node-feature-discovery.selectorLabels\" . | nindent 8 }}"},{"line_number":24,"context_line":"+        app.starlingx.io/component: {{ ternary \"application\" \"platform\" .Values.isApplicationLabel}}"},{"line_number":25,"context_line":"         role: master"},{"line_number":26,"context_line":"       annotations:"},{"line_number":27,"context_line":"+        configchecksum: {{ toYaml .Values.isApplicationLabel | sha256sum | trunc 63 }}"}],"source_content_type":"text/x-diff","patch_set":3,"id":"4536f996_2b8d5382","line":24,"updated":"2025-04-28 15:33:17.000000000","message":"There has been a bit of variability across apps on the implementation of this requirement. We recently decided to standardize this. See https://wiki.openstack.org/wiki/StarlingX/Containers/Applications\n\nSo a tweak to this and values.yaml \n\n    # values.yaml\n    component: \u003cplatform|application\u003e\n\n    # Helm chart label logic to ensure a valid value for resource labels\n    app.starlingx.io/component: {{ ternary \"application\" \"platform\" (eq .Values \"component \"application\")}}","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"},{"author":{"_account_id":35139,"name":"Reynaldo P Gomes","email":"Reynaldo.PatroneGomes@windriver.com","username":"reynaldopgomes"},"change_message_id":"df4b26e38a839b583d275a95f62a9d0b8f2915aa","unresolved":true,"context_lines":[{"line_number":21,"context_line":"     metadata:"},{"line_number":22,"context_line":"       labels:"},{"line_number":23,"context_line":"         {{- include \"node-feature-discovery.selectorLabels\" . | nindent 8 }}"},{"line_number":24,"context_line":"+        app.starlingx.io/component: {{ ternary \"application\" \"platform\" .Values.isApplicationLabel}}"},{"line_number":25,"context_line":"         role: master"},{"line_number":26,"context_line":"       annotations:"},{"line_number":27,"context_line":"+        configchecksum: {{ toYaml .Values.isApplicationLabel | sha256sum | trunc 63 }}"}],"source_content_type":"text/x-diff","patch_set":3,"id":"a9f3d93a_593039a6","line":24,"in_reply_to":"4536f996_2b8d5382","updated":"2025-04-28 17:02:55.000000000","message":"Is the \"configchecksum\" variable in the annotation section still necessary?","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"},{"author":{"_account_id":35139,"name":"Reynaldo P Gomes","email":"Reynaldo.PatroneGomes@windriver.com","username":"reynaldopgomes"},"change_message_id":"52e60820c0dc0e69259f0b56103ae8c159a6a0a6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"     metadata:"},{"line_number":22,"context_line":"       labels:"},{"line_number":23,"context_line":"         {{- include \"node-feature-discovery.selectorLabels\" . | nindent 8 }}"},{"line_number":24,"context_line":"+        app.starlingx.io/component: {{ ternary \"application\" \"platform\" .Values.isApplicationLabel}}"},{"line_number":25,"context_line":"         role: master"},{"line_number":26,"context_line":"       annotations:"},{"line_number":27,"context_line":"+        configchecksum: {{ toYaml .Values.isApplicationLabel | sha256sum | trunc 63 }}"}],"source_content_type":"text/x-diff","patch_set":3,"id":"85f5e9ed_cbbe569e","line":24,"in_reply_to":"a9f3d93a_593039a6","updated":"2025-04-28 21:13:26.000000000","message":"Done","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"669c35f53732e3e0c0348476774d772db9a31229","unresolved":true,"context_lines":[{"line_number":21,"context_line":"     metadata:"},{"line_number":22,"context_line":"       labels:"},{"line_number":23,"context_line":"         {{- include \"node-feature-discovery.selectorLabels\" . | nindent 8 }}"},{"line_number":24,"context_line":"+        app.starlingx.io/component: {{ ternary \"application\" \"platform\" .Values.isApplicationLabel}}"},{"line_number":25,"context_line":"         role: master"},{"line_number":26,"context_line":"       annotations:"},{"line_number":27,"context_line":"+        configchecksum: {{ toYaml .Values.isApplicationLabel | sha256sum | trunc 63 }}"}],"source_content_type":"text/x-diff","patch_set":3,"id":"5c39d488_d75d3cac","line":24,"in_reply_to":"a9f3d93a_593039a6","updated":"2025-04-28 20:11:02.000000000","message":"Typically a checksum is used to make sure the helm resource is updated/restarted when something changes like a configmap. So I think you only need it if you change the label with a helm override and the deployment/pods don\u0027t restart correctly to use the CPUs associated with the label.","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"}],"stx-node-feature-discovery/debian/deb_folder/copyright":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"13f8cbacdb53eece3072ac708a227d9c3e95d6fb","unresolved":true,"context_lines":[{"line_number":3,"context_line":"Source: https://opendev.org/starlingx/app-node-feature-discovery/"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Files: *"},{"line_number":6,"context_line":"Copyright: (c) 2013-2025 Wind River Systems, Inc"},{"line_number":7,"context_line":"License: Apache-2"},{"line_number":8,"context_line":" Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":9,"context_line":" you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"c98bf555_d3c95bab","line":6,"updated":"2025-04-28 15:33:17.000000000","message":"Based on the control file, this should be 2023-2025","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"},{"author":{"_account_id":35139,"name":"Reynaldo P Gomes","email":"Reynaldo.PatroneGomes@windriver.com","username":"reynaldopgomes"},"change_message_id":"390ca8d0be6975589ac9272c4b29b53400500095","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Source: https://opendev.org/starlingx/app-node-feature-discovery/"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Files: *"},{"line_number":6,"context_line":"Copyright: (c) 2013-2025 Wind River Systems, Inc"},{"line_number":7,"context_line":"License: Apache-2"},{"line_number":8,"context_line":" Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":9,"context_line":" you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"d930d678_508d7baf","line":6,"in_reply_to":"c98bf555_d3c95bab","updated":"2025-04-28 17:38:56.000000000","message":"Acknowledged","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"13f8cbacdb53eece3072ac708a227d9c3e95d6fb","unresolved":true,"context_lines":[{"line_number":23,"context_line":"# If you want to use GPL v2 or later for the /debian/* files use"},{"line_number":24,"context_line":"# the following clauses, or change it to suit. Delete these two lines"},{"line_number":25,"context_line":"Files: debian/*"},{"line_number":26,"context_line":"Copyright: 2024-2025 Wind River Systems, Inc"},{"line_number":27,"context_line":"License: Apache-2"},{"line_number":28,"context_line":" Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":29,"context_line":" you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"e88104c4_a93d7661","line":26,"updated":"2025-04-28 15:33:17.000000000","message":"Same as above?","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"},{"author":{"_account_id":35139,"name":"Reynaldo P Gomes","email":"Reynaldo.PatroneGomes@windriver.com","username":"reynaldopgomes"},"change_message_id":"390ca8d0be6975589ac9272c4b29b53400500095","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# If you want to use GPL v2 or later for the /debian/* files use"},{"line_number":24,"context_line":"# the following clauses, or change it to suit. Delete these two lines"},{"line_number":25,"context_line":"Files: debian/*"},{"line_number":26,"context_line":"Copyright: 2024-2025 Wind River Systems, Inc"},{"line_number":27,"context_line":"License: Apache-2"},{"line_number":28,"context_line":" Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":29,"context_line":" you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"0b5443d9_5bbf8f3d","line":26,"in_reply_to":"e88104c4_a93d7661","updated":"2025-04-28 17:38:56.000000000","message":"Acknowledged","commit_id":"534e986592cbe5661cf65136bdd57560e2a598c6"}],"stx-node-feature-discovery/stx-node-feature-discovery/fluxcd-manifests/node-feature-discovery/node-feature-discovery-static-overrides.yaml":[{"author":{"_account_id":34219,"name":"Guilherme Batista Leite","email":"guilhermebatista.leite@windriver.com"},"change_message_id":"92b26950c53004c0555fc90f4aa969f0f78a1ebc","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  - key: \"node-role.kubernetes.io/control-plane\""},{"line_number":31,"context_line":"    operator: Exists"},{"line_number":32,"context_line":"    effect: NoSchedule"},{"line_number":33,"context_line":"  sleepInterval: 3600s"},{"line_number":34,"context_line":"  resources:"},{"line_number":35,"context_line":"    requests:"},{"line_number":36,"context_line":"      cpu: 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a76c439_ae9060fb","line":33,"updated":"2025-04-17 17:44:02.000000000","message":"Could you please review this parameter?\nAs per upstream helm (https://github.com/kubernetes-sigs/node-feature-discovery/blob/v0.17.2/deployment/helm/node-feature-discovery/values.yaml#L181) it should be part of config element.","commit_id":"93b267448ad8df1651dd11455e9499242ef6ee8e"},{"author":{"_account_id":35139,"name":"Reynaldo P Gomes","email":"Reynaldo.PatroneGomes@windriver.com","username":"reynaldopgomes"},"change_message_id":"b95c23752a1e31e887a9f2f16bdf2bdde9a97427","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  - key: \"node-role.kubernetes.io/control-plane\""},{"line_number":31,"context_line":"    operator: Exists"},{"line_number":32,"context_line":"    effect: NoSchedule"},{"line_number":33,"context_line":"  sleepInterval: 3600s"},{"line_number":34,"context_line":"  resources:"},{"line_number":35,"context_line":"    requests:"},{"line_number":36,"context_line":"      cpu: 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"214731cf_2cd93195","line":33,"in_reply_to":"1a76c439_ae9060fb","updated":"2025-04-17 19:19:26.000000000","message":"Fixed","commit_id":"93b267448ad8df1651dd11455e9499242ef6ee8e"}]}