)]}'
{"sysinv/sysinv/sysinv/sysinv/openstack/common/rpc/zmq_receiver.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c9fcf8569b3791549f9ee24d5df600f26c298838","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from sysinv.openstack.common import rpc"},{"line_number":27,"context_line":"from sysinv.openstack.common.rpc import impl_zmq"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"eventlet.monkey_patch()"},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":"CONF.register_opts(rpc.rpc_opts)"},{"line_number":32,"context_line":"CONF.register_opts(impl_zmq.zmq_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_44b101e1","line":29,"updated":"2018-08-21 13:15:14.000000000","message":"This should be left after the import eventlet as before to ensure the patch is applied as early as possible.\nDid this cause a flake8 error? # noqa may be needed to override this case.","commit_id":"ca12f477be70bfc3b976d90b234bc5079669996d"},{"author":{"_account_id":28414,"name":"Austin Sun","email":"austin.sun@intel.com","username":"sunausti"},"change_message_id":"b4cd8684ca14f5d5da963257276a0692f0165396","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from sysinv.openstack.common import rpc"},{"line_number":27,"context_line":"from sysinv.openstack.common.rpc import impl_zmq"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"eventlet.monkey_patch()"},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":"CONF.register_opts(rpc.rpc_opts)"},{"line_number":32,"context_line":"CONF.register_opts(impl_zmq.zmq_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_184d9771","line":29,"in_reply_to":"3f79a3b5_44b101e1","updated":"2018-08-22 00:55:19.000000000","message":"it will cause flake8 issue openstack/common/rpc/zmq_receiver.py:21:1: E402 module level import not at top of file","commit_id":"ca12f477be70bfc3b976d90b234bc5079669996d"}],"sysinv/sysinv/sysinv/sysinv/tests/__init__.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c9fcf8569b3791549f9ee24d5df600f26c298838","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# The code below enables nosetests to work with i18n _() blocks"},{"line_number":32,"context_line":"import __builtin__"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"setattr(__builtin__, \u0027_\u0027, lambda x: x)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_04f9c97e","line":34,"updated":"2018-08-21 13:15:14.000000000","message":"Recommend to Not change the order of eventlet.monkey_patch(..)","commit_id":"ca12f477be70bfc3b976d90b234bc5079669996d"},{"author":{"_account_id":28414,"name":"Austin Sun","email":"austin.sun@intel.com","username":"sunausti"},"change_message_id":"b4cd8684ca14f5d5da963257276a0692f0165396","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# The code below enables nosetests to work with i18n _() blocks"},{"line_number":32,"context_line":"import __builtin__"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"setattr(__builtin__, \u0027_\u0027, lambda x: x)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b83b43c6","line":34,"in_reply_to":"3f79a3b5_04f9c97e","updated":"2018-08-22 00:55:19.000000000","message":"it will cause E402 module level import not at top of file error. If we don\u0027t change the order, we have to suppress E402 error.","commit_id":"ca12f477be70bfc3b976d90b234bc5079669996d"}],"sysinv/sysinv/sysinv/sysinv/tests/objects/test_objects.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c9fcf8569b3791549f9ee24d5df600f26c298838","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from sysinv.openstack.common import timeutils"},{"line_number":25,"context_line":"from sysinv.tests import base as test_base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"gettext.install(\u0027sysinv\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class MyObj(base.SysinvObject):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_64375d4f","line":27,"updated":"2018-08-21 13:15:14.000000000","message":"Please confirm the result of tox unit tests with this change.","commit_id":"ca12f477be70bfc3b976d90b234bc5079669996d"},{"author":{"_account_id":28414,"name":"Austin Sun","email":"austin.sun@intel.com","username":"sunausti"},"change_message_id":"b4cd8684ca14f5d5da963257276a0692f0165396","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from sysinv.openstack.common import timeutils"},{"line_number":25,"context_line":"from sysinv.tests import base as test_base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"gettext.install(\u0027sysinv\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class MyObj(base.SysinvObject):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1876f7a5","line":27,"in_reply_to":"3f79a3b5_64375d4f","updated":"2018-08-22 00:55:19.000000000","message":"I\u0027m trying to run unit tests in my local, I will update once I have result.","commit_id":"ca12f477be70bfc3b976d90b234bc5079669996d"}],"sysinv/sysinv/sysinv/tox.ini":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c9fcf8569b3791549f9ee24d5df600f26c298838","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# H401,H403,H404,H405 are docstring and not important"},{"line_number":83,"context_line":"[flake8]"},{"line_number":84,"context_line":"ignore \u003d E501,F821,H401,H403,H404,H405"},{"line_number":85,"context_line":"#ignore \u003d E501,E127,E128,E402,E126,H101,H102,H104,H105,H231,H232,H233,H234,H235,H236,H237,H238,H401,H403,H404,H405"},{"line_number":86,"context_line":"builtins \u003d _"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"[testenv:flake8]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_e4704d0b","line":85,"updated":"2018-08-21 13:15:14.000000000","message":"The ignore # comment line can be removed with this change.  Please advise on tox results with this change","commit_id":"ca12f477be70bfc3b976d90b234bc5079669996d"},{"author":{"_account_id":28414,"name":"Austin Sun","email":"austin.sun@intel.com","username":"sunausti"},"change_message_id":"b4cd8684ca14f5d5da963257276a0692f0165396","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# H401,H403,H404,H405 are docstring and not important"},{"line_number":83,"context_line":"[flake8]"},{"line_number":84,"context_line":"ignore \u003d E501,F821,H401,H403,H404,H405"},{"line_number":85,"context_line":"#ignore \u003d E501,E127,E128,E402,E126,H101,H102,H104,H105,H231,H232,H233,H234,H235,H236,H237,H238,H401,H403,H404,H405"},{"line_number":86,"context_line":"builtins \u003d _"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"[testenv:flake8]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3f79a3b5_d86f1fc3","line":85,"in_reply_to":"3f79a3b5_e4704d0b","updated":"2018-08-22 00:55:19.000000000","message":"sure. I will remove it.","commit_id":"ca12f477be70bfc3b976d90b234bc5079669996d"}]}