)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"2b8bff522f10bc2f1b830cf7c1c15df92b14134e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Story: 2004760"},{"line_number":20,"context_line":"Task: 28869"},{"line_number":21,"context_line":"Depends-On: https://review.openstack.org/#/c/653914"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I5728586c69689e32afc948009c2b8c9e2bff84e0"},{"line_number":24,"context_line":"Signed-off-by: Mingyuan Qi \u003cmingyuan.qi@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffb9cba7_12cf1e80","line":21,"updated":"2019-04-22 15:09:09.000000000","message":"Update URL to opendev.org path. Also, note Dean\u0027s comment on a couple of other reviews about having the Depends-On in the final block (ie. remove the blank line below):\n\"Also, please note that those footers must be in the last text block, these had a blank line between them and the actual last block of text.\"","commit_id":"3a00836770bbec1660c3b86a41f2def7eb147172"}],"kubernetes/applications/stx-openstack/stx-openstack-helm/stx-openstack-helm/manifests/manifest.yaml":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"25d444c70780ed7dd711038400b943a1c7adbf8f","unresolved":false,"context_lines":[{"line_number":930,"context_line":"            - ServerGroupAffinityFilter"},{"line_number":931,"context_line":"            - ServerGroupAntiAffinityFilter"},{"line_number":932,"context_line":"            - PciPassthroughFilter"},{"line_number":933,"context_line":"            - DiskFilter"},{"line_number":934,"context_line":"          io_ops_weight_multiplier: -5.0"},{"line_number":935,"context_line":"          pci_weight_multiplier: 0.0"},{"line_number":936,"context_line":"          ram_weight_multiplier: 0.0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfbec78f_f6122d09","side":"PARENT","line":933,"range":{"start_line":933,"start_character":14,"end_line":933,"end_character":24},"updated":"2019-05-09 14:45:23.000000000","message":"This doesn\u0027t seem related - was removing this intentional?","commit_id":"7bbe7f1bcd2700422008ab50211cae966f110272"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"92b83bb150a5a101159db803fc2eda39dc0de22c","unresolved":false,"context_lines":[{"line_number":930,"context_line":"            - ServerGroupAffinityFilter"},{"line_number":931,"context_line":"            - ServerGroupAntiAffinityFilter"},{"line_number":932,"context_line":"            - PciPassthroughFilter"},{"line_number":933,"context_line":"            - DiskFilter"},{"line_number":934,"context_line":"          io_ops_weight_multiplier: -5.0"},{"line_number":935,"context_line":"          pci_weight_multiplier: 0.0"},{"line_number":936,"context_line":"          ram_weight_multiplier: 0.0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfbec78f_2f229b01","side":"PARENT","line":933,"range":{"start_line":933,"start_character":14,"end_line":933,"end_character":24},"in_reply_to":"dfbec78f_f6122d09","updated":"2019-05-10 01:55:19.000000000","message":"DiskFilter is deprecated in stein. Because of the new scheduling mechnism(custom resource classes) for ironic, this filter will block the instance scheduling to ironic node.\n\nSee https://docs.openstack.org/releasenotes/nova/stein.html\nThe CoreFilter, DiskFilter and RamFilter are now deprecated. VCPU, DISK_GB and MEMORY_MB filtering is performed natively using the Placement service when using the filter_scheduler driver. Users of the caching_scheduler driver may still rely on these filters but the caching_scheduler driver is itself deprecated. Furthermore, enabling these filters may incorrectly filter out baremetal nodes which must be scheduled using custom resource classes.","commit_id":"7bbe7f1bcd2700422008ab50211cae966f110272"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"a4c6ae7e7da9ec3347480e59c5850bb8387eaff3","unresolved":false,"context_lines":[{"line_number":904,"context_line":"            - ServerGroupAffinityFilter"},{"line_number":905,"context_line":"            - ServerGroupAntiAffinityFilter"},{"line_number":906,"context_line":"            - PciPassthroughFilter"},{"line_number":907,"context_line":"            - DiskFilter"},{"line_number":908,"context_line":"          io_ops_weight_multiplier: -5.0"},{"line_number":909,"context_line":"          pci_weight_multiplier: 0.0"},{"line_number":910,"context_line":"          ram_weight_multiplier: 0.0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bfb3d3c7_b210cb4f","side":"PARENT","line":907,"updated":"2019-05-30 13:08:38.000000000","message":"Is removing DiskFilter intended?","commit_id":"a8b23796fe67c8606988b506de8fe9a36559551a"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"23f04056891712fb211bb7a500de6b3f4b9dbc54","unresolved":false,"context_lines":[{"line_number":904,"context_line":"            - ServerGroupAffinityFilter"},{"line_number":905,"context_line":"            - ServerGroupAntiAffinityFilter"},{"line_number":906,"context_line":"            - PciPassthroughFilter"},{"line_number":907,"context_line":"            - DiskFilter"},{"line_number":908,"context_line":"          io_ops_weight_multiplier: -5.0"},{"line_number":909,"context_line":"          pci_weight_multiplier: 0.0"},{"line_number":910,"context_line":"          ram_weight_multiplier: 0.0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bfb3d3c7_a8013e3a","side":"PARENT","line":907,"in_reply_to":"bfb3d3c7_b210cb4f","updated":"2019-05-30 14:58:46.000000000","message":"Yes, you can find the answer in patch set 4 comments replying to Bart","commit_id":"a8b23796fe67c8606988b506de8fe9a36559551a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"b850b5610c51ac322b6ddb3710807f646d99668c","unresolved":false,"context_lines":[{"line_number":740,"context_line":"      service_ingress_osapi: false"},{"line_number":741,"context_line":"      cron_job_cell_setup: false"},{"line_number":742,"context_line":"      cron_job_service_cleaner: false"},{"line_number":743,"context_line":"      # for managing ironic node via nova compute"},{"line_number":744,"context_line":"      # enabled by overrides if label openstack-ironic\u003denabled set"},{"line_number":745,"context_line":"      statefulset_compute_ironic: false"},{"line_number":746,"context_line":"    labels:"},{"line_number":747,"context_line":"      agent:"},{"line_number":748,"context_line":"        compute:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bfb3d3c7_f19ab611","line":745,"range":{"start_line":743,"start_character":0,"end_line":745,"end_character":1},"updated":"2019-05-30 22:25:32.000000000","message":"nit: Probably can remove the comment. We can refer to the chart to see what the manifest is used for","commit_id":"d0f6e8d8194bac7f68cc2e80033dabb604b54eca"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"db95921e0f12e5e01fd3912120523b55ebf8d239","unresolved":false,"context_lines":[{"line_number":740,"context_line":"      service_ingress_osapi: false"},{"line_number":741,"context_line":"      cron_job_cell_setup: false"},{"line_number":742,"context_line":"      cron_job_service_cleaner: false"},{"line_number":743,"context_line":"      # for managing ironic node via nova compute"},{"line_number":744,"context_line":"      # enabled by overrides if label openstack-ironic\u003denabled set"},{"line_number":745,"context_line":"      statefulset_compute_ironic: false"},{"line_number":746,"context_line":"    labels:"},{"line_number":747,"context_line":"      agent:"},{"line_number":748,"context_line":"        compute:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_05b82528","line":745,"range":{"start_line":743,"start_character":0,"end_line":745,"end_character":1},"in_reply_to":"bfb3d3c7_f19ab611","updated":"2019-06-04 10:18:40.000000000","message":"Done","commit_id":"d0f6e8d8194bac7f68cc2e80033dabb604b54eca"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"f4686d1910354d4dfd080ce71a5bbe1aec1df4c6","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"  chart_name: ironic"},{"line_number":1192,"context_line":"  release: openstack-ironic"},{"line_number":1193,"context_line":"  namespace: openstack"},{"line_number":1194,"context_line":"  test:"},{"line_number":1195,"context_line":"    enabled: false"},{"line_number":1196,"context_line":"  install:"},{"line_number":1197,"context_line":"    no_hooks: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bfb3d3c7_71cd6683","line":1194,"updated":"2019-05-30 22:14:00.000000000","message":"I think you need a wait here:\n    wait:\n      timeout: 1800\n      labels:\n        release_group: osh-openstack-ironic","commit_id":"d0f6e8d8194bac7f68cc2e80033dabb604b54eca"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"db95921e0f12e5e01fd3912120523b55ebf8d239","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"  chart_name: ironic"},{"line_number":1192,"context_line":"  release: openstack-ironic"},{"line_number":1193,"context_line":"  namespace: openstack"},{"line_number":1194,"context_line":"  test:"},{"line_number":1195,"context_line":"    enabled: false"},{"line_number":1196,"context_line":"  install:"},{"line_number":1197,"context_line":"    no_hooks: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_25b52932","line":1194,"in_reply_to":"bfb3d3c7_71cd6683","updated":"2019-06-04 10:18:40.000000000","message":"Done","commit_id":"d0f6e8d8194bac7f68cc2e80033dabb604b54eca"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"37cc2cdd6b0eb11a4af92e4b845ee388a0f1121c","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"    enabled: false"},{"line_number":1196,"context_line":"  install:"},{"line_number":1197,"context_line":"    no_hooks: false"},{"line_number":1198,"context_line":"  upgrade:"},{"line_number":1199,"context_line":"    no_hooks: false"},{"line_number":1200,"context_line":"    pre:"},{"line_number":1201,"context_line":"      delete:"},{"line_number":1202,"context_line":"        - type: job"},{"line_number":1203,"context_line":"          labels:"},{"line_number":1204,"context_line":"            application: ironic"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bfb3d3c7_7e58dc86","line":1201,"range":{"start_line":1198,"start_character":0,"end_line":1201,"end_character":13},"updated":"2019-05-30 16:11:57.000000000","message":"If there any reason that do not clean up the jobs \"bootstrap\", \u0027rabbit_init\u0027, \u0027manage_cleaning_network\u0027 etc when upgrading?\n\nThe release upgrade will fail if there has image overrides for those jobs or ironic password overrides for rabbitmq\n\n\nTo make sure jobs are cleaned up when upgrading\nyou could do \n        - type: job\n          labels:\n            release_group: osh-openstack-ironic","commit_id":"d0f6e8d8194bac7f68cc2e80033dabb604b54eca"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"db95921e0f12e5e01fd3912120523b55ebf8d239","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"    enabled: false"},{"line_number":1196,"context_line":"  install:"},{"line_number":1197,"context_line":"    no_hooks: false"},{"line_number":1198,"context_line":"  upgrade:"},{"line_number":1199,"context_line":"    no_hooks: false"},{"line_number":1200,"context_line":"    pre:"},{"line_number":1201,"context_line":"      delete:"},{"line_number":1202,"context_line":"        - type: job"},{"line_number":1203,"context_line":"          labels:"},{"line_number":1204,"context_line":"            application: ironic"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_c583ed55","line":1201,"range":{"start_line":1198,"start_character":0,"end_line":1201,"end_character":13},"in_reply_to":"bfb3d3c7_7e58dc86","updated":"2019-06-04 10:18:40.000000000","message":"Done","commit_id":"d0f6e8d8194bac7f68cc2e80033dabb604b54eca"},{"author":{"_account_id":28435,"name":"Angie Wang","email":"angie.wang@windriver.com","username":"angiewang"},"change_message_id":"f75532e982515e2fa757049ee476e89015cda520","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"        node_selector_key: openstack-ironic"},{"line_number":1235,"context_line":"        node_selector_value: enabled"},{"line_number":1236,"context_line":"    images:"},{"line_number":1237,"context_line":"      tags:"},{"line_number":1238,"context_line":"        ironic_manage_cleaning_network: docker.io/starlingx/stx-heat:master-centos-stable-latest"},{"line_number":1239,"context_line":"        ironic_retrive_cleaning_network: docker.io/starlingx/stx-heat:master-centos-stable-latest"},{"line_number":1240,"context_line":"        ironic_retrive_swift_config: docker.io/starlingx/stx-heat:master-centos-stable-latest"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_c62945e6","line":1237,"range":{"start_line":1237,"start_character":5,"end_line":1237,"end_character":11},"updated":"2019-06-11 01:12:25.000000000","message":"Hi Mingyuan, please add the image override for db_drop as well. Thanks","commit_id":"662d0d8184e2615cdb6853bd45c8b9291951003f"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"4651d33abf0f1cc6438bd1493d329d2d72e4f5e8","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"        node_selector_key: openstack-ironic"},{"line_number":1235,"context_line":"        node_selector_value: enabled"},{"line_number":1236,"context_line":"    images:"},{"line_number":1237,"context_line":"      tags:"},{"line_number":1238,"context_line":"        ironic_manage_cleaning_network: docker.io/starlingx/stx-heat:master-centos-stable-latest"},{"line_number":1239,"context_line":"        ironic_retrive_cleaning_network: docker.io/starlingx/stx-heat:master-centos-stable-latest"},{"line_number":1240,"context_line":"        ironic_retrive_swift_config: docker.io/starlingx/stx-heat:master-centos-stable-latest"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_81bd7703","line":1237,"range":{"start_line":1237,"start_character":5,"end_line":1237,"end_character":11},"in_reply_to":"9fb8cfa7_c62945e6","updated":"2019-06-11 02:00:02.000000000","message":"Done","commit_id":"662d0d8184e2615cdb6853bd45c8b9291951003f"}]}