)]}'
{"sysinv/sysinv/sysinv/sysinv/agent/pci.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"ac066e86f0a6da221c463c3c6d74b0ea6ed0344c","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def get_label(self, pci_device_list):"},{"line_number":205,"context_line":"        # look for qat vf device"},{"line_number":206,"context_line":"        for qat_vf_device_id in QAT_VF_DEVICES_PCI_DEVICE_ID:"},{"line_number":207,"context_line":"            p \u003d subprocess.Popen([\"lspci\", \"-d\", \"8086:\" + qat_vf_device_id],"},{"line_number":208,"context_line":"                                 stdout\u003dsubprocess.PIPE)"},{"line_number":209,"context_line":"            output \u003d p.stdout.read()"},{"line_number":210,"context_line":"            if output:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_de9f654f","line":207,"updated":"2019-10-17 18:08:31.000000000","message":"Un-related to your commit (since there are other places in this file that also call lspci), but the spec files really should have: \n  Requires: pciutils  \notherwise when these routines lspci, it could fail in an environment where that executable is not installed.","commit_id":"7ebbf013dce81b82f4795183a0d72eee485d22dc"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"e1819445d772a2440bd649aad09fa32e0abb9b77","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def get_label(self, pci_device_list):"},{"line_number":205,"context_line":"        # look for qat vf device"},{"line_number":206,"context_line":"        for qat_vf_device_id in QAT_VF_DEVICES_PCI_DEVICE_ID:"},{"line_number":207,"context_line":"            p \u003d subprocess.Popen([\"lspci\", \"-d\", \"8086:\" + qat_vf_device_id],"},{"line_number":208,"context_line":"                                 stdout\u003dsubprocess.PIPE)"},{"line_number":209,"context_line":"            output \u003d p.stdout.read()"},{"line_number":210,"context_line":"            if output:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2a1c2912","line":207,"in_reply_to":"3fa7e38b_c48b1366","updated":"2019-10-18 12:51:52.000000000","message":"You shouldn\u0027t need to for this commit.  Perhaps in a future commit.  It\u0027s more of a generic cleanup activity, I am sure we have others.","commit_id":"7ebbf013dce81b82f4795183a0d72eee485d22dc"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"6f775cf155a3918c4d77641a57aab34d7f32718f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def get_label(self, pci_device_list):"},{"line_number":205,"context_line":"        # look for qat vf device"},{"line_number":206,"context_line":"        for qat_vf_device_id in QAT_VF_DEVICES_PCI_DEVICE_ID:"},{"line_number":207,"context_line":"            p \u003d subprocess.Popen([\"lspci\", \"-d\", \"8086:\" + qat_vf_device_id],"},{"line_number":208,"context_line":"                                 stdout\u003dsubprocess.PIPE)"},{"line_number":209,"context_line":"            output \u003d p.stdout.read()"},{"line_number":210,"context_line":"            if output:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c48b1366","line":207,"in_reply_to":"3fa7e38b_de9f654f","updated":"2019-10-17 23:28:18.000000000","message":"I’ll check whether I can add the requires in this commit","commit_id":"7ebbf013dce81b82f4795183a0d72eee485d22dc"},{"author":{"_account_id":28682,"name":"Ran An","email":"ran1.an@intel.com","username":"SidneyAn"},"change_message_id":"1a483e4affc0f359eaf3352c6efa3a682fa28b9d","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def get_label(self, pci_device_list):"},{"line_number":205,"context_line":"        # look for qat vf device"},{"line_number":206,"context_line":"        for qat_vf_device_id in QAT_VF_DEVICES_PCI_DEVICE_ID:"},{"line_number":207,"context_line":"            p \u003d subprocess.Popen([\"lspci\", \"-d\", \"8086:\" + qat_vf_device_id],"},{"line_number":208,"context_line":"                                 stdout\u003dsubprocess.PIPE)"},{"line_number":209,"context_line":"            output \u003d p.stdout.read()"},{"line_number":210,"context_line":"            if output:"},{"line_number":211,"context_line":"                label \u003d {}"},{"line_number":212,"context_line":"                label.update({\u0027label_key\u0027: \u0027intelqat\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1f9df456","line":209,"range":{"start_line":207,"start_character":12,"end_line":209,"end_character":36},"updated":"2019-10-18 02:13:29.000000000","message":"it is not required to call \"lspci\" here, you can get all info you want from args \"pci_device_list\"","commit_id":"7ebbf013dce81b82f4795183a0d72eee485d22dc"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"1933ec967b5599a5cac5b095436d99d390b9c05a","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def get_label(self, pci_device_list):"},{"line_number":205,"context_line":"        # look for qat vf device"},{"line_number":206,"context_line":"        for qat_vf_device_id in QAT_VF_DEVICES_PCI_DEVICE_ID:"},{"line_number":207,"context_line":"            p \u003d subprocess.Popen([\"lspci\", \"-d\", \"8086:\" + qat_vf_device_id],"},{"line_number":208,"context_line":"                                 stdout\u003dsubprocess.PIPE)"},{"line_number":209,"context_line":"            output \u003d p.stdout.read()"},{"line_number":210,"context_line":"            if output:"},{"line_number":211,"context_line":"                label \u003d {}"},{"line_number":212,"context_line":"                label.update({\u0027label_key\u0027: \u0027intelqat\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6e6787ec","line":209,"range":{"start_line":207,"start_character":12,"end_line":209,"end_character":36},"in_reply_to":"3fa7e38b_1f9df456","updated":"2019-10-20 06:19:43.000000000","message":"The pci_device_list gets all physical function devices, no virtual function devices.","commit_id":"7ebbf013dce81b82f4795183a0d72eee485d22dc"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"2281bfb37ebb3b1e69c8c505e8de6888e40b2c00","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    def get_label(self, pci_device_list):"},{"line_number":207,"context_line":"        # look for qat vf device"},{"line_number":208,"context_line":"        for qat_vf_device_id in QAT_VF_DEVICES_PCI_DEVICE_ID:"},{"line_number":209,"context_line":"            p \u003d subprocess.Popen([\"lspci\", \"-d\", \"8086:\" + qat_vf_device_id],"},{"line_number":210,"context_line":"                                 stdout\u003dsubprocess.PIPE)"},{"line_number":211,"context_line":"            output \u003d p.stdout.read()"},{"line_number":212,"context_line":"            if output:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_d2b5f5d1","line":209,"range":{"start_line":209,"start_character":50,"end_line":209,"end_character":54},"updated":"2019-10-21 13:18:32.000000000","message":"Probably we want NOVA_PCI_ALIAS_QAT_PF_VENDOR, although that constant is terribly named.","commit_id":"c2018b1c28afe319f2a5d6af4487b50d1125e170"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"3412c52c4deb8f6ff398f929ef0338009e83b790","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    def get_label(self, pci_device_list):"},{"line_number":207,"context_line":"        # look for qat vf device"},{"line_number":208,"context_line":"        for qat_vf_device_id in QAT_VF_DEVICES_PCI_DEVICE_ID:"},{"line_number":209,"context_line":"            p \u003d subprocess.Popen([\"lspci\", \"-d\", \"8086:\" + qat_vf_device_id],"},{"line_number":210,"context_line":"                                 stdout\u003dsubprocess.PIPE)"},{"line_number":211,"context_line":"            output \u003d p.stdout.read()"},{"line_number":212,"context_line":"            if output:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_29d17730","line":209,"range":{"start_line":209,"start_character":50,"end_line":209,"end_character":54},"in_reply_to":"3fa7e38b_d2b5f5d1","updated":"2019-10-22 02:30:00.000000000","message":"Done, I pick VF_VENDOR corresponding to VF devices","commit_id":"c2018b1c28afe319f2a5d6af4487b50d1125e170"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"75e8550e50136912a67176875f1a40fc474541a1","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                label.update({\u0027label_key\u0027: \u0027intelqat\u0027})"},{"line_number":215,"context_line":"                label.update({\u0027label_value\u0027: \u0027enabled\u0027})"},{"line_number":216,"context_line":"                return label"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"DEVICE_PLUGIN_LIST \u003d [IntelGPUdp(), IntelQATDevicePlugin()]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_32f80948","line":217,"updated":"2019-10-21 13:34:25.000000000","message":"If no devices are found for the for loop/if block, it will not return the label, and will implicitly return None.\nIt looks like all the other methods in this file will explicitly return None.\nProbably this method should also follow that pattern.","commit_id":"c2018b1c28afe319f2a5d6af4487b50d1125e170"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"3412c52c4deb8f6ff398f929ef0338009e83b790","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                label.update({\u0027label_key\u0027: \u0027intelqat\u0027})"},{"line_number":215,"context_line":"                label.update({\u0027label_value\u0027: \u0027enabled\u0027})"},{"line_number":216,"context_line":"                return label"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"DEVICE_PLUGIN_LIST \u003d [IntelGPUdp(), IntelQATDevicePlugin()]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_49d6332a","line":217,"in_reply_to":"3fa7e38b_32f80948","updated":"2019-10-22 02:30:00.000000000","message":"I agree","commit_id":"c2018b1c28afe319f2a5d6af4487b50d1125e170"}],"sysinv/sysinv/sysinv/sysinv/common/constants.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"432329509a749454ae28a662e459e296de958d24","unresolved":false,"context_lines":[{"line_number":891,"context_line":"NOVA_PCI_ALIAS_QAT_CLASS \u003d \"0x0b4000\""},{"line_number":892,"context_line":"NOVA_PCI_ALIAS_QAT_DH895XCC_PF_NAME \u003d \"qat-dh895xcc-pf\""},{"line_number":893,"context_line":"NOVA_PCI_ALIAS_QAT_C62X_PF_NAME \u003d \"qat-c62x-pf\""},{"line_number":894,"context_line":"NOVA_PCI_ALIAS_QAT_C3XXX_PF_NAME \u003d \"qat-c3xxx-pf\""},{"line_number":895,"context_line":"NOVA_PCI_ALIAS_QAT_D15XX_PF_NAME \u003d \"qat-d15xx-pf\""},{"line_number":896,"context_line":"NOVA_PCI_ALIAS_QAT_PF_VENDOR \u003d \"8086\""},{"line_number":897,"context_line":"NOVA_PCI_ALIAS_QAT_DH895XCC_PF_DEVICE \u003d \"0435\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b37ae2b7","line":894,"updated":"2019-10-17 18:37:20.000000000","message":"Does the prefix NOVA_ apply?  It shouldnt be required if  these are not particular to openstack nova.","commit_id":"7ebbf013dce81b82f4795183a0d72eee485d22dc"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"6f775cf155a3918c4d77641a57aab34d7f32718f","unresolved":false,"context_lines":[{"line_number":891,"context_line":"NOVA_PCI_ALIAS_QAT_CLASS \u003d \"0x0b4000\""},{"line_number":892,"context_line":"NOVA_PCI_ALIAS_QAT_DH895XCC_PF_NAME \u003d \"qat-dh895xcc-pf\""},{"line_number":893,"context_line":"NOVA_PCI_ALIAS_QAT_C62X_PF_NAME \u003d \"qat-c62x-pf\""},{"line_number":894,"context_line":"NOVA_PCI_ALIAS_QAT_C3XXX_PF_NAME \u003d \"qat-c3xxx-pf\""},{"line_number":895,"context_line":"NOVA_PCI_ALIAS_QAT_D15XX_PF_NAME \u003d \"qat-d15xx-pf\""},{"line_number":896,"context_line":"NOVA_PCI_ALIAS_QAT_PF_VENDOR \u003d \"8086\""},{"line_number":897,"context_line":"NOVA_PCI_ALIAS_QAT_DH895XCC_PF_DEVICE \u003d \"0435\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_849d1bbd","line":894,"in_reply_to":"3fa7e38b_b37ae2b7","updated":"2019-10-17 23:28:18.000000000","message":"For this feature, qat is not related to nova. but this list should be extended to other pci devices that nova supports. This patch leverages this list and I think it could be another commit to consider whether to remove all NOVA prefix and maintain a common pci list. Otherwise, it doesn’t make sense to have 2 pci device constant lists with NOVA prefix and non-NOVA prefix.","commit_id":"7ebbf013dce81b82f4795183a0d72eee485d22dc"},{"author":{"_account_id":28642,"name":"Brent Rowsell","email":"brent.rowsell@windriver.com","username":"browsell"},"change_message_id":"d2e203af441b5585ca8d7c84ea5ba3ea46e69cdb","unresolved":false,"context_lines":[{"line_number":898,"context_line":"NOVA_PCI_ALIAS_QAT_CLASS \u003d \"0x0b4000\""},{"line_number":899,"context_line":"NOVA_PCI_ALIAS_QAT_DH895XCC_PF_NAME \u003d \"qat-dh895xcc-pf\""},{"line_number":900,"context_line":"NOVA_PCI_ALIAS_QAT_C62X_PF_NAME \u003d \"qat-c62x-pf\""},{"line_number":901,"context_line":"NOVA_PCI_ALIAS_QAT_C3XXX_PF_NAME \u003d \"qat-c3xxx-pf\""},{"line_number":902,"context_line":"NOVA_PCI_ALIAS_QAT_D15XX_PF_NAME \u003d \"qat-d15xx-pf\""},{"line_number":903,"context_line":"NOVA_PCI_ALIAS_QAT_PF_VENDOR \u003d \"8086\""},{"line_number":904,"context_line":"NOVA_PCI_ALIAS_QAT_DH895XCC_PF_DEVICE \u003d \"0435\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_112b9282","line":901,"range":{"start_line":901,"start_character":48,"end_line":901,"end_character":49},"updated":"2019-10-20 22:58:30.000000000","message":"As this does not have anything to do with enabling the device plugin, it should be done under a separate commit.","commit_id":"67d3bcde1b0f4b386e9d9ceafcbfb3c982edac9e"},{"author":{"_account_id":28402,"name":"Mingyuan Qi","email":"mingyuan.qi@intel.com","username":"myqi"},"change_message_id":"6233a89c0dd961aa2459734089734bd57d4bbc82","unresolved":false,"context_lines":[{"line_number":898,"context_line":"NOVA_PCI_ALIAS_QAT_CLASS \u003d \"0x0b4000\""},{"line_number":899,"context_line":"NOVA_PCI_ALIAS_QAT_DH895XCC_PF_NAME \u003d \"qat-dh895xcc-pf\""},{"line_number":900,"context_line":"NOVA_PCI_ALIAS_QAT_C62X_PF_NAME \u003d \"qat-c62x-pf\""},{"line_number":901,"context_line":"NOVA_PCI_ALIAS_QAT_C3XXX_PF_NAME \u003d \"qat-c3xxx-pf\""},{"line_number":902,"context_line":"NOVA_PCI_ALIAS_QAT_D15XX_PF_NAME \u003d \"qat-d15xx-pf\""},{"line_number":903,"context_line":"NOVA_PCI_ALIAS_QAT_PF_VENDOR \u003d \"8086\""},{"line_number":904,"context_line":"NOVA_PCI_ALIAS_QAT_DH895XCC_PF_DEVICE \u003d \"0435\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_31c7ae67","line":901,"range":{"start_line":901,"start_character":48,"end_line":901,"end_character":49},"in_reply_to":"3fa7e38b_112b9282","updated":"2019-10-21 02:08:26.000000000","message":"Done","commit_id":"67d3bcde1b0f4b386e9d9ceafcbfb3c982edac9e"}]}