)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"68ed3493b238b66abb58053bbba552fc9c0ffd04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa7e38b_7428a297","updated":"2020-01-15 14:22:42.000000000","message":"I think you are missing a Depends-On.","commit_id":"bf2f2472f11be406c7d4f62bd83d61617fb2a35c"}],"sysinv/sysinv/sysinv/sysinv/tests/conductor/test_kube_app_app_operator.py":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"68ed3493b238b66abb58053bbba552fc9c0ffd04","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_reapply(self):"},{"line_number":72,"context_line":"        dbutils.create_test_app(name\u003d\u0027test-app-1\u0027,"},{"line_number":73,"context_line":"                                active\u003dTrue)"},{"line_number":74,"context_line":"        with mock.patch.object(__builtin__, \u0027open\u0027) as open_mock:"},{"line_number":75,"context_line":"            open_mock.return_value \u003d mock.MagicMock()"},{"line_number":76,"context_line":"            self.app_operator.set_reapply(\u0027test-app-1\u0027)"},{"line_number":77,"context_line":"            with mock.patch(\u0027os.path.isfile\u0027, return_value\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_affd673d","line":74,"range":{"start_line":74,"start_character":13,"end_line":74,"end_character":51},"updated":"2020-01-15 14:22:42.000000000","message":"Instead of mocking open and isfile, we would get better coverage by using a real file. I think you can do it with the TmpDir fixture. Something like this...\n\nAt top of file:\nimport fixtures\n\nIn setUp method:\nself.temp_dir \u003d self.useFixture(fixtures.TempDir())\n\nIn test_reapply:\nconstants.APP_PENDING_REAPPLY_FLAG \u003d self.temp_dir.path + \"/.app_reapply\"\n\nThen the mocks should not be necessary as the code can write to the temporary file.","commit_id":"bf2f2472f11be406c7d4f62bd83d61617fb2a35c"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"973f0213e22fe27a4c7f0a9aa86ca5e731bad79e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        constants.APP_PENDING_REAPPLY_FLAG \u003d self.temp_dir.path + \"/.app_reapply\""},{"line_number":99,"context_line":"        self.app_operator.set_reapply(\u0027test-app-1\u0027)"},{"line_number":100,"context_line":"        result \u003d self.app_operator.needs_reapply(\u0027test-app-1\u0027)"},{"line_number":101,"context_line":"        self.assertEqual(result, True)"},{"line_number":102,"context_line":"        self.app_operator.clear_reapply(\u0027test-app-1\u0027)"},{"line_number":103,"context_line":"        result \u003d self.app_operator.needs_reapply(\u0027test-app-1\u0027)"},{"line_number":104,"context_line":"        self.assertEqual(result, False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ec8cb8d9","line":101,"updated":"2020-01-16 14:51:45.000000000","message":"I wonder if we should be asking unit tests to use  self.assertTrue or  self.assertFalse  for booleans","commit_id":"314f2a9a8c909781fd54409153c1286bae70223a"}]}