)]}'
{"sysinv/sysinv/sysinv/sysinv/common/kubernetes.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"fd7eedf9c5eef78a1e04eaff46370e8077f7e0c9","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            api_response \u003d self._get_kubernetesclient_core().list_namespaced_pod("},{"line_number":179,"context_line":"                namespace)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            if api_response.items:"},{"line_number":182,"context_line":"                return True"},{"line_number":183,"context_line":"            else:"},{"line_number":184,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_bac07c52","line":181,"range":{"start_line":181,"start_character":15,"end_line":181,"end_character":27},"updated":"2020-03-24 14:00:29.000000000","message":"could api_response be None ?","commit_id":"d7ba6775212401f2bfc0bee04febe661152e504d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b54b95919c09c334ff7742599f6cd589a8a572cd","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            api_response \u003d self._get_kubernetesclient_core().list_namespaced_pod("},{"line_number":179,"context_line":"                namespace)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            if api_response.items:"},{"line_number":182,"context_line":"                return True"},{"line_number":183,"context_line":"            else:"},{"line_number":184,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_4b4a4027","line":181,"range":{"start_line":181,"start_character":15,"end_line":181,"end_character":27},"in_reply_to":"df33271e_1a0ec88c","updated":"2020-03-24 15:59:53.000000000","message":"Ok, just wondering if it could also return empty list.","commit_id":"d7ba6775212401f2bfc0bee04febe661152e504d"},{"author":{"_account_id":28709,"name":"Kevin Smith","email":"kevin.smith@windriver.com","username":"kevin.smith.wrs"},"change_message_id":"3f99162e005637e0f8239fbb4d90f7ed770ebef8","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            api_response \u003d self._get_kubernetesclient_core().list_namespaced_pod("},{"line_number":179,"context_line":"                namespace)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            if api_response.items:"},{"line_number":182,"context_line":"                return True"},{"line_number":183,"context_line":"            else:"},{"line_number":184,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_1a0ec88c","line":181,"range":{"start_line":181,"start_character":15,"end_line":181,"end_character":27},"in_reply_to":"df33271e_bac07c52","updated":"2020-03-24 14:15:23.000000000","message":"Not according to the kubernetes python api doc (and what I have seen), will always be there.\nhttps://github.com/kubernetes-client/python/blob/master/kubernetes/docs/V1PodList.md","commit_id":"d7ba6775212401f2bfc0bee04febe661152e504d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"fd7eedf9c5eef78a1e04eaff46370e8077f7e0c9","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            else:"},{"line_number":184,"context_line":"                return False"},{"line_number":185,"context_line":"        except ApiException as e:"},{"line_number":186,"context_line":"            LOG.error(\"Kubernetes exception in list_namespaced_pod: %s\" % e)"},{"line_number":187,"context_line":"            raise"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def kube_get_image_by_selector(self, template_name, namespace, container_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_daa0e0a8","line":186,"updated":"2020-03-24 14:00:29.000000000","message":"May also want to log namespace if that\u0027s not already in the exception.","commit_id":"d7ba6775212401f2bfc0bee04febe661152e504d"},{"author":{"_account_id":28709,"name":"Kevin Smith","email":"kevin.smith@windriver.com","username":"kevin.smith.wrs"},"change_message_id":"3f99162e005637e0f8239fbb4d90f7ed770ebef8","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            else:"},{"line_number":184,"context_line":"                return False"},{"line_number":185,"context_line":"        except ApiException as e:"},{"line_number":186,"context_line":"            LOG.error(\"Kubernetes exception in list_namespaced_pod: %s\" % e)"},{"line_number":187,"context_line":"            raise"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def kube_get_image_by_selector(self, template_name, namespace, container_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_ba67dc25","line":186,"in_reply_to":"df33271e_daa0e0a8","updated":"2020-03-24 14:15:23.000000000","message":"There is a log from the calling function \"Waiting for pod termination in namespace: \", but even if the namespace does not exist list_namespaced_pod does not throw an exception, so don\u0027t think there is a need.","commit_id":"d7ba6775212401f2bfc0bee04febe661152e504d"}],"sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"fd7eedf9c5eef78a1e04eaff46370e8077f7e0c9","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                loop_timeout +\u003d loop_check_interval"},{"line_number":1179,"context_line":"                time.sleep(loop_check_interval)"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"            if loop_timeout \u003e timeout:"},{"line_number":1182,"context_line":"                raise exception.KubePodTerminateTimeout(name\u003dnamespace)"},{"line_number":1183,"context_line":"            LOG.info(\"Pod termination in Namespace %s completed.\" % namespace)"},{"line_number":1184,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5af850c3","line":1181,"updated":"2020-03-24 14:00:29.000000000","message":"nit: this \u0027if loop_timeout..\u0027 could be replaced by \u0027else\u0027 statement, since it should only enter the else if the break is not hit.","commit_id":"d7ba6775212401f2bfc0bee04febe661152e504d"},{"author":{"_account_id":28709,"name":"Kevin Smith","email":"kevin.smith@windriver.com","username":"kevin.smith.wrs"},"change_message_id":"3f99162e005637e0f8239fbb4d90f7ed770ebef8","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                loop_timeout +\u003d loop_check_interval"},{"line_number":1179,"context_line":"                time.sleep(loop_check_interval)"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"            if loop_timeout \u003e timeout:"},{"line_number":1182,"context_line":"                raise exception.KubePodTerminateTimeout(name\u003dnamespace)"},{"line_number":1183,"context_line":"            LOG.info(\"Pod termination in Namespace %s completed.\" % namespace)"},{"line_number":1184,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_7ad714ef","line":1181,"in_reply_to":"df33271e_5af850c3","updated":"2020-03-24 14:15:23.000000000","message":"Agreed, but using the same code as the _delete_namespace above for consistency.","commit_id":"d7ba6775212401f2bfc0bee04febe661152e504d"}]}