)]}'
{"controllerconfig/controllerconfig/upgrade-scripts/96_delete_snmp_records.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"856da5594446f440a8c3bbd60bc62fd6c513d1ab","unresolved":true,"context_lines":[{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# This script will remove snmp related data (icommunity and"},{"line_number":7,"context_line":"# itrapdest) in dcorch database according to the host based"},{"line_number":8,"context_line":"# SNMP removal in preparation for upgrade to release 21.05."},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"63c081e8_520529c9","line":8,"range":{"start_line":8,"start_character":42,"end_line":8,"end_character":58},"updated":"2021-01-05 21:23:01.000000000","message":"from release 20.06","commit_id":"1318beb42b9820df0edcd34557629fdb26395b42"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"856da5594446f440a8c3bbd60bc62fd6c513d1ab","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    LOG.debug(\"%s invoked with from_release \u003d %s to_release \u003d %s action \u003d %s\""},{"line_number":40,"context_line":"              % (sys.argv[0], from_release, to_release, action))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if to_release \u003d\u003d \"21.05\" and action \u003d\u003d \"migrate\":"},{"line_number":43,"context_line":"        try:"},{"line_number":44,"context_line":"            if is_system_controller():"},{"line_number":45,"context_line":"                LOG.info(\"Performing dcorch snmp data removal...\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"a38029b9_1a7ca6c1","line":42,"range":{"start_line":42,"start_character":7,"end_line":42,"end_character":28},"updated":"2021-01-05 21:23:01.000000000","message":"from_release \u003d\u003d \"20.06\"","commit_id":"1318beb42b9820df0edcd34557629fdb26395b42"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"856da5594446f440a8c3bbd60bc62fd6c513d1ab","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def remove_snmp_in_orch_request(cur, job_id):"},{"line_number":65,"context_line":"    # Chekc if the record exists in orch_request"},{"line_number":66,"context_line":"    cur.execute(\"select * from orch_request where orch_job_id \u003d \u0027%d\u0027\" % (job_id))"},{"line_number":67,"context_line":"    orch_request \u003d cur.fetchall()"},{"line_number":68,"context_line":"    if orch_request:"}],"source_content_type":"text/x-python","patch_set":14,"id":"18dbd274_a01da0a1","line":65,"range":{"start_line":65,"start_character":6,"end_line":65,"end_character":12},"updated":"2021-01-05 21:23:01.000000000","message":"Check","commit_id":"1318beb42b9820df0edcd34557629fdb26395b42"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"856da5594446f440a8c3bbd60bc62fd6c513d1ab","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    conn \u003d psycopg2.connect(\"dbname\u003d\u0027dcorch\u0027 user\u003d\u0027postgres\u0027\")"},{"line_number":102,"context_line":"    with conn:"},{"line_number":103,"context_line":"        with conn.cursor(cursor_factory\u003dRealDictCursor) as cur:"},{"line_number":104,"context_line":"            # Check if any icoomunity record exists"},{"line_number":105,"context_line":"            cur.execute(\"select * from resource  where resource_type in \""},{"line_number":106,"context_line":"                        \"(\u0027icommunity\u0027,\u0027itrapdest\u0027)\")"},{"line_number":107,"context_line":"            resource_records \u003d cur.fetchall()"}],"source_content_type":"text/x-python","patch_set":14,"id":"2aab632e_fb3c5281","line":104,"range":{"start_line":104,"start_character":27,"end_line":104,"end_character":38},"updated":"2021-01-05 21:23:01.000000000","message":"icommunity or itrapdest","commit_id":"1318beb42b9820df0edcd34557629fdb26395b42"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"856da5594446f440a8c3bbd60bc62fd6c513d1ab","unresolved":true,"context_lines":[{"line_number":114,"context_line":"                remove_snmp_in_orch_job(cur, master_id)"},{"line_number":115,"context_line":"                cur.execute(\"delete from resource  where master_id \u003d \u0027%s\u0027\" % (master_id))"},{"line_number":116,"context_line":"                LOG.info(\"icommunity/itrapdest is removed from resource.\")"},{"line_number":117,"context_line":"    LOG.info(\"icommunity data removal completed.\")"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"if __name__ \u003d\u003d \"__main__\":"}],"source_content_type":"text/x-python","patch_set":14,"id":"70f40599_3ebd5bb5","line":117,"range":{"start_line":117,"start_character":14,"end_line":117,"end_character":25},"updated":"2021-01-05 21:23:01.000000000","message":"snmp community and trapdest","commit_id":"1318beb42b9820df0edcd34557629fdb26395b42"}],"sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/001_init.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"ca5dd6e0ea20e1b933dc19a74ef7a3d773c3dc57","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4a7f8b49_cb21517b","side":"PARENT","updated":"2020-12-15 13:55:27.000000000","message":"Do not modify previously commited migrate_repo upgrade versions.  Instead, please create an incremental migrate_repo version with the necessary upgrade() method to remove the snmp-related schema.","commit_id":"b311cef4294afca5ba0235f224e2a81841c60fd3"}],"sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/110_remove_snmp.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"d38244ae2c93fee737b154c5eb5cb9ba8afa9ede","unresolved":true,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"from sqlalchemy import Column, Enum, MetaData, Table"},{"line_number":7,"context_line":"from sqlalchemy import DateTime, Integer, String"},{"line_number":8,"context_line":"from sqlalchemy.dialects import postgresql"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"235b9766_f8d71b15","line":6,"updated":"2020-12-31 15:27:37.000000000","message":"Can you put each import on a separate line.\nWe don\u0027t impose that pep8 restriction yet, but we plan to in the future","commit_id":"0bd63395aa8a3f1191d7d7def4d03362e418cdc2"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"d38244ae2c93fee737b154c5eb5cb9ba8afa9ede","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        old_accessEnum.drop(bind\u003dmigrate_engine, checkfirst\u003dFalse)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def downgrade(migrate_engine):"},{"line_number":51,"context_line":"    meta \u003d MetaData()"},{"line_number":52,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"07876228_be441fd4","line":50,"updated":"2020-12-31 15:27:37.000000000","message":"I dont think you need to implement downgrade.  Most other migration scripts indicate downgrade is un-supported.","commit_id":"0bd63395aa8a3f1191d7d7def4d03362e418cdc2"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6e505c64ef0a7bafaf92f6322f68c69e27f8c173","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    if migrate_engine.url.get_dialect() is postgresql.dialect:"},{"line_number":30,"context_line":"        old_typeEnum \u003d Enum(\u0027snmpv2c_trap\u0027,"},{"line_number":31,"context_line":"                         \u0027reserve1\u0027,"},{"line_number":32,"context_line":"                         \u0027reserve2\u0027,"},{"line_number":33,"context_line":"                         name\u003d\u0027snmpVersionEnum\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        old_transportEnum \u003d Enum(\u0027udp\u0027,"},{"line_number":36,"context_line":"                              \u0027reserve1\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9bacd63b_33282bd8","line":33,"range":{"start_line":31,"start_character":25,"end_line":33,"end_character":40},"updated":"2021-01-04 13:50:18.000000000","message":"indentation should align with parenthesis, same comments below","commit_id":"336587fcf5ed867f9188563dca4dd25fda284e48"}],"sysinv/sysinv/sysinv/sysinv/tests/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"d38244ae2c93fee737b154c5eb5cb9ba8afa9ede","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2016-2020 Wind River Systems, Inc."},{"line_number":4,"context_line":"# Copyright 2010-2011 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":7,"id":"853201b2_7bfacb37","line":1,"updated":"2020-12-31 15:27:37.000000000","message":"Can you remove the vim directive here as part of your change.\nIt\u0027s not your modification, but we are trying to remove these whenever we see them in a file being updated by someone.","commit_id":"0bd63395aa8a3f1191d7d7def4d03362e418cdc2"}]}