)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"581347d9eaf480570bcc4e69abacded114911bee","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit also includes an update to the unit test pem"},{"line_number":13,"context_line":"file since the certificates present expired on Dec 22, 2020."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ieac392ed6d560be77327dd9e713fae01b17fda04"},{"line_number":16,"context_line":"Story: 2007361"},{"line_number":17,"context_line":"Task: 41165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"efa94e0e_a1dd7051","line":14,"updated":"2020-12-23 18:03:01.000000000","message":"Doesn\u0027t this need a Depends-On against the following?\nhttps://review.opendev.org/c/starlingx/ansible-playbooks/+/768241","commit_id":"1ad87203d35ed4a9ec5550b9870b73fc57f9c61c"},{"author":{"_account_id":31500,"name":"Sabeel Ansari","email":"Sabeel.Ansari@windriver.com","username":"sansari"},"change_message_id":"7ae28965b8994fd477bcf00f0d7c6f19a326aae5","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit also includes an update to the unit test pem"},{"line_number":13,"context_line":"file since the certificates present expired on Dec 22, 2020."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ieac392ed6d560be77327dd9e713fae01b17fda04"},{"line_number":16,"context_line":"Story: 2007361"},{"line_number":17,"context_line":"Task: 41165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"de7ada44_f7d0ec4a","line":14,"in_reply_to":"efa94e0e_a1dd7051","updated":"2020-12-23 18:20:18.000000000","message":"You are right. Fixed.","commit_id":"1ad87203d35ed4a9ec5550b9870b73fc57f9c61c"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b3afb681227b6a81194d424c78839fe1fdba4ffb","unresolved":true,"context_lines":[{"line_number":12,"context_line":"This commit also includes an update to the unit test pem"},{"line_number":13,"context_line":"file since the certificates present expired on Dec 22, 2020."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-on: https://review.opendev.org/#/c/768241/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ieac392ed6d560be77327dd9e713fae01b17fda04"},{"line_number":18,"context_line":"Story: 2007361"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ce2cd61c_528ea61a","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"updated":"2021-01-04 16:14:29.000000000","message":"As the namespace update is presently done on bootstrap, how will the namespace be updated in an upgrade scenario ?","commit_id":"c4e5289ed1dc34077e7e372dc745032467b148ee"}],"controllerconfig/controllerconfig/upgrade-scripts/75-deployment-ns-upgrade.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"83d10e5fe4008f962fca4bb72a036aded01c1850","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        lines \u003d f.readlines()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    for line in lines:"},{"line_number":51,"context_line":"        if line.strip() \u003d\u003d \u0027nodetype\u003dcontroller\u0027:"},{"line_number":52,"context_line":"            return True"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":8,"id":"07d76165_303fc245","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":36},"updated":"2021-01-14 18:56:50.000000000","message":"Check - for system_controller, this should be \u0027distributed_cloud_role\u003dsystemcontroller\u0027\nFor an example, see 80-dc-cert-upgrade.py","commit_id":"e0d4091dac63cc9d7465a4ced33025362f79ff3a"},{"author":{"_account_id":31500,"name":"Sabeel Ansari","email":"Sabeel.Ansari@windriver.com","username":"sansari"},"change_message_id":"e969fe59ff42be22dfbed968e2da60caab957a98","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        lines \u003d f.readlines()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    for line in lines:"},{"line_number":51,"context_line":"        if line.strip() \u003d\u003d \u0027nodetype\u003dcontroller\u0027:"},{"line_number":52,"context_line":"            return True"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f5c3726_b92e0104","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":36},"in_reply_to":"07d76165_303fc245","updated":"2021-01-14 19:44:33.000000000","message":"the 80-dc-cert is specific in the case of DC role. In a AIO system, there is no \"distributed_could_role\" entry in /etc/platform/platform.conf, which is why I decided to check the \u0027nodetype\u0027 instead.","commit_id":"e0d4091dac63cc9d7465a4ced33025362f79ff3a"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"11e88f73dcd7bfe655c2693a343a44ce1ef96435","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        lines \u003d f.readlines()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    for line in lines:"},{"line_number":51,"context_line":"        if line.strip() \u003d\u003d \u0027nodetype\u003dcontroller\u0027:"},{"line_number":52,"context_line":"            return True"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":8,"id":"ab04feaf_2298596b","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":36},"in_reply_to":"5f5c3726_b92e0104","updated":"2021-01-14 20:25:42.000000000","message":"Ok, sounds like this is to run on any controller (being upgraded)? system_controller is the controller in a DistributedCloud system controller; hence the method name is_system_controller.    If this is required on any controller (including subcloud controllers) being upgraded, then this method isnt needed since this script only runs on controllers.","commit_id":"e0d4091dac63cc9d7465a4ced33025362f79ff3a"},{"author":{"_account_id":31500,"name":"Sabeel Ansari","email":"Sabeel.Ansari@windriver.com","username":"sansari"},"change_message_id":"ce2e0c90a7f18fbbb082441f43c40140ab5c7c52","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        lines \u003d f.readlines()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    for line in lines:"},{"line_number":51,"context_line":"        if line.strip() \u003d\u003d \u0027nodetype\u003dcontroller\u0027:"},{"line_number":52,"context_line":"            return True"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":8,"id":"30cbe66b_e86d0313","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":36},"in_reply_to":"ab04feaf_2298596b","updated":"2021-01-14 21:23:37.000000000","message":"Since we need to run this on all controllers, removing this section.","commit_id":"e0d4091dac63cc9d7465a4ced33025362f79ff3a"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c6b85009b25f170eed718e76356c7a7f90ab3ea5","unresolved":true,"context_lines":[{"line_number":51,"context_line":"\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def update_deployment_ns():"},{"line_number":55,"context_line":"    cmd \u003d \"echo \u0027%s\u0027 | \" \\"},{"line_number":56,"context_line":"          \"kubectl --kubeconfig\u003d/etc/kubernetes/admin.conf apply -f -\" % \\"},{"line_number":57,"context_line":"          deployment_ns_yaml"}],"source_content_type":"text/x-python","patch_set":9,"id":"12f47511_da6fbedc","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":10},"updated":"2021-01-15 00:44:31.000000000","message":"nit: create","commit_id":"fc1a6815b445b0b46547a6fdce032ec746d54ee4"},{"author":{"_account_id":31500,"name":"Sabeel Ansari","email":"Sabeel.Ansari@windriver.com","username":"sansari"},"change_message_id":"e8081085890cc9f82c3824d5a73de4e349b96788","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def update_deployment_ns():"},{"line_number":55,"context_line":"    cmd \u003d \"echo \u0027%s\u0027 | \" \\"},{"line_number":56,"context_line":"          \"kubectl --kubeconfig\u003d/etc/kubernetes/admin.conf apply -f -\" % \\"},{"line_number":57,"context_line":"          deployment_ns_yaml"}],"source_content_type":"text/x-python","patch_set":9,"id":"011d650c_511c7091","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":10},"in_reply_to":"12f47511_da6fbedc","updated":"2021-01-15 14:25:42.000000000","message":"Done","commit_id":"fc1a6815b445b0b46547a6fdce032ec746d54ee4"}],"sysinv/sysinv/sysinv/sysinv/tests/cert_mon/test_cert_mon.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"ef759840ecce18b1dd86dd1ec1b0d554821c6c34","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    def test_platformcert_secret_and_ns_check(self):"},{"line_number":46,"context_line":"        self.assertEqual(\"system-restapi-gui-certificate\","},{"line_number":47,"context_line":"                            constants.PLATFORM_CERT_SECRET_NAME)"},{"line_number":48,"context_line":"        self.assertEqual(\"deployment\","},{"line_number":49,"context_line":"                            constants.CERT_NAMESPACE_PLATFORM_CERTS)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_update_pemfile(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aff484d_1f478d6e","line":48,"updated":"2020-12-24 19:34:38.000000000","message":"Really surprised we have this as a unit test.","commit_id":"c32d5038f2a578ff326014208842bf0f7f8161af"},{"author":{"_account_id":31500,"name":"Sabeel Ansari","email":"Sabeel.Ansari@windriver.com","username":"sansari"},"change_message_id":"53d87404577df57ceb0a903fafe65067bdbea0f3","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    def test_platformcert_secret_and_ns_check(self):"},{"line_number":46,"context_line":"        self.assertEqual(\"system-restapi-gui-certificate\","},{"line_number":47,"context_line":"                            constants.PLATFORM_CERT_SECRET_NAME)"},{"line_number":48,"context_line":"        self.assertEqual(\"deployment\","},{"line_number":49,"context_line":"                            constants.CERT_NAMESPACE_PLATFORM_CERTS)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_update_pemfile(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"640b3a78_e10343ce","line":48,"in_reply_to":"9aff484d_1f478d6e","updated":"2020-12-25 15:26:48.000000000","message":"Didnt want anyone changing the namespace by accident, so added this to fail tox in such a case.","commit_id":"c32d5038f2a578ff326014208842bf0f7f8161af"}]}