)]}'
{"controllerconfig/controllerconfig/scripts/controller_config":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"4d7e32d5bbe2938eb953895641af5d372ac5e8b3","unresolved":true,"context_lines":[{"line_number":589,"context_line":"    SUBFUNCTIONS\u003d\"controller\""},{"line_number":590,"context_line":"    if [ \"${system_type}\" \u003d \"All-in-one\" ]"},{"line_number":591,"context_line":"    then"},{"line_number":592,"context_line":"        SUBFUNCTIONS\u003d\"controller,worker\""},{"line_number":593,"context_line":"    fi"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    if [ -f ${HOST_HIERA} ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"cbafcc5c_7255b533","line":592,"updated":"2021-04-13 18:44:18.000000000","message":"how is \u0027lowlatency\u0027, if provisioned, passed in?","commit_id":"1d849e2d5fa77a63069dfbd6e54143aca937f5d7"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"eea613fdafbb329fd6d664534a0c00fe77c398fe","unresolved":false,"context_lines":[{"line_number":589,"context_line":"    SUBFUNCTIONS\u003d\"controller\""},{"line_number":590,"context_line":"    if [ \"${system_type}\" \u003d \"All-in-one\" ]"},{"line_number":591,"context_line":"    then"},{"line_number":592,"context_line":"        SUBFUNCTIONS\u003d\"controller,worker\""},{"line_number":593,"context_line":"    fi"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    if [ -f ${HOST_HIERA} ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"95b64eb1_4e1cef15","line":592,"in_reply_to":"c9c05866_f7fbdb6d","updated":"2021-04-15 03:59:06.000000000","message":"Yes should work. lowlatency does not play a role in manifest to run. Initially it was designed to treat AIO in general, now the implementation is more specific.","commit_id":"1d849e2d5fa77a63069dfbd6e54143aca937f5d7"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"de59fbdeb9b1d8aadfab4073439b2fa23ddd2e55","unresolved":true,"context_lines":[{"line_number":589,"context_line":"    SUBFUNCTIONS\u003d\"controller\""},{"line_number":590,"context_line":"    if [ \"${system_type}\" \u003d \"All-in-one\" ]"},{"line_number":591,"context_line":"    then"},{"line_number":592,"context_line":"        SUBFUNCTIONS\u003d\"controller,worker\""},{"line_number":593,"context_line":"    fi"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    if [ -f ${HOST_HIERA} ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"c9c05866_f7fbdb6d","line":592,"in_reply_to":"cbafcc5c_7255b533","updated":"2021-04-13 20:56:05.000000000","message":"Given that \"subfunctions\" is defined in platform.conf already, why not just pass that in to puppet-manifest-apply.sh and let that script handle it?","commit_id":"1d849e2d5fa77a63069dfbd6e54143aca937f5d7"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"3363cb11d52baaf4016628dbf88477db32234dcd","unresolved":true,"context_lines":[{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    if [ -f ${HOST_HIERA} ]; then"},{"line_number":590,"context_line":"        echo \"$0: Running puppet manifest apply\""},{"line_number":591,"context_line":"        puppet-manifest-apply.sh ${HIERADATA_PATH} ${IPADDR} ${subfunction}"},{"line_number":592,"context_line":"        RC\u003d$?"},{"line_number":593,"context_line":"        if [ $RC -ne 0 ]"},{"line_number":594,"context_line":"        then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9d38db8b_4236b7c0","line":591,"range":{"start_line":591,"start_character":63,"end_line":591,"end_character":74},"updated":"2021-04-15 12:53:21.000000000","message":"please ensure this value is set when required on initial bootstrap (prior to any puppet manifest first being applied which may update platform.conf;  During initial bootstrap/restore there may also be some cases where it wouldnt enter this code path).","commit_id":"6acd2e3564d3d708e496c1a7e78b064419f1fdbf"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"c47cd13c5dd897355668165a7cdce278fc35e19f","unresolved":true,"context_lines":[{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    if [ -f ${HOST_HIERA} ]; then"},{"line_number":590,"context_line":"        echo \"$0: Running puppet manifest apply\""},{"line_number":591,"context_line":"        puppet-manifest-apply.sh ${HIERADATA_PATH} ${IPADDR} ${subfunction}"},{"line_number":592,"context_line":"        RC\u003d$?"},{"line_number":593,"context_line":"        if [ $RC -ne 0 ]"},{"line_number":594,"context_line":"        then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ff08e106_c9fb2655","line":591,"range":{"start_line":591,"start_character":63,"end_line":591,"end_character":74},"in_reply_to":"9d38db8b_4236b7c0","updated":"2021-04-15 14:19:23.000000000","message":"\"subfunction\" would be written by the kickstart and should never change, so there should never be a case where it isn\u0027t present. A check to make sure it\u0027s set never hurts, though","commit_id":"6acd2e3564d3d708e496c1a7e78b064419f1fdbf"}]}