)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31500,"name":"Sabeel Ansari","email":"Sabeel.Ansari@windriver.com","username":"sansari"},"change_message_id":"a9fbcf07c236d9fb594a0658316c054431a607c3","unresolved":true,"context_lines":[{"line_number":11,"context_line":"at build time and embedded in the ISO. This will make it expire less"},{"line_number":12,"context_line":"than a year from the date the system is installed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change removed the certificate generation at build time, instead"},{"line_number":15,"context_line":"generate it at the first time HTTPS is enabled."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1944438"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fab7017d_c13f9ddb","line":14,"updated":"2021-09-23 14:21:46.000000000","message":"New generation during enabling looks ok, but don\u0027t see any removals/cleanup of build-time cert inclusion as part of this commit.","commit_id":"8a95a6b171053e7a569076d00fc945d8358e6eab"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"d12901f4b1d1bfd37472bf26a5c9fe7cf04958e3","unresolved":true,"context_lines":[{"line_number":11,"context_line":"at build time and embedded in the ISO. This will make it expire less"},{"line_number":12,"context_line":"than a year from the date the system is installed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change removed the certificate generation at build time, instead"},{"line_number":15,"context_line":"generate it at the first time HTTPS is enabled."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1944438"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a02cf0d_ee77bb49","line":14,"in_reply_to":"fab7017d_c13f9ddb","updated":"2021-09-23 14:39:51.000000000","message":"It\u0027s in the other review under the same topic.","commit_id":"8a95a6b171053e7a569076d00fc945d8358e6eab"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f3f1d7a23f14bd4ce558bbe0f1e46a34178c0524","unresolved":true,"context_lines":[{"line_number":12303,"context_line":""},{"line_number":12304,"context_line":"        try:"},{"line_number":12305,"context_line":"            with open(os.devnull, \"w\") as fnull:"},{"line_number":12306,"context_line":"                openssl_cmd \u003d \"/usr/bin/openssl req -new -x509 -sha256 \\"},{"line_number":12307,"context_line":"                        -keyout {file} -out {file} -days 365 -nodes \\"},{"line_number":12308,"context_line":"                        -config \u003c(/usr/bin/echo \\\"{config}\\\"); sync\" \\"},{"line_number":12309,"context_line":"                        .format(file\u003dcertificate_file, config\u003dcsr_config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5dcf5438_6c321ece","line":12306,"updated":"2021-09-21 14:45:35.000000000","message":"sysinv/common/utils  does not use the entire path to openssl when it invokes it.\n\nI dont mind that we have the full path, but I suspect that with different OS (debian, centos) could in theory have it installed in a different location","commit_id":"2442d47650e48c6717e5a2f5ead0d6d9d29e72a8"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"d5c84147d636ad63c668b877cfdfc93fa6806d34","unresolved":true,"context_lines":[{"line_number":12303,"context_line":""},{"line_number":12304,"context_line":"        try:"},{"line_number":12305,"context_line":"            with open(os.devnull, \"w\") as fnull:"},{"line_number":12306,"context_line":"                openssl_cmd \u003d \"/usr/bin/openssl req -new -x509 -sha256 \\"},{"line_number":12307,"context_line":"                        -keyout {file} -out {file} -days 365 -nodes \\"},{"line_number":12308,"context_line":"                        -config \u003c(/usr/bin/echo \\\"{config}\\\"); sync\" \\"},{"line_number":12309,"context_line":"                        .format(file\u003dcertificate_file, config\u003dcsr_config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9cab7551_04f89d4a","line":12306,"in_reply_to":"5dcf5438_6c321ece","updated":"2021-09-21 20:41:30.000000000","message":"\u003e sysinv/common/utils  does not use the entire path to openssl when it invokes it.\n\u003e \n\u003e I dont mind that we have the full path, but I suspect that with different OS (debian, centos) could in theory have it installed in a different location\n\nI see a mixed use of full path in common/utils.py and conductor/manager.py, most of the commands that are not part of coreutiles rpm have absolute path. But to make our life easier with different OS, I will remove the absolute path from openssl and echo.","commit_id":"2442d47650e48c6717e5a2f5ead0d6d9d29e72a8"}]}