)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"513a6fe3518ca78b3c6a2835f39bb944bd0ead3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63431840_9ad6f86c","updated":"2021-11-25 02:13:13.000000000","message":"Hi Enzo, are you still working on this review?  If so, could you answer John\u0027s question above?  Do we have some sort of status about how things are going for the applications adding tolerations for this taint?","commit_id":"82862991d9ef40a68d5edc638cbd2456dc41c9ef"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"ead091a2474a462c19f86c2202d08dfd574cc93f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fbd5a749_e938080b","updated":"2021-10-28 18:24:22.000000000","message":"Hi all,\n\nThis review will keep the WF-1 until all apps and pods have been updated with tolerations.\nIn the meanwhile, could you please take a look a it?\n\nThanks!","commit_id":"82862991d9ef40a68d5edc638cbd2456dc41c9ef"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"8f6ebc9568ccc178f87d8add0c8682164d9ee36a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3dd9f875_e4226a78","updated":"2021-11-01 16:57:32.000000000","message":"I am fine with the change, although it looks like the logs will be shown even if nothing gets run","commit_id":"82862991d9ef40a68d5edc638cbd2456dc41c9ef"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"b1c927403a371f4f827decc862428fa235d7863a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a210e892_07617c2f","updated":"2021-10-19 13:49:43.000000000","message":"WF -1 until all the applications have been updated to tolerate this taint.","commit_id":"82862991d9ef40a68d5edc638cbd2456dc41c9ef"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"3f38a45edcaffea5f8852db3dee9190969e67e8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c962ca8_26efd158","updated":"2021-10-20 15:11:41.000000000","message":"recheck","commit_id":"82862991d9ef40a68d5edc638cbd2456dc41c9ef"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"e64062df57d7e08ec06079c8925b0bec226ecbfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"41c3e7c3_558e4e1a","updated":"2021-10-19 20:44:52.000000000","message":"recheck","commit_id":"82862991d9ef40a68d5edc638cbd2456dc41c9ef"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"745a3ef4d00b9d871a6e38c83b010914837aee70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1227a802_e71355e0","in_reply_to":"63431840_9ad6f86c","updated":"2021-11-25 04:26:48.000000000","message":"Hi Steven,\n\nAll applications have been uploaded and they already have the tolerations for this taint. Those changes will be introduced for Stx6.\n\nOn the other hand, the addition of the taint on master nodes on fresh install and upgrade will be introduced after Stx6 release. So we will merge all these reviews when the new branch is created. That will involve some little changes on this script.\n\nRegarding testing activities, I\u0027ll run again all tests for upgrade and fresh install when we are ready for merge these changes.","commit_id":"82862991d9ef40a68d5edc638cbd2456dc41c9ef"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"98351ae0d7afda2905e5deb5004eea4aa591401d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ab327f15_acd45b4b","updated":"2022-02-28 16:23:02.000000000","message":"Just a minor nit, the copyright can be updated to the current year.  Otherwise I think it looks okay.  I assume the comment about applications all being updated is accurate.","commit_id":"485dae63d44e570cf684c4fe612e5d0044cf7d97"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"62d3a01f1d3566f41e226e2d0d362cd6fb4fd40c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"08fc3254_91f939af","updated":"2022-03-02 15:25:38.000000000","message":"Under tests. We might not need this script to add the taint on upgrade.","commit_id":"485dae63d44e570cf684c4fe612e5d0044cf7d97"}],"controllerconfig/controllerconfig/upgrade-scripts/70-k8s-add-taint.sh":[{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"de01643306fb2cd3263b963f795153336d9b9443","unresolved":true,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# This migration script is used for adding taint for master nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NAME\u003d$(basename $0)"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"f0667c4b_f8df1eb8","line":7,"updated":"2021-09-22 20:49:33.000000000","message":"Please add a note that this can be removed in the release following StX6","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"a645e3ac72a72fbdad57fdc0721ab8b9bb1fa737","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# This migration script is used for adding taint for master nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NAME\u003d$(basename $0)"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a9c1f6e_6bf0c1cb","line":7,"in_reply_to":"f0667c4b_f8df1eb8","updated":"2021-09-22 21:26:44.000000000","message":"Ok, thanks David.","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"211a8365d8cd3347cc72240858d1043ab30b0410","unresolved":true,"context_lines":[{"line_number":13,"context_line":"TO_RELEASE\u003d$2"},{"line_number":14,"context_line":"ACTION\u003d$3"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"source /etc/platform/openrc"},{"line_number":17,"context_line":"source /etc/platform/platform.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# This will log to /var/log/platform.log"}],"source_content_type":"text/x-sh","patch_set":1,"id":"14e6c923_dd22ae03","line":16,"updated":"2021-09-22 20:56:43.000000000","message":"Is this used?","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"a645e3ac72a72fbdad57fdc0721ab8b9bb1fa737","unresolved":true,"context_lines":[{"line_number":13,"context_line":"TO_RELEASE\u003d$2"},{"line_number":14,"context_line":"ACTION\u003d$3"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"source /etc/platform/openrc"},{"line_number":17,"context_line":"source /etc/platform/platform.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# This will log to /var/log/platform.log"}],"source_content_type":"text/x-sh","patch_set":1,"id":"f48e48b8_78abf516","line":16,"in_reply_to":"14e6c923_dd22ae03","updated":"2021-09-22 21:26:44.000000000","message":"No, I\u0027ll delete this line. Thanks","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"de01643306fb2cd3263b963f795153336d9b9443","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"log \"$NAME: Starting adding taint for master nodes from release $FROM_RELEASE to $TO_RELEASE with action $ACTION\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"if [ \"$ACTION\" \u003d\u003d \"activate\" ]; then"},{"line_number":27,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"72911abc_2e2410ca","line":26,"updated":"2021-09-22 20:49:33.000000000","message":"Please check from_release \u003d 21.05","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"8ceee34e4eeee368a9dc6278f942d2c2a4fc0d26","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"log \"$NAME: Starting adding taint for master nodes from release $FROM_RELEASE to $TO_RELEASE with action $ACTION\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"if [ \"$ACTION\" \u003d\u003d \"activate\" ]; then"},{"line_number":27,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"f88516a0_607e7359","line":26,"in_reply_to":"5ce1da18_de1144e1","updated":"2021-09-23 16:16:44.000000000","message":"If this is needed for upgrades from 21.12 we\u0027d need to wait until we start development on the next release. While this is low risk we shouldn\u0027t add code that isn\u0027t used in this release.","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"a645e3ac72a72fbdad57fdc0721ab8b9bb1fa737","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"log \"$NAME: Starting adding taint for master nodes from release $FROM_RELEASE to $TO_RELEASE with action $ACTION\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"if [ \"$ACTION\" \u003d\u003d \"activate\" ]; then"},{"line_number":27,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5ce1da18_de1144e1","line":26,"in_reply_to":"72911abc_2e2410ca","updated":"2021-09-22 21:26:44.000000000","message":"I will. I am waiting for definitions about when to add the taints (whether 21.12 or 22.06).\nIn case we need to check from_release 21.12, is it correct to add this script in the present version?","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"b1c927403a371f4f827decc862428fa235d7863a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"log \"$NAME: Starting adding taint for master nodes from release $FROM_RELEASE to $TO_RELEASE with action $ACTION\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"if [ \"$ACTION\" \u003d\u003d \"activate\" ]; then"},{"line_number":27,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"dec2a92f_61928336","line":26,"in_reply_to":"f88516a0_607e7359","updated":"2021-10-19 13:49:43.000000000","message":"Done","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"de01643306fb2cd3263b963f795153336d9b9443","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"},{"line_number":30,"context_line":"    RESPONSE\u003d$(kubectl --kubeconfig\u003d/etc/kubernetes/admin.conf taint nodes ${NODES} node-role.kubernetes.io/master:NoSchedule)"},{"line_number":31,"context_line":"    log \"$NAME: ${RESPONSE}\""},{"line_number":32,"context_line":"    else"},{"line_number":33,"context_line":"        log \"$NAME: No taint required for AIO system.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"07ad2bd7_c081e917","line":30,"updated":"2021-09-22 20:49:33.000000000","message":"We need to validate that the taint was added. Also this script can be called multiple times so ensure that scenario is tested.","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"a645e3ac72a72fbdad57fdc0721ab8b9bb1fa737","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"},{"line_number":30,"context_line":"    RESPONSE\u003d$(kubectl --kubeconfig\u003d/etc/kubernetes/admin.conf taint nodes ${NODES} node-role.kubernetes.io/master:NoSchedule)"},{"line_number":31,"context_line":"    log \"$NAME: ${RESPONSE}\""},{"line_number":32,"context_line":"    else"},{"line_number":33,"context_line":"        log \"$NAME: No taint required for AIO system.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f272eb5_a2bfcdc9","line":30,"in_reply_to":"07ad2bd7_c081e917","updated":"2021-09-22 21:26:44.000000000","message":"When we run this script and the taint was already added previously, the following stderr is printed:\nnode controller-0 already has node-role.kubernetes.io/master taint(s) with same effect(s) and --overwrite is false\nnode controller-1 already has node-role.kubernetes.io/master taint(s) with same effect(s) and --overwrite is false\n\nAre you ok with redirecting this stderr to the platform.log file as well?","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"8ceee34e4eeee368a9dc6278f942d2c2a4fc0d26","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"},{"line_number":30,"context_line":"    RESPONSE\u003d$(kubectl --kubeconfig\u003d/etc/kubernetes/admin.conf taint nodes ${NODES} node-role.kubernetes.io/master:NoSchedule)"},{"line_number":31,"context_line":"    log \"$NAME: ${RESPONSE}\""},{"line_number":32,"context_line":"    else"},{"line_number":33,"context_line":"        log \"$NAME: No taint required for AIO system.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"f96ce5e9_e476896d","line":30,"in_reply_to":"5f272eb5_a2bfcdc9","updated":"2021-09-23 16:16:44.000000000","message":"Yeah stderr is fine to send to the logs. My concern is that we\u0027re not checking the return code (at least) to ensure the command ran successfully.","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"b1c927403a371f4f827decc862428fa235d7863a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"},{"line_number":30,"context_line":"    RESPONSE\u003d$(kubectl --kubeconfig\u003d/etc/kubernetes/admin.conf taint nodes ${NODES} node-role.kubernetes.io/master:NoSchedule)"},{"line_number":31,"context_line":"    log \"$NAME: ${RESPONSE}\""},{"line_number":32,"context_line":"    else"},{"line_number":33,"context_line":"        log \"$NAME: No taint required for AIO system.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"925d7f61_44de19ef","line":30,"in_reply_to":"f96ce5e9_e476896d","updated":"2021-10-19 13:49:43.000000000","message":"Done","commit_id":"b18e1f41d79a86008f44838843f5d3f3725ba865"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"e34d49c45399bbbe627a7ff39b840cadc432d6f2","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"log \"$NAME: Starting adding taint for master nodes from release $FROM_RELEASE to $TO_RELEASE with action $ACTION\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if [ \"$FROM_RELEASE\" \u003d\u003d \"21.05\" ] \u0026\u0026 [ \"$ACTION\" \u003d\u003d \"activate\" ]; then"},{"line_number":29,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":30,"context_line":"        NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"},{"line_number":31,"context_line":"        RESPONSE\u003d$(kubectl --kubeconfig\u003d/etc/kubernetes/admin.conf taint nodes ${NODES} node-role.kubernetes.io/master:NoSchedule 2\u003e\u00261)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"b551e050_7c196fcd","line":28,"range":{"start_line":28,"start_character":24,"end_line":28,"end_character":31},"updated":"2021-09-23 16:48:59.000000000","message":"TBD","commit_id":"cef7d41add8da06f5a85cbd0a245327bc2a83a53"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"b1c927403a371f4f827decc862428fa235d7863a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"log \"$NAME: Starting adding taint for master nodes from release $FROM_RELEASE to $TO_RELEASE with action $ACTION\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if [ \"$FROM_RELEASE\" \u003d\u003d \"21.05\" ] \u0026\u0026 [ \"$ACTION\" \u003d\u003d \"activate\" ]; then"},{"line_number":29,"context_line":"    if [ ${system_type} !\u003d \u0027All-in-one\u0027 ]; then"},{"line_number":30,"context_line":"        NODES\u003d$(kubectl get nodes --selector\u003dnode-role.kubernetes.io/master | awk \u0027FNR!\u003d1{print $1}\u0027)"},{"line_number":31,"context_line":"        RESPONSE\u003d$(kubectl --kubeconfig\u003d/etc/kubernetes/admin.conf taint nodes ${NODES} node-role.kubernetes.io/master:NoSchedule 2\u003e\u00261)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dcd8ca67_d2348df5","line":28,"range":{"start_line":28,"start_character":24,"end_line":28,"end_character":31},"in_reply_to":"b551e050_7c196fcd","updated":"2021-10-19 13:49:43.000000000","message":"Done","commit_id":"cef7d41add8da06f5a85cbd0a245327bc2a83a53"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"e37e7e04f384f0e048250c25a6a018b6c110e6c0","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# This migration script is used for adding taint for master nodes."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# This script can be removed in the release that follows stx6."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"7b0f9d3e_19aa0cfa","line":8,"updated":"2021-11-02 17:24:53.000000000","message":"Was this script integration tested with 71-enable-separate-etcd-ca.sh ?  This appears to run in between some basic k8s application/infra setup.","commit_id":"82862991d9ef40a68d5edc638cbd2456dc41c9ef"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"98351ae0d7afda2905e5deb5004eea4aa591401d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# This migration script is used for adding taint for master nodes."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# This script can be removed in the release that follows stx6."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"200ea050_5202c2a8","line":8,"in_reply_to":"7b0f9d3e_19aa0cfa","updated":"2022-02-28 16:23:02.000000000","message":"Looks like this is no longer an issue,  71-enable-separate-etcd-ca.sh will not do anything for an upgrade from 21.12.","commit_id":"82862991d9ef40a68d5edc638cbd2456dc41c9ef"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"98351ae0d7afda2905e5deb5004eea4aa591401d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2021 Wind River Systems, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":9,"id":"d51b3f2d_6ee3ef99","line":3,"range":{"start_line":3,"start_character":18,"end_line":3,"end_character":20},"updated":"2022-02-28 16:23:02.000000000","message":"2022","commit_id":"485dae63d44e570cf684c4fe612e5d0044cf7d97"}]}