)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"3514727672ee6cdaf67d7721b89f943d6c762b30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"42fcc114_654adf1e","updated":"2021-10-22 13:30:15.000000000","message":"Thanks Hugo","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":32851,"name":"Douglas Lopes Pereira","email":"douglas.pereira@windriver.com","username":"douglas.pereira"},"change_message_id":"94599c2f05d0cf1ab9a4de9e7cfde9d22300fca0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"649f9afb_e51b945b","updated":"2021-10-22 14:32:29.000000000","message":"Hey guys, can you please take a look at this change?","commit_id":"3cc5673489452ededb46ba77fe78a20297c4ea76"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"f6dfed69ff13ffdf2b4f39e0c21d4337a0855093","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c856d3cf_f0e43bc8","updated":"2021-10-22 21:22:17.000000000","message":"LGTM","commit_id":"3cc5673489452ededb46ba77fe78a20297c4ea76"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"34102d559110981cd9bb32dc64d982a6822d74b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f3203f26_fe6605c3","updated":"2021-10-22 14:45:12.000000000","message":"Marked as WIP again to test some things, please don\u0027t review yet","commit_id":"3cc5673489452ededb46ba77fe78a20297c4ea76"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"005f1ec04a54773f2cb29c6eaf01a09ff0197855","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6bfa67bf_ddbb9f60","updated":"2021-10-22 20:04:42.000000000","message":"Thanks for waiting, the code may be reviewed now","commit_id":"3cc5673489452ededb46ba77fe78a20297c4ea76"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"abda3417cafa2c631eabd95357439c4f539aeea3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8da35892_58233f71","updated":"2021-10-25 16:04:32.000000000","message":"LGTM","commit_id":"8ebaf7b6d0645a0a2bd3ad48e55dfa93bb384b32"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"cfc2a3126c69c5459051a7e7fbb968f01eee5990","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dc337852_098cfad9","updated":"2021-10-25 18:58:01.000000000","message":"LGTM","commit_id":"8ebaf7b6d0645a0a2bd3ad48e55dfa93bb384b32"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"86282f572c6e3ec00704a4c38951dc643d2bf1da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"088d0d2b_c88e2b64","updated":"2021-11-03 18:34:50.000000000","message":"Fixed, please review","commit_id":"dfb8e03a5954f54c8303991526dcc0c4f4e49e25"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"11782ea5eb0fa9d2f0d7ff8eb35c589860be3726","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"69b4f671_6c45e8cd","updated":"2021-11-04 13:57:15.000000000","message":"Updated the version to check","commit_id":"e26b2322c42b548d0676fb898a3157e6c2c2c89f"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"a7cbcd8be9c62f68158e90d25a5cc46685cca2c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9f5dabb5_4b98b2e9","updated":"2021-11-04 14:36:54.000000000","message":"recheck","commit_id":"e26b2322c42b548d0676fb898a3157e6c2c2c89f"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"67a64bfc945a49a0d96f080317f528b7bc52b234","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f71be13d_4dadc71e","updated":"2021-11-04 17:26:17.000000000","message":"Needed to do rebase so the sysinv fix for zuul/tox gets included as part of the parent commit chain","commit_id":"135c1729ba4e19c146387c35a17ad6ac87b2bb42"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"826d8d36f14876ad70da18b97e468e3875134ad7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3dc1efe5_115f5f43","in_reply_to":"f71be13d_4dadc71e","updated":"2021-11-04 17:43:09.000000000","message":"Done","commit_id":"135c1729ba4e19c146387c35a17ad6ac87b2bb42"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"6ad359808388f93db8f6caa9b20a8b8e8f635eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1e72ff9c_6c9c74fd","updated":"2021-11-16 21:27:47.000000000","message":"This change needs to be updated with the current OpenStack version","commit_id":"2a308abaae9a91cfa2b68b77b38d17dec9a63496"}],"sysinv/sysinv/sysinv/sysinv/puppet/pci_irq_affinity.py":[{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"e5e3493960a39e390721b530a44304d5d737ecde","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2021 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"20a1b913_ab950229","line":2,"updated":"2021-10-21 21:44:45.000000000","message":"it should be: 2017-2021","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"3514727672ee6cdaf67d7721b89f943d6c762b30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2021 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"4db1610b_0a97fb2b","line":2,"in_reply_to":"20a1b913_ab950229","updated":"2021-10-22 13:30:15.000000000","message":"Done","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"e5e3493960a39e390721b530a44304d5d737ecde","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"from sysinv.common import constants, utils"},{"line_number":8,"context_line":"from sysinv.helm import helm"},{"line_number":9,"context_line":"from sysinv.puppet import openstack"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"0f194850_29d7a0b4","line":7,"updated":"2021-10-21 21:44:45.000000000","message":"one import per line.","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"3514727672ee6cdaf67d7721b89f943d6c762b30","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"from sysinv.common import constants, utils"},{"line_number":8,"context_line":"from sysinv.helm import helm"},{"line_number":9,"context_line":"from sysinv.puppet import openstack"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"467cf6ce_cb092a8e","line":7,"in_reply_to":"0f194850_29d7a0b4","updated":"2021-10-22 13:30:15.000000000","message":"Done","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"e5e3493960a39e390721b530a44304d5d737ecde","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    PLATFORM_KEYRING_SERVICE \u003d \u0027CGCS\u0027"},{"line_number":15,"context_line":"    OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT \u003d 117"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    def get_agent_container_support(self):"},{"line_number":18,"context_line":"        \"\"\""},{"line_number":19,"context_line":"        Checks whether the OpenStack application version already supports pci irq affinity agent"},{"line_number":20,"context_line":"        (This function will be removed when the service is completely removed from the platform)"}],"source_content_type":"text/x-python","patch_set":3,"id":"497cc169_f7badbe4","line":17,"updated":"2021-10-21 21:44:45.000000000","message":"This returns a boolean, should be something like: is_supported_by_pci_irq_agent_container","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"3514727672ee6cdaf67d7721b89f943d6c762b30","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    PLATFORM_KEYRING_SERVICE \u003d \u0027CGCS\u0027"},{"line_number":15,"context_line":"    OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT \u003d 117"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    def get_agent_container_support(self):"},{"line_number":18,"context_line":"        \"\"\""},{"line_number":19,"context_line":"        Checks whether the OpenStack application version already supports pci irq affinity agent"},{"line_number":20,"context_line":"        (This function will be removed when the service is completely removed from the platform)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5255f19d_7f9226be","line":17,"in_reply_to":"497cc169_f7badbe4","updated":"2021-10-22 13:30:15.000000000","message":"Done","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"e5e3493960a39e390721b530a44304d5d737ecde","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    def get_agent_container_support(self):"},{"line_number":18,"context_line":"        \"\"\""},{"line_number":19,"context_line":"        Checks whether the OpenStack application version already supports pci irq affinity agent"},{"line_number":20,"context_line":"        (This function will be removed when the service is completely removed from the platform)"},{"line_number":21,"context_line":"        \"\"\""},{"line_number":22,"context_line":"        openstack_app_name \u003d constants.HELM_APP_OPENSTACK"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"034ffa77_d0e35755","line":20,"updated":"2021-10-21 21:44:45.000000000","message":"this note should be above the method signature.","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"3514727672ee6cdaf67d7721b89f943d6c762b30","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    def get_agent_container_support(self):"},{"line_number":18,"context_line":"        \"\"\""},{"line_number":19,"context_line":"        Checks whether the OpenStack application version already supports pci irq affinity agent"},{"line_number":20,"context_line":"        (This function will be removed when the service is completely removed from the platform)"},{"line_number":21,"context_line":"        \"\"\""},{"line_number":22,"context_line":"        openstack_app_name \u003d constants.HELM_APP_OPENSTACK"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a4d3872e_f15f04c1","line":20,"in_reply_to":"034ffa77_d0e35755","updated":"2021-10-22 13:30:15.000000000","message":"Done","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"e5e3493960a39e390721b530a44304d5d737ecde","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        openstack_app_version \u003d self.dbapi.kube_app_get(openstack_app_name).app_version"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        # stx-openstack app version string format: x.y-wz-release-info"},{"line_number":29,"context_line":"        split_version \u003d openstack_app_version.split(\u0027-\u0027, 2)"},{"line_number":30,"context_line":"        if int(split_version[1]) \u003c self.OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT:"},{"line_number":31,"context_line":"            return False"},{"line_number":32,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"6e7e98b3_3f17ebc9","line":29,"updated":"2021-10-21 21:44:45.000000000","message":"openstack_app_version \u003d int(openstack_app_version.split(\u0027-\u0027, 2)[1])\nif openstack_app_version \u003c OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT:\n    ...","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"3514727672ee6cdaf67d7721b89f943d6c762b30","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        openstack_app_version \u003d self.dbapi.kube_app_get(openstack_app_name).app_version"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        # stx-openstack app version string format: x.y-wz-release-info"},{"line_number":29,"context_line":"        split_version \u003d openstack_app_version.split(\u0027-\u0027, 2)"},{"line_number":30,"context_line":"        if int(split_version[1]) \u003c self.OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT:"},{"line_number":31,"context_line":"            return False"},{"line_number":32,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd6fbf70_0898d3df","line":29,"in_reply_to":"6e7e98b3_3f17ebc9","updated":"2021-10-22 13:30:15.000000000","message":"Done","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"e5e3493960a39e390721b530a44304d5d737ecde","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        split_version \u003d openstack_app_version.split(\u0027-\u0027, 2)"},{"line_number":30,"context_line":"        if int(split_version[1]) \u003c self.OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT:"},{"line_number":31,"context_line":"            return False"},{"line_number":32,"context_line":"        else:"},{"line_number":33,"context_line":"            return True"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_secure_static_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"015ee3ad_45eb1b17","line":32,"updated":"2021-10-21 21:44:45.000000000","message":"you can remove this else.","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"3514727672ee6cdaf67d7721b89f943d6c762b30","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        split_version \u003d openstack_app_version.split(\u0027-\u0027, 2)"},{"line_number":30,"context_line":"        if int(split_version[1]) \u003c self.OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT:"},{"line_number":31,"context_line":"            return False"},{"line_number":32,"context_line":"        else:"},{"line_number":33,"context_line":"            return True"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_secure_static_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"0776d574_62535226","line":32,"in_reply_to":"015ee3ad_45eb1b17","updated":"2021-10-22 13:30:15.000000000","message":"Done","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"e5e3493960a39e390721b530a44304d5d737ecde","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        if utils.is_openstack_applied(self.dbapi):"},{"line_number":42,"context_line":"            helm_data \u003d helm.HelmOperatorData(self.dbapi)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"            enable_agent \u003d False if self.get_agent_container_support() else True"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            # The openstack services are authenticated with pod based"},{"line_number":47,"context_line":"            # keystone."}],"source_content_type":"text/x-python","patch_set":3,"id":"a289cd53_2454f571","line":44,"updated":"2021-10-21 21:44:45.000000000","message":"I could be wrong, but this should be the other way, no?","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"3514727672ee6cdaf67d7721b89f943d6c762b30","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if utils.is_openstack_applied(self.dbapi):"},{"line_number":42,"context_line":"            helm_data \u003d helm.HelmOperatorData(self.dbapi)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"            enable_agent \u003d False if self.get_agent_container_support() else True"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            # The openstack services are authenticated with pod based"},{"line_number":47,"context_line":"            # keystone."}],"source_content_type":"text/x-python","patch_set":3,"id":"2fb1ed25_f6ac8bf5","line":44,"in_reply_to":"a289cd53_2454f571","updated":"2021-10-22 13:30:15.000000000","message":"No, the agent platform service should be disabled if OpenStack contains the containerized agent (so False if has container support), but anyway I changed the variable name including \u0027service\u0027 on it to try to be clearer","commit_id":"c44d7898a9420ca91077ba836adfebfd41e52781"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"7c1ca5e5cb71e6bebdf6c33d68c8dd180b5d2814","unresolved":true,"context_lines":[{"line_number":24,"context_line":"        openstack_app_name \u003d constants.HELM_APP_OPENSTACK"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        if not self.dbapi.kube_app_get(openstack_app_name).active:"},{"line_number":27,"context_line":"            return False"},{"line_number":28,"context_line":"        openstack_app_version \u003d self.dbapi.kube_app_get(openstack_app_name).app_version"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # stx-openstack app version string format: x.y-wz-release-info"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a65846e_96844e02","line":27,"updated":"2021-10-25 14:04:13.000000000","message":"Are we enabling the pci irq affinity agent platform service even when the openstack application is not active? Is it really necessary?","commit_id":"3cc5673489452ededb46ba77fe78a20297c4ea76"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"c0e9a84df4694224a9fb650bb0f42ae367ef7e1c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        openstack_app_name \u003d constants.HELM_APP_OPENSTACK"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        if not self.dbapi.kube_app_get(openstack_app_name).active:"},{"line_number":27,"context_line":"            return False"},{"line_number":28,"context_line":"        openstack_app_version \u003d self.dbapi.kube_app_get(openstack_app_name).app_version"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # stx-openstack app version string format: x.y-wz-release-info"}],"source_content_type":"text/x-python","patch_set":5,"id":"ace2dbdf_34cd2f12","line":27,"in_reply_to":"5a65846e_96844e02","updated":"2021-10-25 14:50:55.000000000","message":"The logic is wrong indeed, but this part of the code won\u0027t ever be executed because of the check on line 42. Thanks for pointing that out.","commit_id":"3cc5673489452ededb46ba77fe78a20297c4ea76"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"87549202cfcb56fed04ab09c233322682fe871bb","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        includes the pci irq affinity agent container"},{"line_number":23,"context_line":"        \"\"\""},{"line_number":24,"context_line":"        openstack_app_name \u003d constants.HELM_APP_OPENSTACK"},{"line_number":25,"context_line":"        openstack_app_version \u003d self.dbapi.kube_app_get(openstack_app_name).app_version"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        # stx-openstack app version string format: x.y-wz-release-info"},{"line_number":28,"context_line":"        openstack_app_version \u003d int(openstack_app_version.split(\u0027-\u0027, 2)[1])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc37409_fae86847","line":25,"updated":"2021-11-02 17:38:29.000000000","message":"I think this should be wrapped in a try block.\nWe could encounter an exception if that app does not exist.\nhttps://github.com/starlingx/config/blob/master/sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/api.py#L7840","commit_id":"8ebaf7b6d0645a0a2bd3ad48e55dfa93bb384b32"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"86282f572c6e3ec00704a4c38951dc643d2bf1da","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        includes the pci irq affinity agent container"},{"line_number":23,"context_line":"        \"\"\""},{"line_number":24,"context_line":"        openstack_app_name \u003d constants.HELM_APP_OPENSTACK"},{"line_number":25,"context_line":"        openstack_app_version \u003d self.dbapi.kube_app_get(openstack_app_name).app_version"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        # stx-openstack app version string format: x.y-wz-release-info"},{"line_number":28,"context_line":"        openstack_app_version \u003d int(openstack_app_version.split(\u0027-\u0027, 2)[1])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a357911_a382b8fe","line":25,"in_reply_to":"5fc37409_fae86847","updated":"2021-11-03 18:34:50.000000000","message":"Since there is a check with utils.is_openstack_applied(self.dbapi) before calling this function it is highly unlikely that an exception would be raised, but I put it on the try block because in case that the version is not parsed correctly, so that\u0027s the reason of the broader exception clause.","commit_id":"8ebaf7b6d0645a0a2bd3ad48e55dfa93bb384b32"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"5094877738eee995278e66b16c234f1bd2ae8b63","unresolved":true,"context_lines":[{"line_number":13,"context_line":"class PciIrqAffinityPuppet(openstack.OpenstackBasePuppet):"},{"line_number":14,"context_line":"    \"\"\"Class to encapsulate puppet operations for PciIrqAffinity configuration\"\"\""},{"line_number":15,"context_line":"    PLATFORM_KEYRING_SERVICE \u003d \u0027CGCS\u0027"},{"line_number":16,"context_line":"    OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT \u003d 120"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    # This function will be removed when the service is completely removed from the platform"},{"line_number":19,"context_line":"    def should_enable_agent_service(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"32aa6d47_1ae8eba2","line":16,"updated":"2021-11-16 19:49:13.000000000","message":"I think the build will be 124, after the merge of https://review.opendev.org/c/starlingx/openstack-armada-app/+/813247. Let\u0027s see on tomorrow\u0027s build.","commit_id":"2a308abaae9a91cfa2b68b77b38d17dec9a63496"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"6ad359808388f93db8f6caa9b20a8b8e8f635eaf","unresolved":true,"context_lines":[{"line_number":13,"context_line":"class PciIrqAffinityPuppet(openstack.OpenstackBasePuppet):"},{"line_number":14,"context_line":"    \"\"\"Class to encapsulate puppet operations for PciIrqAffinity configuration\"\"\""},{"line_number":15,"context_line":"    PLATFORM_KEYRING_SERVICE \u003d \u0027CGCS\u0027"},{"line_number":16,"context_line":"    OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT \u003d 120"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    # This function will be removed when the service is completely removed from the platform"},{"line_number":19,"context_line":"    def should_enable_agent_service(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"4055cebf_bc30e8e6","line":16,"in_reply_to":"32aa6d47_1ae8eba2","updated":"2021-11-16 21:27:47.000000000","message":"Built the stx-openstack and the version came as 125. I will wait for tomorrow\u0027s build to confirm and then update here. Thanks for raising this discussion.","commit_id":"2a308abaae9a91cfa2b68b77b38d17dec9a63496"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"ef3161cbbbd9554c538f5f0d4ae2f3de786a4f3e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"class PciIrqAffinityPuppet(openstack.OpenstackBasePuppet):"},{"line_number":14,"context_line":"    \"\"\"Class to encapsulate puppet operations for PciIrqAffinity configuration\"\"\""},{"line_number":15,"context_line":"    PLATFORM_KEYRING_SERVICE \u003d \u0027CGCS\u0027"},{"line_number":16,"context_line":"    OPENSTACK_VERSION_WITH_CONTAINER_SUPPORT \u003d 120"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    # This function will be removed when the service is completely removed from the platform"},{"line_number":19,"context_line":"    def should_enable_agent_service(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"44c8e595_09c27382","line":16,"in_reply_to":"4055cebf_bc30e8e6","updated":"2021-11-17 12:30:56.000000000","message":"Done","commit_id":"2a308abaae9a91cfa2b68b77b38d17dec9a63496"}]}