)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"959aee9459104c6d62ca4d101b8816cbac08826d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79fe99e6_b9a2ac90","updated":"2021-10-22 20:32:48.000000000","message":"Even though the review is WIP, I am adding Kyle because he worked on kubernetes watcher related changes and may have alternatives for how to handle this scenario","commit_id":"fdc47cea4f0b3508e37604846debca7a0ebff5bd"},{"author":{"_account_id":33667,"name":"Rafael Camargos","email":"RafaelLucas.Camargos@windriver.com","username":"rcamargo"},"change_message_id":"62de40d3ffeb4aeeab5f24d38b6da39b8f007395","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09397c39_d223475b","updated":"2021-10-26 13:42:28.000000000","message":"The cert-manager behavior mentioned can be confirmed by watching the rootca-certificate secret state during its creation with `kubectl get secret system-kube-rootca-certificate -n deployment -o yaml -w | grep \u0027tls.crt\u0027 --line-buffered -B 2 -A 1`:\n\n```\ndata:\n  ca.crt: \"\"\n  tls.crt: \"\"\n  tls.key: XXX...\n--\ndata:\n  ca.crt: XXX...\n  tls.crt: XXX...\n  tls.key: XXX...\n```","commit_id":"34a886359066917cf95134b5fec7c260eb170a11"},{"author":{"_account_id":32877,"name":"Joao Soubihe","email":"JoaoPaulo.Soubihe@windriver.com","username":"jsoubihe"},"change_message_id":"3a099d578ece673b5dbff686ea684f81ab3c02f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bf84f150_b3e2646c","updated":"2021-10-26 13:44:46.000000000","message":"I previously discussed the changes with Rafael, so I\u0027m good with them","commit_id":"350cc912adfcd28826577abcb1d9c86bcd979457"}],"sysinv/sysinv/sysinv/sysinv/common/kubernetes.py":[{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"c1bf5aada35aa50ec050defaa48af82865a79efe","unresolved":true,"context_lines":[{"line_number":1006,"context_line":"            if secret is not None and secret.data is not None:"},{"line_number":1007,"context_line":"                LOG.debug(\"secret \u003d %s\" % secret)"},{"line_number":1008,"context_line":"                return secret"},{"line_number":1009,"context_line":"            time.sleep(1)"},{"line_number":1010,"context_line":"        raise exception.KubeSecretCreateTimeout(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f889ac7e_b9b6a21c","line":1009,"range":{"start_line":1009,"start_character":12,"end_line":1009,"end_character":25},"updated":"2021-10-25 14:13:08.000000000","message":"This seems fine to me. I think resorting to a k8s watch would be overkill here and not worth the overhead. In my opinion the k8s watches are more for longer-term background notfications, so polling seems fine here. If it turns out to be resource intensive you could back off on the polling interval to 2, 3, or even 5s.","commit_id":"fdc47cea4f0b3508e37604846debca7a0ebff5bd"}]}