)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"2c6db9002462a66406d34cc3d08c290a8aed8cce","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"Verify load import times out"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I50cd9a7d7a6b3b3a334b6bd8a74b2ca189193a7f"},{"line_number":18,"context_line":"Signed-off-by: Jessica Castelino \u003cjessica.castelino@windriver.com\u003e"},{"line_number":19,"context_line":"Closes-Bug: 1949890"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5dd71ce5_d1c28b28","line":16,"updated":"2021-11-05 13:17:19.000000000","message":"should also verify the success case for load-import and regression with license-import, etc.","commit_id":"c4b1b6bebd5d80831901531ff6cd01fb03f21901"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"fff965028202a5599bfeb2d0b8ae4d3391439160","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"Verify load import times out"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I50cd9a7d7a6b3b3a334b6bd8a74b2ca189193a7f"},{"line_number":18,"context_line":"Signed-off-by: Jessica Castelino \u003cjessica.castelino@windriver.com\u003e"},{"line_number":19,"context_line":"Closes-Bug: 1949890"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e2b5e503_4df8683a","line":16,"updated":"2021-11-08 11:59:39.000000000","message":"should also verify the success case for load-import and regression with license-import, etc. (per comment in PS#3)","commit_id":"098824ecba66042a2f10f292306b4cf75bbd47f4"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"5a770b2f9581fdd9cb5f133b8477285a946b9f2c","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"Verify load import times out"},{"line_number":16,"context_line":"Verify license installation works as expecetd"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I50cd9a7d7a6b3b3a334b6bd8a74b2ca189193a7f"},{"line_number":19,"context_line":"Signed-off-by: Jessica Castelino \u003cjessica.castelino@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6e0949a8_2fd71e47","line":16,"range":{"start_line":16,"start_character":37,"end_line":16,"end_character":45},"updated":"2021-11-10 18:24:52.000000000","message":"expected","commit_id":"57be3ca10569647d835595caf7f5bec5bc6949f9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f7cdf0b2056d244195e19f62ffa5c891f9df41a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76840249_d01623c3","updated":"2021-11-04 20:32:14.000000000","message":"I am happy with the changes.\nI will wait and see if the other cores like the defaults, etc..","commit_id":"ccae9a0d9dbd4dce9f6dbae756c6149de044e450"},{"author":{"_account_id":31484,"name":"Jessica Castelino","email":"jessica.castelino@windriver.com","username":"jcasteli"},"change_message_id":"643f71b96a0d627889fb424356148fe4ada8d8b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0b1a3810_cbb325d4","updated":"2021-11-04 20:34:24.000000000","message":"Testing in progress","commit_id":"c4b1b6bebd5d80831901531ff6cd01fb03f21901"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"72fe7ba4b45b645579e70e1cf3456577184d2bbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"38e7c132_c13685ad","updated":"2021-11-09 22:16:07.000000000","message":"I picked the change to my env and verified (by dropping the timeout to 30 seconds, and adding a 60 second sleep in import_load in the API)  that the timeout works.\n\nsystem load-import some_fake.iso some_fake.sig\nThis operation will take a while. Please wait.\n...\nLoad import failed. Reason: HTTPConnectionPool(host\u003d\u0027192.168.204.2\u0027, port\u003d6385): Read timed out. (read timeout\u003d30)\n","commit_id":"098824ecba66042a2f10f292306b4cf75bbd47f4"}],"sysinv/cgts-client/cgts-client/cgtsclient/common/http.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"899ae85f9d592d6a15e46ad9786f8b9608d44940","unresolved":true,"context_lines":[{"line_number":304,"context_line":"        files \u003d {\u0027file\u0027: (\"for_upload\","},{"line_number":305,"context_line":"                          kwargs[\u0027body\u0027],"},{"line_number":306,"context_line":"                          )}"},{"line_number":307,"context_line":"        req \u003d requests.post(connection_url, headers\u003dheaders, files\u003dfiles)"},{"line_number":308,"context_line":"        return req.json()"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def upload_request_with_data(self, method, url, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"2b57233a_bc8ae07e","line":307,"updated":"2021-11-04 19:28:40.000000000","message":"Are you sure the timeout in the parent class gets used here in requests.post?\n\nI thought you would have to pass it in explicitly here. (and other places that call requests.post)","commit_id":"39a347c779ca98d9a65187daf35b82a8c7993a5b"},{"author":{"_account_id":31484,"name":"Jessica Castelino","email":"jessica.castelino@windriver.com","username":"jcasteli"},"change_message_id":"ef403d281629aa5f8f8ff120e3f04ec66bbfd907","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        files \u003d {\u0027file\u0027: (\"for_upload\","},{"line_number":305,"context_line":"                          kwargs[\u0027body\u0027],"},{"line_number":306,"context_line":"                          )}"},{"line_number":307,"context_line":"        req \u003d requests.post(connection_url, headers\u003dheaders, files\u003dfiles)"},{"line_number":308,"context_line":"        return req.json()"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def upload_request_with_data(self, method, url, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"818ce46e_bdfcb905","line":307,"in_reply_to":"2b57233a_bc8ae07e","updated":"2021-11-04 20:28:27.000000000","message":"Fixed it","commit_id":"39a347c779ca98d9a65187daf35b82a8c7993a5b"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f7cdf0b2056d244195e19f62ffa5c891f9df41a5","unresolved":true,"context_lines":[{"line_number":297,"context_line":"        connection_url \u003d self._get_connection_url(url)"},{"line_number":298,"context_line":"        return self._cs_request(connection_url, method, **kwargs)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def upload_request(self, method, url, **kwargs):"},{"line_number":301,"context_line":"        self.authenticate_and_fetch_endpoint_url()"},{"line_number":302,"context_line":"        connection_url \u003d self._get_connection_url(url)"},{"line_number":303,"context_line":"        headers \u003d {\"X-Auth-Token\": self.auth_token}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7eb6cbd4_33ef6d65","side":"PARENT","line":300,"updated":"2021-11-04 20:32:14.000000000","message":"good cleanup.   We never use this method anywhere in the code.","commit_id":"b6405a7ae82cae2ed4477b680047c885a5b5d31a"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"2c6db9002462a66406d34cc3d08c290a8aed8cce","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    def __init__(self, endpoint,"},{"line_number":114,"context_line":"                 username\u003dNone, tenant_name\u003dNone, tenant_id\u003dNone,"},{"line_number":115,"context_line":"                 password\u003dNone, auth_url\u003dNone,"},{"line_number":116,"context_line":"                 token\u003dNone, region_name\u003dNone, timeout\u003d7200,"},{"line_number":117,"context_line":"                 endpoint_url\u003dNone, insecure\u003dFalse,"},{"line_number":118,"context_line":"                 endpoint_type\u003d\u0027publicURL\u0027,"},{"line_number":119,"context_line":"                 auth_strategy\u003d\u0027keystone\u0027, ca_cert\u003dNone, log_credentials\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3780bac4_e5b66f1a","line":116,"range":{"start_line":116,"start_character":55,"end_line":116,"end_character":59},"updated":"2021-11-05 13:17:19.000000000","message":"This is 2 hours?  I\u0027m not aware of load-import operations expecting to take so long- the following is measured at 420s (pre-optimization). 3600 (1h) should be ample? (Also, Confirm also with device image firmware case).\n\nhttps://review.opendev.org/c/starlingx/distcloud/+/806824","commit_id":"c4b1b6bebd5d80831901531ff6cd01fb03f21901"},{"author":{"_account_id":31484,"name":"Jessica Castelino","email":"jessica.castelino@windriver.com","username":"jcasteli"},"change_message_id":"7e26c141fb9c0e819ba3c82f172a4b0a3ff46713","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def __init__(self, endpoint,"},{"line_number":114,"context_line":"                 username\u003dNone, tenant_name\u003dNone, tenant_id\u003dNone,"},{"line_number":115,"context_line":"                 password\u003dNone, auth_url\u003dNone,"},{"line_number":116,"context_line":"                 token\u003dNone, region_name\u003dNone, timeout\u003d7200,"},{"line_number":117,"context_line":"                 endpoint_url\u003dNone, insecure\u003dFalse,"},{"line_number":118,"context_line":"                 endpoint_type\u003d\u0027publicURL\u0027,"},{"line_number":119,"context_line":"                 auth_strategy\u003d\u0027keystone\u0027, ca_cert\u003dNone, log_credentials\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e902681d_0efaa9b1","line":116,"range":{"start_line":116,"start_character":55,"end_line":116,"end_character":59},"in_reply_to":"0f244781_8ed22fd9","updated":"2021-11-05 20:09:59.000000000","message":"This timeout was initially set to \"None\" which would mean \"infinite\". I just reduced it to 2 hours (that is, made it better than before) for all methods using this HTTPClient.\n\nAs for the load import timeout, that uses request library for making the post calls instead of httplib library. I\u0027ll change that to 30 minutes.","commit_id":"c4b1b6bebd5d80831901531ff6cd01fb03f21901"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"97d8de626374dd79673591ea773803cf785f987d","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    def __init__(self, endpoint,"},{"line_number":114,"context_line":"                 username\u003dNone, tenant_name\u003dNone, tenant_id\u003dNone,"},{"line_number":115,"context_line":"                 password\u003dNone, auth_url\u003dNone,"},{"line_number":116,"context_line":"                 token\u003dNone, region_name\u003dNone, timeout\u003d7200,"},{"line_number":117,"context_line":"                 endpoint_url\u003dNone, insecure\u003dFalse,"},{"line_number":118,"context_line":"                 endpoint_type\u003d\u0027publicURL\u0027,"},{"line_number":119,"context_line":"                 auth_strategy\u003d\u0027keystone\u0027, ca_cert\u003dNone, log_credentials\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f244781_8ed22fd9","line":116,"range":{"start_line":116,"start_character":55,"end_line":116,"end_character":59},"in_reply_to":"3780bac4_e5b66f1a","updated":"2021-11-05 13:33:31.000000000","message":"I would reduce to 30 minutes. If load import takes more than 10 minutes then either the network is heavily congested or the system is overloaded and we should not add more load by waiting that long. Load import failure during orchestrated upgrade is fully recoverable.","commit_id":"c4b1b6bebd5d80831901531ff6cd01fb03f21901"}]}