)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0db7d73dbfc10307514d05d7c82462e1a5d63a51","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"    PASS: Upgrade AIO-SX"},{"line_number":16,"context_line":"    PASS: Upgrade AIO-DX"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Story: 2009074"},{"line_number":19,"context_line":"Task: 43879"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"40ee66bf_166ca752","line":16,"updated":"2021-11-08 22:29:19.000000000","message":"This testing only covers the single monitor configs. I would normally want to see this also tested on a 2+2 and 2+2+2 setup, but since this is part of the upgrade activation step all nodes should be upgraded and running the \"to release\", so I think we are good for the 3-monitor quorum scenarios.","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"e2664165a5a31347b6eda5a24bc5c6329552802c","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"    PASS: Upgrade AIO-SX"},{"line_number":16,"context_line":"    PASS: Upgrade AIO-DX"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Story: 2009074"},{"line_number":19,"context_line":"Task: 43879"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"aa5baad4_81e6ad8e","line":16,"in_reply_to":"40ee66bf_166ca752","updated":"2021-11-11 18:20:54.000000000","message":"Ack","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"fd8dd58649adbe3a6cf35e35f14a75bea57be472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ef7418f4_5b907ab6","updated":"2021-11-08 22:17:33.000000000","message":"I am fine with the changes, but I would like David\u0027s comments to be addressed before I add my +2","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"4167a783ecf8f39293bcf8b268c4a798002ec390","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d700db77_8ff1b9c1","updated":"2021-11-10 14:58:37.000000000","message":"Pretty sure this fails on systems without ceph. Have you tested on systems without a ceph backend?","commit_id":"f27e9debc7626ca206b7e2246e71abc88ab207c9"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"2a62bc248ec25de1d78b225a1afbd1eb895419d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4c1ab2dc_b54e86ba","updated":"2021-11-10 14:59:55.000000000","message":"Removing the vote based on David\u0027s comments","commit_id":"f27e9debc7626ca206b7e2246e71abc88ab207c9"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"e2664165a5a31347b6eda5a24bc5c6329552802c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"86d4d1d2_9e02e290","in_reply_to":"d700db77_8ff1b9c1","updated":"2021-11-11 18:20:54.000000000","message":"You are right.\nI am now verifying in the sysinv database if there is a ceph backend configured before running the commands.\n\nTried the database connection using the psycopg2 module, but it seems to work only when in action \u0027migrate\u0027 and we need to be in action \u0027activate\u0027. So I run a command line query to get this value.\n\nTested on a AIO-SX with and without ceph backend.","commit_id":"f27e9debc7626ca206b7e2246e71abc88ab207c9"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"bba86c43adb34cda86f7c4081da927495beeaa1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"91ad7062_82777855","updated":"2021-11-11 18:40:29.000000000","message":"The command to enable protocol v2 was removed from the script because it will be managed by sysinv puppet ceph and conductor manager.","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"}],"controllerconfig/controllerconfig/upgrade-scripts/81-upgrade-ceph.py":[{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"6537bcc9c0aa88cdd69b1e18529043b303607137","unresolved":true,"context_lines":[{"line_number":23,"context_line":"from controllerconfig.common import log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d log.get_logger(__name__)"},{"line_number":26,"context_line":"CEPH_CONF_FILEPATH \u003d \u0027/etc/ceph/ceph.conf\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8fb4b7_fc3b8839","line":26,"updated":"2021-11-05 21:08:49.000000000","message":"This is not being used","commit_id":"8e6b1cc186d908b6b5d81866a3bd06e56b9410f1"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"72c36a90f642bf83ca28e8cd9f48530083d3a6ea","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from controllerconfig.common import log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d log.get_logger(__name__)"},{"line_number":26,"context_line":"CEPH_CONF_FILEPATH \u003d \u0027/etc/ceph/ceph.conf\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3459f4a6_7c73a790","line":26,"in_reply_to":"bf8fb4b7_fc3b8839","updated":"2021-11-05 21:10:50.000000000","message":"Done","commit_id":"8e6b1cc186d908b6b5d81866a3bd06e56b9410f1"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"752fca99ef18dcb02175b788e23f0763558f40d2","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import subprocess"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"from controllerconfig.common import log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d log.get_logger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ffaeb_44c50adc","line":22,"updated":"2021-11-08 19:35:22.000000000","message":"Usually you would need a blank line before the controllerconfig import, otherwise it will violate the alpbahetical imports check for pep8.  I suspect we do not have that check enabled for this repo.","commit_id":"7ad7089f08ebb11aeffb6c8f0b61033c256dff61"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"b6447b470f50f48eda841c32980daf616d3a5f06","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import subprocess"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"from controllerconfig.common import log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d log.get_logger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"519d6853_d8f3ef1f","line":22,"in_reply_to":"7a8ffaeb_44c50adc","updated":"2021-11-08 19:52:33.000000000","message":"Fixed. Thanks.","commit_id":"7ad7089f08ebb11aeffb6c8f0b61033c256dff61"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"752fca99ef18dcb02175b788e23f0763558f40d2","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    release \u003d get_ceph_release()"},{"line_number":63,"context_line":"    if release \u003d\u003d \u0027mimic\u0027:"},{"line_number":64,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":65,"context_line":"        set_nautilus_release()"},{"line_number":66,"context_line":"        enable_straw2()"},{"line_number":67,"context_line":"        enable_v2_protocol()"},{"line_number":68,"context_line":"        LOG.info(\"Upgrade complete\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"ce231c35_5881751a","line":65,"updated":"2021-11-08 19:35:22.000000000","message":"Should this step be done last?\nWhat I mean is, if one of these 3 steps fails, will this script be able to resume?\nBy setting nautilus first,  a re-attempt would just skip the next 2 steps I think","commit_id":"7ad7089f08ebb11aeffb6c8f0b61033c256dff61"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"b6447b470f50f48eda841c32980daf616d3a5f06","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    release \u003d get_ceph_release()"},{"line_number":63,"context_line":"    if release \u003d\u003d \u0027mimic\u0027:"},{"line_number":64,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":65,"context_line":"        set_nautilus_release()"},{"line_number":66,"context_line":"        enable_straw2()"},{"line_number":67,"context_line":"        enable_v2_protocol()"},{"line_number":68,"context_line":"        LOG.info(\"Upgrade complete\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"6aec2fc7_82413379","line":65,"in_reply_to":"ce231c35_5881751a","updated":"2021-11-08 19:52:33.000000000","message":"I agree.","commit_id":"7ad7089f08ebb11aeffb6c8f0b61033c256dff61"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"e55360f816de0986af82b8c193ef4be99abcd642","unresolved":true,"context_lines":[{"line_number":49,"context_line":"              % (sys.argv[0], from_release, to_release, action))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if from_release \u003d\u003d \"21.05\" and \\"},{"line_number":52,"context_line":"       to_release \u003d\u003d \"21.12\" and   \\"},{"line_number":53,"context_line":"       action \u003d\u003d \"activate\":"},{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            upgrade_ceph()"}],"source_content_type":"text/x-python","patch_set":6,"id":"105b9112_0069eebe","line":52,"updated":"2021-11-08 20:02:56.000000000","message":"Just the from_release is required.","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"1afe8832ad5ce20bd926c60d25a11378bdb24d90","unresolved":false,"context_lines":[{"line_number":49,"context_line":"              % (sys.argv[0], from_release, to_release, action))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if from_release \u003d\u003d \"21.05\" and \\"},{"line_number":52,"context_line":"       to_release \u003d\u003d \"21.12\" and   \\"},{"line_number":53,"context_line":"       action \u003d\u003d \"activate\":"},{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            upgrade_ceph()"}],"source_content_type":"text/x-python","patch_set":6,"id":"e5519d24_f7820737","line":52,"in_reply_to":"105b9112_0069eebe","updated":"2021-11-09 19:50:09.000000000","message":"Removed.","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"e55360f816de0986af82b8c193ef4be99abcd642","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    release \u003d get_ceph_release()"},{"line_number":64,"context_line":"    if release \u003d\u003d \u0027mimic\u0027:"},{"line_number":65,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":66,"context_line":"        enable_straw2()"},{"line_number":67,"context_line":"        enable_v2_protocol()"},{"line_number":68,"context_line":"        set_nautilus_release()"},{"line_number":69,"context_line":"        LOG.info(\"Upgrade complete\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"9c2a5884_cf8dd377","line":66,"updated":"2021-11-08 20:02:56.000000000","message":"Any issue with rerunning these commands?","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"1afe8832ad5ce20bd926c60d25a11378bdb24d90","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    release \u003d get_ceph_release()"},{"line_number":64,"context_line":"    if release \u003d\u003d \u0027mimic\u0027:"},{"line_number":65,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":66,"context_line":"        enable_straw2()"},{"line_number":67,"context_line":"        enable_v2_protocol()"},{"line_number":68,"context_line":"        set_nautilus_release()"},{"line_number":69,"context_line":"        LOG.info(\"Upgrade complete\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"38d0838c_6737c96d","line":66,"in_reply_to":"9c2a5884_cf8dd377","updated":"2021-11-09 19:50:09.000000000","message":"No problem rerunning these commands.\nBut I have rewritten the code to verify all the changes before running the commands.","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"6cffde61b1fb704eecf6b9c909041cd644c13ec3","unresolved":true,"context_lines":[{"line_number":83,"context_line":"def set_nautilus_release():"},{"line_number":84,"context_line":"    LOG.info(\"set nautilus in require_osd_release...\")"},{"line_number":85,"context_line":"    command \u003d \"ceph osd require-osd-release nautilus\""},{"line_number":86,"context_line":"    exec_ceph_command(command)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def enable_straw2():"}],"source_content_type":"text/x-python","patch_set":6,"id":"f0b2a1e4_471b9c03","line":86,"updated":"2021-11-08 22:23:09.000000000","message":"Execute another command here to ensure that this command was successful. Return an error if the value is not set as expected","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"1afe8832ad5ce20bd926c60d25a11378bdb24d90","unresolved":false,"context_lines":[{"line_number":83,"context_line":"def set_nautilus_release():"},{"line_number":84,"context_line":"    LOG.info(\"set nautilus in require_osd_release...\")"},{"line_number":85,"context_line":"    command \u003d \"ceph osd require-osd-release nautilus\""},{"line_number":86,"context_line":"    exec_ceph_command(command)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def enable_straw2():"}],"source_content_type":"text/x-python","patch_set":6,"id":"20164ba7_5db94902","line":86,"in_reply_to":"f0b2a1e4_471b9c03","updated":"2021-11-09 19:50:09.000000000","message":"Ack","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"6cffde61b1fb704eecf6b9c909041cd644c13ec3","unresolved":true,"context_lines":[{"line_number":89,"context_line":"def enable_straw2():"},{"line_number":90,"context_line":"    LOG.info(\"enabling straw2...\")"},{"line_number":91,"context_line":"    command \u003d \"ceph osd crush set-all-straw-buckets-to-straw2\""},{"line_number":92,"context_line":"    exec_ceph_command(command)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def enable_v2_protocol():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3cf7bcd5_38a4a325","line":92,"updated":"2021-11-08 22:23:09.000000000","message":"Execute another command here to ensure that this command was successful. Return an error if the value is not set as expected","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"1afe8832ad5ce20bd926c60d25a11378bdb24d90","unresolved":false,"context_lines":[{"line_number":89,"context_line":"def enable_straw2():"},{"line_number":90,"context_line":"    LOG.info(\"enabling straw2...\")"},{"line_number":91,"context_line":"    command \u003d \"ceph osd crush set-all-straw-buckets-to-straw2\""},{"line_number":92,"context_line":"    exec_ceph_command(command)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def enable_v2_protocol():"}],"source_content_type":"text/x-python","patch_set":6,"id":"db10ebd0_56d67fca","line":92,"in_reply_to":"3cf7bcd5_38a4a325","updated":"2021-11-09 19:50:09.000000000","message":"Ack","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"6cffde61b1fb704eecf6b9c909041cd644c13ec3","unresolved":true,"context_lines":[{"line_number":95,"context_line":"def enable_v2_protocol():"},{"line_number":96,"context_line":"    LOG.info(\"enabling v2 protocol...\")"},{"line_number":97,"context_line":"    command \u003d \"ceph mon enable-msgr2\""},{"line_number":98,"context_line":"    exec_ceph_command(command)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def exec_ceph_command(command):"}],"source_content_type":"text/x-python","patch_set":6,"id":"02efad16_df38e305","line":98,"updated":"2021-11-08 22:23:09.000000000","message":"Execute another command here to ensure that this command was successful. Return an error if the value is not set as expected","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"1afe8832ad5ce20bd926c60d25a11378bdb24d90","unresolved":false,"context_lines":[{"line_number":95,"context_line":"def enable_v2_protocol():"},{"line_number":96,"context_line":"    LOG.info(\"enabling v2 protocol...\")"},{"line_number":97,"context_line":"    command \u003d \"ceph mon enable-msgr2\""},{"line_number":98,"context_line":"    exec_ceph_command(command)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def exec_ceph_command(command):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ea887cfd_9adf3a10","line":98,"in_reply_to":"02efad16_df38e305","updated":"2021-11-09 19:50:09.000000000","message":"Ack","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"6cffde61b1fb704eecf6b9c909041cd644c13ec3","unresolved":true,"context_lines":[{"line_number":101,"context_line":"def exec_ceph_command(command):"},{"line_number":102,"context_line":"    LOG.info(\"Running command %s\" % command)"},{"line_number":103,"context_line":"    command_list \u003d command.split(\u0027 \u0027)"},{"line_number":104,"context_line":"    process \u003d subprocess.Popen(command_list,"},{"line_number":105,"context_line":"                               stdout\u003dsubprocess.PIPE,"},{"line_number":106,"context_line":"                               stderr\u003dsubprocess.STDOUT)"},{"line_number":107,"context_line":"    stdout, stderr \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":6,"id":"c2ae0b39_2edccb76","line":104,"updated":"2021-11-08 22:23:09.000000000","message":"This need a timeout to handle the case when there are not enough monitors in the quorum (monitor crash or networking issues) as these ceph commands will hang.","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"1afe8832ad5ce20bd926c60d25a11378bdb24d90","unresolved":false,"context_lines":[{"line_number":101,"context_line":"def exec_ceph_command(command):"},{"line_number":102,"context_line":"    LOG.info(\"Running command %s\" % command)"},{"line_number":103,"context_line":"    command_list \u003d command.split(\u0027 \u0027)"},{"line_number":104,"context_line":"    process \u003d subprocess.Popen(command_list,"},{"line_number":105,"context_line":"                               stdout\u003dsubprocess.PIPE,"},{"line_number":106,"context_line":"                               stderr\u003dsubprocess.STDOUT)"},{"line_number":107,"context_line":"    stdout, stderr \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":6,"id":"f2fc9c9f_42df69dd","line":104,"in_reply_to":"c2ae0b39_2edccb76","updated":"2021-11-09 19:50:09.000000000","message":"All ceph commands have now a timeout of 60s added","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"e55360f816de0986af82b8c193ef4be99abcd642","unresolved":true,"context_lines":[{"line_number":106,"context_line":"                               stderr\u003dsubprocess.STDOUT)"},{"line_number":107,"context_line":"    stdout, stderr \u003d process.communicate()"},{"line_number":108,"context_line":"    if stderr and len(stderr.strip()) \u003e 0:"},{"line_number":109,"context_line":"        raise Exception(\"Failed to run command: %s\" % command)"},{"line_number":110,"context_line":"    return stdout"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"57156729_ee1036cc","line":109,"updated":"2021-11-08 20:02:56.000000000","message":"Can we output the results of the command in this case?","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":33443,"name":"Felipe Sanches Zanoni","email":"Felipe.SanchesZanoni@windriver.com","username":"fsanches"},"change_message_id":"1afe8832ad5ce20bd926c60d25a11378bdb24d90","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                               stderr\u003dsubprocess.STDOUT)"},{"line_number":107,"context_line":"    stdout, stderr \u003d process.communicate()"},{"line_number":108,"context_line":"    if stderr and len(stderr.strip()) \u003e 0:"},{"line_number":109,"context_line":"        raise Exception(\"Failed to run command: %s\" % command)"},{"line_number":110,"context_line":"    return stdout"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"47d720ae_65b6bb68","line":109,"in_reply_to":"57156729_ee1036cc","updated":"2021-11-09 19:50:09.000000000","message":"Done","commit_id":"3034ee86e0d94ec5fc0baa051dc1301c07f361df"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"# Copyright (c) 2020 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"}],"source_content_type":"text/x-python","patch_set":11,"id":"190a4aee_2a53085a","line":1,"updated":"2021-11-13 07:15:56.000000000","message":"Based on the other scripts:\n  #!/usr/bin/env python","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"# Copyright (c) 2020 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a358bf6_fd343b30","line":1,"in_reply_to":"190a4aee_2a53085a","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"# Copyright (c) 2020 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"f90a8b61_f61f7b9f","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"updated":"2021-11-13 07:15:56.000000000","message":"2021","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"# Copyright (c) 2020 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"4ca168d4_96d5cf80","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"in_reply_to":"f90a8b61_f61f7b9f","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# This script is supposed to run after all nodes have been upgraded."},{"line_number":7,"context_line":"# This will set ceph cluster in the nautilus release and enable:"},{"line_number":8,"context_line":"# straw2: A new bucket algorithm (present since hammer release). It has"},{"line_number":9,"context_line":"#        improvements over previous straw algorithm. For more information check"},{"line_number":10,"context_line":"#   https://docs.ceph.com/en/latest/rados/operations/crush-map/#hammer-crush-v4"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# This script can be removed in the release that follows 21.12."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"92fa6100_fff7da26","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":79},"updated":"2021-11-13 07:15:56.000000000","message":"Recommend come cleanup:\n\n # This script will run during the upgrade activation step after all nodes have\n # been upgraded.\n #\n # This will set the required_osd_release to \u0027nautilus\u0027 and enable the straw2\n # bucket algorithm. \u0027straw2\u0027 has improvements over the previous \u0027straw\u0027\n # algorithm. For more information see:\n # https://docs.ceph.com/en/latest/rados/operations/crush-map/#hammer-crush-v4","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# This script is supposed to run after all nodes have been upgraded."},{"line_number":7,"context_line":"# This will set ceph cluster in the nautilus release and enable:"},{"line_number":8,"context_line":"# straw2: A new bucket algorithm (present since hammer release). It has"},{"line_number":9,"context_line":"#        improvements over previous straw algorithm. For more information check"},{"line_number":10,"context_line":"#   https://docs.ceph.com/en/latest/rados/operations/crush-map/#hammer-crush-v4"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# This script can be removed in the release that follows 21.12."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"4b3614b4_dea17541","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":79},"in_reply_to":"92fa6100_fff7da26","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def upgrade_ceph():"},{"line_number":55,"context_line":"    if not is_ceph_configured():"},{"line_number":56,"context_line":"        LOG.info(\"Ceph backend not configured. Skipping...\")"},{"line_number":57,"context_line":"        return"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        LOG.info(\"Ceph backend detected. Applying changes...\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"d6affec0_d97e20eb","line":56,"range":{"start_line":56,"start_character":18,"end_line":56,"end_character":58},"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n  LOG.info(\"Ceph backend absent. No further upgrade actions are required.\")","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def upgrade_ceph():"},{"line_number":55,"context_line":"    if not is_ceph_configured():"},{"line_number":56,"context_line":"        LOG.info(\"Ceph backend not configured. Skipping...\")"},{"line_number":57,"context_line":"        return"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        LOG.info(\"Ceph backend detected. Applying changes...\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"a7a9cb65_82af8ac9","line":56,"range":{"start_line":56,"start_character":18,"end_line":56,"end_character":58},"in_reply_to":"d6affec0_d97e20eb","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        LOG.info(\"Ceph backend not configured. Skipping...\")"},{"line_number":57,"context_line":"        return"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        LOG.info(\"Ceph backend detected. Applying changes...\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    release \u003d get_ceph_release()"},{"line_number":62,"context_line":"    straw2_enabled \u003d is_straw2_enabled()"}],"source_content_type":"text/x-python","patch_set":11,"id":"958771c0_e29361fb","line":59,"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n  LOG.info(\"Ceph backend present. Verifying Ceph upgrade to Nautilus is \"\n           \"complete.\")","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        LOG.info(\"Ceph backend not configured. Skipping...\")"},{"line_number":57,"context_line":"        return"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        LOG.info(\"Ceph backend detected. Applying changes...\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    release \u003d get_ceph_release()"},{"line_number":62,"context_line":"    straw2_enabled \u003d is_straw2_enabled()"}],"source_content_type":"text/x-python","patch_set":11,"id":"2003ffff_e163de31","line":59,"in_reply_to":"958771c0_e29361fb","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        LOG.info(\"Ceph backend detected. Applying changes...\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    release \u003d get_ceph_release()"},{"line_number":62,"context_line":"    straw2_enabled \u003d is_straw2_enabled()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if release !\u003d \u0027nautilus\u0027 or not straw2_enabled:"}],"source_content_type":"text/x-python","patch_set":11,"id":"c78ce58a_2a7fa0f0","line":61,"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n  osd_release \u003d get_required_osd_release()","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        LOG.info(\"Ceph backend detected. Applying changes...\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    release \u003d get_ceph_release()"},{"line_number":62,"context_line":"    straw2_enabled \u003d is_straw2_enabled()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if release !\u003d \u0027nautilus\u0027 or not straw2_enabled:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ca83604_a28e8441","line":61,"in_reply_to":"c78ce58a_2a7fa0f0","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    release \u003d get_ceph_release()"},{"line_number":62,"context_line":"    straw2_enabled \u003d is_straw2_enabled()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if release !\u003d \u0027nautilus\u0027 or not straw2_enabled:"},{"line_number":65,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Setting to nautilus release first is mandatory"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a7b9634_5ee40c39","line":64,"range":{"start_line":64,"start_character":7,"end_line":64,"end_character":14},"updated":"2021-11-13 07:15:56.000000000","message":"osd_release","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    release \u003d get_ceph_release()"},{"line_number":62,"context_line":"    straw2_enabled \u003d is_straw2_enabled()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if release !\u003d \u0027nautilus\u0027 or not straw2_enabled:"},{"line_number":65,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Setting to nautilus release first is mandatory"}],"source_content_type":"text/x-python","patch_set":11,"id":"35d30058_d11cd50b","line":64,"range":{"start_line":64,"start_character":7,"end_line":64,"end_character":14},"in_reply_to":"3a7b9634_5ee40c39","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    straw2_enabled \u003d is_straw2_enabled()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if release !\u003d \u0027nautilus\u0027 or not straw2_enabled:"},{"line_number":65,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Setting to nautilus release first is mandatory"},{"line_number":68,"context_line":"        if release !\u003d \u0027nautilus\u0027:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5c641b0e_a6732d73","line":65,"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n  LOG.info(\"Completing upgrade to Ceph Nautilus...\")","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    straw2_enabled \u003d is_straw2_enabled()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if release !\u003d \u0027nautilus\u0027 or not straw2_enabled:"},{"line_number":65,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Setting to nautilus release first is mandatory"},{"line_number":68,"context_line":"        if release !\u003d \u0027nautilus\u0027:"}],"source_content_type":"text/x-python","patch_set":11,"id":"80dbf408_a3a76b2c","line":65,"in_reply_to":"5c641b0e_a6732d73","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Setting to nautilus release first is mandatory"},{"line_number":68,"context_line":"        if release !\u003d \u0027nautilus\u0027:"},{"line_number":69,"context_line":"            set_nautilus_release()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if not straw2_enabled:"}],"source_content_type":"text/x-python","patch_set":11,"id":"f299fbce_54b824c7","line":68,"range":{"start_line":68,"start_character":11,"end_line":68,"end_character":18},"updated":"2021-11-13 07:15:56.000000000","message":"osd_release","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        LOG.info(\"Running finishing steps...\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Setting to nautilus release first is mandatory"},{"line_number":68,"context_line":"        if release !\u003d \u0027nautilus\u0027:"},{"line_number":69,"context_line":"            set_nautilus_release()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if not straw2_enabled:"}],"source_content_type":"text/x-python","patch_set":11,"id":"8029fb59_27524f7d","line":68,"range":{"start_line":68,"start_character":11,"end_line":68,"end_character":18},"in_reply_to":"f299fbce_54b824c7","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Setting to nautilus release first is mandatory"},{"line_number":68,"context_line":"        if release !\u003d \u0027nautilus\u0027:"},{"line_number":69,"context_line":"            set_nautilus_release()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if not straw2_enabled:"},{"line_number":72,"context_line":"            enable_straw2()"}],"source_content_type":"text/x-python","patch_set":11,"id":"061e870d_c035dfca","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":32},"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n  set_required_osd_release()","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Setting to nautilus release first is mandatory"},{"line_number":68,"context_line":"        if release !\u003d \u0027nautilus\u0027:"},{"line_number":69,"context_line":"            set_nautilus_release()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if not straw2_enabled:"},{"line_number":72,"context_line":"            enable_straw2()"}],"source_content_type":"text/x-python","patch_set":11,"id":"f2ecbd3a_4297c8f3","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":32},"in_reply_to":"061e870d_c035dfca","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        if not straw2_enabled:"},{"line_number":72,"context_line":"            enable_straw2()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        LOG.info(\"Upgrade complete\")"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        LOG.info(\"Already upgraded\")"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"f07dd0d1_e880a937","line":74,"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n  LOG.info(\"Upgrade complete to Ceph Nautilus\")","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if not straw2_enabled:"},{"line_number":72,"context_line":"            enable_straw2()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        LOG.info(\"Upgrade complete\")"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        LOG.info(\"Already upgraded\")"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"4fe94468_f88f3b59","line":74,"in_reply_to":"f07dd0d1_e880a937","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        LOG.info(\"Upgrade complete\")"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        LOG.info(\"Already upgraded\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def is_ceph_configured():"}],"source_content_type":"text/x-python","patch_set":11,"id":"1db1f6c9_1d7e3dab","line":76,"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n  LOG.info(\"No additional Ceph upgraded actions required\")","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        LOG.info(\"Upgrade complete\")"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        LOG.info(\"Already upgraded\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def is_ceph_configured():"}],"source_content_type":"text/x-python","patch_set":11,"id":"58e1f866_10c091b3","line":76,"in_reply_to":"1db1f6c9_1d7e3dab","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":80,"context_line":"    # This command was used because it was not possible to connect to"},{"line_number":81,"context_line":"    # the sysinv database using the psycopg2 module when in \u0027activate\u0027"},{"line_number":82,"context_line":"    # action"},{"line_number":83,"context_line":"    command \u003d \"sudo -u postgres psql -U postgres -d sysinv -t -A -q \"\\"},{"line_number":84,"context_line":"        \"-c \\\"SELECT backend FROM storage_backend;\\\" | grep ceph | sort -u\""},{"line_number":85,"context_line":"    out \u003d exec_command(command)"},{"line_number":86,"context_line":"    return out.strip() \u003d\u003d \u0027ceph\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def get_ceph_release():"}],"source_content_type":"text/x-python","patch_set":11,"id":"bc8feae3_f56ecc1d","line":86,"range":{"start_line":83,"start_character":0,"end_line":86,"end_character":32},"updated":"2021-11-13 07:15:56.000000000","message":"Recommend letting the postgres query do all the work:\n\n    command \u003d (\"sudo -u postgres psql -U postgres -d sysinv -t -A -q -c \"\n               \"\\\"SELECT count(*) FROM storage_backend \"\n               \"where backend\u003d\u0027ceph\u0027 AND name\u003d\u0027ceph-store\u0027;\\\"\")\n    out \u003d exec_command(command)\n    return out.strip() \u003d\u003d \"1\"","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    # This command was used because it was not possible to connect to"},{"line_number":81,"context_line":"    # the sysinv database using the psycopg2 module when in \u0027activate\u0027"},{"line_number":82,"context_line":"    # action"},{"line_number":83,"context_line":"    command \u003d \"sudo -u postgres psql -U postgres -d sysinv -t -A -q \"\\"},{"line_number":84,"context_line":"        \"-c \\\"SELECT backend FROM storage_backend;\\\" | grep ceph | sort -u\""},{"line_number":85,"context_line":"    out \u003d exec_command(command)"},{"line_number":86,"context_line":"    return out.strip() \u003d\u003d \u0027ceph\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def get_ceph_release():"}],"source_content_type":"text/x-python","patch_set":11,"id":"aeb09ae4_f1907612","line":86,"range":{"start_line":83,"start_character":0,"end_line":86,"end_character":32},"in_reply_to":"bc8feae3_f56ecc1d","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    return out.strip() \u003d\u003d \u0027ceph\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def get_ceph_release():"},{"line_number":90,"context_line":"    command \u003d \"ceph osd dump -f json\""},{"line_number":91,"context_line":"    out \u003d exec_ceph_command(command)"},{"line_number":92,"context_line":"    json_out \u003d json.loads(out)"}],"source_content_type":"text/x-python","patch_set":11,"id":"da9c2c84_cefeea24","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":20},"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n get_required_osd_release()","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    return out.strip() \u003d\u003d \u0027ceph\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def get_ceph_release():"},{"line_number":90,"context_line":"    command \u003d \"ceph osd dump -f json\""},{"line_number":91,"context_line":"    out \u003d exec_ceph_command(command)"},{"line_number":92,"context_line":"    json_out \u003d json.loads(out)"}],"source_content_type":"text/x-python","patch_set":11,"id":"956315db_ccaecf8f","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":20},"in_reply_to":"da9c2c84_cefeea24","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def is_straw2_enabled():"},{"line_number":97,"context_line":"    command \u003d \"ceph osd getcrushmap -o /tmp/map 1\u003e/dev/null 2\u003e\u00261 \"\\"},{"line_number":98,"context_line":"              \"\u0026\u0026 crushtool -d /tmp/map -o /tmp/d_map \"\\"},{"line_number":99,"context_line":"              \"\u0026\u0026 cat /tmp/d_map | grep \u0027alg straw\u0027 | sort -u\""},{"line_number":100,"context_line":"    out \u003d exec_ceph_command(command)"},{"line_number":101,"context_line":"    command \u003d \"rm -f /tmp/map /tmp/d_map\""},{"line_number":102,"context_line":"    exec_command(command)"},{"line_number":103,"context_line":"    return out.strip() \u003d\u003d \u0027alg straw2\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def set_nautilus_release():"}],"source_content_type":"text/x-python","patch_set":11,"id":"8d75c40d_64f21a63","line":103,"range":{"start_line":97,"start_character":0,"end_line":103,"end_character":38},"updated":"2021-11-13 07:15:56.000000000","message":"Recommend avoiding all the crushmap manipulation:\n\n    command \u003d \"ceph osd crush dump -f json\"\n    out \u003d exec_ceph_command(command)\n    json_out \u003d json.loads(out)\n    algs \u003d [b[\u0027alg\u0027] for b in json_out.get(\u0027buckets\u0027)]\n    return algs.count(\u0027straw\u0027) \u003d\u003d 0\n\nBasically make sure that no straw buckets are present, then we know we\u0027ve converted the crushmap.\n\nBased on this, shouldn\u0027t all the default crushmaps in sysinv/sysinv/sysinv/etc/sysinv have \u0027alg2 straw\u0027? Looks to me like crushmap-aio-sx.txt, crushmap-controller-model.txt, and crushmap-storage-model.txt are incorrect.","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"6b71d4a0f8c482841e579e633f59cc2187ff54a9","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def is_straw2_enabled():"},{"line_number":97,"context_line":"    command \u003d \"ceph osd getcrushmap -o /tmp/map 1\u003e/dev/null 2\u003e\u00261 \"\\"},{"line_number":98,"context_line":"              \"\u0026\u0026 crushtool -d /tmp/map -o /tmp/d_map \"\\"},{"line_number":99,"context_line":"              \"\u0026\u0026 cat /tmp/d_map | grep \u0027alg straw\u0027 | sort -u\""},{"line_number":100,"context_line":"    out \u003d exec_ceph_command(command)"},{"line_number":101,"context_line":"    command \u003d \"rm -f /tmp/map /tmp/d_map\""},{"line_number":102,"context_line":"    exec_command(command)"},{"line_number":103,"context_line":"    return out.strip() \u003d\u003d \u0027alg straw2\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def set_nautilus_release():"}],"source_content_type":"text/x-python","patch_set":11,"id":"42f980d1_0d63b3b3","line":103,"range":{"start_line":97,"start_character":0,"end_line":103,"end_character":38},"in_reply_to":"77861cb1_30ac5b55","updated":"2021-11-14 21:46:32.000000000","message":"Addressed with: https://review.opendev.org/c/starlingx/config/+/817864","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":true,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def is_straw2_enabled():"},{"line_number":97,"context_line":"    command \u003d \"ceph osd getcrushmap -o /tmp/map 1\u003e/dev/null 2\u003e\u00261 \"\\"},{"line_number":98,"context_line":"              \"\u0026\u0026 crushtool -d /tmp/map -o /tmp/d_map \"\\"},{"line_number":99,"context_line":"              \"\u0026\u0026 cat /tmp/d_map | grep \u0027alg straw\u0027 | sort -u\""},{"line_number":100,"context_line":"    out \u003d exec_ceph_command(command)"},{"line_number":101,"context_line":"    command \u003d \"rm -f /tmp/map /tmp/d_map\""},{"line_number":102,"context_line":"    exec_command(command)"},{"line_number":103,"context_line":"    return out.strip() \u003d\u003d \u0027alg straw2\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def set_nautilus_release():"}],"source_content_type":"text/x-python","patch_set":11,"id":"77861cb1_30ac5b55","line":103,"range":{"start_line":97,"start_character":0,"end_line":103,"end_character":38},"in_reply_to":"8d75c40d_64f21a63","updated":"2021-11-13 12:26:43.000000000","message":"I agree  crushmap-aio-sx.txt, crushmap-controller-model.txt and crushmap-storage-model.txt should be updated to use straw2. I\u0027m not sure if it has been verified in a fresh install the straw version being used.","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    return out.strip() \u003d\u003d \u0027alg straw2\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def set_nautilus_release():"},{"line_number":107,"context_line":"    LOG.info(\"set nautilus in require_osd_release...\")"},{"line_number":108,"context_line":"    command \u003d \"ceph osd require-osd-release nautilus\""},{"line_number":109,"context_line":"    exec_ceph_command(command)"}],"source_content_type":"text/x-python","patch_set":11,"id":"0301b3b5_6da88b35","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":24},"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n  set_required_osd_release()","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    return out.strip() \u003d\u003d \u0027alg straw2\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def set_nautilus_release():"},{"line_number":107,"context_line":"    LOG.info(\"set nautilus in require_osd_release...\")"},{"line_number":108,"context_line":"    command \u003d \"ceph osd require-osd-release nautilus\""},{"line_number":109,"context_line":"    exec_ceph_command(command)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a766f48_a17da9e0","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":24},"in_reply_to":"0301b3b5_6da88b35","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def set_nautilus_release():"},{"line_number":107,"context_line":"    LOG.info(\"set nautilus in require_osd_release...\")"},{"line_number":108,"context_line":"    command \u003d \"ceph osd require-osd-release nautilus\""},{"line_number":109,"context_line":"    exec_ceph_command(command)"},{"line_number":110,"context_line":"    release \u003d get_ceph_release()"}],"source_content_type":"text/x-python","patch_set":11,"id":"09ec7153_f400ce7e","line":107,"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n  LOG.info(\"Set \u0027nautilus\u0027 for require_osd_release...\")","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def set_nautilus_release():"},{"line_number":107,"context_line":"    LOG.info(\"set nautilus in require_osd_release...\")"},{"line_number":108,"context_line":"    command \u003d \"ceph osd require-osd-release nautilus\""},{"line_number":109,"context_line":"    exec_ceph_command(command)"},{"line_number":110,"context_line":"    release \u003d get_ceph_release()"}],"source_content_type":"text/x-python","patch_set":11,"id":"b775b22e_07bce17e","line":107,"in_reply_to":"09ec7153_f400ce7e","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    LOG.info(\"set nautilus in require_osd_release...\")"},{"line_number":108,"context_line":"    command \u003d \"ceph osd require-osd-release nautilus\""},{"line_number":109,"context_line":"    exec_ceph_command(command)"},{"line_number":110,"context_line":"    release \u003d get_ceph_release()"},{"line_number":111,"context_line":"    if release !\u003d \u0027nautilus\u0027:"},{"line_number":112,"context_line":"        raise Exception(\"Could not set nautilus release\")"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"834ca2ab_75c30727","line":110,"range":{"start_line":110,"start_character":14,"end_line":110,"end_character":30},"updated":"2021-11-13 07:15:56.000000000","message":"get_required_osd_release()","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    LOG.info(\"set nautilus in require_osd_release...\")"},{"line_number":108,"context_line":"    command \u003d \"ceph osd require-osd-release nautilus\""},{"line_number":109,"context_line":"    exec_ceph_command(command)"},{"line_number":110,"context_line":"    release \u003d get_ceph_release()"},{"line_number":111,"context_line":"    if release !\u003d \u0027nautilus\u0027:"},{"line_number":112,"context_line":"        raise Exception(\"Could not set nautilus release\")"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"f1878210_9787ec3d","line":110,"range":{"start_line":110,"start_character":14,"end_line":110,"end_character":30},"in_reply_to":"834ca2ab_75c30727","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    exec_ceph_command(command)"},{"line_number":110,"context_line":"    release \u003d get_ceph_release()"},{"line_number":111,"context_line":"    if release !\u003d \u0027nautilus\u0027:"},{"line_number":112,"context_line":"        raise Exception(\"Could not set nautilus release\")"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def enable_straw2():"}],"source_content_type":"text/x-python","patch_set":11,"id":"77f6fa2d_26c88b1a","line":112,"range":{"start_line":112,"start_character":24,"end_line":112,"end_character":56},"updated":"2021-11-13 07:15:56.000000000","message":"\"Could not set \u0027require_osd_release\u0027 to \u0027nautilus\u0027\"","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    exec_ceph_command(command)"},{"line_number":110,"context_line":"    release \u003d get_ceph_release()"},{"line_number":111,"context_line":"    if release !\u003d \u0027nautilus\u0027:"},{"line_number":112,"context_line":"        raise Exception(\"Could not set nautilus release\")"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def enable_straw2():"}],"source_content_type":"text/x-python","patch_set":11,"id":"1380479f_8d2fd954","line":112,"range":{"start_line":112,"start_character":24,"end_line":112,"end_character":56},"in_reply_to":"77f6fa2d_26c88b1a","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def enable_straw2():"},{"line_number":116,"context_line":"    LOG.info(\"enabling straw2...\")"},{"line_number":117,"context_line":"    command \u003d \"ceph osd crush set-all-straw-buckets-to-straw2\""},{"line_number":118,"context_line":"    exec_ceph_command(command)"},{"line_number":119,"context_line":"    if not is_straw2_enabled():"}],"source_content_type":"text/x-python","patch_set":11,"id":"32a04fe1_91cfeb13","line":116,"updated":"2021-11-13 07:15:56.000000000","message":"Recommend:\n LOG.info(\"Enabling straw2 bucket algortithm...\")","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def enable_straw2():"},{"line_number":116,"context_line":"    LOG.info(\"enabling straw2...\")"},{"line_number":117,"context_line":"    command \u003d \"ceph osd crush set-all-straw-buckets-to-straw2\""},{"line_number":118,"context_line":"    exec_ceph_command(command)"},{"line_number":119,"context_line":"    if not is_straw2_enabled():"}],"source_content_type":"text/x-python","patch_set":11,"id":"0e7593a8_91896c9d","line":116,"in_reply_to":"32a04fe1_91cfeb13","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ebc663c72e279032d804b0bdc71fe5c1fcb90358","unresolved":true,"context_lines":[{"line_number":117,"context_line":"    command \u003d \"ceph osd crush set-all-straw-buckets-to-straw2\""},{"line_number":118,"context_line":"    exec_ceph_command(command)"},{"line_number":119,"context_line":"    if not is_straw2_enabled():"},{"line_number":120,"context_line":"        raise Exception(\"Could not enable straw2 buckets\")"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def exec_command(command):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1bea3288_a9acdbac","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":57},"updated":"2021-11-13 07:15:56.000000000","message":"\"Could not enable straw2 bucket algorithm\"","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"462ffe9b31078812571a53b15adac1fe2fed7a54","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    command \u003d \"ceph osd crush set-all-straw-buckets-to-straw2\""},{"line_number":118,"context_line":"    exec_ceph_command(command)"},{"line_number":119,"context_line":"    if not is_straw2_enabled():"},{"line_number":120,"context_line":"        raise Exception(\"Could not enable straw2 buckets\")"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def exec_command(command):"}],"source_content_type":"text/x-python","patch_set":11,"id":"e8e2b8cc_5aaa0d2c","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":57},"in_reply_to":"1bea3288_a9acdbac","updated":"2021-11-13 12:26:43.000000000","message":"Done","commit_id":"3da6a5174966a2890aaada83b12bc4f4dbe53750"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"cad7fdb88a2d7e8b7e93d2c200bb79fc789d727c","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    if from_release \u003d\u003d \"21.05\" and action \u003d\u003d \"activate\":"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            upgrade_ceph()"},{"line_number":50,"context_line":"        except Exception as e:"},{"line_number":51,"context_line":"            LOG.exception(\u0027Upgrade failed due to the following exception: %s\u0027"},{"line_number":52,"context_line":"                          % e)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fd244281_65bbefeb","line":49,"updated":"2021-11-15 01:12:33.000000000","message":"I think this is fine.  Only one of the scripts in this folder explicitly returns zero on success","commit_id":"5e53f99d7f1bb81a65540c768354f261a6a597a2"}]}