)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"87b614843c5660abb07f00baa7304077f976e0db","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Test Plan:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"PASS: Verify on a controller with IPV6 enabled if the openstack"},{"line_number":21,"context_line":"      user password set change the password on the keystone"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-bug: 1949983"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"75d71956_50dbc249","line":20,"updated":"2021-11-05 20:05:41.000000000","message":"nit: \u0027openstack user password set\u0027 in quotes would help in making this more readable","commit_id":"51e28d7d13fa2924aeb350d002628e79519e4e6d"},{"author":{"_account_id":33560,"name":"Alexandre Horst","email":"alexandre.horst@encora.com","username":"ahorst"},"change_message_id":"7d5aac5a6ce26e05fcf8c22980f58fa5b6f0bd52","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Test Plan:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"PASS: Verify on a controller with IPV6 enabled if the openstack"},{"line_number":21,"context_line":"      user password set change the password on the keystone"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-bug: 1949983"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"79896b35_57638c73","line":20,"in_reply_to":"75d71956_50dbc249","updated":"2021-11-08 16:09:20.000000000","message":"Done","commit_id":"51e28d7d13fa2924aeb350d002628e79519e4e6d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"3840cf05aff311cb7048303c0f176e0fd8aaaabe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f2a2761_6cc20ec3","updated":"2021-11-08 17:34:17.000000000","message":"Code seems fine.  It would be nice if there was a unit test for that method","commit_id":"03418c3f7527b7132a8998aa54dc21ab39e29bf6"},{"author":{"_account_id":33560,"name":"Alexandre Horst","email":"alexandre.horst@encora.com","username":"ahorst"},"change_message_id":"7d5aac5a6ce26e05fcf8c22980f58fa5b6f0bd52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df4367ed_db0bae66","updated":"2021-11-08 16:09:20.000000000","message":"Commit message is changed. ","commit_id":"03418c3f7527b7132a8998aa54dc21ab39e29bf6"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"0668fdefec0b777ebcaf35bc9d801aaded99b441","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"049e6d9c_7f7abeae","updated":"2021-11-08 21:08:39.000000000","message":"recheck","commit_id":"9bbe1d024820e03e16d226bd96237fc9b919e59f"},{"author":{"_account_id":33560,"name":"Alexandre Horst","email":"alexandre.horst@encora.com","username":"ahorst"},"change_message_id":"d3f14fc644b13329d0d941547701797b472aa6af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa491f68_018a7385","updated":"2021-11-09 19:26:41.000000000","message":"All the review have been addressed. Is there anything missing here?\n","commit_id":"84f466763a60646fbe4f47b8cb33bf1044a2b75b"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"762270e160bcc3c989cc4a199fe17abefc5067be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96d4a255_a80193e9","updated":"2021-11-08 23:52:11.000000000","message":"recheck","commit_id":"84f466763a60646fbe4f47b8cb33bf1044a2b75b"}],"sysinv/sysinv/sysinv/sysinv/conductor/keystone_listener.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"d60490066ce477082e96751ade457a1d9bbd5d71","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    auth_password \u003d keyring.get_password(\u0027amqp\u0027, \u0027rabbit\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if utils.is_valid_ipv6(address.address):"},{"line_number":69,"context_line":"        address \u003d \"[%s]\" % address.address"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    transport_url \u003d \"rabbit://guest:%s@%s:5672\" % (auth_password, address)"},{"line_number":72,"context_line":"    return transport_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"56c47cb6_d3a5740a","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"updated":"2021-11-08 14:16:27.000000000","message":"Can you please explain why this change will make secure_system.yaml updated with the new password?","commit_id":"51e28d7d13fa2924aeb350d002628e79519e4e6d"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"06cac7d9fc92b8133284df063aa0b5f93a23ef57","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    auth_password \u003d keyring.get_password(\u0027amqp\u0027, \u0027rabbit\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if utils.is_valid_ipv6(address.address):"},{"line_number":69,"context_line":"        address \u003d \"[%s]\" % address.address"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    transport_url \u003d \"rabbit://guest:%s@%s:5672\" % (auth_password, address)"},{"line_number":72,"context_line":"    return transport_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"845bc172_ce3e167b","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"in_reply_to":"51255cf1_45be22bc","updated":"2021-11-08 15:28:44.000000000","message":"Did you grep secure_system.yaml to see if the password actually updated?","commit_id":"51e28d7d13fa2924aeb350d002628e79519e4e6d"},{"author":{"_account_id":33560,"name":"Alexandre Horst","email":"alexandre.horst@encora.com","username":"ahorst"},"change_message_id":"a25b2e55c1aa7349af6c822f7f84e58aa70ef65d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    auth_password \u003d keyring.get_password(\u0027amqp\u0027, \u0027rabbit\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if utils.is_valid_ipv6(address.address):"},{"line_number":69,"context_line":"        address \u003d \"[%s]\" % address.address"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    transport_url \u003d \"rabbit://guest:%s@%s:5672\" % (auth_password, address)"},{"line_number":72,"context_line":"    return transport_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"51255cf1_45be22bc","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"in_reply_to":"56c47cb6_d3a5740a","updated":"2021-11-08 15:00:36.000000000","message":"So Andy, I saw in the log where the error occurred in the test, a message from a python object being passed to the https/rabbit request. At that moment, I checked all the changes and realized that in the IPV4 version, it works, but in IPV6 it was necessary to put the square brackets. So the passed object is now the IPV6 address instead of the address object.","commit_id":"51e28d7d13fa2924aeb350d002628e79519e4e6d"},{"author":{"_account_id":33560,"name":"Alexandre Horst","email":"alexandre.horst@encora.com","username":"ahorst"},"change_message_id":"d6a3b2ce7a106555cee6f936445df7286f1ca251","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    auth_password \u003d keyring.get_password(\u0027amqp\u0027, \u0027rabbit\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if utils.is_valid_ipv6(address.address):"},{"line_number":69,"context_line":"        address \u003d \"[%s]\" % address.address"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    transport_url \u003d \"rabbit://guest:%s@%s:5672\" % (auth_password, address)"},{"line_number":72,"context_line":"    return transport_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"8e044ae5_8e2b920f","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"in_reply_to":"845bc172_ce3e167b","updated":"2021-11-08 19:51:57.000000000","message":"I tested in IPV6 controller.\n\n [sysadmin@controller-0 ~(keystone_admin)]$ echo $OS_PASSWORD\n Li69nux*\n [sysadmin@controller-0 ~(keystone_admin)]$ sudo grep Li69nux* /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/*\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_static.yaml:dcmanager::api::keystone_admin_password: !!python/unicode \u0027Li69nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_static.yaml:dcorch::api_proxy::keystone_admin_password: !!python/unicode \u0027Li69nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_static.yaml:keystone::admin_password: !!python/unicode \u0027Li69nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_static.yaml:keystone::roles::admin::password: !!python/unicode \u0027Li69nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_static.yaml:platform::client::params::admin_password: !!python/unicode \u0027Li69nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:dcmanager::api::keystone_admin_password: !!python/unicode \u0027Li69nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:dcorch::api_proxy::keystone_admin_password: !!python/unicode \u0027Li69nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:keystone::admin_password: !!python/unicode \u0027Li69nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:keystone::roles::admin::password: !!python/unicode \u0027Li69nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:platform::client::params::admin_password: !!python/unicode \u0027Li69nux*\u0027\n [sysadmin@controller-0 ~(keystone_admin)]$ \n [sysadmin@controller-0 ~(keystone_admin)]$ openstack user password set \n Current Password:\n New Password:\n Repeat New Password:\n [sysadmin@controller-0 ~(keystone_admin)]$ less /var/log/sysinv.log\n [sysadmin@controller-0 ~(keystone_admin)]$ sudo grep Li70nux* /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/*\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:dcmanager::api::keystone_admin_password: !!python/unicode \u0027Li70nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:dcorch::api_proxy::keystone_admin_password: !!python/unicode \u0027Li70nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:keystone::admin_password: !!python/unicode \u0027Li70nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:keystone::roles::admin::password: !!python/unicode \u0027Li70nux*\u0027\n /opt/platform/puppet/\u003csoftware-version\u003e/hieradata/secure_system.yaml:platform::client::params::admin_password: !!python/unicode \u0027Li70nux*\u0027\n [sysadmin@controller-0 ~(keystone_admin)]$ \n source /etc/platform/openrc\n [sysadmin@controller-0 ~(keystone_admin)]$ echo $OS_PASSWORD\n Li70nux*","commit_id":"51e28d7d13fa2924aeb350d002628e79519e4e6d"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"996f12319c81f3eba7da143538d3126e3ce86793","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    auth_password \u003d keyring.get_password(\u0027amqp\u0027, \u0027rabbit\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if utils.is_valid_ipv6(address.address):"},{"line_number":69,"context_line":"        address \u003d \"[%s]\" % address.address"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    transport_url \u003d \"rabbit://guest:%s@%s:5672\" % (auth_password, address)"},{"line_number":72,"context_line":"    return transport_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c93b675_31c7c6b3","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"in_reply_to":"8e044ae5_8e2b920f","updated":"2021-11-08 20:23:48.000000000","message":"It looks fine. Just update the commit log to include this test case.","commit_id":"51e28d7d13fa2924aeb350d002628e79519e4e6d"}]}