)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0dbd250e32f8fca47777426c0e88bc2e0d72fe9d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"monitors have been upgraded to Ceph Nautilus."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/utilities/+/817504"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Vinicius Lopes da Silva \u003cvinicius.lopesdasilva@windriver.com\u003e"},{"line_number":17,"context_line":"Change-Id: Ibe112ad51177aee95fa990caf81bd9a376a9f0af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f38ffd51_bb01345a","line":15,"updated":"2021-11-11 02:05:12.000000000","message":"Need LP or Story/Task","commit_id":"d99dd2f4682ffa91b075d91299bc58f2462ee1c0"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"e7b3a66612feac5214714115796d4e466547387d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"monitors have been upgraded to Ceph Nautilus."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/utilities/+/817504"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Vinicius Lopes da Silva \u003cvinicius.lopesdasilva@windriver.com\u003e"},{"line_number":17,"context_line":"Change-Id: Ibe112ad51177aee95fa990caf81bd9a376a9f0af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bb48830d_eb24559b","line":15,"in_reply_to":"f38ffd51_bb01345a","updated":"2021-11-14 22:42:16.000000000","message":"Ack","commit_id":"d99dd2f4682ffa91b075d91299bc58f2462ee1c0"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9c886bebfd20778d1c44decd78802c45717aa2d0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Once all monitors are upgraded, a ceph alarm is raised, requesting"},{"line_number":12,"context_line":"msgr2 to be enabled and this is done as part of the method that"},{"line_number":13,"context_line":"audits the upgrade."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/utilities/+/817504"},{"line_number":16,"context_line":"Story: 2009074"},{"line_number":17,"context_line":"Task: 43944"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"4f9b5dfd_0ee22313","line":14,"updated":"2021-11-12 18:39:38.000000000","message":"Add a section here on testing covered","commit_id":"5e9054c4e4b69b015535afa333fc7eca3c25fe28"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"c10b761252a692ac647696168ff6fd078f9c043b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Once all monitors are upgraded, a ceph alarm is raised, requesting"},{"line_number":12,"context_line":"msgr2 to be enabled and this is done as part of the method that"},{"line_number":13,"context_line":"audits the upgrade."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/utilities/+/817504"},{"line_number":16,"context_line":"Story: 2009074"},{"line_number":17,"context_line":"Task: 43944"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"dbee9cb0_0ee4bfe3","line":14,"in_reply_to":"4f9b5dfd_0ee22313","updated":"2021-11-14 21:43:52.000000000","message":"Ack","commit_id":"5e9054c4e4b69b015535afa333fc7eca3c25fe28"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"062a902ee9b9adf56af21656d3b32a075ac66c84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48d17daa_94e07a03","updated":"2021-11-11 02:34:48.000000000","message":"Also created story/task","commit_id":"e2f279aca01b02f24cd5dbc323050ff9517e7513"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"afcca778e12dbb81166f726473b2e2cc89b1583b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8c5dba07_627bc830","updated":"2021-11-11 03:33:18.000000000","message":"The puppet change would also need to part of stx.5.0 so that it would support formatting the ceph monitor addresses correctly on controller-1 unlock. As this is the first node upgraded in a multi node setup, it will need to have the correct addressing to talk to the Mimic v1 monitors.\n\nThe initial change can go into stx.6.0. Can you split these two changes? I think we may need to handle the puppet change directly in the puppet manifest to avoid having to patch stx 5.0. This way the newly installed node will take the monitor address and format correctly for v1 or v2 depending on upgrade state.","commit_id":"fafcad6c1a7fa96a34dea74db13b56a7ba438a1c"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0dbd250e32f8fca47777426c0e88bc2e0d72fe9d","unresolved":true,"context_lines":[{"line_number":5730,"context_line":"        elif upgrade.state \u003d\u003d constants.UPGRADE_UPGRADING_HOSTS:"},{"line_number":5731,"context_line":"            # As part of a 3-host Ceph monitor quorum, over a platform upgrade"},{"line_number":5732,"context_line":"            # we may need to take action once all monitors are running"},{"line_number":5733,"context_line":"            ceph_storage_backends \u003d self.dbapi.storage_ceph_get_list()"},{"line_number":5734,"context_line":"            if ceph_storage_backends:"},{"line_number":5735,"context_line":"                monitor_list \u003d self.dbapi.ceph_mon_get_list()"},{"line_number":5736,"context_line":"                for mon in monitor_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1418559_c75842ce","line":5733,"updated":"2021-11-11 02:05:12.000000000","message":"Use existing patterns:\n\n ceph_storage_backend \u003d StorageBackendConfig.get_backend(\n            self.dbapi,\n            constants.SB_TYPE_CEPH)","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"062a902ee9b9adf56af21656d3b32a075ac66c84","unresolved":true,"context_lines":[{"line_number":5730,"context_line":"        elif upgrade.state \u003d\u003d constants.UPGRADE_UPGRADING_HOSTS:"},{"line_number":5731,"context_line":"            # As part of a 3-host Ceph monitor quorum, over a platform upgrade"},{"line_number":5732,"context_line":"            # we may need to take action once all monitors are running"},{"line_number":5733,"context_line":"            ceph_storage_backends \u003d self.dbapi.storage_ceph_get_list()"},{"line_number":5734,"context_line":"            if ceph_storage_backends:"},{"line_number":5735,"context_line":"                monitor_list \u003d self.dbapi.ceph_mon_get_list()"},{"line_number":5736,"context_line":"                for mon in monitor_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e70062d0_47332680","line":5733,"in_reply_to":"a1418559_c75842ce","updated":"2021-11-11 02:34:48.000000000","message":"Done","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":5730,"context_line":"        elif upgrade.state \u003d\u003d constants.UPGRADE_UPGRADING_HOSTS:"},{"line_number":5731,"context_line":"            # As part of a 3-host Ceph monitor quorum, over a platform upgrade"},{"line_number":5732,"context_line":"            # we may need to take action once all monitors are running"},{"line_number":5733,"context_line":"            ceph_storage_backends \u003d self.dbapi.storage_ceph_get_list()"},{"line_number":5734,"context_line":"            if ceph_storage_backends:"},{"line_number":5735,"context_line":"                monitor_list \u003d self.dbapi.ceph_mon_get_list()"},{"line_number":5736,"context_line":"                for mon in monitor_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7fd3e735_24a5382b","line":5733,"in_reply_to":"e70062d0_47332680","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0dbd250e32f8fca47777426c0e88bc2e0d72fe9d","unresolved":true,"context_lines":[{"line_number":5732,"context_line":"            # we may need to take action once all monitors are running"},{"line_number":5733,"context_line":"            ceph_storage_backends \u003d self.dbapi.storage_ceph_get_list()"},{"line_number":5734,"context_line":"            if ceph_storage_backends:"},{"line_number":5735,"context_line":"                monitor_list \u003d self.dbapi.ceph_mon_get_list()"},{"line_number":5736,"context_line":"                for mon in monitor_list:"},{"line_number":5737,"context_line":"                    if mon.host.host_upgrade.target_load !\u003d upgrade.to_release:"},{"line_number":5738,"context_line":"                        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"2de8cdc1_5a828b16","line":5735,"updated":"2021-11-11 02:05:12.000000000","message":"Add:\n  LOG.info(\"Ceph Upgrade: Checking monitor states\")","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"062a902ee9b9adf56af21656d3b32a075ac66c84","unresolved":true,"context_lines":[{"line_number":5732,"context_line":"            # we may need to take action once all monitors are running"},{"line_number":5733,"context_line":"            ceph_storage_backends \u003d self.dbapi.storage_ceph_get_list()"},{"line_number":5734,"context_line":"            if ceph_storage_backends:"},{"line_number":5735,"context_line":"                monitor_list \u003d self.dbapi.ceph_mon_get_list()"},{"line_number":5736,"context_line":"                for mon in monitor_list:"},{"line_number":5737,"context_line":"                    if mon.host.host_upgrade.target_load !\u003d upgrade.to_release:"},{"line_number":5738,"context_line":"                        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ccdf686_394d8678","line":5735,"in_reply_to":"2de8cdc1_5a828b16","updated":"2021-11-11 02:34:48.000000000","message":"Done","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":5732,"context_line":"            # we may need to take action once all monitors are running"},{"line_number":5733,"context_line":"            ceph_storage_backends \u003d self.dbapi.storage_ceph_get_list()"},{"line_number":5734,"context_line":"            if ceph_storage_backends:"},{"line_number":5735,"context_line":"                monitor_list \u003d self.dbapi.ceph_mon_get_list()"},{"line_number":5736,"context_line":"                for mon in monitor_list:"},{"line_number":5737,"context_line":"                    if mon.host.host_upgrade.target_load !\u003d upgrade.to_release:"},{"line_number":5738,"context_line":"                        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"c5627cbe_b865c8ca","line":5735,"in_reply_to":"7ccdf686_394d8678","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0dbd250e32f8fca47777426c0e88bc2e0d72fe9d","unresolved":true,"context_lines":[{"line_number":5735,"context_line":"                monitor_list \u003d self.dbapi.ceph_mon_get_list()"},{"line_number":5736,"context_line":"                for mon in monitor_list:"},{"line_number":5737,"context_line":"                    if mon.host.host_upgrade.target_load !\u003d upgrade.to_release:"},{"line_number":5738,"context_line":"                        return"},{"line_number":5739,"context_line":"                    mon_config_target \u003d mon.host.config_target"},{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ebf2158d_a2dc5b1e","line":5738,"updated":"2021-11-11 02:05:12.000000000","message":"Add:\n  LOG.info(\"Ceph Upgrade: Monitor %s is not upgraded to %s\" % (mon.hostname, upgrade.to_release))","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":5735,"context_line":"                monitor_list \u003d self.dbapi.ceph_mon_get_list()"},{"line_number":5736,"context_line":"                for mon in monitor_list:"},{"line_number":5737,"context_line":"                    if mon.host.host_upgrade.target_load !\u003d upgrade.to_release:"},{"line_number":5738,"context_line":"                        return"},{"line_number":5739,"context_line":"                    mon_config_target \u003d mon.host.config_target"},{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"}],"source_content_type":"text/x-python","patch_set":1,"id":"91d31651_bbc88224","line":5738,"in_reply_to":"dc2ab416_6d2a6d46","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"062a902ee9b9adf56af21656d3b32a075ac66c84","unresolved":true,"context_lines":[{"line_number":5735,"context_line":"                monitor_list \u003d self.dbapi.ceph_mon_get_list()"},{"line_number":5736,"context_line":"                for mon in monitor_list:"},{"line_number":5737,"context_line":"                    if mon.host.host_upgrade.target_load !\u003d upgrade.to_release:"},{"line_number":5738,"context_line":"                        return"},{"line_number":5739,"context_line":"                    mon_config_target \u003d mon.host.config_target"},{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc2ab416_6d2a6d46","line":5738,"in_reply_to":"ebf2158d_a2dc5b1e","updated":"2021-11-11 02:34:48.000000000","message":"Done","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0dbd250e32f8fca47777426c0e88bc2e0d72fe9d","unresolved":true,"context_lines":[{"line_number":5738,"context_line":"                        return"},{"line_number":5739,"context_line":"                    mon_config_target \u003d mon.host.config_target"},{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d4d0781_f57fd18f","line":5741,"range":{"start_line":5741,"start_character":68,"end_line":5741,"end_character":70},"updated":"2021-11-11 02:05:12.000000000","message":"Should be !\u003d","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"062a902ee9b9adf56af21656d3b32a075ac66c84","unresolved":true,"context_lines":[{"line_number":5738,"context_line":"                        return"},{"line_number":5739,"context_line":"                    mon_config_target \u003d mon.host.config_target"},{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d8bd89ff_3dcdf6e4","line":5741,"range":{"start_line":5741,"start_character":68,"end_line":5741,"end_character":70},"in_reply_to":"1d4d0781_f57fd18f","updated":"2021-11-11 02:34:48.000000000","message":"Done","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":5738,"context_line":"                        return"},{"line_number":5739,"context_line":"                    mon_config_target \u003d mon.host.config_target"},{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"877d7019_754699d2","line":5741,"range":{"start_line":5741,"start_character":68,"end_line":5741,"end_character":70},"in_reply_to":"d8bd89ff_3dcdf6e4","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0dbd250e32f8fca47777426c0e88bc2e0d72fe9d","unresolved":true,"context_lines":[{"line_number":5739,"context_line":"                    mon_config_target \u003d mon.host.config_target"},{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"},{"line_number":5745,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"16e8ac65_e5b70015","line":5742,"updated":"2021-11-11 02:05:12.000000000","message":"Add: \n  LOG.info(\"Ceph Upgrade: Monitor %s has not applied the latest configuration changes\" % mon.hostname)","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":5739,"context_line":"                    mon_config_target \u003d mon.host.config_target"},{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"},{"line_number":5745,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4a62ea8_96a9c7e9","line":5742,"in_reply_to":"0af9508d_d046ac1d","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"062a902ee9b9adf56af21656d3b32a075ac66c84","unresolved":true,"context_lines":[{"line_number":5739,"context_line":"                    mon_config_target \u003d mon.host.config_target"},{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"},{"line_number":5745,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"0af9508d_d046ac1d","line":5742,"in_reply_to":"16e8ac65_e5b70015","updated":"2021-11-11 02:34:48.000000000","message":"Done","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0dbd250e32f8fca47777426c0e88bc2e0d72fe9d","unresolved":true,"context_lines":[{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"},{"line_number":5745,"context_line":"                return"},{"line_number":5746,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"340b3833_3d3b9c8d","line":5743,"updated":"2021-11-11 02:05:12.000000000","message":"Add:\n  LOG.info(\"Ceph Upgrade: Enabling monitor msgr2\")","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"},{"line_number":5745,"context_line":"                return"},{"line_number":5746,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f8b533bc_469afa05","line":5743,"in_reply_to":"09b7b233_f22bf55f","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"062a902ee9b9adf56af21656d3b32a075ac66c84","unresolved":true,"context_lines":[{"line_number":5740,"context_line":"                    mon_config_applied \u003d mon.host.config_applied"},{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"},{"line_number":5745,"context_line":"                return"},{"line_number":5746,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"09b7b233_f22bf55f","line":5743,"in_reply_to":"340b3833_3d3b9c8d","updated":"2021-11-11 02:34:48.000000000","message":"Done","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0dbd250e32f8fca47777426c0e88bc2e0d72fe9d","unresolved":true,"context_lines":[{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"},{"line_number":5745,"context_line":"                return"},{"line_number":5746,"context_line":""},{"line_number":5747,"context_line":"    def _audit_install_states(self, hosts):"}],"source_content_type":"text/x-python","patch_set":1,"id":"118fff23_4fffc62f","line":5744,"updated":"2021-11-11 02:05:12.000000000","message":"else not needed.","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"062a902ee9b9adf56af21656d3b32a075ac66c84","unresolved":true,"context_lines":[{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"},{"line_number":5745,"context_line":"                return"},{"line_number":5746,"context_line":""},{"line_number":5747,"context_line":"    def _audit_install_states(self, hosts):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c5b4826_95ac90aa","line":5744,"in_reply_to":"118fff23_4fffc62f","updated":"2021-11-11 02:34:48.000000000","message":"Done","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":5741,"context_line":"                    if not (mon_config_target and mon_config_target \u003d\u003d mon_config_applied):"},{"line_number":5742,"context_line":"                        return"},{"line_number":5743,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5744,"context_line":"            else:"},{"line_number":5745,"context_line":"                return"},{"line_number":5746,"context_line":""},{"line_number":5747,"context_line":"    def _audit_install_states(self, hosts):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a2d2b74_85299c97","line":5744,"in_reply_to":"8c5b4826_95ac90aa","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"b7096f3d7f96fdd49cc979e090fb31c132f709af"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"9c886bebfd20778d1c44decd78802c45717aa2d0","unresolved":true,"context_lines":[{"line_number":5755,"context_line":"                                 \"latest configuration changes\" % mon.hostname)"},{"line_number":5756,"context_line":"                        return"},{"line_number":5757,"context_line":"                LOG.info(\"Ceph Upgrade: Enabling monitor msgr2\")"},{"line_number":5758,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5759,"context_line":"                LOG.info(\"Ceph Upgrade: Enabled monitor msgr2\")"},{"line_number":5760,"context_line":""},{"line_number":5761,"context_line":"    def _audit_install_states(self, hosts):"}],"source_content_type":"text/x-python","patch_set":15,"id":"e43a9c83_77f4fcb6","line":5758,"updated":"2021-11-12 18:39:38.000000000","message":"This is probably OK for now, but for a future update may want to consider:\n\n- Add a timeout to this call to timebox how long we\u0027ll allow this to run, this should be a quick operation if all iw working correctly\n- Add a defensive try/exception around this in case the REST API is not accessible or there is a problem so that we log a message and try again on the next audit cycle\n- If we have a break in the quorum or ceph mgr is not running for some reason, will this API call take a long time to time out and block the audit? If so we could offload this logic to the HandleUpgradesMixin in utilities/ceph/ceph-manager/ceph-manager/ceph_manager/monitor.py","commit_id":"5e9054c4e4b69b015535afa333fc7eca3c25fe28"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"2a4c760bbe27724ff655374229eb144480b5c20f","unresolved":false,"context_lines":[{"line_number":5755,"context_line":"                                 \"latest configuration changes\" % mon.hostname)"},{"line_number":5756,"context_line":"                        return"},{"line_number":5757,"context_line":"                LOG.info(\"Ceph Upgrade: Enabling monitor msgr2\")"},{"line_number":5758,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5759,"context_line":"                LOG.info(\"Ceph Upgrade: Enabled monitor msgr2\")"},{"line_number":5760,"context_line":""},{"line_number":5761,"context_line":"    def _audit_install_states(self, hosts):"}],"source_content_type":"text/x-python","patch_set":15,"id":"980b805a_d827e347","line":5758,"in_reply_to":"0289dbbc_db659a9d","updated":"2021-11-14 21:45:21.000000000","message":"Will address this in a future commit and create a task in SB for this.","commit_id":"5e9054c4e4b69b015535afa333fc7eca3c25fe28"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"c84a1b1c19146100541f42df63574765be5e979e","unresolved":false,"context_lines":[{"line_number":5755,"context_line":"                                 \"latest configuration changes\" % mon.hostname)"},{"line_number":5756,"context_line":"                        return"},{"line_number":5757,"context_line":"                LOG.info(\"Ceph Upgrade: Enabling monitor msgr2\")"},{"line_number":5758,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5759,"context_line":"                LOG.info(\"Ceph Upgrade: Enabled monitor msgr2\")"},{"line_number":5760,"context_line":""},{"line_number":5761,"context_line":"    def _audit_install_states(self, hosts):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3b7192cf_8482999a","line":5758,"in_reply_to":"980b805a_d827e347","updated":"2021-11-17 14:00:45.000000000","message":"Task create in SB  43998","commit_id":"5e9054c4e4b69b015535afa333fc7eca3c25fe28"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"c10b761252a692ac647696168ff6fd078f9c043b","unresolved":false,"context_lines":[{"line_number":5755,"context_line":"                                 \"latest configuration changes\" % mon.hostname)"},{"line_number":5756,"context_line":"                        return"},{"line_number":5757,"context_line":"                LOG.info(\"Ceph Upgrade: Enabling monitor msgr2\")"},{"line_number":5758,"context_line":"                self._ceph_api.enable_msgr2()"},{"line_number":5759,"context_line":"                LOG.info(\"Ceph Upgrade: Enabled monitor msgr2\")"},{"line_number":5760,"context_line":""},{"line_number":5761,"context_line":"    def _audit_install_states(self, hosts):"}],"source_content_type":"text/x-python","patch_set":15,"id":"0289dbbc_db659a9d","line":5758,"in_reply_to":"e43a9c83_77f4fcb6","updated":"2021-11-14 21:43:52.000000000","message":"Ack","commit_id":"5e9054c4e4b69b015535afa333fc7eca3c25fe28"}],"sysinv/sysinv/sysinv/sysinv/puppet/ceph.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ed98b4106ae51c70b907e418c76436b0dd7409ce","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            mon_2_addr \u003d None"},{"line_number":86,"context_line":"        floating_mon_addr \u003d self._format_ceph_mon_address(floating_mon_ip)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # ceph can not bind to multiple address families, so only enable IPv6"},{"line_number":89,"context_line":"        # if the monitors are IPv6 addresses"},{"line_number":90,"context_line":"        ms_bind_ipv6 \u003d (netaddr.IPAddress(mon_0_ip).version \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":6,"id":"c98498c4_eca45c19","side":"PARENT","line":87,"updated":"2021-11-11 18:39:27.000000000","message":"don\u0027t remove...","commit_id":"5bcd7b22da679f22677a1493b6d4a82b35929f6c"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            mon_2_addr \u003d None"},{"line_number":86,"context_line":"        floating_mon_addr \u003d self._format_ceph_mon_address(floating_mon_ip)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # ceph can not bind to multiple address families, so only enable IPv6"},{"line_number":89,"context_line":"        # if the monitors are IPv6 addresses"},{"line_number":90,"context_line":"        ms_bind_ipv6 \u003d (netaddr.IPAddress(mon_0_ip).version \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":6,"id":"98477dcc_7b187671","side":"PARENT","line":87,"in_reply_to":"82526e6b_ec9d11d4","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"5bcd7b22da679f22677a1493b6d4a82b35929f6c"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"bed537edf8986edd1a6998cf77037a85e9b74ab7","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            mon_2_addr \u003d None"},{"line_number":86,"context_line":"        floating_mon_addr \u003d self._format_ceph_mon_address(floating_mon_ip)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # ceph can not bind to multiple address families, so only enable IPv6"},{"line_number":89,"context_line":"        # if the monitors are IPv6 addresses"},{"line_number":90,"context_line":"        ms_bind_ipv6 \u003d (netaddr.IPAddress(mon_0_ip).version \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":6,"id":"82526e6b_ec9d11d4","side":"PARENT","line":87,"in_reply_to":"c98498c4_eca45c19","updated":"2021-11-11 18:55:17.000000000","message":"done","commit_id":"5bcd7b22da679f22677a1493b6d4a82b35929f6c"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ed98b4106ae51c70b907e418c76436b0dd7409ce","unresolved":true,"context_lines":[{"line_number":264,"context_line":"        except Exception:"},{"line_number":265,"context_line":"            pass"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            LOG.info(\"Formatting addresses to enforce v1 in monitors\")"},{"line_number":268,"context_line":"            mon_0_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_0_ip), self.SERVICE_PORT_MON_V1)"},{"line_number":269,"context_line":"            mon_1_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_1_ip), self.SERVICE_PORT_MON_V1)"},{"line_number":270,"context_line":"            if mon_2_ip:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dcb0a200_c722dd71","line":267,"updated":"2021-11-11 18:39:27.000000000","message":"This should only be done if this is a monitor host, other hosts can use the defaults set in system_config","commit_id":"d67539500c0975078aeeb5c0a4d06a6e0e39ea94"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"bed537edf8986edd1a6998cf77037a85e9b74ab7","unresolved":true,"context_lines":[{"line_number":264,"context_line":"        except Exception:"},{"line_number":265,"context_line":"            pass"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            LOG.info(\"Formatting addresses to enforce v1 in monitors\")"},{"line_number":268,"context_line":"            mon_0_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_0_ip), self.SERVICE_PORT_MON_V1)"},{"line_number":269,"context_line":"            mon_1_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_1_ip), self.SERVICE_PORT_MON_V1)"},{"line_number":270,"context_line":"            if mon_2_ip:"}],"source_content_type":"text/x-python","patch_set":6,"id":"f7471193_2c31c5ab","line":267,"in_reply_to":"dcb0a200_c722dd71","updated":"2021-11-11 18:55:17.000000000","message":"done","commit_id":"d67539500c0975078aeeb5c0a4d06a6e0e39ea94"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        except Exception:"},{"line_number":265,"context_line":"            pass"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            LOG.info(\"Formatting addresses to enforce v1 in monitors\")"},{"line_number":268,"context_line":"            mon_0_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_0_ip), self.SERVICE_PORT_MON_V1)"},{"line_number":269,"context_line":"            mon_1_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_1_ip), self.SERVICE_PORT_MON_V1)"},{"line_number":270,"context_line":"            if mon_2_ip:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a97fe31_707e5e19","line":267,"in_reply_to":"f7471193_2c31c5ab","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"d67539500c0975078aeeb5c0a4d06a6e0e39ea94"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"5fca229f717e03d764265174fc33b29825ef9f46","unresolved":true,"context_lines":[{"line_number":249,"context_line":"            mon_lv_size \u003d constants.SB_CEPH_MON_GIB"},{"line_number":250,"context_line":"        config[\u0027platform::ceph::params::mon_lv_size\u0027] \u003d mon_lv_size"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        ceph_mon_ips \u003d StorageBackendConfig.get_ceph_mon_ip_addresses("},{"line_number":253,"context_line":"            self.dbapi"},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if not ceph_mon_ips:"},{"line_number":257,"context_line":"            return {}  # system configuration is not yet ready"}],"source_content_type":"text/x-python","patch_set":10,"id":"f1670810_8c5730f0","line":254,"range":{"start_line":252,"start_character":8,"end_line":254,"end_character":9},"updated":"2021-11-12 08:16:10.000000000","message":"Move this to be part of the else clause below","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            mon_lv_size \u003d constants.SB_CEPH_MON_GIB"},{"line_number":250,"context_line":"        config[\u0027platform::ceph::params::mon_lv_size\u0027] \u003d mon_lv_size"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        ceph_mon_ips \u003d StorageBackendConfig.get_ceph_mon_ip_addresses("},{"line_number":253,"context_line":"            self.dbapi"},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if not ceph_mon_ips:"},{"line_number":257,"context_line":"            return {}  # system configuration is not yet ready"}],"source_content_type":"text/x-python","patch_set":10,"id":"20bbbf14_8e5a1521","line":254,"range":{"start_line":252,"start_character":8,"end_line":254,"end_character":9},"in_reply_to":"49b5d6dd_3bb9762c","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"e18eb93430ef51cdb44de62e1247b4ae141bfd8c","unresolved":true,"context_lines":[{"line_number":249,"context_line":"            mon_lv_size \u003d constants.SB_CEPH_MON_GIB"},{"line_number":250,"context_line":"        config[\u0027platform::ceph::params::mon_lv_size\u0027] \u003d mon_lv_size"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        ceph_mon_ips \u003d StorageBackendConfig.get_ceph_mon_ip_addresses("},{"line_number":253,"context_line":"            self.dbapi"},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if not ceph_mon_ips:"},{"line_number":257,"context_line":"            return {}  # system configuration is not yet ready"}],"source_content_type":"text/x-python","patch_set":10,"id":"49b5d6dd_3bb9762c","line":254,"range":{"start_line":252,"start_character":8,"end_line":254,"end_character":9},"in_reply_to":"f1670810_8c5730f0","updated":"2021-11-12 13:20:49.000000000","message":"Done","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"5fca229f717e03d764265174fc33b29825ef9f46","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            self.dbapi"},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if not ceph_mon_ips:"},{"line_number":257,"context_line":"            return {}  # system configuration is not yet ready"},{"line_number":258,"context_line":"        if ceph_mon:"},{"line_number":259,"context_line":"            mon_0_ip \u003d ceph_mon_ips[constants.CEPH_MON_0]"},{"line_number":260,"context_line":"            mon_1_ip \u003d ceph_mon_ips[constants.CEPH_MON_1]"}],"source_content_type":"text/x-python","patch_set":10,"id":"f3c8d74f_28ceaafc","line":257,"range":{"start_line":256,"start_character":8,"end_line":257,"end_character":62},"updated":"2021-11-12 08:16:10.000000000","message":"This can be removed if the above is part of the else clause as the if ceph_mon on line 257 below will make sure that this is a monitor host.","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            self.dbapi"},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if not ceph_mon_ips:"},{"line_number":257,"context_line":"            return {}  # system configuration is not yet ready"},{"line_number":258,"context_line":"        if ceph_mon:"},{"line_number":259,"context_line":"            mon_0_ip \u003d ceph_mon_ips[constants.CEPH_MON_0]"},{"line_number":260,"context_line":"            mon_1_ip \u003d ceph_mon_ips[constants.CEPH_MON_1]"}],"source_content_type":"text/x-python","patch_set":10,"id":"7926daea_dce97c3d","line":257,"range":{"start_line":256,"start_character":8,"end_line":257,"end_character":62},"in_reply_to":"76fbdcd3_4b93c821","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"e18eb93430ef51cdb44de62e1247b4ae141bfd8c","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            self.dbapi"},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        if not ceph_mon_ips:"},{"line_number":257,"context_line":"            return {}  # system configuration is not yet ready"},{"line_number":258,"context_line":"        if ceph_mon:"},{"line_number":259,"context_line":"            mon_0_ip \u003d ceph_mon_ips[constants.CEPH_MON_0]"},{"line_number":260,"context_line":"            mon_1_ip \u003d ceph_mon_ips[constants.CEPH_MON_1]"}],"source_content_type":"text/x-python","patch_set":10,"id":"76fbdcd3_4b93c821","line":257,"range":{"start_line":256,"start_character":8,"end_line":257,"end_character":62},"in_reply_to":"f3c8d74f_28ceaafc","updated":"2021-11-12 13:20:49.000000000","message":"Done","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"5fca229f717e03d764265174fc33b29825ef9f46","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        if not ceph_mon_ips:"},{"line_number":257,"context_line":"            return {}  # system configuration is not yet ready"},{"line_number":258,"context_line":"        if ceph_mon:"},{"line_number":259,"context_line":"            mon_0_ip \u003d ceph_mon_ips[constants.CEPH_MON_0]"},{"line_number":260,"context_line":"            mon_1_ip \u003d ceph_mon_ips[constants.CEPH_MON_1]"},{"line_number":261,"context_line":"            mon_2_ip \u003d ceph_mon_ips.get(constants.CEPH_MON_2, None)"},{"line_number":262,"context_line":"            try:"},{"line_number":263,"context_line":"                upgrade \u003d self.dbapi.software_upgrade_get_one()"},{"line_number":264,"context_line":"                LOG.info(\"Platform Upgrade in Progress %s\" % upgrade.state)"}],"source_content_type":"text/x-python","patch_set":10,"id":"66a742d4_d75a8949","line":261,"range":{"start_line":259,"start_character":12,"end_line":261,"end_character":67},"updated":"2021-11-12 08:16:10.000000000","message":"Also move this to within the else clause","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"e18eb93430ef51cdb44de62e1247b4ae141bfd8c","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        if not ceph_mon_ips:"},{"line_number":257,"context_line":"            return {}  # system configuration is not yet ready"},{"line_number":258,"context_line":"        if ceph_mon:"},{"line_number":259,"context_line":"            mon_0_ip \u003d ceph_mon_ips[constants.CEPH_MON_0]"},{"line_number":260,"context_line":"            mon_1_ip \u003d ceph_mon_ips[constants.CEPH_MON_1]"},{"line_number":261,"context_line":"            mon_2_ip \u003d ceph_mon_ips.get(constants.CEPH_MON_2, None)"},{"line_number":262,"context_line":"            try:"},{"line_number":263,"context_line":"                upgrade \u003d self.dbapi.software_upgrade_get_one()"},{"line_number":264,"context_line":"                LOG.info(\"Platform Upgrade in Progress %s\" % upgrade.state)"}],"source_content_type":"text/x-python","patch_set":10,"id":"d64d40b3_6f636ec5","line":261,"range":{"start_line":259,"start_character":12,"end_line":261,"end_character":67},"in_reply_to":"66a742d4_d75a8949","updated":"2021-11-12 13:20:49.000000000","message":"Done","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        if not ceph_mon_ips:"},{"line_number":257,"context_line":"            return {}  # system configuration is not yet ready"},{"line_number":258,"context_line":"        if ceph_mon:"},{"line_number":259,"context_line":"            mon_0_ip \u003d ceph_mon_ips[constants.CEPH_MON_0]"},{"line_number":260,"context_line":"            mon_1_ip \u003d ceph_mon_ips[constants.CEPH_MON_1]"},{"line_number":261,"context_line":"            mon_2_ip \u003d ceph_mon_ips.get(constants.CEPH_MON_2, None)"},{"line_number":262,"context_line":"            try:"},{"line_number":263,"context_line":"                upgrade \u003d self.dbapi.software_upgrade_get_one()"},{"line_number":264,"context_line":"                LOG.info(\"Platform Upgrade in Progress %s\" % upgrade.state)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a82b499_75050d75","line":261,"range":{"start_line":259,"start_character":12,"end_line":261,"end_character":67},"in_reply_to":"d64d40b3_6f636ec5","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"5fca229f717e03d764265174fc33b29825ef9f46","unresolved":true,"context_lines":[{"line_number":259,"context_line":"            mon_0_ip \u003d ceph_mon_ips[constants.CEPH_MON_0]"},{"line_number":260,"context_line":"            mon_1_ip \u003d ceph_mon_ips[constants.CEPH_MON_1]"},{"line_number":261,"context_line":"            mon_2_ip \u003d ceph_mon_ips.get(constants.CEPH_MON_2, None)"},{"line_number":262,"context_line":"            try:"},{"line_number":263,"context_line":"                upgrade \u003d self.dbapi.software_upgrade_get_one()"},{"line_number":264,"context_line":"                LOG.info(\"Platform Upgrade in Progress %s\" % upgrade.state)"},{"line_number":265,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":10,"id":"70b44cf6_fcf763cf","line":262,"updated":"2021-11-12 08:16:10.000000000","message":"Add a comment above:\n\n # During an upgrade from STX.5.0 -\u003e STX.6.0, enforce msgr v1\n # addressing on all monitors. Can revert this change in STX.7.0","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"e18eb93430ef51cdb44de62e1247b4ae141bfd8c","unresolved":true,"context_lines":[{"line_number":259,"context_line":"            mon_0_ip \u003d ceph_mon_ips[constants.CEPH_MON_0]"},{"line_number":260,"context_line":"            mon_1_ip \u003d ceph_mon_ips[constants.CEPH_MON_1]"},{"line_number":261,"context_line":"            mon_2_ip \u003d ceph_mon_ips.get(constants.CEPH_MON_2, None)"},{"line_number":262,"context_line":"            try:"},{"line_number":263,"context_line":"                upgrade \u003d self.dbapi.software_upgrade_get_one()"},{"line_number":264,"context_line":"                LOG.info(\"Platform Upgrade in Progress %s\" % upgrade.state)"},{"line_number":265,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":10,"id":"e1183dc9_4699a6b1","line":262,"in_reply_to":"70b44cf6_fcf763cf","updated":"2021-11-12 13:20:49.000000000","message":"Done","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            mon_0_ip \u003d ceph_mon_ips[constants.CEPH_MON_0]"},{"line_number":260,"context_line":"            mon_1_ip \u003d ceph_mon_ips[constants.CEPH_MON_1]"},{"line_number":261,"context_line":"            mon_2_ip \u003d ceph_mon_ips.get(constants.CEPH_MON_2, None)"},{"line_number":262,"context_line":"            try:"},{"line_number":263,"context_line":"                upgrade \u003d self.dbapi.software_upgrade_get_one()"},{"line_number":264,"context_line":"                LOG.info(\"Platform Upgrade in Progress %s\" % upgrade.state)"},{"line_number":265,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":10,"id":"c34f7f94_14ed67ba","line":262,"in_reply_to":"e1183dc9_4699a6b1","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"5fca229f717e03d764265174fc33b29825ef9f46","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                upgrade \u003d self.dbapi.software_upgrade_get_one()"},{"line_number":264,"context_line":"                LOG.info(\"Platform Upgrade in Progress %s\" % upgrade.state)"},{"line_number":265,"context_line":"            except Exception:"},{"line_number":266,"context_line":"                pass"},{"line_number":267,"context_line":"            else:"},{"line_number":268,"context_line":"                LOG.info(\"Formatting addresses to enforce v1 in monitors\")"},{"line_number":269,"context_line":"                mon_0_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_0_ip),"}],"source_content_type":"text/x-python","patch_set":10,"id":"40c9737b_81dd1f23","line":266,"updated":"2021-11-12 08:16:10.000000000","message":"Add a comment:\n # Use default values from the system config if no upgrade in progress","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"e18eb93430ef51cdb44de62e1247b4ae141bfd8c","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                upgrade \u003d self.dbapi.software_upgrade_get_one()"},{"line_number":264,"context_line":"                LOG.info(\"Platform Upgrade in Progress %s\" % upgrade.state)"},{"line_number":265,"context_line":"            except Exception:"},{"line_number":266,"context_line":"                pass"},{"line_number":267,"context_line":"            else:"},{"line_number":268,"context_line":"                LOG.info(\"Formatting addresses to enforce v1 in monitors\")"},{"line_number":269,"context_line":"                mon_0_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_0_ip),"}],"source_content_type":"text/x-python","patch_set":10,"id":"8f514621_2c3404b8","line":266,"in_reply_to":"40c9737b_81dd1f23","updated":"2021-11-12 13:20:49.000000000","message":"Done","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                upgrade \u003d self.dbapi.software_upgrade_get_one()"},{"line_number":264,"context_line":"                LOG.info(\"Platform Upgrade in Progress %s\" % upgrade.state)"},{"line_number":265,"context_line":"            except Exception:"},{"line_number":266,"context_line":"                pass"},{"line_number":267,"context_line":"            else:"},{"line_number":268,"context_line":"                LOG.info(\"Formatting addresses to enforce v1 in monitors\")"},{"line_number":269,"context_line":"                mon_0_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_0_ip),"}],"source_content_type":"text/x-python","patch_set":10,"id":"c3b85613_54606c13","line":266,"in_reply_to":"8f514621_2c3404b8","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"5fca229f717e03d764265174fc33b29825ef9f46","unresolved":true,"context_lines":[{"line_number":266,"context_line":"                pass"},{"line_number":267,"context_line":"            else:"},{"line_number":268,"context_line":"                LOG.info(\"Formatting addresses to enforce v1 in monitors\")"},{"line_number":269,"context_line":"                mon_0_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_0_ip),"},{"line_number":270,"context_line":"                                             self.SERVICE_PORT_MON_V1)"},{"line_number":271,"context_line":"                mon_1_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_1_ip),"},{"line_number":272,"context_line":"                                             self.SERVICE_PORT_MON_V1)"}],"source_content_type":"text/x-python","patch_set":10,"id":"51d9c753_6e5bded5","line":269,"updated":"2021-11-12 08:16:10.000000000","message":"With this formatting an IPv6 address would look like [v1:[fe80::42:88ff:fe6c:8a5b]:6798]. Has this been tested? Do we needd too tweak the formatting for IPv6","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"fb0443b8401f7b7028cfaf5d39c8b3d4ec61913d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                pass"},{"line_number":267,"context_line":"            else:"},{"line_number":268,"context_line":"                LOG.info(\"Formatting addresses to enforce v1 in monitors\")"},{"line_number":269,"context_line":"                mon_0_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_0_ip),"},{"line_number":270,"context_line":"                                             self.SERVICE_PORT_MON_V1)"},{"line_number":271,"context_line":"                mon_1_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_1_ip),"},{"line_number":272,"context_line":"                                             self.SERVICE_PORT_MON_V1)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dd9beffa_2a246949","line":269,"in_reply_to":"14c55ae0_fc9c4866","updated":"2021-11-14 22:43:44.000000000","message":"Ack","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"},{"author":{"_account_id":33278,"name":"Vinicius Lopes da Silva","email":"vinicius.lopesdasilva@windriver.com","username":"vlopesda"},"change_message_id":"e18eb93430ef51cdb44de62e1247b4ae141bfd8c","unresolved":true,"context_lines":[{"line_number":266,"context_line":"                pass"},{"line_number":267,"context_line":"            else:"},{"line_number":268,"context_line":"                LOG.info(\"Formatting addresses to enforce v1 in monitors\")"},{"line_number":269,"context_line":"                mon_0_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_0_ip),"},{"line_number":270,"context_line":"                                             self.SERVICE_PORT_MON_V1)"},{"line_number":271,"context_line":"                mon_1_addr \u003d \"[v1:%s:%s]\" % (self._format_ceph_mon_address(mon_1_ip),"},{"line_number":272,"context_line":"                                             self.SERVICE_PORT_MON_V1)"}],"source_content_type":"text/x-python","patch_set":10,"id":"14c55ae0_fc9c4866","line":269,"in_reply_to":"51d9c753_6e5bded5","updated":"2021-11-12 13:20:49.000000000","message":"It hasn\u0027t been tested, but according to what I found, ipv6 should be enclosed by brackets.","commit_id":"edd6c776cf6abf8d3fcf26b5eed46e5fb5bb3c5d"}]}