)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"0742c519959d8c987a5da5dcff49061a0c4f24ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70e3f859_68ce5f9d","updated":"2021-11-12 18:18:56.000000000","message":"Won\u0027t merge until new release branch.","commit_id":"1120562c0009af55b7179f78fc30ee72f4d50c48"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"ac395dacb9c2b0e28191c9abf5cb6d2b50049401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"18da7932_2d3bcfc2","updated":"2021-11-16 13:23:53.000000000","message":"W-1 until r/stx.6.0 branch gets created.","commit_id":"ce5259f40c17ec6f05ddee23b90101e2d9d41e29"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"c87acde7db8898d9ba658eda1cacc9d58569f788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6e85c5c5_6eec4527","updated":"2021-11-16 22:08:15.000000000","message":"I have a few questions about the behaviour here, will follow up tomorrow.","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"b65e6fa7c1da9003c5fc835178845a35b71837cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ca7e7a38_d2b58a57","updated":"2022-01-20 15:11:31.000000000","message":"Testing upgrade procedure.","commit_id":"fe57dac179dfc9a174f5174914288e4d60234a3e"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"60c97f7f66a38ccc326f4e682319549ba06b95db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4448976c_5cad7fb0","updated":"2022-01-21 21:53:02.000000000","message":"Upgrade procedure worked successfully to migrate service-parameters in r/stx6.0 to ptp-parameters (with creation of legacy ptp-instances) in r/stx7.0 (master).","commit_id":"c4df9fb82c2d2ba01602d6ea68244a58bc46dc2a"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"97420f82796b7f4aaf6431d003bb21da3502c657","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ee976e1f_a4ee3d77","updated":"2022-01-24 19:52:56.000000000","message":"Running another round of upgrade for the new patchsets...","commit_id":"8adb5809305f7f9c334bb52088fe3b64f17c75ee"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"e348d56131ea5346db202cb51599ede021ad7df7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"36e04a7d_e897158c","updated":"2022-01-25 17:18:32.000000000","message":"Testing the migration of global PTP configuration (from \u0027ptp\u0027 table) in a VBOX AIO-SX...","commit_id":"1530f90a3b896e0f9007d23025f806de5ac1786e"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"3f81368beb6f9da10d2328273a45730956cd34a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"950bfa4d_3c748086","updated":"2022-01-26 13:54:42.000000000","message":"Testing upgrade procedure with the new 61-move-ptp-parameters.py...","commit_id":"73031d8dd26df6e338e6156cda85c339d1ee4c0b"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"47e1cda7a0b418c8b9530783cef35a59c59687a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"86af96d9_749da187","updated":"2022-01-27 18:07:56.000000000","message":"LGTM","commit_id":"3635767e56aac4bd98ed63edc8e59d123c727e5e"}],"controllerconfig/controllerconfig/upgrade-scripts/61-move-ptp-parameters.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6f7155ecfa15f79a4702b873b9c02c3fa0541fe6","unresolved":true,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# This script will add service parameters specific to handling of ghcr.io"},{"line_number":7,"context_line":"# registry into the sysinv database during migration phase of upgrade"},{"line_number":8,"context_line":"# procedure."},{"line_number":9,"context_line":"# Also, the previous horizon parameters will be removed without necessity"},{"line_number":10,"context_line":"# to keep the old unused values."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"import sys"},{"line_number":13,"context_line":"import psycopg2"}],"source_content_type":"text/x-python","patch_set":13,"id":"3195dab9_756f5050","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":32},"updated":"2022-01-26 19:59:19.000000000","message":"comment needs update","commit_id":"f5575d7f4d4462e2fc8e2c4cecf94619d1dea756"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"f06705a8c0620bb85a1954a9fe7c1e47d8075f68","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# This script will add service parameters specific to handling of ghcr.io"},{"line_number":7,"context_line":"# registry into the sysinv database during migration phase of upgrade"},{"line_number":8,"context_line":"# procedure."},{"line_number":9,"context_line":"# Also, the previous horizon parameters will be removed without necessity"},{"line_number":10,"context_line":"# to keep the old unused values."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"import sys"},{"line_number":13,"context_line":"import psycopg2"}],"source_content_type":"text/x-python","patch_set":13,"id":"409bac8d_17ed216a","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":32},"in_reply_to":"3195dab9_756f5050","updated":"2022-01-26 20:52:36.000000000","message":"Done","commit_id":"f5575d7f4d4462e2fc8e2c4cecf94619d1dea756"}],"sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/120_ptp_instances.py":[{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"c87acde7db8898d9ba658eda1cacc9d58569f788","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            LOG.debug(\"Found PTP configuration in \u0027service_parameter\u0027 \""},{"line_number":49,"context_line":"                      \"table, migrating\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            # Migrated parameters will belong to legacy instances associated to"},{"line_number":52,"context_line":"            # controller-0"},{"line_number":53,"context_line":"            ctrl0_select \u003d i_host.select().where("},{"line_number":54,"context_line":"                i_host.c.hostname \u003d\u003d \u0027controller-0\u0027)"},{"line_number":55,"context_line":"            ctrl0_id \u003d conn.execute(ctrl0_select).fetchone()[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3c3097f7_87f4d3ed","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":26},"updated":"2021-11-16 22:08:15.000000000","message":"Does this mean that there will be no legacy instances for additional nodes?","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"f79211eb572f13ef3702582ba190c6c3c2960115","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            LOG.debug(\"Found PTP configuration in \u0027service_parameter\u0027 \""},{"line_number":49,"context_line":"                      \"table, migrating\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            # Migrated parameters will belong to legacy instances associated to"},{"line_number":52,"context_line":"            # controller-0"},{"line_number":53,"context_line":"            ctrl0_select \u003d i_host.select().where("},{"line_number":54,"context_line":"                i_host.c.hostname \u003d\u003d \u0027controller-0\u0027)"},{"line_number":55,"context_line":"            ctrl0_id \u003d conn.execute(ctrl0_select).fetchone()[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"8a8ba292_9d191942","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":26},"in_reply_to":"3c3097f7_87f4d3ed","updated":"2021-11-17 11:26:56.000000000","message":"I got your point and we need to clarify on how to proceed in this case.\n\nCurrent PTP configuration is loosely associated with the hosts: when \u0027clock_synchronization\u0027 is set to \u0027ptp\u0027, that host is configured with the global parameters. On the other hand, the new data model makes the association between a PTP instance and a particular host to be explicit.\n\nIn order to mimic the legacy behavior, then I should create as many instances as the number of [current? configured?] hosts in the system. Or, the host field could be Null in this case, meaning the instance apply to all hosts.","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":28439,"name":"Matt Peters","email":"matt.peters@windriver.com","username":"mpeters-wrs"},"change_message_id":"535b5041dbd9c73ec6192d8d55a3f8035cac30e2","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            LOG.debug(\"Found PTP configuration in \u0027service_parameter\u0027 \""},{"line_number":49,"context_line":"                      \"table, migrating\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            # Migrated parameters will belong to legacy instances associated to"},{"line_number":52,"context_line":"            # controller-0"},{"line_number":53,"context_line":"            ctrl0_select \u003d i_host.select().where("},{"line_number":54,"context_line":"                i_host.c.hostname \u003d\u003d \u0027controller-0\u0027)"},{"line_number":55,"context_line":"            ctrl0_id \u003d conn.execute(ctrl0_select).fetchone()[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfc09b27_deb6c385","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":26},"in_reply_to":"8a8ba292_9d191942","updated":"2021-11-18 17:12:44.000000000","message":"The legacy parameters need to be associated with every host that has clock_synchronization\u003dptp rather than controller-0.","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"5fef6d349d8574f234a6fcf4b97c4f56f2000c28","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            LOG.debug(\"Found PTP configuration in \u0027service_parameter\u0027 \""},{"line_number":49,"context_line":"                      \"table, migrating\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            # Migrated parameters will belong to legacy instances associated to"},{"line_number":52,"context_line":"            # controller-0"},{"line_number":53,"context_line":"            ctrl0_select \u003d i_host.select().where("},{"line_number":54,"context_line":"                i_host.c.hostname \u003d\u003d \u0027controller-0\u0027)"},{"line_number":55,"context_line":"            ctrl0_id \u003d conn.execute(ctrl0_select).fetchone()[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"a271b4ad_236ff1e2","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":26},"in_reply_to":"dfc09b27_deb6c385","updated":"2022-01-20 00:14:23.000000000","message":"Please refer to _assign_instance_to_host() in https://review.opendev.org/c/starlingx/config/+/817802/7/sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/124_move_ptp_parameters.py","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"c87acde7db8898d9ba658eda1cacc9d58569f788","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"b881b49c_4ca85282","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"updated":"2021-11-16 22:08:15.000000000","message":"We are going to have to include a phc2sys global parameter for uds_address, as this will be required to associate the legacy phc2sys instance with the legacy ptp4l instance. I can provide additional details to clarify.","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"a512cb0d695b69c3b7019f35ab536ae19bce89f9","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"dc32f276_950e31c0","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"0902ece7_689bcbc1","updated":"2022-01-21 22:01:37.000000000","message":"Also, do we already know all of such parameters that should be automatically set during this upgrade step?","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"b84df3babb21d3c68dc72b16a7a805d00c6a7caf","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"88a33702_b5c607d3","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"1f1ba8d4_2ff16cee","updated":"2022-01-24 19:04:03.000000000","message":"\"domainNumber should be configured as a global parameter for BOTH default ptp4l and default phc2sys, value should be the same for both\"\n\nWherever it comes from (found or not in service-parameter table), it will be on set on both instances, right? Is it the only already supported that should be duplicated due to that split of config files?","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"5fef6d349d8574f234a6fcf4b97c4f56f2000c28","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"0902ece7_689bcbc1","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"30c4f1a0_c80a5c5a","updated":"2022-01-20 00:14:23.000000000","message":"This still needs clarification.","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"a6aa169343234f7f5892ab1d57603b8c73ab1a76","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1ba8d4_2ff16cee","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"37e1e375_30d4c20a","updated":"2022-01-24 18:15:27.000000000","message":"\"Putting in another way: create default ptp4l AND phc2sys instances if the following in the current patchset (#9) is true:\nif len(ptp_entries) \u003e 0 or len(host_entries) \u003e 0\"\n\nCorrect\n\ndomainNumber should be configured as a global parameter for BOTH default ptp4l and default phc2sys, value should be the same for both\n\nuds_address just needs to be applied to phc2sys","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"bb3d10d5c02f6f9c606eb6c4f0363817343fc03c","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"37e1e375_30d4c20a","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"59ab5365_a00748e5","updated":"2022-01-24 18:02:17.000000000","message":"ERRATA: *as default phy2sys/ptp4l instance\u0027s parameter","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"3d7ae8f75a57fc64d81845f2fbf7618cece82beb","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"59ab5365_a00748e5","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"75c46050_57536d39","updated":"2022-01-24 17:59:30.000000000","message":"\"default ptp4l and phc2sys services should be created if there are existing ptp4l and phc2sys configurations. There may not be service_parameter entries to be migrated, but we need to create the instances if ptp is configured.\"\n\nPutting in another way: create default ptp4l AND phc2sys instances if the following in the current patchset (#9) is true:\nif len(ptp_entries) \u003e 0 or len(host_entries) \u003e 0:\n\n\"In multi-instance, they use separate config files so we need two parameters to map phc2sys to ptp4l\ndomainNumber \u003cvalue present in service_parameter OR 24 if none\u003e\nuds_address /var/run/ptp4l-default \u003c- this name should be whatever you decide to name the default ptp4l instance.\"\n\nJust to confirm that while uds_address is clear to be created as default phy2sys\u0027s instance, domainNumber is to be created as default ptp4l\u0027s instance since it is originally a \"global\" parameter in service-parameter.","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"d05a76b8f8b99184190869df7b4386d19809e413","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"de8a9bd1_a4ce076e","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"75c46050_57536d39","updated":"2022-01-24 17:53:33.000000000","message":"UPDATE: domain should be 0 if not found in service_paramter\ndomainNumber \u003cvalue present in service_parameter OR 0 if none\u003e","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"5082190cba94daa1f96e1bd7e56b3e32e7b55814","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"d96aef29_32b0d129","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"88a33702_b5c607d3","updated":"2022-01-25 17:25:17.000000000","message":"Ack","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"f79211eb572f13ef3702582ba190c6c3c2960115","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"30c4f1a0_c80a5c5a","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"b881b49c_4ca85282","updated":"2021-11-17 11:26:56.000000000","message":"So this would be a PTP parameter to be always included in \u0027ptp_parameters\u0027 table for phc2sys, together with the ones eventually found and added in the specific logic below, is that correct?\n\nDoes it mean that default instances for ptp4l and phc2sys services will be *always* created, regardless there are/aren\u0027t service_parameter entries to be migrated (thus differently from this current implementation)?","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"bc085bede57a9a9c84e681161c4b4b7473f5ca2c","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                     (constants.PTP_INSTANCE_LEGACY_PTP4L, ctrl0_id))"},{"line_number":73,"context_line":"            legacy_ptp4l_ins.execute(values)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            # Legacy instance for the migrated parameters of section \"phc2sys\","},{"line_number":76,"context_line":"            # if any"},{"line_number":77,"context_line":"            legacy_phc2sys_ins \u003d ptp_instances.insert()"},{"line_number":78,"context_line":"            phc2sys_uuid \u003d str(uuid.uuid4())"},{"line_number":79,"context_line":"            values \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"75c46050_57536d39","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":20},"in_reply_to":"dc32f276_950e31c0","updated":"2022-01-24 17:44:01.000000000","message":"\"Does it mean that default instances for ptp4l and phc2sys services will be *always* created, regardless there are/aren\u0027t service_parameter entries to be migrated?\"\n\ndefault ptp4l and phc2sys services should be created if there are existing ptp4l and phc2sys configurations. There may not be service_parameter entries to be migrated, but we need to create the instances if ptp is configured.\n\nFor this design there are two parameters that must always be included for phc2sys. In the single instance config, ptp4l and phc2sys shared a config file, so there was no need to map them together. In multi-instance, they use separate config files so we need two parameters to map phc2sys to ptp4l\ndomainNumber \u003cvalue present in service_parameter OR 24 if none\u003e\nuds_address /var/run/ptp4l-default \u003c- this name should be whatever you decide to name the default ptp4l instance.\n\nLet me know if you need more details.","commit_id":"40e754aaed60a22d7a9cb0fc847d7894fa56460b"}],"sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/124_move_ptp_parameters.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"69dd3e2aec7f68967625f4323e83cdfc63a4d16e","unresolved":true,"context_lines":[{"line_number":245,"context_line":"        \u0027ptp_instance_maps\u0027: ptp_instance_maps"},{"line_number":246,"context_line":"    })"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    _populate_ptp_tables(migrate_engine, meta, tables)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9cd1f192_8f657a57","line":248,"updated":"2022-01-24 19:53:16.000000000","message":"Since this migration appears to be for populate_ptp_tables(), (and db migration isnt supported on sw-patch) this part of the update should be considered in the config/controller_config/upgrade-scripts.\n\nFurthermore, if skip of a release is required on the upgrade, updating here would not be sufficient as the version update will only be run once.","commit_id":"8adb5809305f7f9c334bb52088fe3b64f17c75ee"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"3f81368beb6f9da10d2328273a45730956cd34a7","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \u0027ptp_instance_maps\u0027: ptp_instance_maps"},{"line_number":246,"context_line":"    })"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    _populate_ptp_tables(migrate_engine, meta, tables)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":10,"id":"98b2caa8_9fef6617","line":248,"in_reply_to":"94777820_0c5e0044","updated":"2022-01-26 13:54:42.000000000","message":"Ack","commit_id":"8adb5809305f7f9c334bb52088fe3b64f17c75ee"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"5082190cba94daa1f96e1bd7e56b3e32e7b55814","unresolved":true,"context_lines":[{"line_number":245,"context_line":"        \u0027ptp_instance_maps\u0027: ptp_instance_maps"},{"line_number":246,"context_line":"    })"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    _populate_ptp_tables(migrate_engine, meta, tables)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":10,"id":"df2d653f_ebb7c4a2","line":248,"in_reply_to":"9cd1f192_8f657a57","updated":"2022-01-25 17:25:17.000000000","message":"\"this part of the update should be considered in the config/controller_config/upgrade-scripts.\"\nFor my correct understanding: you\u0027re proposing _populate_ptp_tables() - and associated methods - being moved to that module and just called from this migration script, is that correct?\n\n\"if skip of a release is required on the upgrade, updating here would not be sufficient as the version update will only be run once.\"\nSorry, I didn\u0027t get your point (probably lacking of knowledge), could you please give me some directions here?","commit_id":"8adb5809305f7f9c334bb52088fe3b64f17c75ee"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"4c8f928931b8b83ef109deebc86ab1af05359e76","unresolved":true,"context_lines":[{"line_number":245,"context_line":"        \u0027ptp_instance_maps\u0027: ptp_instance_maps"},{"line_number":246,"context_line":"    })"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    _populate_ptp_tables(migrate_engine, meta, tables)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":10,"id":"94777820_0c5e0044","line":248,"in_reply_to":"df2d653f_ebb7c4a2","updated":"2022-01-25 21:20:09.000000000","message":"As per your summary, \"replace db/sqlalchemy/migrate_repo/versions/124_move_ptp_parameters.py by controllerconfig/upgrade-scripts/61_move_ptp_parameters.py in order to guarantee this migration from 21.12 to any future release\" .  Also generally, patch to migrate_repo is not supported incycle.","commit_id":"8adb5809305f7f9c334bb52088fe3b64f17c75ee"}]}