)]}'
{"controllerconfig/controllerconfig/upgrade-scripts/09-resize-for-platform-backup.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"27dfe090278af628d52d03481b33a02e784e7128","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"LOG \u003d log.get_logger(__name__)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BACKUP_GUID \u003d \u0027ba5eba11-0000-1111-2222-000000000002\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":1,"id":"f66e1d7e_22bc1ace","line":19,"updated":"2021-11-15 19:57:19.000000000","message":"Can we be sure this constant will be correct?\n\nDoes (or should) the other constant that references this need to change?\nhttps://github.com/starlingx/config/blob/master/sysinv/sysinv/sysinv/sysinv/common/constants.py#L1350","commit_id":"363146adf8295cc6aaa24edc8df40e2ea174eef9"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"e023bc8d12457fbc6644fc23a67689dcf82083a0","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"LOG \u003d log.get_logger(__name__)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"BACKUP_GUID \u003d \u0027ba5eba11-0000-1111-2222-000000000002\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":1,"id":"e27416f6_1f10c452","line":19,"in_reply_to":"f66e1d7e_22bc1ace","updated":"2021-11-15 21:24:53.000000000","message":"This is the static id defined in the kickstart.\nhttps://opendev.org/starlingx/metal/src/commit/217d56dd2452eacdc614859ba7f4fe1d1579cd09/bsp-files/kickstarts/pre_disk_setup_common.cfg#L230\nWe do a .lower() to ensure case insensitivity.","commit_id":"363146adf8295cc6aaa24edc8df40e2ea174eef9"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"27dfe090278af628d52d03481b33a02e784e7128","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    LOG.debug(\"%s invoked with from_release \u003d %s to_release \u003d %s action \u003d %s\""},{"line_number":43,"context_line":"              % (sys.argv[0], from_release, to_release, action))"},{"line_number":44,"context_line":"    if from_release \u003d\u003d \"20.06\" and action \u003d\u003d \"migrate\":"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            adjust_backup_partition()"},{"line_number":47,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"278c8d8d_a9e73640","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":31},"updated":"2021-11-15 19:57:19.000000000","message":"does this suggest we would port this back to stx 5 (to potentially handle an upgrade from 4)\nand it would therefore not necessarily be needed in stx 5 (when upgrading to 6)","commit_id":"363146adf8295cc6aaa24edc8df40e2ea174eef9"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"e023bc8d12457fbc6644fc23a67689dcf82083a0","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    LOG.debug(\"%s invoked with from_release \u003d %s to_release \u003d %s action \u003d %s\""},{"line_number":43,"context_line":"              % (sys.argv[0], from_release, to_release, action))"},{"line_number":44,"context_line":"    if from_release \u003d\u003d \"20.06\" and action \u003d\u003d \"migrate\":"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            adjust_backup_partition()"},{"line_number":47,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9bca3f8a_2665ba82","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":31},"in_reply_to":"278c8d8d_a9e73640","updated":"2021-11-15 21:24:53.000000000","message":"No, that\u0027s a mistake on my part. I need to update this to 21.05.","commit_id":"363146adf8295cc6aaa24edc8df40e2ea174eef9"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"27dfe090278af628d52d03481b33a02e784e7128","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                # Otherwise we\u0027ll reduce the backup fs by up to 15GB and remove"},{"line_number":121,"context_line":"                # the rest from the docker fs"},{"line_number":122,"context_line":"                required_space -\u003d cgts_vg_free_space"},{"line_number":123,"context_line":"                required_gb \u003d int(math.ceil(required_space / 1024))"},{"line_number":124,"context_line":"                backup_fs_reduction \u003d min(15, required_gb)"},{"line_number":125,"context_line":"                update_host_fs(cur, controller, \u0027backup\u0027, backup_fs_reduction)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0087e622_2afc8b44","line":123,"range":{"start_line":123,"start_character":58,"end_line":123,"end_character":60},"updated":"2021-11-15 19:57:19.000000000","message":"in python2 this math would only be using integers so the math.ceil is un-necessary\nimport math\nprint(math.ceil(2222/1024))\n2.0\n\nin python3 it would be a float (unless you use //)  so the math.ceil would round it up\n\nimport math\nprint(math.ceil(2222/1024))\n3\n\nJust checking which you are expecting here","commit_id":"363146adf8295cc6aaa24edc8df40e2ea174eef9"},{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"e023bc8d12457fbc6644fc23a67689dcf82083a0","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                # Otherwise we\u0027ll reduce the backup fs by up to 15GB and remove"},{"line_number":121,"context_line":"                # the rest from the docker fs"},{"line_number":122,"context_line":"                required_space -\u003d cgts_vg_free_space"},{"line_number":123,"context_line":"                required_gb \u003d int(math.ceil(required_space / 1024))"},{"line_number":124,"context_line":"                backup_fs_reduction \u003d min(15, required_gb)"},{"line_number":125,"context_line":"                update_host_fs(cur, controller, \u0027backup\u0027, backup_fs_reduction)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a03a985_8665c373","line":123,"range":{"start_line":123,"start_character":58,"end_line":123,"end_character":60},"in_reply_to":"0087e622_2afc8b44","updated":"2021-11-15 21:24:53.000000000","message":"Yeah we want floats.","commit_id":"363146adf8295cc6aaa24edc8df40e2ea174eef9"}]}