)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"9ba516a673fd6ffcabde2e5fe0e757f205130e63","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Modify OVS puppet plugin and host vswitch hugepages allocation logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change vswitch and puppet plugins variables to enable and disable itself"},{"line_number":10,"context_line":"based on host labels. Also, modify some host memory allocation checks that"},{"line_number":11,"context_line":"only make sense when the host has the vswitch enabled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1002842d_4e3a548c","line":10,"range":{"start_line":10,"start_character":70,"end_line":10,"end_character":74},"updated":"2021-12-15 22:34:24.000000000","message":"nit: commit message too wide here.","commit_id":"4f1533eb441ee8401206c84474dbeb63fc47da04"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"8eda65dbaf96cc92e85cf2955cb7756ae8f52eb1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modify OVS puppet plugin and host vswitch hugepages allocation logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change vswitch and puppet plugins variables to enable and disable itself"},{"line_number":10,"context_line":"based on host labels. Also, modify some host memory allocation checks that"},{"line_number":11,"context_line":"only make sense when the host has the vswitch enabled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"6a8038af_3ae8e00c","line":10,"range":{"start_line":10,"start_character":70,"end_line":10,"end_character":74},"in_reply_to":"1002842d_4e3a548c","updated":"2022-01-25 13:39:39.000000000","message":"Done","commit_id":"4f1533eb441ee8401206c84474dbeb63fc47da04"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"ca6276c2a275806f1967cea3e339d4380483f9c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"64ad7a9f_b7c0ef6e","updated":"2021-11-24 19:50:40.000000000","message":"Again, maybe we should separate pci-irq-affinity-agent and vswitch changes into two different changes","commit_id":"df147da3cbd483ad8247dcc7ddbbc8d6fd0f781e"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"354e0bf02b08d00c80c8eabcce4304c559932837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7d8e4f59_14a36a35","updated":"2021-11-22 15:22:40.000000000","message":"Great job! Looks good to me but before approving it I would like to see some test results listed on this change ","commit_id":"df147da3cbd483ad8247dcc7ddbbc8d6fd0f781e"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"24995f21a6152df4f0707a84de57f3604709f62d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aed108c3_3510e4c1","updated":"2021-12-08 15:21:52.000000000","message":"Some optimizations are required, but the direction LGTM.","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"0c5d646975936837c725658764085b66ce1acfa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e15827b9_6e1aedb5","updated":"2021-12-08 17:54:45.000000000","message":"Awesome job!","commit_id":"82d88b3cbf758e7d40ec29f01fd6cafdc99a5de4"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"c7573be61b9926e30c44c38fa11f83b43b5ee4dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a486acbd_18ad0ecf","updated":"2021-12-14 15:29:01.000000000","message":"I would prefer to move the pci_irq_affinity.py into it\u0027s own change-set.  Was this change-set testing on StarlingX with ovs-dpdk (host) and ovs (containerized), by launching some VMs and confirming connectivity?  Looks good overall","commit_id":"82d88b3cbf758e7d40ec29f01fd6cafdc99a5de4"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"fa63034ac681386003ba97b3a5d27d93c001ede9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5924b32d_c9769c4a","in_reply_to":"a486acbd_18ad0ecf","updated":"2021-12-14 17:27:55.000000000","message":"I agree, I should\u0027ve done two different changes... And yes, I tested with ovs-dpdk and ovs containerized (vswitch_type\u003dnone) but I didn\u0027t launch VM\u0027s, just checked if the ovs pod (or service if it is ovs-dpdk) were in running state.","commit_id":"82d88b3cbf758e7d40ec29f01fd6cafdc99a5de4"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"8e94e3095328311750a1a6bc64f09b69489ade27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ea896381_aa06dd71","updated":"2021-12-15 14:18:48.000000000","message":"I think if you\u0027ve confirmed that the various vswitches come up correctly, that should be ok as nothing here should be affecting the datapath","commit_id":"4f1533eb441ee8401206c84474dbeb63fc47da04"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/memory.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"c7573be61b9926e30c44c38fa11f83b43b5ee4dc","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2013-2016 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"141c5727_bede143d","line":18,"updated":"2021-12-14 15:29:01.000000000","message":"2021","commit_id":"82d88b3cbf758e7d40ec29f01fd6cafdc99a5de4"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"fa63034ac681386003ba97b3a5d27d93c001ede9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2013-2016 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"84c1e064_abbefb8c","line":18,"in_reply_to":"141c5727_bede143d","updated":"2021-12-14 17:27:55.000000000","message":"Done","commit_id":"82d88b3cbf758e7d40ec29f01fd6cafdc99a5de4"}],"sysinv/sysinv/sysinv/sysinv/common/constants.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"24995f21a6152df4f0707a84de57f3604709f62d","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"PERSONALITIES \u003d [CONTROLLER, STORAGE, WORKER, EDGEWORKER]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Subfunction features"},{"line_number":122,"context_line":"SUBFUNCTIONS \u003d \u0027subfunctions\u0027"},{"line_number":123,"context_line":"LOWLATENCY \u003d \u0027lowlatency\u0027"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"255d6803_622f1805","line":121,"updated":"2021-12-08 15:21:52.000000000","message":"nit: avoid these unrelated/unmeaningful changes next time to ease reviewing","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"8eda65dbaf96cc92e85cf2955cb7756ae8f52eb1","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"PERSONALITIES \u003d [CONTROLLER, STORAGE, WORKER, EDGEWORKER]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Subfunction features"},{"line_number":122,"context_line":"SUBFUNCTIONS \u003d \u0027subfunctions\u0027"},{"line_number":123,"context_line":"LOWLATENCY \u003d \u0027lowlatency\u0027"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"b7340775_a2215950","line":121,"in_reply_to":"255d6803_622f1805","updated":"2022-01-25 13:39:39.000000000","message":"Done","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"}],"sysinv/sysinv/sysinv/sysinv/common/utils.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"24995f21a6152df4f0707a84de57f3604709f62d","unresolved":true,"context_lines":[{"line_number":2426,"context_line":"def has_vswitch_enabled(host_labels, dbapi):"},{"line_number":2427,"context_line":"    \"\"\"Returns true if the vswitch label is set \"\"\""},{"line_number":2428,"context_line":"    platform_vswitch \u003d get_vswitch_type(dbapi)"},{"line_number":2429,"context_line":"    openvswitch_labels \u003d {"},{"line_number":2430,"context_line":"        \u0027openvswitch\u0027: [constants.VSWITCH_TYPE_OVS_DPDK],"},{"line_number":2431,"context_line":"    }"},{"line_number":2432,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"c2474940_933d3bd9","line":2429,"updated":"2021-12-08 15:21:52.000000000","message":"My suggestion is to rename this variable to \"ovs_labels_to_types\"","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"3b302c80cf68089374a760ead43bcdfbac337bfe","unresolved":false,"context_lines":[{"line_number":2426,"context_line":"def has_vswitch_enabled(host_labels, dbapi):"},{"line_number":2427,"context_line":"    \"\"\"Returns true if the vswitch label is set \"\"\""},{"line_number":2428,"context_line":"    platform_vswitch \u003d get_vswitch_type(dbapi)"},{"line_number":2429,"context_line":"    openvswitch_labels \u003d {"},{"line_number":2430,"context_line":"        \u0027openvswitch\u0027: [constants.VSWITCH_TYPE_OVS_DPDK],"},{"line_number":2431,"context_line":"    }"},{"line_number":2432,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"6874137a_b86f96cc","line":2429,"in_reply_to":"c2474940_933d3bd9","updated":"2021-12-08 17:38:16.000000000","message":"Done","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"24995f21a6152df4f0707a84de57f3604709f62d","unresolved":true,"context_lines":[{"line_number":2433,"context_line":"    if not host_labels:"},{"line_number":2434,"context_line":"        return False"},{"line_number":2435,"context_line":""},{"line_number":2436,"context_line":"    for label in host_labels:"},{"line_number":2437,"context_line":"        vswitch_host_labels \u003d openvswitch_labels.get(label.label_key, None)"},{"line_number":2438,"context_line":"        if vswitch_host_labels:"},{"line_number":2439,"context_line":"            if platform_vswitch in vswitch_host_labels:"}],"source_content_type":"text/x-python","patch_set":12,"id":"b4669291_84a48fb4","line":2436,"updated":"2021-12-08 15:21:52.000000000","message":"I think you\u0027d go over some unnecessary loops here because the labels have way more stuff than just vswitch configuration. Maybe we should invert that loop or remove the labels we don\u0027t want to check from the iteration list.","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"3b302c80cf68089374a760ead43bcdfbac337bfe","unresolved":false,"context_lines":[{"line_number":2433,"context_line":"    if not host_labels:"},{"line_number":2434,"context_line":"        return False"},{"line_number":2435,"context_line":""},{"line_number":2436,"context_line":"    for label in host_labels:"},{"line_number":2437,"context_line":"        vswitch_host_labels \u003d openvswitch_labels.get(label.label_key, None)"},{"line_number":2438,"context_line":"        if vswitch_host_labels:"},{"line_number":2439,"context_line":"            if platform_vswitch in vswitch_host_labels:"}],"source_content_type":"text/x-python","patch_set":12,"id":"8a38e42d_3e25754f","line":2436,"in_reply_to":"b4669291_84a48fb4","updated":"2021-12-08 17:38:16.000000000","message":"Done","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"24995f21a6152df4f0707a84de57f3604709f62d","unresolved":true,"context_lines":[{"line_number":2434,"context_line":"        return False"},{"line_number":2435,"context_line":""},{"line_number":2436,"context_line":"    for label in host_labels:"},{"line_number":2437,"context_line":"        vswitch_host_labels \u003d openvswitch_labels.get(label.label_key, None)"},{"line_number":2438,"context_line":"        if vswitch_host_labels:"},{"line_number":2439,"context_line":"            if platform_vswitch in vswitch_host_labels:"},{"line_number":2440,"context_line":"                return helm_common.LABEL_VALUE_ENABLED \u003d\u003d label.label_value.lower()"}],"source_content_type":"text/x-python","patch_set":12,"id":"e81d0087_b611e5e6","line":2437,"updated":"2021-12-08 15:21:52.000000000","message":"What you are getting here is the ovs types allowed when the label \"openvswitch\u003denabled\" is there. This code is rather complex, I suggest simplifying its understanding by naming the variable properly. Suggestion here is \"vswitch_allowed_types\".","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"8eda65dbaf96cc92e85cf2955cb7756ae8f52eb1","unresolved":false,"context_lines":[{"line_number":2434,"context_line":"        return False"},{"line_number":2435,"context_line":""},{"line_number":2436,"context_line":"    for label in host_labels:"},{"line_number":2437,"context_line":"        vswitch_host_labels \u003d openvswitch_labels.get(label.label_key, None)"},{"line_number":2438,"context_line":"        if vswitch_host_labels:"},{"line_number":2439,"context_line":"            if platform_vswitch in vswitch_host_labels:"},{"line_number":2440,"context_line":"                return helm_common.LABEL_VALUE_ENABLED \u003d\u003d label.label_value.lower()"}],"source_content_type":"text/x-python","patch_set":12,"id":"b20db309_0618e7e2","line":2437,"in_reply_to":"7e8ebe77_51c92fd6","updated":"2022-01-25 13:39:39.000000000","message":"Done","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"3b302c80cf68089374a760ead43bcdfbac337bfe","unresolved":true,"context_lines":[{"line_number":2434,"context_line":"        return False"},{"line_number":2435,"context_line":""},{"line_number":2436,"context_line":"    for label in host_labels:"},{"line_number":2437,"context_line":"        vswitch_host_labels \u003d openvswitch_labels.get(label.label_key, None)"},{"line_number":2438,"context_line":"        if vswitch_host_labels:"},{"line_number":2439,"context_line":"            if platform_vswitch in vswitch_host_labels:"},{"line_number":2440,"context_line":"                return helm_common.LABEL_VALUE_ENABLED \u003d\u003d label.label_value.lower()"}],"source_content_type":"text/x-python","patch_set":12,"id":"7e8ebe77_51c92fd6","line":2437,"in_reply_to":"e81d0087_b611e5e6","updated":"2021-12-08 17:38:16.000000000","message":"Thanks.","commit_id":"067703d718524e6023dfab0204282c80fbbaaff5"}],"sysinv/sysinv/sysinv/sysinv/puppet/ovs.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"c7573be61b9926e30c44c38fa11f83b43b5ee4dc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2018 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":13,"id":"d102736b_173cbcc0","line":2,"updated":"2021-12-14 15:29:01.000000000","message":"2018-2021","commit_id":"82d88b3cbf758e7d40ec29f01fd6cafdc99a5de4"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"fa63034ac681386003ba97b3a5d27d93c001ede9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2018 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":13,"id":"264457f0_261d96c2","line":2,"in_reply_to":"d102736b_173cbcc0","updated":"2021-12-14 17:27:55.000000000","message":"Done","commit_id":"82d88b3cbf758e7d40ec29f01fd6cafdc99a5de4"}],"sysinv/sysinv/sysinv/sysinv/puppet/pci_irq_affinity.py":[{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"ca6276c2a275806f1967cea3e339d4380483f9c5","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    def get_host_config(self, host):"},{"line_number":91,"context_line":"        host_labels \u003d self.dbapi.label_get_by_host(host.id)"},{"line_number":92,"context_line":"        return {"},{"line_number":93,"context_line":"            \u0027platform::pciirqaffinity::params::enabled\u0027:"},{"line_number":94,"context_line":"                utils.is_openstack_applied(self.dbapi) and"},{"line_number":95,"context_line":"                utils.has_openstack_compute(host_labels),"},{"line_number":96,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"69381aaf_df90191e","line":93,"range":{"start_line":93,"start_character":47,"end_line":93,"end_character":54},"updated":"2021-11-24 19:50:40.000000000","message":"I don\u0027t think we need to change the parameter name","commit_id":"df147da3cbd483ad8247dcc7ddbbc8d6fd0f781e"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"8eda65dbaf96cc92e85cf2955cb7756ae8f52eb1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def get_host_config(self, host):"},{"line_number":91,"context_line":"        host_labels \u003d self.dbapi.label_get_by_host(host.id)"},{"line_number":92,"context_line":"        return {"},{"line_number":93,"context_line":"            \u0027platform::pciirqaffinity::params::enabled\u0027:"},{"line_number":94,"context_line":"                utils.is_openstack_applied(self.dbapi) and"},{"line_number":95,"context_line":"                utils.has_openstack_compute(host_labels),"},{"line_number":96,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"f8369e30_4504d925","line":93,"range":{"start_line":93,"start_character":47,"end_line":93,"end_character":54},"in_reply_to":"69381aaf_df90191e","updated":"2022-01-25 13:39:39.000000000","message":"Done","commit_id":"df147da3cbd483ad8247dcc7ddbbc8d6fd0f781e"}]}