)]}'
{"sysinv/sysinv/sysinv/sysinv/cert_alarm/utils.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ce1ead7934201f85e191df1934fac666da44eca8","unresolved":true,"context_lines":[{"line_number":392,"context_line":"            for item in cert_list:"},{"line_number":393,"context_line":"                key \u003d \u0027certtype\u0027"},{"line_number":394,"context_line":"                if get_mode(certname) \u003d\u003d \u0027ssl_ca\u0027:"},{"line_number":395,"context_line":"                    key \u003d \u0027signature\u0027"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"                if item[key] \u003d\u003d certname:"},{"line_number":398,"context_line":"                    ret \u003d item[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1149c6b1_3ded26f6","line":395,"updated":"2021-11-22 16:23:34.000000000","message":"The reason we need to use signature instead of certtype is because we could have multiple ssl_ca certs installed. (So if we support multiple certs for other types, we would have to use signature for that types of certs as well). I would think eventually using signature is better than certtype. For now I think it\u0027s ok (because the API returns certtypes now).","commit_id":"9f43864472de302325237f39c88f3fe7decfc309"},{"author":{"_account_id":31500,"name":"Sabeel Ansari","email":"Sabeel.Ansari@windriver.com","username":"sansari"},"change_message_id":"60b0ca176915dd1eeda724fa92a19828f5444464","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            for item in cert_list:"},{"line_number":393,"context_line":"                key \u003d \u0027certtype\u0027"},{"line_number":394,"context_line":"                if get_mode(certname) \u003d\u003d \u0027ssl_ca\u0027:"},{"line_number":395,"context_line":"                    key \u003d \u0027signature\u0027"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"                if item[key] \u003d\u003d certname:"},{"line_number":398,"context_line":"                    ret \u003d item[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fe0927de_2800a1f2","line":395,"in_reply_to":"1149c6b1_3ded26f6","updated":"2021-11-22 16:29:05.000000000","message":"Correct. A \u0027certtype\u0027 in case of ssl_ca would just return a \u0027ssl_ca\u0027 and we wouldnt be able to differentiate. Hence the use of \u0027signature\u0027 key for ssl_ca cert types. The rest of this feature has been designed with using that unique certname across the service.","commit_id":"9f43864472de302325237f39c88f3fe7decfc309"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"26c03006837a019af4f7d35cea54cd6983d5cda3","unresolved":true,"context_lines":[{"line_number":394,"context_line":"                if get_mode(certname) \u003d\u003d \u0027ssl_ca\u0027:"},{"line_number":395,"context_line":"                    key \u003d \u0027signature\u0027"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"                if item[key] \u003d\u003d certname:"},{"line_number":398,"context_line":"                    ret \u003d item[\u0027uuid\u0027]"},{"line_number":399,"context_line":"                    break"},{"line_number":400,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"10e3775e_cb3b2915","line":397,"range":{"start_line":397,"start_character":19,"end_line":397,"end_character":28},"updated":"2021-11-22 15:48:47.000000000","message":"I think this is fine although a KeyError here will raise an exception, breaking the loop, so if there was a valid value later in the cert_list, we wont return it.","commit_id":"9f43864472de302325237f39c88f3fe7decfc309"},{"author":{"_account_id":31500,"name":"Sabeel Ansari","email":"Sabeel.Ansari@windriver.com","username":"sansari"},"change_message_id":"60b0ca176915dd1eeda724fa92a19828f5444464","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                if get_mode(certname) \u003d\u003d \u0027ssl_ca\u0027:"},{"line_number":395,"context_line":"                    key \u003d \u0027signature\u0027"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"                if item[key] \u003d\u003d certname:"},{"line_number":398,"context_line":"                    ret \u003d item[\u0027uuid\u0027]"},{"line_number":399,"context_line":"                    break"},{"line_number":400,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"12452f2c_38be2827","line":397,"range":{"start_line":397,"start_character":19,"end_line":397,"end_character":28},"in_reply_to":"10e3775e_cb3b2915","updated":"2021-11-22 16:29:05.000000000","message":"Ack","commit_id":"9f43864472de302325237f39c88f3fe7decfc309"}]}