)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ed96e5d6b3b4a399f543cb0ef3eab19899698cb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2941d9c9_7ff2f513","updated":"2021-11-25 14:44:17.000000000","message":"LGTM","commit_id":"e6191da09bb968390a19540b5fa724e308302135"},{"author":{"_account_id":21776,"name":"Jerry Sun","email":"jerry.sun@windriver.com","username":"jerrysun"},"change_message_id":"ec2802ece034280af5afe7c8cf12bb6b05bfaba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c079ba5_ae438fc3","updated":"2021-11-24 22:42:42.000000000","message":"upgrades test finished","commit_id":"e6191da09bb968390a19540b5fa724e308302135"},{"author":{"_account_id":21776,"name":"Jerry Sun","email":"jerry.sun@windriver.com","username":"jerrysun"},"change_message_id":"5ba67070382d27540de52d4e4df9a7cc627522f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d382ae9_9ddc7f75","updated":"2021-11-24 15:40:14.000000000","message":"workflow -1, upgrade testing in progress","commit_id":"e6191da09bb968390a19540b5fa724e308302135"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"a5dcb1700c3ae44fd6d979abf48be7630d3d809e","unresolved":true,"context_lines":[{"line_number":12571,"context_line":"                                                config_dict,"},{"line_number":12572,"context_line":"                                                force\u003dTrue)"},{"line_number":12573,"context_line":""},{"line_number":12574,"context_line":"            personalities \u003d [constants.CONTROLLER]"},{"line_number":12575,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":12576,"context_line":"            config_dict \u003d {"},{"line_number":12577,"context_line":"                \"personalities\": personalities,"},{"line_number":12578,"context_line":"                \"classes\": [\u0027platform::kubernetes::master::apiserver::runtime\u0027]"},{"line_number":12579,"context_line":"            }"},{"line_number":12580,"context_line":"            self._config_apply_runtime_manifest(context,"},{"line_number":12581,"context_line":"                                                config_uuid,"},{"line_number":12582,"context_line":"                                                config_dict)"},{"line_number":12583,"context_line":""},{"line_number":12584,"context_line":"        elif mode \u003d\u003d constants.CERT_MODE_DOCKER_REGISTRY:"},{"line_number":12585,"context_line":"            LOG.info(\"Docker registry certificate install\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dffe8e88_ac60dee9","line":12582,"range":{"start_line":12574,"start_character":0,"end_line":12582,"end_character":60},"updated":"2021-11-25 15:01:55.000000000","message":"I see existing code that involve runtime_manifest apply twice (for example, update_remotelogging_config()), but arranged personalities in a way that only one config_uuid is needed. Maybe John Kung can comment on the advantage of doing that way?","commit_id":"e6191da09bb968390a19540b5fa724e308302135"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"f5fbcc468a57eac4f8db103dda62ef0e13ebaa46","unresolved":true,"context_lines":[{"line_number":12571,"context_line":"                                                config_dict,"},{"line_number":12572,"context_line":"                                                force\u003dTrue)"},{"line_number":12573,"context_line":""},{"line_number":12574,"context_line":"            personalities \u003d [constants.CONTROLLER]"},{"line_number":12575,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":12576,"context_line":"            config_dict \u003d {"},{"line_number":12577,"context_line":"                \"personalities\": personalities,"},{"line_number":12578,"context_line":"                \"classes\": [\u0027platform::kubernetes::master::apiserver::runtime\u0027]"},{"line_number":12579,"context_line":"            }"},{"line_number":12580,"context_line":"            self._config_apply_runtime_manifest(context,"},{"line_number":12581,"context_line":"                                                config_uuid,"},{"line_number":12582,"context_line":"                                                config_dict)"},{"line_number":12583,"context_line":""},{"line_number":12584,"context_line":"        elif mode \u003d\u003d constants.CERT_MODE_DOCKER_REGISTRY:"},{"line_number":12585,"context_line":"            LOG.info(\"Docker registry certificate install\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb88ef6c_b88389a9","line":12582,"range":{"start_line":12574,"start_character":0,"end_line":12582,"end_character":60},"in_reply_to":"489b6f78_72ae3b51","updated":"2021-11-25 21:52:58.000000000","message":"The AIO case may need to be special cased in order to avoid the redundant runtime manifest (esp now we have aio.pp in puppet).  I think this is ok for now given the test coverage (bootstrap, upgrades).\n\nPlease add the testcases performed on AIO to commit message, including bootstrap case.","commit_id":"e6191da09bb968390a19540b5fa724e308302135"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"587a5bc696af780ee5ac85707c2532de0a9026ae","unresolved":true,"context_lines":[{"line_number":12571,"context_line":"                                                config_dict,"},{"line_number":12572,"context_line":"                                                force\u003dTrue)"},{"line_number":12573,"context_line":""},{"line_number":12574,"context_line":"            personalities \u003d [constants.CONTROLLER]"},{"line_number":12575,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":12576,"context_line":"            config_dict \u003d {"},{"line_number":12577,"context_line":"                \"personalities\": personalities,"},{"line_number":12578,"context_line":"                \"classes\": [\u0027platform::kubernetes::master::apiserver::runtime\u0027]"},{"line_number":12579,"context_line":"            }"},{"line_number":12580,"context_line":"            self._config_apply_runtime_manifest(context,"},{"line_number":12581,"context_line":"                                                config_uuid,"},{"line_number":12582,"context_line":"                                                config_dict)"},{"line_number":12583,"context_line":""},{"line_number":12584,"context_line":"        elif mode \u003d\u003d constants.CERT_MODE_DOCKER_REGISTRY:"},{"line_number":12585,"context_line":"            LOG.info(\"Docker registry certificate install\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"489b6f78_72ae3b51","line":12582,"range":{"start_line":12574,"start_character":0,"end_line":12582,"end_character":60},"in_reply_to":"dffe8e88_ac60dee9","updated":"2021-11-25 21:03:59.000000000","message":"An advantage is dont need to wait for another set of runtime manifests to apply on the same target (controller).  Unless this must be applied in sequence, it\u0027d be more efficient to collate the runtime apply once per target personality.","commit_id":"e6191da09bb968390a19540b5fa724e308302135"},{"author":{"_account_id":21776,"name":"Jerry Sun","email":"jerry.sun@windriver.com","username":"jerrysun"},"change_message_id":"dec367c2f3e56f3486232730cf37814f7250ed6f","unresolved":false,"context_lines":[{"line_number":12571,"context_line":"                                                config_dict,"},{"line_number":12572,"context_line":"                                                force\u003dTrue)"},{"line_number":12573,"context_line":""},{"line_number":12574,"context_line":"            personalities \u003d [constants.CONTROLLER]"},{"line_number":12575,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":12576,"context_line":"            config_dict \u003d {"},{"line_number":12577,"context_line":"                \"personalities\": personalities,"},{"line_number":12578,"context_line":"                \"classes\": [\u0027platform::kubernetes::master::apiserver::runtime\u0027]"},{"line_number":12579,"context_line":"            }"},{"line_number":12580,"context_line":"            self._config_apply_runtime_manifest(context,"},{"line_number":12581,"context_line":"                                                config_uuid,"},{"line_number":12582,"context_line":"                                                config_dict)"},{"line_number":12583,"context_line":""},{"line_number":12584,"context_line":"        elif mode \u003d\u003d constants.CERT_MODE_DOCKER_REGISTRY:"},{"line_number":12585,"context_line":"            LOG.info(\"Docker registry certificate install\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4c25927_bd93e3dc","line":12582,"range":{"start_line":12574,"start_character":0,"end_line":12582,"end_character":60},"in_reply_to":"fb88ef6c_b88389a9","updated":"2021-11-25 21:59:39.000000000","message":"Ack","commit_id":"e6191da09bb968390a19540b5fa724e308302135"}]}