)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"3a3a5b7be72eabec8ac589525bc915e1e7a7d8bb","unresolved":true,"context_lines":[{"line_number":14,"context_line":"and consider removing the setting altogether."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This is due to a change in systemd-246, where syslog is"},{"line_number":17,"context_line":"no longer supported. This was only changed for Debian because"},{"line_number":18,"context_line":"Centos remains untested with the change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Copied the original controllerconfig.service and replaced"},{"line_number":21,"context_line":"the \u0027syslog+console\u0027 with \u0027journal+console\u0027. This was only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8032c3d3_b8318443","line":18,"range":{"start_line":17,"start_character":21,"end_line":18,"end_character":40},"updated":"2021-11-25 20:53:59.000000000","message":"Would this be cleaner: \u0027Change only for Debian so we avoid a CentOS retest.\u0027?","commit_id":"e25bfeae2d01e28cbcdd374b15607d523c4a6e6a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"41260dfcdebdb01631a591313298c3d46a2a55b3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"and consider removing the setting altogether."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This is due to a change in systemd-246, where syslog is"},{"line_number":17,"context_line":"no longer supported. This was only changed for Debian because"},{"line_number":18,"context_line":"Centos remains untested with the change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Copied the original controllerconfig.service and replaced"},{"line_number":21,"context_line":"the \u0027syslog+console\u0027 with \u0027journal+console\u0027. This was only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bd921b19_db9e3357","line":18,"range":{"start_line":17,"start_character":21,"end_line":18,"end_character":40},"in_reply_to":"8032c3d3_b8318443","updated":"2021-12-06 18:35:34.000000000","message":"Done","commit_id":"e25bfeae2d01e28cbcdd374b15607d523c4a6e6a"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"3a3a5b7be72eabec8ac589525bc915e1e7a7d8bb","unresolved":true,"context_lines":[{"line_number":18,"context_line":"Centos remains untested with the change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Copied the original controllerconfig.service and replaced"},{"line_number":21,"context_line":"the \u0027syslog+console\u0027 with \u0027journal+console\u0027. This was only"},{"line_number":22,"context_line":"done for"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Signed-off-by: Charles Short \u003ccharles.short@windriver.com\u003e"},{"line_number":25,"context_line":"Change-Id: I5b41005ae53a1a9dd75dc665a217d607fa80c3f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c6db454b_21a1bdde","line":22,"range":{"start_line":21,"start_character":45,"end_line":22,"end_character":8},"updated":"2021-11-25 20:53:59.000000000","message":"Remove, idea is mentioned above.","commit_id":"e25bfeae2d01e28cbcdd374b15607d523c4a6e6a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"41260dfcdebdb01631a591313298c3d46a2a55b3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Centos remains untested with the change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Copied the original controllerconfig.service and replaced"},{"line_number":21,"context_line":"the \u0027syslog+console\u0027 with \u0027journal+console\u0027. This was only"},{"line_number":22,"context_line":"done for"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Signed-off-by: Charles Short \u003ccharles.short@windriver.com\u003e"},{"line_number":25,"context_line":"Change-Id: I5b41005ae53a1a9dd75dc665a217d607fa80c3f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4a5fcef8_1fb8bfba","line":22,"range":{"start_line":21,"start_character":45,"end_line":22,"end_character":8},"in_reply_to":"c6db454b_21a1bdde","updated":"2021-12-06 18:35:34.000000000","message":"Done","commit_id":"e25bfeae2d01e28cbcdd374b15607d523c4a6e6a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"63361c3b64e38b7e8e4a918683c3b6b90d863ade","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix controllerconfig service warning on boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the controllerconfig service starts the following"},{"line_number":10,"context_line":"warning is emiitted in the dmesg:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Standard output type syslog+console is obsolet, automatically"},{"line_number":13,"context_line":"updating to journal+console. Please update your unit file,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c62021b5_32a546a4","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":19},"updated":"2021-12-15 14:56:41.000000000","message":"sp: emitted","commit_id":"0a353624c34576fc99226a1dc8d2e95db8465215"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"cf33af716f839073c12b98b5aa912357d30ce163","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix controllerconfig service warning on boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the controllerconfig service starts the following"},{"line_number":10,"context_line":"warning is emiitted in the dmesg:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Standard output type syslog+console is obsolet, automatically"},{"line_number":13,"context_line":"updating to journal+console. Please update your unit file,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f5be24a8_e57038bf","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":19},"in_reply_to":"c62021b5_32a546a4","updated":"2021-12-15 15:16:05.000000000","message":"Done","commit_id":"0a353624c34576fc99226a1dc8d2e95db8465215"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"63361c3b64e38b7e8e4a918683c3b6b90d863ade","unresolved":true,"context_lines":[{"line_number":9,"context_line":"When the controllerconfig service starts the following"},{"line_number":10,"context_line":"warning is emiitted in the dmesg:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Standard output type syslog+console is obsolet, automatically"},{"line_number":13,"context_line":"updating to journal+console. Please update your unit file,"},{"line_number":14,"context_line":"and consider removing the setting altogether."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e3667a9d_42f80076","line":12,"range":{"start_line":12,"start_character":39,"end_line":12,"end_character":46},"updated":"2021-12-15 14:56:41.000000000","message":"sp:obsolete","commit_id":"0a353624c34576fc99226a1dc8d2e95db8465215"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"cf33af716f839073c12b98b5aa912357d30ce163","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When the controllerconfig service starts the following"},{"line_number":10,"context_line":"warning is emiitted in the dmesg:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Standard output type syslog+console is obsolet, automatically"},{"line_number":13,"context_line":"updating to journal+console. Please update your unit file,"},{"line_number":14,"context_line":"and consider removing the setting altogether."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"528a1e73_257c7c7e","line":12,"range":{"start_line":12,"start_character":39,"end_line":12,"end_character":46},"in_reply_to":"e3667a9d_42f80076","updated":"2021-12-15 15:16:05.000000000","message":"Done","commit_id":"0a353624c34576fc99226a1dc8d2e95db8465215"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"6dcb9c1e7ef703d256e669f51b727f907bb4c3e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b2098d0d_7019829d","updated":"2021-12-06 18:48:34.000000000","message":"\u0027-p\u0027 still there","commit_id":"602b537c6988722ca3059559084ab887aedea17b"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8a82e99b3e3802f63a22313cf2fcd8e83f6170e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"356146f4_c4a54a1d","in_reply_to":"b2098d0d_7019829d","updated":"2021-12-06 18:59:50.000000000","message":"done","commit_id":"602b537c6988722ca3059559084ab887aedea17b"}],"controllerconfig/debian/deb_folder/rules":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8987f21fdcc14ca6e4432c03b844a9d7ccdfcf55","unresolved":true,"context_lines":[{"line_number":38,"context_line":"endif"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"override_dh_installsystemd:"},{"line_number":41,"context_line":"\tdh_installsystemd -p controllerconfig controllerconfig.service"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"override_dh_python3:"},{"line_number":44,"context_line":"\tdh_python3 --shebang\u003d/usr/bin/python3"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ff635677_4cbb4255","line":41,"range":{"start_line":41,"start_character":19,"end_line":41,"end_character":21},"updated":"2021-11-25 19:40:22.000000000","message":"--name? don\u0027t see the \u0027-p\u0027\n\nhttps://man7.org/linux/man-pages/man1/dh_installsystemd.1.html","commit_id":"e25bfeae2d01e28cbcdd374b15607d523c4a6e6a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8a82e99b3e3802f63a22313cf2fcd8e83f6170e5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"endif"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"override_dh_installsystemd:"},{"line_number":41,"context_line":"\tdh_installsystemd -p controllerconfig controllerconfig.service"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"override_dh_python3:"},{"line_number":44,"context_line":"\tdh_python3 --shebang\u003d/usr/bin/python3"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"aefb1a39_66f87928","line":41,"range":{"start_line":41,"start_character":19,"end_line":41,"end_character":21},"in_reply_to":"292f791f_af5f9774","updated":"2021-12-06 18:59:50.000000000","message":"Done","commit_id":"e25bfeae2d01e28cbcdd374b15607d523c4a6e6a"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"6dcb9c1e7ef703d256e669f51b727f907bb4c3e3","unresolved":true,"context_lines":[{"line_number":38,"context_line":"endif"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"override_dh_installsystemd:"},{"line_number":41,"context_line":"\tdh_installsystemd -p controllerconfig controllerconfig.service"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"override_dh_python3:"},{"line_number":44,"context_line":"\tdh_python3 --shebang\u003d/usr/bin/python3"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"292f791f_af5f9774","line":41,"range":{"start_line":41,"start_character":19,"end_line":41,"end_character":21},"in_reply_to":"a5d5c876_e8a8c7c1","updated":"2021-12-06 18:48:34.000000000","message":"I meant: I don\u0027t see -p in the manual, could we use \u0027--name\u0027 instead?\nFrom the response \u0027-p is not needed\u0027 I get that even \u0027--name\u0027 is not needed, so we can drop it.\n\nPlease remove the \u0027-p \u003cname\u003e\u0027, it is still here in Patchset 2.","commit_id":"e25bfeae2d01e28cbcdd374b15607d523c4a6e6a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"41260dfcdebdb01631a591313298c3d46a2a55b3","unresolved":true,"context_lines":[{"line_number":38,"context_line":"endif"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"override_dh_installsystemd:"},{"line_number":41,"context_line":"\tdh_installsystemd -p controllerconfig controllerconfig.service"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"override_dh_python3:"},{"line_number":44,"context_line":"\tdh_python3 --shebang\u003d/usr/bin/python3"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"a5d5c876_e8a8c7c1","line":41,"range":{"start_line":41,"start_character":19,"end_line":41,"end_character":21},"in_reply_to":"ff635677_4cbb4255","updated":"2021-12-06 18:35:34.000000000","message":"-p is not needed in this case","commit_id":"e25bfeae2d01e28cbcdd374b15607d523c4a6e6a"}]}