)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"38ede68041d0babfe6a46c4953d87671055c3512","unresolved":true,"context_lines":[{"line_number":9,"context_line":"When doing a: \"system service-parameter-apply kubernetes\""},{"line_number":10,"context_line":"the kube apiserver will be restarted but the service"},{"line_number":11,"context_line":"parameter command will return regardless of the apiserver"},{"line_number":12,"context_line":"state. And if we run some \u0027kubectl\u0027 commands afer that, they will"},{"line_number":13,"context_line":"fail until the apiserver is back online."},{"line_number":14,"context_line":"To avoid these bad scenarios, we will wait for the kube apiserver"},{"line_number":15,"context_line":"to be up after we apply the service parameter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c31fcbcb_769deab0","line":12,"range":{"start_line":12,"start_character":45,"end_line":12,"end_character":50},"updated":"2021-12-04 15:36:40.000000000","message":"after","commit_id":"7de857b74ce0db5273fcbfdcb10b2b54a165f661"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28434,"name":"David Sullivan","email":"david.sullivan@windriver.com","username":"dsullivanwr"},"change_message_id":"4828b84721ff9bf12214be2de0c1cff2712ca6a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d9c625ca_ca231f92","updated":"2021-12-04 20:50:19.000000000","message":"FYI this is effectively blocking the CLI for up to 5 minutes. I\u0027m not sure if this is desired. It might be better just to make a documentation change to note that this command will bring down kube serivces, and to wait for the config-out-date alarm to clear. With the corresponding puppet change we\u0027ll know that the kubeapi is up once that alarm clears.","commit_id":"945afb4a5fbed6a1689bd95d4dcf3820e75be0a5"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"848a8e55050439ca9952e225c4bd662b2a2731d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"343a7267_e291aae9","updated":"2021-12-05 15:13:11.000000000","message":"I\u0027ll remove my vote for now in case David\u0027s concerns need to be addressed","commit_id":"945afb4a5fbed6a1689bd95d4dcf3820e75be0a5"},{"author":{"_account_id":31273,"name":"Mihnea Saracin","email":"mihneasaracin@yahoo.com","username":"mihneasaracin"},"change_message_id":"a1d6200a0506205e8d61d6cfa88914a0fb8836d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f70bd4c_99a39660","updated":"2021-12-04 16:22:45.000000000","message":"recheck","commit_id":"945afb4a5fbed6a1689bd95d4dcf3820e75be0a5"},{"author":{"_account_id":31273,"name":"Mihnea Saracin","email":"mihneasaracin@yahoo.com","username":"mihneasaracin"},"change_message_id":"024e154f16ee4cca855d2155dbce476d8863ef28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9711279_deaa67c8","updated":"2021-12-04 16:05:11.000000000","message":"recheck","commit_id":"945afb4a5fbed6a1689bd95d4dcf3820e75be0a5"},{"author":{"_account_id":31273,"name":"Mihnea Saracin","email":"mihneasaracin@yahoo.com","username":"mihneasaracin"},"change_message_id":"1e8548c14bd6347e834215e65d9c9d9189461ed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2652b023_483510db","in_reply_to":"99e30305_1acfa394","updated":"2021-12-06 08:26:46.000000000","message":"I agree with this","commit_id":"945afb4a5fbed6a1689bd95d4dcf3820e75be0a5"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"b1e43bdb101ce688a7c74a4d72e7e2e079208ae0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"99e30305_1acfa394","in_reply_to":"d9c625ca_ca231f92","updated":"2021-12-06 06:08:39.000000000","message":"I\u0027m game to make the documentation change rather than causing a delay in the CLI, but then we\u0027d need to make sure that all automated testing waits for the alarm to clear or for \"/usr/bin/curl -k https://localhost:6443/readyz\" to return success.","commit_id":"945afb4a5fbed6a1689bd95d4dcf3820e75be0a5"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"38ede68041d0babfe6a46c4953d87671055c3512","unresolved":true,"context_lines":[{"line_number":9499,"context_line":""},{"line_number":9500,"context_line":"                # Wait for the manifest(s) to be applied"},{"line_number":9501,"context_line":"                elapsed \u003d 0"},{"line_number":9502,"context_line":"                timeout \u003d 270"},{"line_number":9503,"context_line":"                interval \u003d 10"},{"line_number":9504,"context_line":"                while elapsed \u003c timeout:"},{"line_number":9505,"context_line":"                    elapsed +\u003d interval"}],"source_content_type":"text/x-python","patch_set":1,"id":"48134fc0_fe6e4ccc","line":9502,"range":{"start_line":9502,"start_character":26,"end_line":9502,"end_character":29},"updated":"2021-12-04 15:36:40.000000000","message":"you likely do not want these declared here.  We would want them defined somewhere as constants","commit_id":"7de857b74ce0db5273fcbfdcb10b2b54a165f661"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"38ede68041d0babfe6a46c4953d87671055c3512","unresolved":true,"context_lines":[{"line_number":9513,"context_line":"                                      host_obj.hostname)"},{"line_number":9514,"context_line":"                            break"},{"line_number":9515,"context_line":"                    else:"},{"line_number":9516,"context_line":"                        LOG.info(\"Config was applied for all controller hosts\")"},{"line_number":9517,"context_line":"                        break"},{"line_number":9518,"context_line":"                else:"},{"line_number":9519,"context_line":"                    LOG.warning(\"Manifest apply failed for a controller host\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6e90a15_b9047b06","line":9516,"updated":"2021-12-04 15:36:40.000000000","message":"should all these logs (debug above, warning below) include the name of the service. It seems like the log might not indicate that we are doing this for kubernetes","commit_id":"7de857b74ce0db5273fcbfdcb10b2b54a165f661"}],"sysinv/sysinv/sysinv/sysinv/conductor/rpcapi.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"971209aa5909800ec17944961cc14e74a2f84520","unresolved":true,"context_lines":[{"line_number":1367,"context_line":"                                       service\u003dservice,"},{"line_number":1368,"context_line":"                                       section\u003dsection,"},{"line_number":1369,"context_line":"                                       do_apply\u003ddo_apply),"},{"line_number":1370,"context_line":"                         timeout\u003d270)"},{"line_number":1371,"context_line":""},{"line_number":1372,"context_line":"    def start_upgrade(self, context, upgrade):"},{"line_number":1373,"context_line":"        \"\"\"Asynchronously, have the conductor start the upgrade"}],"source_content_type":"text/x-python","patch_set":2,"id":"1244dec3_cc53a063","line":1370,"range":{"start_line":1370,"start_character":33,"end_line":1370,"end_character":36},"updated":"2021-12-04 17:24:47.000000000","message":"It feels like you probably will never hit your 270 in the \u0027apply\u0027 with the same value here (since there is additional overhead), but I think this is still fine.","commit_id":"945afb4a5fbed6a1689bd95d4dcf3820e75be0a5"}]}