)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"28637b673dcd2eaaeb0157215204cc07618e3024","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Shrinidhi M \u003cShrinidhi.Shrinidhim@commscope.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-08 16:55:16 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CPU isolation change code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id3c96d3d95b5a39024d74558de07c5e5b2045a35"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"96f802a6_ee3563a3","line":7,"updated":"2021-12-14 13:12:53.000000000","message":"The StarlingX community follow a very strict guideline for commit messages. Please check here: https://docs.starlingx.io/developer_resources/code-submission-guide.html#pre-review-and-pre-submission-testing","commit_id":"f0d81aebc5e694b250a7bbdefc82e333da2a40bf"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"d1cb25dbf21202f20f9cc25d7e5c7f3507c1341e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Setting rcu_nocbs same as isolcpus"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In current starlingx 5.0 CPU isolation does not work ."},{"line_number":10,"context_line":"To fix it set the rcu_nocbs parameter can be set same as isolcpus."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Test Plan: Test cases for Isol CPU feature"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d532e550_4266606f","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":54},"updated":"2022-03-24 19:48:31.000000000","message":"This commit is against the master branch, which will become StarlingX 7.0.\n\nThe bug report was against StarlingX 5.0.  Do we still have a problem in the current StarlingX master branch?","commit_id":"7dbf056e45d9e816e7c16285300b66962e0d75e6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34312,"name":"Shrinidhi M","email":"Shrinidhi.Shrinidhim@commscope.com","username":"shrinidhim"},"change_message_id":"5863c960360bd7938d26b5036192ae7f7782966c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea043529_d419ea2b","updated":"2021-12-14 04:59:35.000000000","message":"CPU isolation doesn\u0027t work in StarlingX 5.0 ,\nKindly review the modified code which enables CPU isolation change in StarlingX 5.0","commit_id":"f0d81aebc5e694b250a7bbdefc82e333da2a40bf"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"8fd01b7ed4bf47124d94188320c7891dc34f1b83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9280012_432e218e","updated":"2021-12-14 13:11:27.000000000","message":"Hi Shrinidhi, thank you for your contribution. I have some comments inline.","commit_id":"f0d81aebc5e694b250a7bbdefc82e333da2a40bf"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"8fd01b7ed4bf47124d94188320c7891dc34f1b83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8ec3a62_a359a4dc","in_reply_to":"ea043529_d419ea2b","updated":"2021-12-14 13:11:27.000000000","message":"You mentioned that you are having a problem with StarlingX 5.0, but you submited your code to master. Did you find this problem also on StarlinX master?","commit_id":"f0d81aebc5e694b250a7bbdefc82e333da2a40bf"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"82967cba96187e6ff996d615a0de9f9de81d093b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e967436f_e9c44572","updated":"2022-01-07 14:34:51.000000000","message":"Hi Shrinidhi, I still see commented code on PS2. Also, please follow the commit message guidelines:\nhttps://docs.starlingx.io/developer_resources/code-submission-guide.html#pre-review-and-pre-submission-testing","commit_id":"282def92c1af0eedd38b6dd1c86d0f62e824b162"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"f241dbbf53483af08f51157ab86512c0d4a4305a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5629bc4b_ce6db48b","updated":"2022-01-18 19:18:04.000000000","message":"Your commit message is still not following the guidelines at https://docs.starlingx.io/developer_resources/code-submission-guide.html","commit_id":"6b8a1f51d2bc9f2241a60ca557fe08043a678faa"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"294c58ac5196efdf5b74c8f3d52b94d67c450ae1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e9e1e4d4_8c0e0d9c","updated":"2022-03-11 15:17:43.000000000","message":"A colleague at Wind River (Thales Elero Cervi) brought this commit to my attention during a discussion.\n\nWe encountered a very similar (if not the same!) issue with the 5.10 kernel as well, and a solution was merged to the master branch at the time: https://review.opendev.org/c/starlingx/config/+/812711\n\nHowever, my recollection (with the 5.10 kernel, mind you) was that the isolcpus and the nohz_full arguments needed to be aligned, and that the code for rcu_nocbs argument could stay as is. Of course, I did not confirm this with the 4.18 kernel.\n\nThank you,\n\nVefa","commit_id":"7dbf056e45d9e816e7c16285300b66962e0d75e6"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"b67267cbeb02e64d0d83d72c643e20adf582177b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"78d073bd_e1c90325","updated":"2022-03-24 19:55:42.000000000","message":"As described by others, the fix for the 5.10 kernel was to align the isolcpus and nohz_full cpusets, we didn\u0027t need to modify rcu_nocbs.","commit_id":"7dbf056e45d9e816e7c16285300b66962e0d75e6"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"06ee8905211981f372dcbe1036ee920d633dc464","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"48b0332d_06b3e50d","updated":"2022-03-18 17:22:23.000000000","message":"Jim and Chris should take a look","commit_id":"7dbf056e45d9e816e7c16285300b66962e0d75e6"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"b67267cbeb02e64d0d83d72c643e20adf582177b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e947464b_91b91f56","in_reply_to":"e9e1e4d4_8c0e0d9c","updated":"2022-03-24 19:55:42.000000000","message":"Agreed, the fix for the 5.10 kernel was to align the isolcpus and nohz_full cpusets, we didn\u0027t need to modify rcu_nocbs.  (It is allowed for rcu_nocbs to be a superset of isolcpus/nohz_full.)","commit_id":"7dbf056e45d9e816e7c16285300b66962e0d75e6"}],"sysinv/sysinv/sysinv/sysinv/puppet/platform.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"8fd01b7ed4bf47124d94188320c7891dc34f1b83","unresolved":true,"context_lines":[{"line_number":580,"context_line":"            vswitch_cpuset \u003d set([c.cpu for c in vswitch_cpus])"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"            # non-platform logical cpus"},{"line_number":583,"context_line":"            #rcu_nocbs_cpuset \u003d host_cpuset - platform_cpuset"},{"line_number":584,"context_line":"            #rcu_nocbs_ranges \u003d utils.format_range_set(rcu_nocbs_cpuset)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"            # isolated logical cpus"}],"source_content_type":"text/x-python","patch_set":1,"id":"c338f955_8d9638eb","line":583,"updated":"2021-12-14 13:11:27.000000000","message":"Commented code, please remove.","commit_id":"f0d81aebc5e694b250a7bbdefc82e333da2a40bf"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"8fd01b7ed4bf47124d94188320c7891dc34f1b83","unresolved":true,"context_lines":[{"line_number":589,"context_line":"            app_isolated_cpuset \u003d set([c.cpu for c in app_isolated_cpus])"},{"line_number":590,"context_line":"            # non-platform logical cpus"},{"line_number":591,"context_line":"            rcu_nocbs_cpuset \u003d host_cpuset - platform_cpuset"},{"line_number":592,"context_line":"            #rcu_nocbs_ranges \u003d utils.format_range_set(rcu_nocbs_cpuset)"},{"line_number":593,"context_line":"            rcu_nocbs_ranges \u003d utils.format_range_set(vswitch_cpuset.union(app_isolated_cpuset))"},{"line_number":594,"context_line":"            isolcpus_ranges \u003d utils.format_range_set(vswitch_cpuset.union(app_isolated_cpuset))"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a782d38c_aa7692a4","line":592,"updated":"2021-12-14 13:11:27.000000000","message":"Ditto for commented code.","commit_id":"f0d81aebc5e694b250a7bbdefc82e333da2a40bf"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"8fd01b7ed4bf47124d94188320c7891dc34f1b83","unresolved":true,"context_lines":[{"line_number":624,"context_line":"            cpu_ranges.update({"},{"line_number":625,"context_line":"                \"isolcpus\": isolcpus_ranges,"},{"line_number":626,"context_line":"n-platform logical cpus"},{"line_number":627,"context_line":"\u003e             rcu_nocbs_cpuset \u003d host_cpuset - platform_cpuset"},{"line_number":628,"context_line":"\u003e             #rcu_nocbs_ranges \u003d utils.format_range_set(rcu_nocbs_cpuset)"},{"line_number":629,"context_line":"\u003e             rcu_nocbs_ranges \u003d utils.format_range_set(vswitch_cpuset.union(app_isolated_cpuset))"},{"line_number":630,"context_line":"                \"rcu_nocbs\": rcu_nocbs_ranges,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff07a891_d2b294b2","line":627,"updated":"2021-12-14 13:11:27.000000000","message":"These \"\u003e\"  are invalid on python syntax. Did you not properly fixed any merge conflicts on this part?","commit_id":"f0d81aebc5e694b250a7bbdefc82e333da2a40bf"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"82967cba96187e6ff996d615a0de9f9de81d093b","unresolved":true,"context_lines":[{"line_number":585,"context_line":"            app_isolated_cpuset \u003d set([c.cpu for c in app_isolated_cpus])"},{"line_number":586,"context_line":"            # non-platform logical cpus"},{"line_number":587,"context_line":"            rcu_nocbs_cpuset \u003d host_cpuset - platform_cpuset"},{"line_number":588,"context_line":"            #rcu_nocbs_ranges \u003d utils.format_range_set(rcu_nocbs_cpuset)"},{"line_number":589,"context_line":"            rcu_nocbs_ranges \u003d utils.format_range_set(vswitch_cpuset.union(app_isolated_cpuset))"},{"line_number":590,"context_line":"            isolcpus_ranges \u003d utils.format_range_set(vswitch_cpuset.union(app_isolated_cpuset))"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a7a5ddbc_0402a911","line":588,"updated":"2022-01-07 14:34:51.000000000","message":"please remove commented code","commit_id":"282def92c1af0eedd38b6dd1c86d0f62e824b162"}]}