)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"db298f7a46a0ed361f9c0021062bd8030a8d2447","unresolved":true,"context_lines":[{"line_number":10,"context_line":"an app and there is a lifecycle hook"},{"line_number":11,"context_line":"which raises an exception the traceback"},{"line_number":12,"context_line":"will be displayed on the screen."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit addresses this issue and keeps"},{"line_number":15,"context_line":"just the exception message displayed."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"79157582_cfab63c8","line":13,"updated":"2021-12-13 16:02:48.000000000","message":"In my opinion, we should address each of these using the same kind of fix. Would like someone else to weigh-in here.","commit_id":"9b08f077f875c44b823a5e941c4c94b1264a1ae8"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"04abe37ed7d8c075ffc72b00dc9de8fdbfb62a98","unresolved":false,"context_lines":[{"line_number":10,"context_line":"an app and there is a lifecycle hook"},{"line_number":11,"context_line":"which raises an exception the traceback"},{"line_number":12,"context_line":"will be displayed on the screen."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit addresses this issue and keeps"},{"line_number":15,"context_line":"just the exception message displayed."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"94445c2e_c375c5ef","line":13,"in_reply_to":"79157582_cfab63c8","updated":"2021-12-14 14:57:54.000000000","message":"addressed all the application-* cmds in patchset 5","commit_id":"9b08f077f875c44b823a5e941c4c94b1264a1ae8"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"74f78894d1e7172a42621616e1b312fb6bf420a7","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Note: this might be needed for the other"},{"line_number":18,"context_line":"system cmds changed here:"},{"line_number":19,"context_line":"https://opendev.org/starlingx/config/commit/12df6a264c6f23807d004e20da1f8a0e3147b29c"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-bug: 1954671"},{"line_number":22,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ccc5932_e17e4315","line":19,"updated":"2021-12-14 13:40:27.000000000","message":"is there a separate LP tracking the potential other areas needing update?  If not, recommend creating one with reference to this review for potential fix.","commit_id":"2f02cdbe1c691aba4efc941f408a98276a4fbb61"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"04abe37ed7d8c075ffc72b00dc9de8fdbfb62a98","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Note: this might be needed for the other"},{"line_number":18,"context_line":"system cmds changed here:"},{"line_number":19,"context_line":"https://opendev.org/starlingx/config/commit/12df6a264c6f23807d004e20da1f8a0e3147b29c"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-bug: 1954671"},{"line_number":22,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1faa650b_630a8683","line":19,"in_reply_to":"9ccc5932_e17e4315","updated":"2021-12-14 14:57:54.000000000","message":"I\u0027m not aware of any LP tracking the changes needed in other components, will be addressed","commit_id":"2f02cdbe1c691aba4efc941f408a98276a4fbb61"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"bdf036306b975aec2004e408494c4e5fb143a274","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3ad5eb2d_13a97fee","updated":"2021-12-13 15:23:49.000000000","message":"Shouldn\u0027t this same change be made in each of the other usages from Chuck\u0027s commit?","commit_id":"9b08f077f875c44b823a5e941c4c94b1264a1ae8"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"f33280ea69f0458921a2329d1f9936fac13de2eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"033a6db1_3acbc160","in_reply_to":"3ad5eb2d_13a97fee","updated":"2021-12-13 15:38:48.000000000","message":"Probably yes, since many of these error messages get propagated up through the CLI to the user.   Or create a utility method and call it to determine the \u0027message\u0027","commit_id":"9b08f077f875c44b823a5e941c4c94b1264a1ae8"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_app.py":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"0d8398e1ac6d6d0b1c96bf8af4dbc0fe97fe6d06","unresolved":true,"context_lines":[{"line_number":325,"context_line":"                self._app_lifecycle_actions(db_app,"},{"line_number":326,"context_line":"                                            lifecycle_hook_info)"},{"line_number":327,"context_line":"            except Exception as e:"},{"line_number":328,"context_line":"                if six.PY2:"},{"line_number":329,"context_line":"                    raise wsme.exc.ClientSideError(_("},{"line_number":330,"context_line":"                        \"Application-apply rejected: \" + str(e.message)))"},{"line_number":331,"context_line":"                elif six.PY3:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3eebd2b6_1bec92c3","line":328,"range":{"start_line":328,"start_character":16,"end_line":328,"end_character":26},"updated":"2021-12-10 13:38:11.000000000","message":"check if the exception object has message attribute instead e.g. if hasattr(e, \u0027message\u0027)","commit_id":"a6a958772151585f96ea0778cbbb05381336817d"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"8016f3bcf446d222b45320a2dda2f2c6a558a0db","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                self._app_lifecycle_actions(db_app,"},{"line_number":326,"context_line":"                                            lifecycle_hook_info)"},{"line_number":327,"context_line":"            except Exception as e:"},{"line_number":328,"context_line":"                if six.PY2:"},{"line_number":329,"context_line":"                    raise wsme.exc.ClientSideError(_("},{"line_number":330,"context_line":"                        \"Application-apply rejected: \" + str(e.message)))"},{"line_number":331,"context_line":"                elif six.PY3:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e50dd76_345a0e9f","line":328,"range":{"start_line":328,"start_character":16,"end_line":328,"end_character":26},"in_reply_to":"3eebd2b6_1bec92c3","updated":"2021-12-13 12:12:42.000000000","message":"Done","commit_id":"a6a958772151585f96ea0778cbbb05381336817d"}]}
