)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"97fa4a7eff5c84f56182803a5e064a26e161d4dd","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Also added the information needed for"},{"line_number":16,"context_line":"system kube-version-list."},{"line_number":17,"context_line":"Tested upgrade from k8s 1.21.8 on SX, DX and"},{"line_number":18,"context_line":"Standard setup. The k8s componenets upgrade"},{"line_number":19,"context_line":"is successfull."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/integ/+/822904"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"65fd1363_e58f343c","line":18,"range":{"start_line":18,"start_character":24,"end_line":18,"end_character":36},"updated":"2022-01-28 16:13:45.000000000","message":"components","commit_id":"dc25f82852c3f31980b7f0ac7eee8f305f3c1c77"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"97fa4a7eff5c84f56182803a5e064a26e161d4dd","unresolved":true,"context_lines":[{"line_number":16,"context_line":"system kube-version-list."},{"line_number":17,"context_line":"Tested upgrade from k8s 1.21.8 on SX, DX and"},{"line_number":18,"context_line":"Standard setup. The k8s componenets upgrade"},{"line_number":19,"context_line":"is successfull."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/integ/+/822904"},{"line_number":22,"context_line":"Story: 2009789"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d73736ae_b9c75336","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":14},"updated":"2022-01-28 16:13:45.000000000","message":"successful","commit_id":"dc25f82852c3f31980b7f0ac7eee8f305f3c1c77"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"3aba778f643f0860fcf09c18c019397dbf8f6128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"03d645ec_44c90058","updated":"2022-01-19 20:32:14.000000000","message":"Probably want to make this depend on Ibb9be075fa0b1491b9ab1854ebb1fddf4df53461 (which adds k8s 1.22.5)","commit_id":"d62a9de3b2b71501979f8c9230a7a71c5d4621dd"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0fc7ba6196284cae23e35c06bfee70e2110d100d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"883acb69_8022af8e","updated":"2022-01-19 20:36:11.000000000","message":"Should mention what testing has been done.  Is the new way of getting the config supported back to k8s 1.18.1?","commit_id":"d62a9de3b2b71501979f8c9230a7a71c5d4621dd"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"a8fd08c1c9779eb300c8031f2fc53ac29d57f014","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f36e509a_a53e4eba","in_reply_to":"883acb69_8022af8e","updated":"2022-01-28 10:15:19.000000000","message":"I have tested the new way of retrieving the infor from kubeadm-config in 1.21.8 and can retrieve the config. Fetched the key, added it to the file and ran: \nkubeadm init phase upload-certs --upload-certs --config my_config. \n\nIt is working: \n[upload-certs] Storing the certificates in Secret \"kubeadm-certs\" in the \"kube-system\" Namespace\n[upload-certs] Using certificate key: *****","commit_id":"d62a9de3b2b71501979f8c9230a7a71c5d4621dd"}],"sysinv/sysinv/sysinv/sysinv/common/kubernetes.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dc9b7612f1adbdea477ccc0a6e95a2a4e31f2117","unresolved":true,"context_lines":[{"line_number":154,"context_line":"         \u0027available_patches\u0027: [],"},{"line_number":155,"context_line":"         },"},{"line_number":156,"context_line":"        {\u0027version\u0027: \u0027v1.22.4\u0027,"},{"line_number":157,"context_line":"         \u0027upgrade_from\u0027: [\u0027v1.21.8\u0027],"},{"line_number":158,"context_line":"         \u0027downgrade_to\u0027: [],"},{"line_number":159,"context_line":"         \u0027applied_patches\u0027: [],"},{"line_number":160,"context_line":"         \u0027available_patches\u0027: [],"}],"source_content_type":"text/x-python","patch_set":3,"id":"eee8e848_6430a111","line":157,"range":{"start_line":157,"start_character":28,"end_line":157,"end_character":33},"updated":"2022-01-18 14:36:58.000000000","message":"this has a dependency on Chris\u0027s review\nhttps://review.opendev.org/c/starlingx/config/+/824804\n\nnot that it breaks anything, but if this merges first you wont be able to upgrade to this version until his change merges.","commit_id":"1d200361e0cac68c5209cf304066f9258bc87a67"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"63b871a37d9973fd23376f58295f34ea1251972d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"         \u0027available_patches\u0027: [],"},{"line_number":155,"context_line":"         },"},{"line_number":156,"context_line":"        {\u0027version\u0027: \u0027v1.22.4\u0027,"},{"line_number":157,"context_line":"         \u0027upgrade_from\u0027: [\u0027v1.21.8\u0027],"},{"line_number":158,"context_line":"         \u0027downgrade_to\u0027: [],"},{"line_number":159,"context_line":"         \u0027applied_patches\u0027: [],"},{"line_number":160,"context_line":"         \u0027available_patches\u0027: [],"}],"source_content_type":"text/x-python","patch_set":3,"id":"ad617847_b27687b6","line":157,"range":{"start_line":157,"start_character":28,"end_line":157,"end_character":33},"in_reply_to":"eee8e848_6430a111","updated":"2022-01-25 12:10:45.000000000","message":"his change already merged so we should be covered here.","commit_id":"1d200361e0cac68c5209cf304066f9258bc87a67"}],"sysinv/sysinv/sysinv/sysinv/puppet/kubernetes.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dc9b7612f1adbdea477ccc0a6e95a2a4e31f2117","unresolved":true,"context_lines":[{"line_number":243,"context_line":"                fd, temp_kubeadm_config_view \u003d tempfile.mkstemp("},{"line_number":244,"context_line":"                    dir\u003d\u0027/tmp\u0027, suffix\u003d\u0027.yaml\u0027)"},{"line_number":245,"context_line":"                with os.fdopen(fd, \u0027w\u0027) as f:"},{"line_number":246,"context_line":"                    cmd \u003d \u0027kubectl get cm -n kube-system kubeadm-config \\"},{"line_number":247,"context_line":"                        -o\u003djsonpath\u003d\"{.data.ClusterConfiguration}\" \u0027 + KUBECONFIG"},{"line_number":248,"context_line":"                    subprocess.check_call(cmd, stdout\u003df, shell\u003dTrue)  # pylint: disable\u003dnot-callable"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"01269f18_f438ba6e","line":246,"range":{"start_line":246,"start_character":20,"end_line":246,"end_character":24},"updated":"2022-01-18 14:36:58.000000000","message":"everywhere else in this file  populates \u0027cmd\u0027 variable as a list/array.\nIs the new command unable to be formatted using that convention?","commit_id":"1d200361e0cac68c5209cf304066f9258bc87a67"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"63b871a37d9973fd23376f58295f34ea1251972d","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                fd, temp_kubeadm_config_view \u003d tempfile.mkstemp("},{"line_number":244,"context_line":"                    dir\u003d\u0027/tmp\u0027, suffix\u003d\u0027.yaml\u0027)"},{"line_number":245,"context_line":"                with os.fdopen(fd, \u0027w\u0027) as f:"},{"line_number":246,"context_line":"                    cmd \u003d \u0027kubectl get cm -n kube-system kubeadm-config \\"},{"line_number":247,"context_line":"                        -o\u003djsonpath\u003d\"{.data.ClusterConfiguration}\" \u0027 + KUBECONFIG"},{"line_number":248,"context_line":"                    subprocess.check_call(cmd, stdout\u003df, shell\u003dTrue)  # pylint: disable\u003dnot-callable"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"162569cc_b4ae8c9e","line":246,"range":{"start_line":246,"start_character":20,"end_line":246,"end_character":24},"in_reply_to":"01269f18_f438ba6e","updated":"2022-01-25 12:10:45.000000000","message":"Done","commit_id":"1d200361e0cac68c5209cf304066f9258bc87a67"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"97fa4a7eff5c84f56182803a5e064a26e161d4dd","unresolved":true,"context_lines":[{"line_number":244,"context_line":"                    dir\u003d\u0027/tmp\u0027, suffix\u003d\u0027.yaml\u0027)"},{"line_number":245,"context_line":"                with os.fdopen(fd, \u0027w\u0027) as f:"},{"line_number":246,"context_line":"                    cmd \u003d [\u0027kubectl\u0027, \u0027get\u0027, \u0027cm\u0027, \u0027-n\u0027, \u0027kube-system\u0027,"},{"line_number":247,"context_line":"                           \u0027kubeadm-config\u0027, \u0027-o\u003djsonpath\u003d{.data.ClusterConfiguration}\u0027,"},{"line_number":248,"context_line":"                           KUBECONFIG]"},{"line_number":249,"context_line":"                    subprocess.check_call(cmd, stdout\u003df)  # pylint: disable\u003dnot-callable"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6024b4f7_2a4d2fda","line":247,"range":{"start_line":247,"start_character":28,"end_line":247,"end_character":42},"updated":"2022-01-28 16:13:45.000000000","message":"command seems to be valid in older kube (1.18) also","commit_id":"dc25f82852c3f31980b7f0ac7eee8f305f3c1c77"}]}
