)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"fc035487e80146ead540fed2a9eaa4d62653434c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"603a2645_33afc4c4","updated":"2022-02-02 13:37:35.000000000","message":"-1 workflow per the discussion on ansible-playbooks review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/826665","commit_id":"00c7293d196d01133b42dd48c5d7671e6bb0bee7"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"777c754ceb3aab3b9f32576b382c3c52f16e5d20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a259e564_4dd3738a","updated":"2022-02-01 14:30:22.000000000","message":"recheck","commit_id":"00c7293d196d01133b42dd48c5d7671e6bb0bee7"},{"author":{"_account_id":28558,"name":"Ghada Khalil","email":"ghada.khalil@windriver.com","username":"gkhalil"},"change_message_id":"48924ca84d1860c6e03906ccafa1e667614a6336","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a772e005_fe29cb77","updated":"2022-02-14 15:54:24.000000000","message":"@Steve, can you please +2 based on Andy\u0027s review. Thanks.","commit_id":"49117ccaa7e1de8d8376bc0fbdb479ef95a362d0"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"3ff72c78c69f25c9c2c2c63c31f0e0544c72e7fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"59eba585_e1b4c6b5","updated":"2022-02-14 13:39:19.000000000","message":"Testing for this change includes:\n - both IPv4 and IPv6\n - with and without the user and auth settings present before attempt to remove\n - testing both the Etcd url (ipv4 and ipv6) and localhost urls independently","commit_id":"49117ccaa7e1de8d8376bc0fbdb479ef95a362d0"}],"controllerconfig/controllerconfig/upgrade-scripts/72-remove-etcd-rbac.sh":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"0a24046abd49b268c9ad102659905d8c93f081f1","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"log \"Script ${0} invoked with from_release \u003d ${FROM_REL} to_release \u003d ${TO_REL} action \u003d ${ACTION}\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"if [ ${FROM_REL} \u003d\u003d \"$ACCEPTED_REL\" -a ${ACTION} \u003d\u003d \"activate\" ]; then"},{"line_number":70,"context_line":"    remove-etcd-rbac"},{"line_number":71,"context_line":"else"},{"line_number":72,"context_line":"    log \"Script $0: No actions required from release $FROM_REL to $TO_REL with action $ACTION\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"6d6ace5f_506be573","line":69,"updated":"2022-02-14 16:05:36.000000000","message":"Just small nit: ACCEPTED_REL should be wrapped in {}, same for vars in L72.  In this case, does not affect faculty","commit_id":"49117ccaa7e1de8d8376bc0fbdb479ef95a362d0"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"0e20b1f3de38aad21c91df0b0fe4436bf06d889a","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"log \"Script ${0} invoked with from_release \u003d ${FROM_REL} to_release \u003d ${TO_REL} action \u003d ${ACTION}\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"if [ ${FROM_REL} \u003d\u003d \"$ACCEPTED_REL\" -a ${ACTION} \u003d\u003d \"activate\" ]; then"},{"line_number":70,"context_line":"    remove-etcd-rbac"},{"line_number":71,"context_line":"else"},{"line_number":72,"context_line":"    log \"Script $0: No actions required from release $FROM_REL to $TO_REL with action $ACTION\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ab793719_811ae510","line":69,"in_reply_to":"6d6ace5f_506be573","updated":"2022-02-14 16:56:39.000000000","message":"Ack","commit_id":"49117ccaa7e1de8d8376bc0fbdb479ef95a362d0"},{"author":{"_account_id":28739,"name":"Michel Thebeau","email":"michel.thebeau@windriver.com","username":"michel.thebeau"},"change_message_id":"16cb82d377213ef7eb1ef64b2c495453ba97f3ee","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"log \"Script ${0} invoked with from_release \u003d ${FROM_REL} to_release \u003d ${TO_REL} action \u003d ${ACTION}\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"if [ ${FROM_REL} \u003d\u003d \"$ACCEPTED_REL\" -a ${ACTION} \u003d\u003d \"activate\" ]; then"},{"line_number":70,"context_line":"    remove-etcd-rbac"},{"line_number":71,"context_line":"else"},{"line_number":72,"context_line":"    log \"Script $0: No actions required from release $FROM_REL to $TO_REL with action $ACTION\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"2b62be5d_a2105567","line":69,"in_reply_to":"ab793719_811ae510","updated":"2022-02-14 16:57:51.000000000","message":"I should have put the command line parameters FROM_REL and ACTION in quotes","commit_id":"49117ccaa7e1de8d8376bc0fbdb479ef95a362d0"}]}