)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccea4499062a23a830812d67f97eb28be9a208f2","unresolved":true,"context_lines":[{"line_number":9,"context_line":"STX does not support managed pool quotas. This is legacy code left over"},{"line_number":10,"context_line":"from the project seed code that was never properly cleaned up."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Test plan:"},{"line_number":13,"context_line":"    PASS: Test horizon around the storage overview page."},{"line_number":14,"context_line":"    PASS: Checked sysinv logs for errors/messages regarding quotas."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fb0b666a_848ecd1b","line":12,"updated":"2022-02-09 22:41:04.000000000","message":"What system type was installed (AIO-DX, AIO-DX,...) and did you confirm that the system was enabled with a Ceph backend?","commit_id":"45d98b71ea943eeb9ec8a6bbe414265c6555c798"},{"author":{"_account_id":34374,"name":"Daian Cardoso Sganderlla","email":"Daian.CardosoSganderlla@windriver.com","username":"dcardos1"},"change_message_id":"3bf319f1b5134e011b5dde4f0c3fab32ba8195df","unresolved":false,"context_lines":[{"line_number":9,"context_line":"STX does not support managed pool quotas. This is legacy code left over"},{"line_number":10,"context_line":"from the project seed code that was never properly cleaned up."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Test plan:"},{"line_number":13,"context_line":"    PASS: Test horizon around the storage overview page."},{"line_number":14,"context_line":"    PASS: Checked sysinv logs for errors/messages regarding quotas."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"11dae512_03932af8","line":12,"in_reply_to":"fb0b666a_848ecd1b","updated":"2022-02-15 18:55:57.000000000","message":"Done","commit_id":"45d98b71ea943eeb9ec8a6bbe414265c6555c798"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a2a562604a0a86f8874ea364e56143d785cd298","unresolved":true,"context_lines":[{"line_number":9,"context_line":"STX does not support managed pool quotas. This is legacy code left over"},{"line_number":10,"context_line":"from the project seed code that was never properly cleaned up."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Test plan: The tests were executed in an AIO-SX system with CEPH backend enabled."},{"line_number":13,"context_line":"    PASS: Test horizon around the storage overview page."},{"line_number":14,"context_line":"    PASS: Checked sysinv logs for errors/messages regarding quotas."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f1f90644_d8277269","line":12,"range":{"start_line":12,"start_character":73,"end_line":12,"end_character":81},"updated":"2022-02-15 18:44:46.000000000","message":"nit: long line","commit_id":"75e3b69464cb78035ae809993908539261822522"},{"author":{"_account_id":34374,"name":"Daian Cardoso Sganderlla","email":"Daian.CardosoSganderlla@windriver.com","username":"dcardos1"},"change_message_id":"3bf319f1b5134e011b5dde4f0c3fab32ba8195df","unresolved":false,"context_lines":[{"line_number":9,"context_line":"STX does not support managed pool quotas. This is legacy code left over"},{"line_number":10,"context_line":"from the project seed code that was never properly cleaned up."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Test plan: The tests were executed in an AIO-SX system with CEPH backend enabled."},{"line_number":13,"context_line":"    PASS: Test horizon around the storage overview page."},{"line_number":14,"context_line":"    PASS: Checked sysinv logs for errors/messages regarding quotas."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bc29998e_ae8739be","line":12,"range":{"start_line":12,"start_character":73,"end_line":12,"end_character":81},"in_reply_to":"f1f90644_d8277269","updated":"2022-02-15 18:55:57.000000000","message":"Done","commit_id":"75e3b69464cb78035ae809993908539261822522"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccea4499062a23a830812d67f97eb28be9a208f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f96ece48_bb875fe8","updated":"2022-02-09 22:41:04.000000000","message":"A couple of more cleanup items.","commit_id":"45d98b71ea943eeb9ec8a6bbe414265c6555c798"}],"sysinv/sysinv/sysinv/sysinv/conductor/ceph.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccea4499062a23a830812d67f97eb28be9a208f2","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        else:"},{"line_number":300,"context_line":"            LOG.error(\"Getting the quota for %(name)s pool failed:%(reason)s)\""},{"line_number":301,"context_line":"                      % {\"name\": pool_name, \"reason\": resp.reason})"},{"line_number":302,"context_line":"            raise exception.CephPoolGetQuotaFailure(pool\u003dpool_name,"},{"line_number":303,"context_line":"                                                    reason\u003dresp.reason)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def osd_create(self, stor_uuid, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"295e590e_3d3a312a","side":"PARENT","line":302,"range":{"start_line":302,"start_character":18,"end_line":302,"end_character":51},"updated":"2022-02-09 22:41:04.000000000","message":"Remove this exception class too.","commit_id":"655e816bb0f475b02f458ddd04c43cf56b0e0a1d"},{"author":{"_account_id":34374,"name":"Daian Cardoso Sganderlla","email":"Daian.CardosoSganderlla@windriver.com","username":"dcardos1"},"change_message_id":"3bf319f1b5134e011b5dde4f0c3fab32ba8195df","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        else:"},{"line_number":300,"context_line":"            LOG.error(\"Getting the quota for %(name)s pool failed:%(reason)s)\""},{"line_number":301,"context_line":"                      % {\"name\": pool_name, \"reason\": resp.reason})"},{"line_number":302,"context_line":"            raise exception.CephPoolGetQuotaFailure(pool\u003dpool_name,"},{"line_number":303,"context_line":"                                                    reason\u003dresp.reason)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def osd_create(self, stor_uuid, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ca09ce82_9c5537b6","side":"PARENT","line":302,"range":{"start_line":302,"start_character":18,"end_line":302,"end_character":51},"in_reply_to":"295e590e_3d3a312a","updated":"2022-02-15 18:55:57.000000000","message":"Done","commit_id":"655e816bb0f475b02f458ddd04c43cf56b0e0a1d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccea4499062a23a830812d67f97eb28be9a208f2","unresolved":true,"context_lines":[{"line_number":500,"context_line":"                LOG.info(_(\"Set OSD pool quota: \""},{"line_number":501,"context_line":"                           \"pool\u003d{}, max_bytes\u003d{}\").format(pool, max_bytes))"},{"line_number":502,"context_line":"            else:"},{"line_number":503,"context_line":"                e \u003d exception.CephPoolSetQuotaFailure("},{"line_number":504,"context_line":"                    pool\u003dpool, name\u003d\u0027max_bytes\u0027, value\u003dmax_bytes, reason\u003dresp.reason)"},{"line_number":505,"context_line":"                LOG.error(e)"},{"line_number":506,"context_line":"                raise e"}],"source_content_type":"text/x-python","patch_set":4,"id":"fdf12ed4_672356fd","side":"PARENT","line":503,"range":{"start_line":503,"start_character":20,"end_line":503,"end_character":53},"updated":"2022-02-09 22:41:04.000000000","message":"Remove this exception class too, pls.","commit_id":"655e816bb0f475b02f458ddd04c43cf56b0e0a1d"},{"author":{"_account_id":34374,"name":"Daian Cardoso Sganderlla","email":"Daian.CardosoSganderlla@windriver.com","username":"dcardos1"},"change_message_id":"3bf319f1b5134e011b5dde4f0c3fab32ba8195df","unresolved":false,"context_lines":[{"line_number":500,"context_line":"                LOG.info(_(\"Set OSD pool quota: \""},{"line_number":501,"context_line":"                           \"pool\u003d{}, max_bytes\u003d{}\").format(pool, max_bytes))"},{"line_number":502,"context_line":"            else:"},{"line_number":503,"context_line":"                e \u003d exception.CephPoolSetQuotaFailure("},{"line_number":504,"context_line":"                    pool\u003dpool, name\u003d\u0027max_bytes\u0027, value\u003dmax_bytes, reason\u003dresp.reason)"},{"line_number":505,"context_line":"                LOG.error(e)"},{"line_number":506,"context_line":"                raise e"}],"source_content_type":"text/x-python","patch_set":4,"id":"e72b95ba_3caec240","side":"PARENT","line":503,"range":{"start_line":503,"start_character":20,"end_line":503,"end_character":53},"in_reply_to":"fdf12ed4_672356fd","updated":"2022-02-15 18:55:57.000000000","message":"Done","commit_id":"655e816bb0f475b02f458ddd04c43cf56b0e0a1d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"ccea4499062a23a830812d67f97eb28be9a208f2","unresolved":true,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        pool[\u0027quota_gib\u0027] \u003d self.set_quota_gib(pool[\u0027pool_name\u0027])"},{"line_number":660,"context_line":"        try:"},{"line_number":661,"context_line":"            self.create_or_resize_osd_pool(pool[\u0027pool_name\u0027],"},{"line_number":662,"context_line":"                                           pool[\u0027pg_num\u0027],"},{"line_number":663,"context_line":"                                           pool[\u0027pgp_num\u0027],"},{"line_number":664,"context_line":"                                           size,"}],"source_content_type":"text/x-python","patch_set":4,"id":"210e3938_d5aa95a4","side":"PARENT","line":661,"range":{"start_line":661,"start_character":12,"end_line":661,"end_character":42},"updated":"2022-02-09 22:41:04.000000000","message":"I think this can be removed too, but would support doing that in a followup commit to make this just quota based.","commit_id":"655e816bb0f475b02f458ddd04c43cf56b0e0a1d"},{"author":{"_account_id":34374,"name":"Daian Cardoso Sganderlla","email":"Daian.CardosoSganderlla@windriver.com","username":"dcardos1"},"change_message_id":"3bf319f1b5134e011b5dde4f0c3fab32ba8195df","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        pool[\u0027quota_gib\u0027] \u003d self.set_quota_gib(pool[\u0027pool_name\u0027])"},{"line_number":660,"context_line":"        try:"},{"line_number":661,"context_line":"            self.create_or_resize_osd_pool(pool[\u0027pool_name\u0027],"},{"line_number":662,"context_line":"                                           pool[\u0027pg_num\u0027],"},{"line_number":663,"context_line":"                                           pool[\u0027pgp_num\u0027],"},{"line_number":664,"context_line":"                                           size,"}],"source_content_type":"text/x-python","patch_set":4,"id":"aacd9a5d_9ff79aab","side":"PARENT","line":661,"range":{"start_line":661,"start_character":12,"end_line":661,"end_character":42},"in_reply_to":"210e3938_d5aa95a4","updated":"2022-02-15 18:55:57.000000000","message":"Done","commit_id":"655e816bb0f475b02f458ddd04c43cf56b0e0a1d"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"0a53e6de5d0ab508c5a6012f74cf4e615a751324","unresolved":true,"context_lines":[{"line_number":533,"context_line":"        return rc"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    # TODO(CephPoolsDecouple): remove"},{"line_number":536,"context_line":"    def _configure_secondary_tier_pools(self, tier_obj, size, min_size):"},{"line_number":537,"context_line":"        \"\"\"Configure the service pools that are allowed for additional ceph tiers."},{"line_number":538,"context_line":"        \"\"\""},{"line_number":539,"context_line":"        # Get the backend object if there is one attached."}],"source_content_type":"text/x-python","patch_set":7,"id":"11c244db_792f23a9","line":536,"range":{"start_line":536,"start_character":8,"end_line":536,"end_character":39},"updated":"2022-02-17 22:51:53.000000000","message":"Note: this method is also not being used anywhere.","commit_id":"abcfb640dc17dcccb78b239535ea718454491d16"},{"author":{"_account_id":34374,"name":"Daian Cardoso Sganderlla","email":"Daian.CardosoSganderlla@windriver.com","username":"dcardos1"},"change_message_id":"e4905e1b1a56ef1643901d76ecdd0a178ce3be39","unresolved":true,"context_lines":[{"line_number":533,"context_line":"        return rc"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    # TODO(CephPoolsDecouple): remove"},{"line_number":536,"context_line":"    def _configure_secondary_tier_pools(self, tier_obj, size, min_size):"},{"line_number":537,"context_line":"        \"\"\"Configure the service pools that are allowed for additional ceph tiers."},{"line_number":538,"context_line":"        \"\"\""},{"line_number":539,"context_line":"        # Get the backend object if there is one attached."}],"source_content_type":"text/x-python","patch_set":7,"id":"b87e2ac9_eacb38a3","line":536,"range":{"start_line":536,"start_character":8,"end_line":536,"end_character":39},"in_reply_to":"11c244db_792f23a9","updated":"2022-02-18 12:56:36.000000000","message":"This is the same case as the method `create_or_resize_osd_pool` mentioned by Bob in a comment above. We are keeping this commit just quota based and will remove other unused methods in a follow up commit.","commit_id":"abcfb640dc17dcccb78b239535ea718454491d16"}]}