)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"b5feb533c2fc602043253334f4d6e17ca344efc5","unresolved":true,"context_lines":[{"line_number":10,"context_line":"support kickstarts to avoid processing installer RPMs"},{"line_number":11,"context_line":"in future releases."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change introudces a new sysinv API to query if an"},{"line_number":14,"context_line":"upgrade is in progress (i.e, upgrade starts, but not"},{"line_number":15,"context_line":"abort)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f7710b0_bf5fbe65","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":23},"updated":"2022-02-18 20:50:03.000000000","message":"introduces","commit_id":"a75469c23c67f94a4d87642c6676db09301d7eff"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"0119ffaa62bc84350c5dd8f3e74c8d27135c6166","unresolved":false,"context_lines":[{"line_number":10,"context_line":"support kickstarts to avoid processing installer RPMs"},{"line_number":11,"context_line":"in future releases."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change introudces a new sysinv API to query if an"},{"line_number":14,"context_line":"upgrade is in progress (i.e, upgrade starts, but not"},{"line_number":15,"context_line":"abort)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"93f1b3b8_0ac2f922","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":23},"in_reply_to":"3f7710b0_bf5fbe65","updated":"2022-02-18 21:29:45.000000000","message":"Done","commit_id":"a75469c23c67f94a4d87642c6676db09301d7eff"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"b5feb533c2fc602043253334f4d6e17ca344efc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"08f4b504_85886d65","updated":"2022-02-18 20:50:03.000000000","message":"I assume you noticed the in_upgrade API that was already there.\nIt looks to me like the only difference is that you added 2 extra states to declare \u0027false\u0027, but all other states would be the same.\n\nAlso curious why your boolean logic is essentially the opposite as the existing method, while yielding the same true/false for all but 2 states.","commit_id":"a75469c23c67f94a4d87642c6676db09301d7eff"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"0119ffaa62bc84350c5dd8f3e74c8d27135c6166","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"52b0d41f_b9c8500a","in_reply_to":"08f4b504_85886d65","updated":"2022-02-18 21:29:45.000000000","message":"This new api is not the same scope as the existing one. The current query is to distinguish where upgrade is \"started and moving forward\".\nmy preference is when it makes sense, clearly define positive return (\"what is\"), and leave negative return (\"what is not\") in otherwise.","commit_id":"a75469c23c67f94a4d87642c6676db09301d7eff"}]}