)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"b1d40ad4cea509341924e066d3c04ba4709771a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"358028c9_67388897","updated":"2022-02-22 14:01:14.000000000","message":"Change makes sense to me.\n\n","commit_id":"c53d555e2df7c9126b7c129562542761d4fc1884"},{"author":{"_account_id":33987,"name":"Pedro Monteiro Azevedo de Moura Almeida","display_name":"Pedro Almeida","email":"pedro.monteiroazevedodemouraalmeida@windriver.com","username":"pedroalmd"},"change_message_id":"4442d662a84312eb1a088c15a7f22f618c1f928b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a16c908c_f09077fa","updated":"2022-02-21 22:13:28.000000000","message":"LGTM","commit_id":"c53d555e2df7c9126b7c129562542761d4fc1884"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"f30658bd2a03e9209e5f0f426db97fe3e3fe96ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b58b966b_df7d4866","updated":"2022-02-21 21:58:37.000000000","message":"LGTM, thanks.","commit_id":"c53d555e2df7c9126b7c129562542761d4fc1884"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/kube_app.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"4713db4c581af54fc1d5a41d01f19f6cf419160c","unresolved":true,"context_lines":[{"line_number":280,"context_line":"                \"Application-{} rejected: application not found.\".format(directive)))"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        if name.endswith(constants.HELM_APP_OPENSTACK):"},{"line_number":283,"context_line":"            mode_name \u003d constants.HELM_APP_OPENSTACK"},{"line_number":284,"context_line":"        else:"},{"line_number":285,"context_line":"            mode_name \u003d name"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"25aac603_e924879d","line":283,"updated":"2022-02-21 14:21:21.000000000","message":"You can use utils.find_app_plugin_name() here, it\u0027s the default behavior we use on several places where the openstack app name was generalized as in sysinv/sysinv/sysinv/sysinv/helm/helm.py#224, #273, #339, #492","commit_id":"cfe97473f28c795dd930521ab636b338a2d82821"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"34eb0eb83dc73f22305ea69288c6cd0ddc19ef0a","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                \"Application-{} rejected: application not found.\".format(directive)))"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        if name.endswith(constants.HELM_APP_OPENSTACK):"},{"line_number":283,"context_line":"            mode_name \u003d constants.HELM_APP_OPENSTACK"},{"line_number":284,"context_line":"        else:"},{"line_number":285,"context_line":"            mode_name \u003d name"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dc0151a1_a00669bb","line":283,"in_reply_to":"25aac603_e924879d","updated":"2022-02-21 14:37:03.000000000","message":"You are definitely right on this one. Thanks for pointing it out :)","commit_id":"cfe97473f28c795dd930521ab636b338a2d82821"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"4713db4c581af54fc1d5a41d01f19f6cf419160c","unresolved":true,"context_lines":[{"line_number":287,"context_line":"        if directive \u003d\u003d \u0027apply\u0027:"},{"line_number":288,"context_line":"            if not values:"},{"line_number":289,"context_line":"                mode \u003d None"},{"line_number":290,"context_line":"            elif mode_name not in constants.HELM_APP_APPLY_MODES:"},{"line_number":291,"context_line":"                raise wsme.exc.ClientSideError(_("},{"line_number":292,"context_line":"                    \"Application-apply rejected: Mode is not supported \""},{"line_number":293,"context_line":"                    \"for app {}.\".format(name)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d657fe3_8d19cdb2","line":290,"updated":"2022-02-21 14:21:21.000000000","message":"Not the \"mode\" name, but the \"app plugin\" name.","commit_id":"cfe97473f28c795dd930521ab636b338a2d82821"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"34eb0eb83dc73f22305ea69288c6cd0ddc19ef0a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        if directive \u003d\u003d \u0027apply\u0027:"},{"line_number":288,"context_line":"            if not values:"},{"line_number":289,"context_line":"                mode \u003d None"},{"line_number":290,"context_line":"            elif mode_name not in constants.HELM_APP_APPLY_MODES:"},{"line_number":291,"context_line":"                raise wsme.exc.ClientSideError(_("},{"line_number":292,"context_line":"                    \"Application-apply rejected: Mode is not supported \""},{"line_number":293,"context_line":"                    \"for app {}.\".format(name)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"60a30112_50e222a4","line":290,"in_reply_to":"2d657fe3_8d19cdb2","updated":"2022-02-21 14:37:03.000000000","message":"Done","commit_id":"cfe97473f28c795dd930521ab636b338a2d82821"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"4713db4c581af54fc1d5a41d01f19f6cf419160c","unresolved":true,"context_lines":[{"line_number":292,"context_line":"                    \"Application-apply rejected: Mode is not supported \""},{"line_number":293,"context_line":"                    \"for app {}.\".format(name)))"},{"line_number":294,"context_line":"            elif (values[\u0027mode\u0027] and"},{"line_number":295,"context_line":"                    values[\u0027mode\u0027] not in constants.HELM_APP_APPLY_MODES[mode_name]):"},{"line_number":296,"context_line":"                raise wsme.exc.ClientSideError(_("},{"line_number":297,"context_line":"                    \"Application-apply rejected: Mode {} for app {} is not \""},{"line_number":298,"context_line":"                    \"valid. Valid modes are {}.\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"98dd3e8b_6dfee9e7","line":295,"updated":"2022-02-21 14:21:21.000000000","message":"ditto","commit_id":"cfe97473f28c795dd930521ab636b338a2d82821"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"34eb0eb83dc73f22305ea69288c6cd0ddc19ef0a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                    \"Application-apply rejected: Mode is not supported \""},{"line_number":293,"context_line":"                    \"for app {}.\".format(name)))"},{"line_number":294,"context_line":"            elif (values[\u0027mode\u0027] and"},{"line_number":295,"context_line":"                    values[\u0027mode\u0027] not in constants.HELM_APP_APPLY_MODES[mode_name]):"},{"line_number":296,"context_line":"                raise wsme.exc.ClientSideError(_("},{"line_number":297,"context_line":"                    \"Application-apply rejected: Mode {} for app {} is not \""},{"line_number":298,"context_line":"                    \"valid. Valid modes are {}.\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"b41fd1bd_a587dbd7","line":295,"in_reply_to":"98dd3e8b_6dfee9e7","updated":"2022-02-21 14:37:03.000000000","message":"Done","commit_id":"cfe97473f28c795dd930521ab636b338a2d82821"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"4713db4c581af54fc1d5a41d01f19f6cf419160c","unresolved":true,"context_lines":[{"line_number":297,"context_line":"                    \"Application-apply rejected: Mode {} for app {} is not \""},{"line_number":298,"context_line":"                    \"valid. Valid modes are {}.\".format("},{"line_number":299,"context_line":"                        values[\u0027mode\u0027], name,"},{"line_number":300,"context_line":"                        constants.HELM_APP_APPLY_MODES[mode_name])))"},{"line_number":301,"context_line":"            else:"},{"line_number":302,"context_line":"                mode \u003d values[\u0027mode\u0027]"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa745ebc_ee5ad8db","line":300,"updated":"2022-02-21 14:21:21.000000000","message":"ditto","commit_id":"cfe97473f28c795dd930521ab636b338a2d82821"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"34eb0eb83dc73f22305ea69288c6cd0ddc19ef0a","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                    \"Application-apply rejected: Mode {} for app {} is not \""},{"line_number":298,"context_line":"                    \"valid. Valid modes are {}.\".format("},{"line_number":299,"context_line":"                        values[\u0027mode\u0027], name,"},{"line_number":300,"context_line":"                        constants.HELM_APP_APPLY_MODES[mode_name])))"},{"line_number":301,"context_line":"            else:"},{"line_number":302,"context_line":"                mode \u003d values[\u0027mode\u0027]"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"71e70ffb_a5978507","line":300,"in_reply_to":"fa745ebc_ee5ad8db","updated":"2022-02-21 14:37:03.000000000","message":"Done","commit_id":"cfe97473f28c795dd930521ab636b338a2d82821"}]}