)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"2e3422ef9f977ef82976346849d6c326966f4e1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a44276a_fd5bd62b","updated":"2022-04-05 13:08:21.000000000","message":"Probably the info log when processing the mode is un-needed, but it doesnt hurt anything, and its unlikely to spam the logs.","commit_id":"74302d2b12e462d2ec33bb7ca4fa88e46bc01061"}],"sysinv/sysinv/sysinv/sysinv/common/constants.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"9ea33555f40779258479dcd40ea2b43166117cda","unresolved":true,"context_lines":[{"line_number":1436,"context_line":"DOCKER_REGISTRY_PKCS1_KEY_FILE_SHARED \u003d os.path.join(tsc.CONFIG_PATH,"},{"line_number":1437,"context_line":"                                              \"registry-cert-pkcs1.key\")"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"OPENLDAP_CERTS_DIR \u003d \"/etc/openldap/certs\""},{"line_number":1440,"context_line":"OPENLDAP_CERT_FILE \u003d os.path.join(OPENLDAP_CERTS_DIR, \"openldap-cert.crt\")"},{"line_number":1441,"context_line":"OPENLDAP_KEY_FILE \u003d os.path.join(OPENLDAP_CERTS_DIR, \"openldap-cert.key\")"},{"line_number":1442,"context_line":"OPENLDAP_CERT_FILE_SHARED \u003d os.path.join(tsc.CONFIG_PATH,"},{"line_number":1443,"context_line":"                                                \"openldap-cert.crt\")"},{"line_number":1444,"context_line":"OPENLDAP_KEY_FILE_SHARED \u003d os.path.join(tsc.CONFIG_PATH,"},{"line_number":1445,"context_line":"                                               \"openldap-cert.key\")"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"SSL_CERT_CA_DIR \u003d \"/etc/pki/ca-trust/source/anchors/\""},{"line_number":1448,"context_line":"SSL_CERT_CA_FILE \u003d os.path.join(SSL_CERT_CA_DIR, CERT_CA_FILE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"692d6df0_c51d4d23","line":1445,"range":{"start_line":1439,"start_character":0,"end_line":1445,"end_character":67},"updated":"2022-04-04 15:33:28.000000000","message":"I don\u0027t think these constants are in use any more.","commit_id":"3f0784c829f7e13e832e542325ae7239f84c271f"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"5e67d581688f948ddc247ebd4f9c9e363229adc9","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"DOCKER_REGISTRY_PKCS1_KEY_FILE_SHARED \u003d os.path.join(tsc.CONFIG_PATH,"},{"line_number":1437,"context_line":"                                              \"registry-cert-pkcs1.key\")"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"OPENLDAP_CERTS_DIR \u003d \"/etc/openldap/certs\""},{"line_number":1440,"context_line":"OPENLDAP_CERT_FILE \u003d os.path.join(OPENLDAP_CERTS_DIR, \"openldap-cert.crt\")"},{"line_number":1441,"context_line":"OPENLDAP_KEY_FILE \u003d os.path.join(OPENLDAP_CERTS_DIR, \"openldap-cert.key\")"},{"line_number":1442,"context_line":"OPENLDAP_CERT_FILE_SHARED \u003d os.path.join(tsc.CONFIG_PATH,"},{"line_number":1443,"context_line":"                                                \"openldap-cert.crt\")"},{"line_number":1444,"context_line":"OPENLDAP_KEY_FILE_SHARED \u003d os.path.join(tsc.CONFIG_PATH,"},{"line_number":1445,"context_line":"                                               \"openldap-cert.key\")"},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"SSL_CERT_CA_DIR \u003d \"/etc/pki/ca-trust/source/anchors/\""},{"line_number":1448,"context_line":"SSL_CERT_CA_FILE \u003d os.path.join(SSL_CERT_CA_DIR, CERT_CA_FILE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"06f401b1_b32b6c85","line":1445,"range":{"start_line":1439,"start_character":0,"end_line":1445,"end_character":67},"in_reply_to":"692d6df0_c51d4d23","updated":"2022-04-04 18:33:42.000000000","message":"removed","commit_id":"3f0784c829f7e13e832e542325ae7239f84c271f"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"5f122d6bb61bdaa6f3f185e2240f1c956a8a08a7","unresolved":true,"context_lines":[{"line_number":12976,"context_line":"            LOG.info(\"OpenLDAP certificate install\")"},{"line_number":12977,"context_line":"            # install certificate, key to controllers"},{"line_number":12978,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":12979,"context_line":"            key_path \u003d constants.OPENLDAP_KEY_FILE"},{"line_number":12980,"context_line":"            cert_path \u003d constants.OPENLDAP_KEY_FILE"},{"line_number":12981,"context_line":""},{"line_number":12982,"context_line":"            private_bytes \u003d self._get_private_bytes_one(private_key)"},{"line_number":12983,"context_line":"            public_bytes \u003d self._get_public_bytes(cert_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"41fa0422_d0635c73","line":12980,"range":{"start_line":12979,"start_character":0,"end_line":12980,"end_character":51},"updated":"2022-04-01 15:43:32.000000000","message":"cert_path is the same as key_path?","commit_id":"e86aa7a4da086bbdb8595e99473a46b0813ec9a8"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"039fc4fdeb11e64ef1fbd472ddd73b47b44fe260","unresolved":false,"context_lines":[{"line_number":12976,"context_line":"            LOG.info(\"OpenLDAP certificate install\")"},{"line_number":12977,"context_line":"            # install certificate, key to controllers"},{"line_number":12978,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":12979,"context_line":"            key_path \u003d constants.OPENLDAP_KEY_FILE"},{"line_number":12980,"context_line":"            cert_path \u003d constants.OPENLDAP_KEY_FILE"},{"line_number":12981,"context_line":""},{"line_number":12982,"context_line":"            private_bytes \u003d self._get_private_bytes_one(private_key)"},{"line_number":12983,"context_line":"            public_bytes \u003d self._get_public_bytes(cert_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4997e65f_cbc5c53b","line":12980,"range":{"start_line":12979,"start_character":0,"end_line":12980,"end_character":51},"in_reply_to":"41fa0422_d0635c73","updated":"2022-04-03 23:12:06.000000000","message":"updated","commit_id":"e86aa7a4da086bbdb8595e99473a46b0813ec9a8"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"5f122d6bb61bdaa6f3f185e2240f1c956a8a08a7","unresolved":true,"context_lines":[{"line_number":12990,"context_line":"                \u0027nobackup\u0027: True,"},{"line_number":12991,"context_line":"                \u0027permissions\u0027: constants.CONFIG_FILE_PERMISSION_ROOT_READ_ONLY,"},{"line_number":12992,"context_line":"            }"},{"line_number":12993,"context_line":"            self._config_update_file(context, config_uuid, config_dict)"},{"line_number":12994,"context_line":""},{"line_number":12995,"context_line":"            # copy certificate to shared directory"},{"line_number":12996,"context_line":"            with os.fdopen(os.open(constants.OPENLDAP_CERT_FILE_SHARED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5f30cd9_c3f7328a","line":12993,"range":{"start_line":12993,"start_character":12,"end_line":12993,"end_character":71},"updated":"2022-04-01 15:43:32.000000000","message":"I thinks this call will save the cert/key to the destination directory of both controllers. You can either use this call to save them, or you can retrieve the cert/key from secret and save them to the destination in puppet manifests (which you did). But you don\u0027t have to do both.","commit_id":"e86aa7a4da086bbdb8595e99473a46b0813ec9a8"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"039fc4fdeb11e64ef1fbd472ddd73b47b44fe260","unresolved":false,"context_lines":[{"line_number":12990,"context_line":"                \u0027nobackup\u0027: True,"},{"line_number":12991,"context_line":"                \u0027permissions\u0027: constants.CONFIG_FILE_PERMISSION_ROOT_READ_ONLY,"},{"line_number":12992,"context_line":"            }"},{"line_number":12993,"context_line":"            self._config_update_file(context, config_uuid, config_dict)"},{"line_number":12994,"context_line":""},{"line_number":12995,"context_line":"            # copy certificate to shared directory"},{"line_number":12996,"context_line":"            with os.fdopen(os.open(constants.OPENLDAP_CERT_FILE_SHARED,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0042ea5e_6779795c","line":12993,"range":{"start_line":12993,"start_character":12,"end_line":12993,"end_character":71},"in_reply_to":"d5f30cd9_c3f7328a","updated":"2022-04-03 23:12:06.000000000","message":"Removed.","commit_id":"e86aa7a4da086bbdb8595e99473a46b0813ec9a8"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"5f122d6bb61bdaa6f3f185e2240f1c956a8a08a7","unresolved":true,"context_lines":[{"line_number":12992,"context_line":"            }"},{"line_number":12993,"context_line":"            self._config_update_file(context, config_uuid, config_dict)"},{"line_number":12994,"context_line":""},{"line_number":12995,"context_line":"            # copy certificate to shared directory"},{"line_number":12996,"context_line":"            with os.fdopen(os.open(constants.OPENLDAP_CERT_FILE_SHARED,"},{"line_number":12997,"context_line":"                                   os.O_CREAT | os.O_TRUNC | os.O_WRONLY,"},{"line_number":12998,"context_line":"                                   constants.CONFIG_FILE_PERMISSION_ROOT_READ_ONLY),"},{"line_number":12999,"context_line":"                                   \u0027wb\u0027) as f:"},{"line_number":13000,"context_line":"                f.write(public_bytes)"},{"line_number":13001,"context_line":"            with os.fdopen(os.open(constants.OPENLDAP_KEY_FILE_SHARED,"},{"line_number":13002,"context_line":"                                   os.O_CREAT | os.O_TRUNC | os.O_WRONLY,"},{"line_number":13003,"context_line":"                                   constants.CONFIG_FILE_PERMISSION_ROOT_READ_ONLY),"},{"line_number":13004,"context_line":"                                   \u0027wb\u0027) as f:"},{"line_number":13005,"context_line":"                f.write(private_bytes)"},{"line_number":13006,"context_line":""},{"line_number":13007,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":13008,"context_line":"            config_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"b20ca06c_88a68807","line":13005,"range":{"start_line":12995,"start_character":1,"end_line":13005,"end_character":38},"updated":"2022-04-01 15:43:32.000000000","message":"I don\u0027t think we need to store the cert/key in the shared directory. They are secret and are accessible on both controllers.","commit_id":"e86aa7a4da086bbdb8595e99473a46b0813ec9a8"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"039fc4fdeb11e64ef1fbd472ddd73b47b44fe260","unresolved":false,"context_lines":[{"line_number":12992,"context_line":"            }"},{"line_number":12993,"context_line":"            self._config_update_file(context, config_uuid, config_dict)"},{"line_number":12994,"context_line":""},{"line_number":12995,"context_line":"            # copy certificate to shared directory"},{"line_number":12996,"context_line":"            with os.fdopen(os.open(constants.OPENLDAP_CERT_FILE_SHARED,"},{"line_number":12997,"context_line":"                                   os.O_CREAT | os.O_TRUNC | os.O_WRONLY,"},{"line_number":12998,"context_line":"                                   constants.CONFIG_FILE_PERMISSION_ROOT_READ_ONLY),"},{"line_number":12999,"context_line":"                                   \u0027wb\u0027) as f:"},{"line_number":13000,"context_line":"                f.write(public_bytes)"},{"line_number":13001,"context_line":"            with os.fdopen(os.open(constants.OPENLDAP_KEY_FILE_SHARED,"},{"line_number":13002,"context_line":"                                   os.O_CREAT | os.O_TRUNC | os.O_WRONLY,"},{"line_number":13003,"context_line":"                                   constants.CONFIG_FILE_PERMISSION_ROOT_READ_ONLY),"},{"line_number":13004,"context_line":"                                   \u0027wb\u0027) as f:"},{"line_number":13005,"context_line":"                f.write(private_bytes)"},{"line_number":13006,"context_line":""},{"line_number":13007,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":13008,"context_line":"            config_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"37ebcc16_e846f505","line":13005,"range":{"start_line":12995,"start_character":1,"end_line":13005,"end_character":38},"in_reply_to":"b20ca06c_88a68807","updated":"2022-04-03 23:12:06.000000000","message":"Removed","commit_id":"e86aa7a4da086bbdb8595e99473a46b0813ec9a8"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"5c6639bf46dcb5011981be0e02c615e6d48e8438","unresolved":true,"context_lines":[{"line_number":12974,"context_line":"            self._config_update_file(context, config_uuid, config_dict)"},{"line_number":12975,"context_line":"        elif mode \u003d\u003d constants.CERT_MODE_OPENLDAP:"},{"line_number":12976,"context_line":"            LOG.info(\"OpenLDAP certificate install\")"},{"line_number":12977,"context_line":"            # install certificate, key to controllers"},{"line_number":12978,"context_line":"            key_path \u003d constants.OPENLDAP_KEY_FILE"},{"line_number":12979,"context_line":"            cert_path \u003d constants.OPENLDAP_CERT_FILE"},{"line_number":12980,"context_line":""},{"line_number":12981,"context_line":"            private_bytes \u003d self._get_private_bytes_one(private_key)"},{"line_number":12982,"context_line":"            public_bytes \u003d self._get_public_bytes(cert_list)"},{"line_number":12983,"context_line":""},{"line_number":12984,"context_line":"            config_dict \u003d {"},{"line_number":12985,"context_line":"                \u0027personalities\u0027: personalities,"},{"line_number":12986,"context_line":"                \u0027file_names\u0027: [key_path, cert_path],"},{"line_number":12987,"context_line":"                \u0027file_content\u0027: {key_path: private_bytes,"},{"line_number":12988,"context_line":"                                 cert_path: public_bytes},"},{"line_number":12989,"context_line":"                \u0027nobackup\u0027: True,"},{"line_number":12990,"context_line":"                \u0027permissions\u0027: constants.CONFIG_FILE_PERMISSION_ROOT_READ_ONLY,"},{"line_number":12991,"context_line":"            }"},{"line_number":12992,"context_line":""},{"line_number":12993,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":12994,"context_line":"            config_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"17977c5a_07e2fb29","line":12991,"range":{"start_line":12977,"start_character":0,"end_line":12991,"end_character":13},"updated":"2022-04-04 15:29:09.000000000","message":"I think the block from line 12977 to line 12991 can be removed.","commit_id":"3f0784c829f7e13e832e542325ae7239f84c271f"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"5e67d581688f948ddc247ebd4f9c9e363229adc9","unresolved":false,"context_lines":[{"line_number":12974,"context_line":"            self._config_update_file(context, config_uuid, config_dict)"},{"line_number":12975,"context_line":"        elif mode \u003d\u003d constants.CERT_MODE_OPENLDAP:"},{"line_number":12976,"context_line":"            LOG.info(\"OpenLDAP certificate install\")"},{"line_number":12977,"context_line":"            # install certificate, key to controllers"},{"line_number":12978,"context_line":"            key_path \u003d constants.OPENLDAP_KEY_FILE"},{"line_number":12979,"context_line":"            cert_path \u003d constants.OPENLDAP_CERT_FILE"},{"line_number":12980,"context_line":""},{"line_number":12981,"context_line":"            private_bytes \u003d self._get_private_bytes_one(private_key)"},{"line_number":12982,"context_line":"            public_bytes \u003d self._get_public_bytes(cert_list)"},{"line_number":12983,"context_line":""},{"line_number":12984,"context_line":"            config_dict \u003d {"},{"line_number":12985,"context_line":"                \u0027personalities\u0027: personalities,"},{"line_number":12986,"context_line":"                \u0027file_names\u0027: [key_path, cert_path],"},{"line_number":12987,"context_line":"                \u0027file_content\u0027: {key_path: private_bytes,"},{"line_number":12988,"context_line":"                                 cert_path: public_bytes},"},{"line_number":12989,"context_line":"                \u0027nobackup\u0027: True,"},{"line_number":12990,"context_line":"                \u0027permissions\u0027: constants.CONFIG_FILE_PERMISSION_ROOT_READ_ONLY,"},{"line_number":12991,"context_line":"            }"},{"line_number":12992,"context_line":""},{"line_number":12993,"context_line":"            config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":12994,"context_line":"            config_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9329b1a1_aceb7693","line":12991,"range":{"start_line":12977,"start_character":0,"end_line":12991,"end_character":13},"in_reply_to":"17977c5a_07e2fb29","updated":"2022-04-04 18:33:42.000000000","message":"removed","commit_id":"3f0784c829f7e13e832e542325ae7239f84c271f"}]}