)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"09e7fb28948b6727b68e977f33f5cc7e7a298728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d1733df1_71d58ef3","updated":"2022-04-05 14:49:29.000000000","message":"Will add test results to the commit message.","commit_id":"2d5e0b865b95c4aaacd81f55778c1f5ebdc19d25"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/pci_device.py":[{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"7af1de9243b9ced4fde041fe24f626c5f29d8ca1","unresolved":true,"context_lines":[{"line_number":424,"context_line":"                                                                hostid\u003dhost[\u0027id\u0027])"},{"line_number":425,"context_line":"            if (current_device[\u0027sriov_vf_driver\u0027] is not None or"},{"line_number":426,"context_line":"                    current_device[\u0027sriov_numvfs\u0027] !\u003d 0):"},{"line_number":427,"context_line":"                msg \u003d (_(\"The SR-IOV VF driver must first be set to {} and \""},{"line_number":428,"context_line":"                         \"the number of VFs set to 0 before setting the PF \""},{"line_number":429,"context_line":"                         \"driver to {}.  Current values: \""},{"line_number":430,"context_line":"                         \"sriov_vf_driver: {}, sriov_numvfs: {}\").format("},{"line_number":431,"context_line":"                         dconstants.FPGA_INTEL_5GNR_FEC_DRIVER_NONE,"},{"line_number":432,"context_line":"                         dconstants.FPGA_INTEL_5GNR_FEC_DRIVER_NONE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1837599_e123e58a","line":429,"range":{"start_line":427,"start_character":26,"end_line":429,"end_character":38},"updated":"2022-04-05 17:02:25.000000000","message":"Do you think some user could be messed by this message since he/she indeed set those values (they are now in \"extra_info\") but they were not applied to device yet? Should we be more specific about where is happening the mismatch?","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"9766f17057843e1e16f1da48203266d4e1fc05eb","unresolved":true,"context_lines":[{"line_number":424,"context_line":"                                                                hostid\u003dhost[\u0027id\u0027])"},{"line_number":425,"context_line":"            if (current_device[\u0027sriov_vf_driver\u0027] is not None or"},{"line_number":426,"context_line":"                    current_device[\u0027sriov_numvfs\u0027] !\u003d 0):"},{"line_number":427,"context_line":"                msg \u003d (_(\"The SR-IOV VF driver must first be set to {} and \""},{"line_number":428,"context_line":"                         \"the number of VFs set to 0 before setting the PF \""},{"line_number":429,"context_line":"                         \"driver to {}.  Current values: \""},{"line_number":430,"context_line":"                         \"sriov_vf_driver: {}, sriov_numvfs: {}\").format("},{"line_number":431,"context_line":"                         dconstants.FPGA_INTEL_5GNR_FEC_DRIVER_NONE,"},{"line_number":432,"context_line":"                         dconstants.FPGA_INTEL_5GNR_FEC_DRIVER_NONE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dd1bd6ab_bd195adf","line":429,"range":{"start_line":427,"start_character":26,"end_line":429,"end_character":38},"in_reply_to":"c1837599_e123e58a","updated":"2022-04-06 10:05:13.000000000","message":"I think there shouldn\u0027t be any confusion as these values won\u0027t even make it to the extra_info.  That is, this semantic check will be performed before any write to DB. If this check gets triggered, a system host-device-show \u003chost\u003e \u003cdevice\u003e will show exactly the same parameters as what were present before the command was run.","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"001e59dc8b616f2fda8a4c651d8a73159b399061","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                                                                hostid\u003dhost[\u0027id\u0027])"},{"line_number":425,"context_line":"            if (current_device[\u0027sriov_vf_driver\u0027] is not None or"},{"line_number":426,"context_line":"                    current_device[\u0027sriov_numvfs\u0027] !\u003d 0):"},{"line_number":427,"context_line":"                msg \u003d (_(\"The SR-IOV VF driver must first be set to {} and \""},{"line_number":428,"context_line":"                         \"the number of VFs set to 0 before setting the PF \""},{"line_number":429,"context_line":"                         \"driver to {}.  Current values: \""},{"line_number":430,"context_line":"                         \"sriov_vf_driver: {}, sriov_numvfs: {}\").format("},{"line_number":431,"context_line":"                         dconstants.FPGA_INTEL_5GNR_FEC_DRIVER_NONE,"},{"line_number":432,"context_line":"                         dconstants.FPGA_INTEL_5GNR_FEC_DRIVER_NONE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1eec60b_eee90509","line":429,"range":{"start_line":427,"start_character":26,"end_line":429,"end_character":38},"in_reply_to":"dd1bd6ab_bd195adf","updated":"2022-04-06 12:00:50.000000000","message":"Ack","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"7af1de9243b9ced4fde041fe24f626c5f29d8ca1","unresolved":true,"context_lines":[{"line_number":433,"context_line":"                         current_device[\u0027sriov_vf_driver\u0027],"},{"line_number":434,"context_line":"                         current_device[\u0027sriov_numvfs\u0027]))"},{"line_number":435,"context_line":"                raise wsme.exc.ClientSideError(msg)"},{"line_number":436,"context_line":"            if (current_device[\u0027sriov_vf_driver\u0027] is None and"},{"line_number":437,"context_line":"                    current_device[\u0027sriov_numvfs\u0027] \u003d\u003d 0 and"},{"line_number":438,"context_line":"                    current_device[\u0027sriov_vfs_pci_address\u0027].count(\u0027,\u0027) \u003e 0):"},{"line_number":439,"context_line":"                # This catches the case of the VF driver and number of VFs being"},{"line_number":440,"context_line":"                # reset to None/0, but before the information has been reported"},{"line_number":441,"context_line":"                # to the sysinv conductor.  This is a similar check that is done"},{"line_number":442,"context_line":"                # when trying to unlock a host before the SR-IOV configuration has"}],"source_content_type":"text/x-python","patch_set":2,"id":"3716422b_e55b85c4","line":439,"range":{"start_line":436,"start_character":0,"end_line":439,"end_character":0},"updated":"2022-04-05 17:02:25.000000000","message":"nit: This could be replaced by:\n\n  elif current_device[\u0027sriov_vfs_pci_address\u0027].count(\u0027,\u0027) \u003e 0:","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"9766f17057843e1e16f1da48203266d4e1fc05eb","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                         current_device[\u0027sriov_vf_driver\u0027],"},{"line_number":434,"context_line":"                         current_device[\u0027sriov_numvfs\u0027]))"},{"line_number":435,"context_line":"                raise wsme.exc.ClientSideError(msg)"},{"line_number":436,"context_line":"            if (current_device[\u0027sriov_vf_driver\u0027] is None and"},{"line_number":437,"context_line":"                    current_device[\u0027sriov_numvfs\u0027] \u003d\u003d 0 and"},{"line_number":438,"context_line":"                    current_device[\u0027sriov_vfs_pci_address\u0027].count(\u0027,\u0027) \u003e 0):"},{"line_number":439,"context_line":"                # This catches the case of the VF driver and number of VFs being"},{"line_number":440,"context_line":"                # reset to None/0, but before the information has been reported"},{"line_number":441,"context_line":"                # to the sysinv conductor.  This is a similar check that is done"},{"line_number":442,"context_line":"                # when trying to unlock a host before the SR-IOV configuration has"}],"source_content_type":"text/x-python","patch_set":2,"id":"6e2a6eb1_912a343d","line":439,"range":{"start_line":436,"start_character":0,"end_line":439,"end_character":0},"in_reply_to":"3716422b_e55b85c4","updated":"2022-04-06 10:05:13.000000000","message":"Done","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"7af1de9243b9ced4fde041fe24f626c5f29d8ca1","unresolved":true,"context_lines":[{"line_number":463,"context_line":"            raise wsme.exc.ClientSideError(_("},{"line_number":464,"context_line":"                \"The value for number of SR-IOV VFs must be \u003e 0 \""},{"line_number":465,"context_line":"                \"when the VF driver is {}\").format(device[\u0027sriov_vf_driver\u0027]))"},{"line_number":466,"context_line":"        if (\u0027driver\u0027 in device.keys() and not device[\u0027driver\u0027] and"},{"line_number":467,"context_line":"                device[\u0027sriov_numvfs\u0027] \u003e 0):"},{"line_number":468,"context_line":"            raise wsme.exc.ClientSideError(_("},{"line_number":469,"context_line":"                \"The SR-IOV PF driver must not be None to set the number of VFs.\"))"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if \u0027sriov_totalvfs\u0027 in device.keys():"},{"line_number":472,"context_line":"            if not device[\u0027sriov_totalvfs\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"d1fe457a_2b1f31e6","line":469,"range":{"start_line":466,"start_character":0,"end_line":469,"end_character":74},"updated":"2022-04-05 17:02:25.000000000","message":"Shouldn\u0027t we have a similar test below (for sriov_vf_driver!\u003dNone)?","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"001e59dc8b616f2fda8a4c651d8a73159b399061","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            raise wsme.exc.ClientSideError(_("},{"line_number":464,"context_line":"                \"The value for number of SR-IOV VFs must be \u003e 0 \""},{"line_number":465,"context_line":"                \"when the VF driver is {}\").format(device[\u0027sriov_vf_driver\u0027]))"},{"line_number":466,"context_line":"        if (\u0027driver\u0027 in device.keys() and not device[\u0027driver\u0027] and"},{"line_number":467,"context_line":"                device[\u0027sriov_numvfs\u0027] \u003e 0):"},{"line_number":468,"context_line":"            raise wsme.exc.ClientSideError(_("},{"line_number":469,"context_line":"                \"The SR-IOV PF driver must not be None to set the number of VFs.\"))"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if \u0027sriov_totalvfs\u0027 in device.keys():"},{"line_number":472,"context_line":"            if not device[\u0027sriov_totalvfs\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"351793aa_b632907e","line":469,"range":{"start_line":466,"start_character":0,"end_line":469,"end_character":74},"in_reply_to":"1252f1b2_0199ba17","updated":"2022-04-06 12:00:50.000000000","message":"Ack","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"9766f17057843e1e16f1da48203266d4e1fc05eb","unresolved":true,"context_lines":[{"line_number":463,"context_line":"            raise wsme.exc.ClientSideError(_("},{"line_number":464,"context_line":"                \"The value for number of SR-IOV VFs must be \u003e 0 \""},{"line_number":465,"context_line":"                \"when the VF driver is {}\").format(device[\u0027sriov_vf_driver\u0027]))"},{"line_number":466,"context_line":"        if (\u0027driver\u0027 in device.keys() and not device[\u0027driver\u0027] and"},{"line_number":467,"context_line":"                device[\u0027sriov_numvfs\u0027] \u003e 0):"},{"line_number":468,"context_line":"            raise wsme.exc.ClientSideError(_("},{"line_number":469,"context_line":"                \"The SR-IOV PF driver must not be None to set the number of VFs.\"))"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if \u0027sriov_totalvfs\u0027 in device.keys():"},{"line_number":472,"context_line":"            if not device[\u0027sriov_totalvfs\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1252f1b2_0199ba17","line":469,"range":{"start_line":466,"start_character":0,"end_line":469,"end_character":74},"in_reply_to":"d1fe457a_2b1f31e6","updated":"2022-04-06 10:05:13.000000000","message":"This is a good question, but actually another semantic check is going to kick in for this case on L463.  So if the driver is already None and one tries to set the VF driver, they will get \"The value for number of SR-IOV VFs must be \u003e 0 when the VF driver is \u003cdriver\u003e\".  If they try to set the number of VFs (with or without the VF driver specified) while the PF driver is None, they will get this new semantic check.","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"}],"sysinv/sysinv/sysinv/sysinv/tests/api/test_device.py":[{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"7af1de9243b9ced4fde041fe24f626c5f29d8ca1","unresolved":true,"context_lines":[{"line_number":356,"context_line":"            sriov_numvfs\u003d2)"},{"line_number":357,"context_line":"        response \u003d self.patch_dict_json("},{"line_number":358,"context_line":"            \u0027%s\u0027 % self._get_path(self.pci_device[\u0027uuid\u0027]),"},{"line_number":359,"context_line":"            sriov_vf_driver\u003d\u0027igb_uio\u0027,"},{"line_number":360,"context_line":"            expect_errors\u003dFalse)"},{"line_number":361,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":362,"context_line":"        self.assertEqual(http_client.OK, response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6fd1594b_1d18e24d","line":359,"range":{"start_line":359,"start_character":29,"end_line":359,"end_character":36},"updated":"2022-04-05 17:02:25.000000000","message":"In fact, from now you\u0027re modifying nothing in VF driver, right? Seems this test case became useless.","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"001e59dc8b616f2fda8a4c651d8a73159b399061","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            sriov_numvfs\u003d2)"},{"line_number":357,"context_line":"        response \u003d self.patch_dict_json("},{"line_number":358,"context_line":"            \u0027%s\u0027 % self._get_path(self.pci_device[\u0027uuid\u0027]),"},{"line_number":359,"context_line":"            sriov_vf_driver\u003d\u0027igb_uio\u0027,"},{"line_number":360,"context_line":"            expect_errors\u003dFalse)"},{"line_number":361,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":362,"context_line":"        self.assertEqual(http_client.OK, response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"34e8d4ba_4f204714","line":359,"range":{"start_line":359,"start_character":29,"end_line":359,"end_character":36},"in_reply_to":"6fd1594b_1d18e24d","updated":"2022-04-06 12:00:50.000000000","message":"Ack","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"7af1de9243b9ced4fde041fe24f626c5f29d8ca1","unresolved":true,"context_lines":[{"line_number":397,"context_line":"        response \u003d self.patch_dict_json("},{"line_number":398,"context_line":"            \u0027%s\u0027 % self._get_path(self.pci_device[\u0027uuid\u0027]),"},{"line_number":399,"context_line":"            sriov_vf_driver\u003d\u0027bad\u0027,"},{"line_number":400,"context_line":"            driver\u003d\u0027igb_uio\u0027,"},{"line_number":401,"context_line":"            sriov_numvfs\u003d2,"},{"line_number":402,"context_line":"            expect_errors\u003dTrue)"},{"line_number":403,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aba0286_1720d879","line":400,"updated":"2022-04-05 17:02:25.000000000","message":"nit: Maybe this line should be moved one line up, to be like all other tests.","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"9766f17057843e1e16f1da48203266d4e1fc05eb","unresolved":true,"context_lines":[{"line_number":397,"context_line":"        response \u003d self.patch_dict_json("},{"line_number":398,"context_line":"            \u0027%s\u0027 % self._get_path(self.pci_device[\u0027uuid\u0027]),"},{"line_number":399,"context_line":"            sriov_vf_driver\u003d\u0027bad\u0027,"},{"line_number":400,"context_line":"            driver\u003d\u0027igb_uio\u0027,"},{"line_number":401,"context_line":"            sriov_numvfs\u003d2,"},{"line_number":402,"context_line":"            expect_errors\u003dTrue)"},{"line_number":403,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"97b21c2d_44d98080","line":400,"in_reply_to":"1aba0286_1720d879","updated":"2022-04-06 10:05:13.000000000","message":"Ha! Absolutely correct. Fixed.","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"001e59dc8b616f2fda8a4c651d8a73159b399061","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        response \u003d self.patch_dict_json("},{"line_number":398,"context_line":"            \u0027%s\u0027 % self._get_path(self.pci_device[\u0027uuid\u0027]),"},{"line_number":399,"context_line":"            sriov_vf_driver\u003d\u0027bad\u0027,"},{"line_number":400,"context_line":"            driver\u003d\u0027igb_uio\u0027,"},{"line_number":401,"context_line":"            sriov_numvfs\u003d2,"},{"line_number":402,"context_line":"            expect_errors\u003dTrue)"},{"line_number":403,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"14147945_9bd207fe","line":400,"in_reply_to":"97b21c2d_44d98080","updated":"2022-04-06 12:00:50.000000000","message":"Ack","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"08e24f338ea590795ad12fc580dce320463a3c60","unresolved":true,"context_lines":[{"line_number":447,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":448,"context_line":"        self.assertIn(\u0027is unlocked for the first time\u0027, response.json[\u0027error_message\u0027])"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    def test_device_modify_sriov_reset_all(self):"},{"line_number":451,"context_line":"        self.pci_device \u003d dbutils.create_test_pci_device("},{"line_number":452,"context_line":"            host_id\u003dself.worker.id,"},{"line_number":453,"context_line":"            pclass_id\u003dself.pclass_id,"},{"line_number":454,"context_line":"            pdevice_id\u003ddconstants.PCI_DEVICE_ID_FPGA_INTEL_5GNR_FEC_PF,"},{"line_number":455,"context_line":"            driver\u003d\u0027igb_uio\u0027,"},{"line_number":456,"context_line":"            sriov_vf_driver\u003d\u0027igb_uio\u0027,"},{"line_number":457,"context_line":"            sriov_totalvfs\u003d8,"},{"line_number":458,"context_line":"            sriov_numvfs\u003d2)"},{"line_number":459,"context_line":"        response \u003d self.patch_dict_json("},{"line_number":460,"context_line":"            \u0027%s\u0027 % self._get_path(self.pci_device[\u0027uuid\u0027]),"},{"line_number":461,"context_line":"            driver\u003d\u0027none\u0027,"},{"line_number":462,"context_line":"            sriov_vf_driver\u003d\u0027none\u0027,"},{"line_number":463,"context_line":"            sriov_numvfs\u003d0,"},{"line_number":464,"context_line":"            expect_errors\u003dTrue)"},{"line_number":465,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"},{"line_number":466,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":467,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":468,"context_line":"        self.assertIn(\u0027The SR-IOV VF driver must first be set to none and the number \u0027"},{"line_number":469,"context_line":"                      \u0027of VFs set to 0 before setting the PF driver to none.  \u0027"},{"line_number":470,"context_line":"                      \u0027Current values: sriov_vf_driver: igb_uio, sriov_numvfs: 2\u0027,"},{"line_number":471,"context_line":"                      response.json[\u0027error_message\u0027])"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    def test_device_modify_sriov_set_numvfs_no_pf_driver(self):"},{"line_number":474,"context_line":"        self.pci_device \u003d dbutils.create_test_pci_device("},{"line_number":475,"context_line":"            host_id\u003dself.worker.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"63a0acef_dca87d06","line":472,"range":{"start_line":450,"start_character":0,"end_line":472,"end_character":0},"updated":"2022-04-05 16:50:09.000000000","message":"I think you should add a test to check the correct processing\n\nGiven the database is already in \n  driver\u003digb_uio,\n  sriov_vf_driver\u003digb_uio,\n  sriov_num_vfs\u003d2\n  sriov_totalvfs\u003d8\n\nWhen you send \n  sriov_vf_driver\u003d\u0027none\u0027,\n  sriov_num_vfs\u003d0\nThen no errors should be received\n\nWhen you send \n  driver\u003d\u0027none\u0027,\nThen no errors should be received\n\nUnless it is already done on other part","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"9766f17057843e1e16f1da48203266d4e1fc05eb","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":448,"context_line":"        self.assertIn(\u0027is unlocked for the first time\u0027, response.json[\u0027error_message\u0027])"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    def test_device_modify_sriov_reset_all(self):"},{"line_number":451,"context_line":"        self.pci_device \u003d dbutils.create_test_pci_device("},{"line_number":452,"context_line":"            host_id\u003dself.worker.id,"},{"line_number":453,"context_line":"            pclass_id\u003dself.pclass_id,"},{"line_number":454,"context_line":"            pdevice_id\u003ddconstants.PCI_DEVICE_ID_FPGA_INTEL_5GNR_FEC_PF,"},{"line_number":455,"context_line":"            driver\u003d\u0027igb_uio\u0027,"},{"line_number":456,"context_line":"            sriov_vf_driver\u003d\u0027igb_uio\u0027,"},{"line_number":457,"context_line":"            sriov_totalvfs\u003d8,"},{"line_number":458,"context_line":"            sriov_numvfs\u003d2)"},{"line_number":459,"context_line":"        response \u003d self.patch_dict_json("},{"line_number":460,"context_line":"            \u0027%s\u0027 % self._get_path(self.pci_device[\u0027uuid\u0027]),"},{"line_number":461,"context_line":"            driver\u003d\u0027none\u0027,"},{"line_number":462,"context_line":"            sriov_vf_driver\u003d\u0027none\u0027,"},{"line_number":463,"context_line":"            sriov_numvfs\u003d0,"},{"line_number":464,"context_line":"            expect_errors\u003dTrue)"},{"line_number":465,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"},{"line_number":466,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":467,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":468,"context_line":"        self.assertIn(\u0027The SR-IOV VF driver must first be set to none and the number \u0027"},{"line_number":469,"context_line":"                      \u0027of VFs set to 0 before setting the PF driver to none.  \u0027"},{"line_number":470,"context_line":"                      \u0027Current values: sriov_vf_driver: igb_uio, sriov_numvfs: 2\u0027,"},{"line_number":471,"context_line":"                      response.json[\u0027error_message\u0027])"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    def test_device_modify_sriov_set_numvfs_no_pf_driver(self):"},{"line_number":474,"context_line":"        self.pci_device \u003d dbutils.create_test_pci_device("},{"line_number":475,"context_line":"            host_id\u003dself.worker.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad5c44c_4a03a8b4","line":472,"range":{"start_line":450,"start_character":0,"end_line":472,"end_character":0},"in_reply_to":"63a0acef_dca87d06","updated":"2022-04-06 10:05:13.000000000","message":"Done","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"7af1de9243b9ced4fde041fe24f626c5f29d8ca1","unresolved":true,"context_lines":[{"line_number":480,"context_line":"            sriov_numvfs\u003d2)"},{"line_number":481,"context_line":"        response \u003d self.patch_dict_json("},{"line_number":482,"context_line":"            \u0027%s\u0027 % self._get_path(self.pci_device[\u0027uuid\u0027]),"},{"line_number":483,"context_line":"            sriov_vf_driver\u003d\u0027none\u0027,"},{"line_number":484,"context_line":"            sriov_numvfs\u003d4,"},{"line_number":485,"context_line":"            expect_errors\u003dTrue)"},{"line_number":486,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef87b41d_70f6e2bd","line":483,"updated":"2022-04-05 17:02:25.000000000","message":"Should we have another test case for when driver\u003dNone and you set only sriov_vf_driver!\u003dNone (without changing the number of VFs)?","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"9766f17057843e1e16f1da48203266d4e1fc05eb","unresolved":false,"context_lines":[{"line_number":480,"context_line":"            sriov_numvfs\u003d2)"},{"line_number":481,"context_line":"        response \u003d self.patch_dict_json("},{"line_number":482,"context_line":"            \u0027%s\u0027 % self._get_path(self.pci_device[\u0027uuid\u0027]),"},{"line_number":483,"context_line":"            sriov_vf_driver\u003d\u0027none\u0027,"},{"line_number":484,"context_line":"            sriov_numvfs\u003d4,"},{"line_number":485,"context_line":"            expect_errors\u003dTrue)"},{"line_number":486,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0cb25802_2e5146df","line":483,"in_reply_to":"ef87b41d_70f6e2bd","updated":"2022-04-06 10:05:13.000000000","message":"Done","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":32932,"name":"Douglas Henrique Koerich","display_name":"Douglas Koerich","email":"douglashenrique.koerich@windriver.com","username":"dkoerich"},"change_message_id":"7af1de9243b9ced4fde041fe24f626c5f29d8ca1","unresolved":true,"context_lines":[{"line_number":490,"context_line":"                      \u0027of VFs.\u0027,"},{"line_number":491,"context_line":"                      response.json[\u0027error_message\u0027])"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_device_modify_sriov_set_vf_driver_no_pf_driver(self):"},{"line_number":494,"context_line":"        self.pci_device \u003d dbutils.create_test_pci_device("},{"line_number":495,"context_line":"            host_id\u003dself.worker.id,"},{"line_number":496,"context_line":"            pclass_id\u003dself.pclass_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b00dd00_999253f5","line":493,"range":{"start_line":493,"start_character":33,"end_line":493,"end_character":59},"updated":"2022-04-05 17:02:25.000000000","message":"Seems like it should be: test_device_modify_sriov_set_numvfs_no_vf_driver","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"9766f17057843e1e16f1da48203266d4e1fc05eb","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                      \u0027of VFs.\u0027,"},{"line_number":491,"context_line":"                      response.json[\u0027error_message\u0027])"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_device_modify_sriov_set_vf_driver_no_pf_driver(self):"},{"line_number":494,"context_line":"        self.pci_device \u003d dbutils.create_test_pci_device("},{"line_number":495,"context_line":"            host_id\u003dself.worker.id,"},{"line_number":496,"context_line":"            pclass_id\u003dself.pclass_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"cba7ed79_1abb78ee","line":493,"range":{"start_line":493,"start_character":33,"end_line":493,"end_character":59},"in_reply_to":"9b00dd00_999253f5","updated":"2022-04-06 10:05:13.000000000","message":"Done","commit_id":"b50f2ae7263147c43c9c9bc10bbb66ca3e6cb574"}]}