)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"88d876d8ba869bcda1361488805b860ee2422417","unresolved":true,"context_lines":[{"line_number":15,"context_line":"service-parameter apply must fail."},{"line_number":16,"context_line":"- WIP: When an exist file is set in audit-policy-file,"},{"line_number":17,"context_line":"service-parameter apply must work and apply the changes."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Story: 2009766"},{"line_number":20,"context_line":"Task: 45074"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e25b2bc1_b87e8ca0","line":18,"updated":"2022-04-21 18:14:31.000000000","message":"should add a test with an existing-but-invalid file.","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"94cb306ff7d06974a2a9a50b4594e16ca1c0c733","unresolved":true,"context_lines":[{"line_number":15,"context_line":"service-parameter apply must fail."},{"line_number":16,"context_line":"- WIP: When an exist file is set in audit-policy-file,"},{"line_number":17,"context_line":"service-parameter apply must work and apply the changes."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Story: 2009766"},{"line_number":20,"context_line":"Task: 45074"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4195f392_6cf57d14","line":18,"in_reply_to":"3e9fa87a_cfae0dd2","updated":"2022-04-28 13:47:59.000000000","message":"I don\u0027t think that setting a null is suffice to recover, due to stx-puppet needs to run some kubectl parameter to update control-plane components.\nI guess a workaround should be remove the audi-policy-file line from /etc/kubernetes/manifests/kube-apiserver.yaml and wait until kube-apiserver restart itself","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"e4fed00e7ce25cff11e18793a90e4249db5467cc","unresolved":true,"context_lines":[{"line_number":15,"context_line":"service-parameter apply must fail."},{"line_number":16,"context_line":"- WIP: When an exist file is set in audit-policy-file,"},{"line_number":17,"context_line":"service-parameter apply must work and apply the changes."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Story: 2009766"},{"line_number":20,"context_line":"Task: 45074"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"db44c134_9c023a17","line":18,"in_reply_to":"4195f392_6cf57d14","updated":"2022-04-28 14:21:04.000000000","message":"please confirm recovery and add to TestPlan.  If not system alternative; will need to doc.","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"358016ea101a9202e228293bf114257ad98a4241","unresolved":false,"context_lines":[{"line_number":15,"context_line":"service-parameter apply must fail."},{"line_number":16,"context_line":"- WIP: When an exist file is set in audit-policy-file,"},{"line_number":17,"context_line":"service-parameter apply must work and apply the changes."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Story: 2009766"},{"line_number":20,"context_line":"Task: 45074"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5372be13_426a1842","line":18,"in_reply_to":"db44c134_9c023a17","updated":"2022-04-29 18:37:59.000000000","message":"Done","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"0930bfe37a2bd9e13aae627e4b341ec707881c68","unresolved":true,"context_lines":[{"line_number":15,"context_line":"service-parameter apply must fail."},{"line_number":16,"context_line":"- WIP: When an exist file is set in audit-policy-file,"},{"line_number":17,"context_line":"service-parameter apply must work and apply the changes."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Story: 2009766"},{"line_number":20,"context_line":"Task: 45074"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fd25a8ab_be770f0c","line":18,"in_reply_to":"e25b2bc1_b87e8ca0","updated":"2022-04-26 18:10:08.000000000","message":"if existing-but-invalid file is set to the parameter, kube-apiserver will fail at start after applying configuration.","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"1a3f650394c4c8246c13606c4eae71fcaae31b85","unresolved":true,"context_lines":[{"line_number":15,"context_line":"service-parameter apply must fail."},{"line_number":16,"context_line":"- WIP: When an exist file is set in audit-policy-file,"},{"line_number":17,"context_line":"service-parameter apply must work and apply the changes."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Story: 2009766"},{"line_number":20,"context_line":"Task: 45074"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3e9fa87a_cfae0dd2","line":18,"in_reply_to":"fd25a8ab_be770f0c","updated":"2022-04-28 13:23:23.000000000","message":"how can the kube-apiserver be recovered in such case after invalid file apply? (Does apply of a null audit-policy-file suffice to recover in such case?)","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"2626bfbe5dd5cc7fb7c07a638e7a40f5e088c464","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d6b436f6_0a3a0095","updated":"2022-05-02 14:24:58.000000000","message":"Code looks fine to me, just need John\u0027s concerns to be addressed","commit_id":"538f363a276a6073149aa419ad7c5258b1ccb70d"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"fb686e5b7c3f47279e9f27840a1a7e0becdf5091","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9dd2aa26_4a2d3378","updated":"2022-05-02 15:12:33.000000000","message":"Just a few minor suggestions.","commit_id":"538f363a276a6073149aa419ad7c5258b1ccb70d"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/service_parameter.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"88d876d8ba869bcda1361488805b860ee2422417","unresolved":true,"context_lines":[{"line_number":756,"context_line":"                    subprocess.check_call(cmd, stdout\u003df)  # pylint: disable\u003dnot-callable"},{"line_number":757,"context_line":"                except Exception as e:"},{"line_number":758,"context_line":"                    LOG.exception(e)"},{"line_number":759,"context_line":"                    msg \u003d _(\"Unable to apply service parameters.\")"},{"line_number":760,"context_line":"                    raise wsme.exc.ClientSideError(msg)"},{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"}],"source_content_type":"text/x-python","patch_set":3,"id":"f388b09a_64cc8343","line":759,"range":{"start_line":759,"start_character":39,"end_line":759,"end_character":63},"updated":"2022-04-21 18:14:31.000000000","message":"this could be more specific, the error is that we were unable to get the current configuration.","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"8beea383f240d01d77c47ba7ec955456b723fa32","unresolved":false,"context_lines":[{"line_number":756,"context_line":"                    subprocess.check_call(cmd, stdout\u003df)  # pylint: disable\u003dnot-callable"},{"line_number":757,"context_line":"                except Exception as e:"},{"line_number":758,"context_line":"                    LOG.exception(e)"},{"line_number":759,"context_line":"                    msg \u003d _(\"Unable to apply service parameters.\")"},{"line_number":760,"context_line":"                    raise wsme.exc.ClientSideError(msg)"},{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"}],"source_content_type":"text/x-python","patch_set":3,"id":"14229efb_897b4d8b","line":759,"range":{"start_line":759,"start_character":39,"end_line":759,"end_character":63},"in_reply_to":"f388b09a_64cc8343","updated":"2022-04-28 12:44:32.000000000","message":"Done","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"88d876d8ba869bcda1361488805b860ee2422417","unresolved":true,"context_lines":[{"line_number":757,"context_line":"                except Exception as e:"},{"line_number":758,"context_line":"                    LOG.exception(e)"},{"line_number":759,"context_line":"                    msg \u003d _(\"Unable to apply service parameters.\")"},{"line_number":760,"context_line":"                    raise wsme.exc.ClientSideError(msg)"},{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"},{"line_number":763,"context_line":"                lines \u003d f.readlines()"}],"source_content_type":"text/x-python","patch_set":3,"id":"cca60597_cee0e571","line":760,"range":{"start_line":760,"start_character":35,"end_line":760,"end_character":50},"updated":"2022-04-21 18:14:31.000000000","message":"Is this appropriate?  It\u0027s an error on the server side.","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"1a3f650394c4c8246c13606c4eae71fcaae31b85","unresolved":true,"context_lines":[{"line_number":757,"context_line":"                except Exception as e:"},{"line_number":758,"context_line":"                    LOG.exception(e)"},{"line_number":759,"context_line":"                    msg \u003d _(\"Unable to apply service parameters.\")"},{"line_number":760,"context_line":"                    raise wsme.exc.ClientSideError(msg)"},{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"},{"line_number":763,"context_line":"                lines \u003d f.readlines()"}],"source_content_type":"text/x-python","patch_set":3,"id":"b766d3a7_d4e20968","line":760,"range":{"start_line":760,"start_character":35,"end_line":760,"end_character":50},"in_reply_to":"4490d6eb_02e545d2","updated":"2022-04-28 13:23:23.000000000","message":"in this case, it appears the \u0027kubectl get cm ...\u0027 error would have occurred regardless of user/ClientSide input?","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"f55ffcee31233ea421cc291b08ab0f78ce7fa0de","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                except Exception as e:"},{"line_number":758,"context_line":"                    LOG.exception(e)"},{"line_number":759,"context_line":"                    msg \u003d _(\"Unable to apply service parameters.\")"},{"line_number":760,"context_line":"                    raise wsme.exc.ClientSideError(msg)"},{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"},{"line_number":763,"context_line":"                lines \u003d f.readlines()"}],"source_content_type":"text/x-python","patch_set":3,"id":"e0eecdd1_4b38430f","line":760,"range":{"start_line":760,"start_character":35,"end_line":760,"end_character":50},"in_reply_to":"451b161c_1fae9666","updated":"2022-05-02 18:20:17.000000000","message":"Done","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"358016ea101a9202e228293bf114257ad98a4241","unresolved":true,"context_lines":[{"line_number":757,"context_line":"                except Exception as e:"},{"line_number":758,"context_line":"                    LOG.exception(e)"},{"line_number":759,"context_line":"                    msg \u003d _(\"Unable to apply service parameters.\")"},{"line_number":760,"context_line":"                    raise wsme.exc.ClientSideError(msg)"},{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"},{"line_number":763,"context_line":"                lines \u003d f.readlines()"}],"source_content_type":"text/x-python","patch_set":3,"id":"d3d899df_c99dbec3","line":760,"range":{"start_line":760,"start_character":35,"end_line":760,"end_character":50},"in_reply_to":"b766d3a7_d4e20968","updated":"2022-04-29 18:37:59.000000000","message":"Yes. Do you suggest raise this exception.SysinvException instead of  wsme.exc.ClientSideError?","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"8cbbbc5d4b3f37d7556f28346d5facf51688bab8","unresolved":true,"context_lines":[{"line_number":757,"context_line":"                except Exception as e:"},{"line_number":758,"context_line":"                    LOG.exception(e)"},{"line_number":759,"context_line":"                    msg \u003d _(\"Unable to apply service parameters.\")"},{"line_number":760,"context_line":"                    raise wsme.exc.ClientSideError(msg)"},{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"},{"line_number":763,"context_line":"                lines \u003d f.readlines()"}],"source_content_type":"text/x-python","patch_set":3,"id":"4490d6eb_02e545d2","line":760,"range":{"start_line":760,"start_character":35,"end_line":760,"end_character":50},"in_reply_to":"cca60597_cee0e571","updated":"2022-04-22 18:59:56.000000000","message":"I need some guidance at this point, the file path configured in audit_policy_file parameter, should exist in the pod to kube-apiserver starts and do not fail.\nI thought that getting the current ClusterConfiguration using kubectl and filtering by mountPath to generate a list of the existing files in the pod. And using that list and comparing if the value of audit_policy_file is in the list is the safest way to avoid the end-users configured a invalid file to audit_policy_file.\nFYI: The end-users need this parameter to enable Audit log feature.","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"fb686e5b7c3f47279e9f27840a1a7e0becdf5091","unresolved":true,"context_lines":[{"line_number":757,"context_line":"                except Exception as e:"},{"line_number":758,"context_line":"                    LOG.exception(e)"},{"line_number":759,"context_line":"                    msg \u003d _(\"Unable to apply service parameters.\")"},{"line_number":760,"context_line":"                    raise wsme.exc.ClientSideError(msg)"},{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"},{"line_number":763,"context_line":"                lines \u003d f.readlines()"}],"source_content_type":"text/x-python","patch_set":3,"id":"451b161c_1fae9666","line":760,"range":{"start_line":760,"start_character":35,"end_line":760,"end_character":50},"in_reply_to":"d3d899df_c99dbec3","updated":"2022-05-02 15:12:33.000000000","message":"Something other than wsme.exc.ClientSideError.  You could add a new exception after KubeNotConfigured, maybe called something like KubeOperationFailed or KubeCmdFailed with an error for this case of something like \"Kubectl operation failed, return code: \u003cinsert_rc\u003e, command: \u003cinsert_cmd\u003e\"","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"88d876d8ba869bcda1361488805b860ee2422417","unresolved":true,"context_lines":[{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"},{"line_number":763,"context_line":"                lines \u003d f.readlines()"},{"line_number":764,"context_line":"                for line in lines:"},{"line_number":765,"context_line":"                    if line.strip().startswith(\u0027mountPath\u0027):"},{"line_number":766,"context_line":"                        path \u003d line.strip().split(\u0027:\u0027)[1]"},{"line_number":767,"context_line":"                        mount_paths.append(path.strip())"},{"line_number":768,"context_line":"            os.unlink(temp_kubeadm_config_view)"},{"line_number":769,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":770,"context_line":"                msg \u003d _(\"Unable to apply service parameters. Please choose one of \""}],"source_content_type":"text/x-python","patch_set":3,"id":"24857a8b_389dda38","line":767,"range":{"start_line":764,"start_character":0,"end_line":767,"end_character":56},"updated":"2022-04-21 18:14:31.000000000","message":"could you add a comment explaining how this works?  why would we expect there to be a mountPath entry in the kubeadm cluster configuration matching the audit_policy_file?","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"8cbbbc5d4b3f37d7556f28346d5facf51688bab8","unresolved":false,"context_lines":[{"line_number":761,"context_line":"            mount_paths \u003d []"},{"line_number":762,"context_line":"            with open(temp_kubeadm_config_view, \"r\") as f:"},{"line_number":763,"context_line":"                lines \u003d f.readlines()"},{"line_number":764,"context_line":"                for line in lines:"},{"line_number":765,"context_line":"                    if line.strip().startswith(\u0027mountPath\u0027):"},{"line_number":766,"context_line":"                        path \u003d line.strip().split(\u0027:\u0027)[1]"},{"line_number":767,"context_line":"                        mount_paths.append(path.strip())"},{"line_number":768,"context_line":"            os.unlink(temp_kubeadm_config_view)"},{"line_number":769,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":770,"context_line":"                msg \u003d _(\"Unable to apply service parameters. Please choose one of \""}],"source_content_type":"text/x-python","patch_set":3,"id":"cda6aae8_c3b39617","line":767,"range":{"start_line":764,"start_character":0,"end_line":767,"end_character":56},"in_reply_to":"24857a8b_389dda38","updated":"2022-04-22 18:59:56.000000000","message":"Ack","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"88d876d8ba869bcda1361488805b860ee2422417","unresolved":true,"context_lines":[{"line_number":767,"context_line":"                        mount_paths.append(path.strip())"},{"line_number":768,"context_line":"            os.unlink(temp_kubeadm_config_view)"},{"line_number":769,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":770,"context_line":"                msg \u003d _(\"Unable to apply service parameters. Please choose one of \""},{"line_number":771,"context_line":"                        \"the valid audit-policy-file\")"},{"line_number":772,"context_line":"                raise wsme.exc.ClientSideError(msg)"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    def _service_parameter_apply_semantic_check(self, service):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7343656f_41eb531a","line":771,"range":{"start_line":770,"start_character":61,"end_line":771,"end_character":52},"updated":"2022-04-21 18:14:31.000000000","message":"this doesn\u0027t make sense grammatically.  Maybe \"Please specify a valid audit-policy-file.\" ?","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"8cbbbc5d4b3f37d7556f28346d5facf51688bab8","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                        mount_paths.append(path.strip())"},{"line_number":768,"context_line":"            os.unlink(temp_kubeadm_config_view)"},{"line_number":769,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":770,"context_line":"                msg \u003d _(\"Unable to apply service parameters. Please choose one of \""},{"line_number":771,"context_line":"                        \"the valid audit-policy-file\")"},{"line_number":772,"context_line":"                raise wsme.exc.ClientSideError(msg)"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    def _service_parameter_apply_semantic_check(self, service):"}],"source_content_type":"text/x-python","patch_set":3,"id":"14471afd_a886ddd5","line":771,"range":{"start_line":770,"start_character":61,"end_line":771,"end_character":52},"in_reply_to":"7343656f_41eb531a","updated":"2022-04-22 18:59:56.000000000","message":"Done","commit_id":"2465f5d0462d337e7171e5b5627c8315671473fc"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"1a3f650394c4c8246c13606c4eae71fcaae31b85","unresolved":true,"context_lines":[{"line_number":773,"context_line":"            # This validation is required due to if the file does not exist in kube-apiserver pod"},{"line_number":774,"context_line":"            # After stx-puppet applying the configuration kube-apiserver will fail at start"},{"line_number":775,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":776,"context_line":"                msg \u003d _(\"Unable to apply service parameters. \""},{"line_number":777,"context_line":"                        \"Please specify a valid audit-policy-file.\")"},{"line_number":778,"context_line":"                raise wsme.exc.ClientSideError(msg)"},{"line_number":779,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"a7345542_eda9fd40","line":776,"range":{"start_line":776,"start_character":59,"end_line":776,"end_character":61},"updated":"2022-04-28 13:23:23.000000000","message":"could provide here a more specific hint as to reason it failed to apply","commit_id":"1299ab0a98c14facd3d24f2af3fe3f75cd177573"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"94cb306ff7d06974a2a9a50b4594e16ca1c0c733","unresolved":true,"context_lines":[{"line_number":773,"context_line":"            # This validation is required due to if the file does not exist in kube-apiserver pod"},{"line_number":774,"context_line":"            # After stx-puppet applying the configuration kube-apiserver will fail at start"},{"line_number":775,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":776,"context_line":"                msg \u003d _(\"Unable to apply service parameters. \""},{"line_number":777,"context_line":"                        \"Please specify a valid audit-policy-file.\")"},{"line_number":778,"context_line":"                raise wsme.exc.ClientSideError(msg)"},{"line_number":779,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c69c4af5_3054e671","line":776,"range":{"start_line":776,"start_character":59,"end_line":776,"end_character":61},"in_reply_to":"a7345542_eda9fd40","updated":"2022-04-28 13:47:59.000000000","message":"is it fine add to the error the list of valid files from mount_paths array?","commit_id":"1299ab0a98c14facd3d24f2af3fe3f75cd177573"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"358016ea101a9202e228293bf114257ad98a4241","unresolved":false,"context_lines":[{"line_number":773,"context_line":"            # This validation is required due to if the file does not exist in kube-apiserver pod"},{"line_number":774,"context_line":"            # After stx-puppet applying the configuration kube-apiserver will fail at start"},{"line_number":775,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":776,"context_line":"                msg \u003d _(\"Unable to apply service parameters. \""},{"line_number":777,"context_line":"                        \"Please specify a valid audit-policy-file.\")"},{"line_number":778,"context_line":"                raise wsme.exc.ClientSideError(msg)"},{"line_number":779,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f5024136_da7b010f","line":776,"range":{"start_line":776,"start_character":59,"end_line":776,"end_character":61},"in_reply_to":"c3bca0c5_a5afd183","updated":"2022-04-29 18:37:59.000000000","message":"Done","commit_id":"1299ab0a98c14facd3d24f2af3fe3f75cd177573"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"e4fed00e7ce25cff11e18793a90e4249db5467cc","unresolved":true,"context_lines":[{"line_number":773,"context_line":"            # This validation is required due to if the file does not exist in kube-apiserver pod"},{"line_number":774,"context_line":"            # After stx-puppet applying the configuration kube-apiserver will fail at start"},{"line_number":775,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":776,"context_line":"                msg \u003d _(\"Unable to apply service parameters. \""},{"line_number":777,"context_line":"                        \"Please specify a valid audit-policy-file.\")"},{"line_number":778,"context_line":"                raise wsme.exc.ClientSideError(msg)"},{"line_number":779,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c3bca0c5_a5afd183","line":776,"range":{"start_line":776,"start_character":59,"end_line":776,"end_character":61},"in_reply_to":"c69c4af5_3054e671","updated":"2022-04-28 14:21:04.000000000","message":"sounds reasonable to me; thanks for the suggestion","commit_id":"1299ab0a98c14facd3d24f2af3fe3f75cd177573"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"fb686e5b7c3f47279e9f27840a1a7e0becdf5091","unresolved":true,"context_lines":[{"line_number":769,"context_line":"                        path \u003d line.strip().split(\u0027:\u0027)[1]"},{"line_number":770,"context_line":"                        mount_paths.append(path.strip())"},{"line_number":771,"context_line":"            os.unlink(temp_kubeadm_config_view)"},{"line_number":772,"context_line":"            # Verify if the file configured in parameter audit_policy_file is in the mount_path list"},{"line_number":773,"context_line":"            # This validation is required due to if the file does not exist in kube-apiserver pod"},{"line_number":774,"context_line":"            # After stx-puppet applying the configuration kube-apiserver will fail at start"},{"line_number":775,"context_line":"            if audit_policy_file.value not in mount_paths:"}],"source_content_type":"text/x-python","patch_set":7,"id":"11fee190_715ac3fc","line":772,"range":{"start_line":772,"start_character":12,"end_line":772,"end_character":100},"updated":"2022-05-02 15:12:33.000000000","message":"Where does the audit_policy_file get added to the ConfigMap?   This should be mentioned in this comment block to help future developers maintain this code.","commit_id":"538f363a276a6073149aa419ad7c5258b1ccb70d"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"f55ffcee31233ea421cc291b08ab0f78ce7fa0de","unresolved":false,"context_lines":[{"line_number":769,"context_line":"                        path \u003d line.strip().split(\u0027:\u0027)[1]"},{"line_number":770,"context_line":"                        mount_paths.append(path.strip())"},{"line_number":771,"context_line":"            os.unlink(temp_kubeadm_config_view)"},{"line_number":772,"context_line":"            # Verify if the file configured in parameter audit_policy_file is in the mount_path list"},{"line_number":773,"context_line":"            # This validation is required due to if the file does not exist in kube-apiserver pod"},{"line_number":774,"context_line":"            # After stx-puppet applying the configuration kube-apiserver will fail at start"},{"line_number":775,"context_line":"            if audit_policy_file.value not in mount_paths:"}],"source_content_type":"text/x-python","patch_set":7,"id":"c92408bd_3993076f","line":772,"range":{"start_line":772,"start_character":12,"end_line":772,"end_character":100},"in_reply_to":"11fee190_715ac3fc","updated":"2022-05-02 18:20:17.000000000","message":"Done","commit_id":"538f363a276a6073149aa419ad7c5258b1ccb70d"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"fb686e5b7c3f47279e9f27840a1a7e0becdf5091","unresolved":true,"context_lines":[{"line_number":770,"context_line":"                        mount_paths.append(path.strip())"},{"line_number":771,"context_line":"            os.unlink(temp_kubeadm_config_view)"},{"line_number":772,"context_line":"            # Verify if the file configured in parameter audit_policy_file is in the mount_path list"},{"line_number":773,"context_line":"            # This validation is required due to if the file does not exist in kube-apiserver pod"},{"line_number":774,"context_line":"            # After stx-puppet applying the configuration kube-apiserver will fail at start"},{"line_number":775,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":776,"context_line":"                msg \u003d _(\"Unable to apply service parameters. \""},{"line_number":777,"context_line":"                        \"Please specify a valid audit-policy-file: {}\".format(mount_paths))"}],"source_content_type":"text/x-python","patch_set":7,"id":"cc36477f_a2c97a09","line":774,"range":{"start_line":773,"start_character":0,"end_line":774,"end_character":91},"updated":"2022-05-02 15:12:33.000000000","message":"would be better as:\n\nThis validation is required since if the file does not exist in the kube-apiserver pod then after puppet applies the new configuration kube-apiserver will fail to start.","commit_id":"538f363a276a6073149aa419ad7c5258b1ccb70d"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"f55ffcee31233ea421cc291b08ab0f78ce7fa0de","unresolved":false,"context_lines":[{"line_number":770,"context_line":"                        mount_paths.append(path.strip())"},{"line_number":771,"context_line":"            os.unlink(temp_kubeadm_config_view)"},{"line_number":772,"context_line":"            # Verify if the file configured in parameter audit_policy_file is in the mount_path list"},{"line_number":773,"context_line":"            # This validation is required due to if the file does not exist in kube-apiserver pod"},{"line_number":774,"context_line":"            # After stx-puppet applying the configuration kube-apiserver will fail at start"},{"line_number":775,"context_line":"            if audit_policy_file.value not in mount_paths:"},{"line_number":776,"context_line":"                msg \u003d _(\"Unable to apply service parameters. \""},{"line_number":777,"context_line":"                        \"Please specify a valid audit-policy-file: {}\".format(mount_paths))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5bb23852_9e0b05d7","line":774,"range":{"start_line":773,"start_character":0,"end_line":774,"end_character":91},"in_reply_to":"cc36477f_a2c97a09","updated":"2022-05-02 18:20:17.000000000","message":"Done","commit_id":"538f363a276a6073149aa419ad7c5258b1ccb70d"}],"sysinv/sysinv/sysinv/sysinv/common/exception.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"2576240cf617c584f45932c248b6c9b0ff562b42","unresolved":true,"context_lines":[{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"class KubeCmdFailed(SysinvException):"},{"line_number":1594,"context_line":"    message \u003d _(\"Kubectl operation failed\")"},{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"class RestoreAlreadyExists(Conflict):"}],"source_content_type":"text/x-python","patch_set":8,"id":"833d6ebd_620d9e1b","line":1594,"updated":"2022-05-03 19:10:42.000000000","message":"%(msg)s\n\nis probably needed to properly display the msg passed in.\n\nOtherwise, looks ok.","commit_id":"00e420c76351f66ea51e772b30b00f77fb0966eb"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"b19e19cdd902386c8d98d44d053446bda5141bd9","unresolved":false,"context_lines":[{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"class KubeCmdFailed(SysinvException):"},{"line_number":1594,"context_line":"    message \u003d _(\"Kubectl operation failed\")"},{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"class RestoreAlreadyExists(Conflict):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1d6acfca_aec9c8df","line":1594,"in_reply_to":"833d6ebd_620d9e1b","updated":"2022-05-03 19:54:09.000000000","message":"Done","commit_id":"00e420c76351f66ea51e772b30b00f77fb0966eb"}],"sysinv/sysinv/sysinv/sysinv/common/service_parameter.py":[{"author":{"_account_id":32241,"name":"Takamasa Takenaka","email":"takamasa.takenaka@windriver.com","username":"ttakenak"},"change_message_id":"20fe8c2ff113a5659bed7f6587efb55cf8251721","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017-2021 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"629ae058_ed39791b","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":25},"updated":"2022-04-27 19:08:53.000000000","message":"Could you update to 2022?","commit_id":"19b51e0181ff349e50f51a585cc61f2fba49eb3d"},{"author":{"_account_id":33391,"name":"Francisco Giana","email":"francisco.giana@windriver.com","username":"fgiana"},"change_message_id":"8beea383f240d01d77c47ba7ec955456b723fa32","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017-2021 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"35640e8e_391ea900","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":25},"in_reply_to":"629ae058_ed39791b","updated":"2022-04-28 12:44:32.000000000","message":"Done","commit_id":"19b51e0181ff349e50f51a585cc61f2fba49eb3d"}]}