)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"8336b79b0ca379f00eedbf476e344a427a145594","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Test Plan:"},{"line_number":13,"context_line":" PASS: Install ISO and resize /var/log on a Simplex"},{"line_number":14,"context_line":"    https://paste.opendev.org/show/b1gJyqtBPX6VGVTMkZx8/"},{"line_number":15,"context_line":" PENDING: Install and resize /var/log on a Standard"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story:"},{"line_number":18,"context_line":"Task:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Heron Vieira \u003cheron.vieira@windriver.com\u003e"},{"line_number":21,"context_line":"Change-Id: I78c7ead4d7209986781d24d6aec013ff7d66991f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f41373b_9123c9e3","line":18,"range":{"start_line":15,"start_character":1,"end_line":18,"end_character":5},"updated":"2022-05-04 18:13:13.000000000","message":"Please don\u0027t forget to fill this information when removing WIP, and I think you may want to change the Topic too.","commit_id":"f9e4f4a92eec00ad51ff4dfe16f552488cc33fa1"},{"author":{"_account_id":34215,"name":"Heron Vieira","email":"heron.vieira@windriver.com","username":"hvieira"},"change_message_id":"9c4896470209f94f0b1e780e08002416352a1cc5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Test Plan:"},{"line_number":13,"context_line":" PASS: Install ISO and resize /var/log on a Simplex"},{"line_number":14,"context_line":"    https://paste.opendev.org/show/b1gJyqtBPX6VGVTMkZx8/"},{"line_number":15,"context_line":" PENDING: Install and resize /var/log on a Standard"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story:"},{"line_number":18,"context_line":"Task:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Signed-off-by: Heron Vieira \u003cheron.vieira@windriver.com\u003e"},{"line_number":21,"context_line":"Change-Id: I78c7ead4d7209986781d24d6aec013ff7d66991f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dff9e734_a912f4c5","line":18,"range":{"start_line":15,"start_character":1,"end_line":18,"end_character":5},"in_reply_to":"7f41373b_9123c9e3","updated":"2022-05-06 00:35:42.000000000","message":"Done. Thanks Heitor.","commit_id":"f9e4f4a92eec00ad51ff4dfe16f552488cc33fa1"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"27c71b303da7f5e67e768c72bcc0f1c6c99c3b44","unresolved":true,"context_lines":[{"line_number":13,"context_line":" PASS: Install ISO and resize /var/log on a Simplex"},{"line_number":14,"context_line":"    https://paste.opendev.org/show/b1gJyqtBPX6VGVTMkZx8/"},{"line_number":15,"context_line":" PASS: Unit tests on test_manager.py"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2010026"},{"line_number":18,"context_line":"Task: 45269"},{"line_number":19,"context_line":"Depends on: https://review.opendev.org/c/starlingx/stx-puppet/+/839617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7dd8b4a5_9ac4844c","line":16,"updated":"2022-05-11 13:24:56.000000000","message":"recommend to verify behaviour when attempting to reduce the log size.  should be rejected and persist over host-lock/unlock","commit_id":"cba93071f2a60aca36b847987c07d7712cdeafae"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"41da42011dec6a95376c6d3cf8479ea9ddd44cea","unresolved":true,"context_lines":[{"line_number":13,"context_line":" PASS: Install ISO and resize /var/log on a Simplex"},{"line_number":14,"context_line":"    https://paste.opendev.org/show/b1gJyqtBPX6VGVTMkZx8/"},{"line_number":15,"context_line":" PASS: Unit tests on test_manager.py"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2010026"},{"line_number":18,"context_line":"Task: 45269"},{"line_number":19,"context_line":"Depends on: https://review.opendev.org/c/starlingx/stx-puppet/+/839617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"2f12955d_afff7f7a","line":16,"updated":"2022-05-11 13:20:47.000000000","message":"upgrade testcase should be performed to verify expected filesystem size over an upgrade","commit_id":"cba93071f2a60aca36b847987c07d7712cdeafae"},{"author":{"_account_id":34215,"name":"Heron Vieira","email":"heron.vieira@windriver.com","username":"hvieira"},"change_message_id":"9e4f46907f7122cd9df3a4887d8e9ae96cd043a1","unresolved":false,"context_lines":[{"line_number":13,"context_line":" PASS: Install ISO and resize /var/log on a Simplex"},{"line_number":14,"context_line":"    https://paste.opendev.org/show/b1gJyqtBPX6VGVTMkZx8/"},{"line_number":15,"context_line":" PASS: Unit tests on test_manager.py"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2010026"},{"line_number":18,"context_line":"Task: 45269"},{"line_number":19,"context_line":"Depends on: https://review.opendev.org/c/starlingx/stx-puppet/+/839617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"59bfc6a7_9fd364d4","line":16,"in_reply_to":"2f12955d_afff7f7a","updated":"2022-05-12 18:25:02.000000000","message":"Made an upgrade with the modifications on a 22.06 ISO, and the feature worked as expected. Added to commit message.","commit_id":"cba93071f2a60aca36b847987c07d7712cdeafae"},{"author":{"_account_id":34215,"name":"Heron Vieira","email":"heron.vieira@windriver.com","username":"hvieira"},"change_message_id":"9e4f46907f7122cd9df3a4887d8e9ae96cd043a1","unresolved":false,"context_lines":[{"line_number":13,"context_line":" PASS: Install ISO and resize /var/log on a Simplex"},{"line_number":14,"context_line":"    https://paste.opendev.org/show/b1gJyqtBPX6VGVTMkZx8/"},{"line_number":15,"context_line":" PASS: Unit tests on test_manager.py"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2010026"},{"line_number":18,"context_line":"Task: 45269"},{"line_number":19,"context_line":"Depends on: https://review.opendev.org/c/starlingx/stx-puppet/+/839617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"88e252e0_b23d4486","line":16,"in_reply_to":"7dd8b4a5_9ac4844c","updated":"2022-05-12 18:25:02.000000000","message":"Made this test and updated the commit message with the result, the system rejected the resize to a smaller value as expected.","commit_id":"cba93071f2a60aca36b847987c07d7712cdeafae"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"41da42011dec6a95376c6d3cf8479ea9ddd44cea","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2010026"},{"line_number":18,"context_line":"Task: 45269"},{"line_number":19,"context_line":"Depends on: https://review.opendev.org/c/starlingx/stx-puppet/+/839617"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Signed-off-by: Heron Vieira \u003cheron.vieira@windriver.com\u003e"},{"line_number":22,"context_line":"Change-Id: I78c7ead4d7209986781d24d6aec013ff7d66991f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"475f5da9_b6880445","line":19,"updated":"2022-05-11 13:20:47.000000000","message":"appears to be circular Depends-On.   One Depends-On and the other review should be WF-1","commit_id":"cba93071f2a60aca36b847987c07d7712cdeafae"},{"author":{"_account_id":34215,"name":"Heron Vieira","email":"heron.vieira@windriver.com","username":"hvieira"},"change_message_id":"9e4f46907f7122cd9df3a4887d8e9ae96cd043a1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2010026"},{"line_number":18,"context_line":"Task: 45269"},{"line_number":19,"context_line":"Depends on: https://review.opendev.org/c/starlingx/stx-puppet/+/839617"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Signed-off-by: Heron Vieira \u003cheron.vieira@windriver.com\u003e"},{"line_number":22,"context_line":"Change-Id: I78c7ead4d7209986781d24d6aec013ff7d66991f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"298af12d_fbfdc3d2","line":19,"in_reply_to":"475f5da9_b6880445","updated":"2022-05-12 18:25:02.000000000","message":"Edited the commit message of this review to remove the circular depends-on and put WF-1 on the puppet review.","commit_id":"cba93071f2a60aca36b847987c07d7712cdeafae"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"ec0b27a148082fdada4ffc60ec1ba3615a41e351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9585d26_31858aee","updated":"2022-04-27 20:54:08.000000000","message":"Thanks, Heron. Just a nit inline.","commit_id":"5c6a3320590d6af1c11eaf2d5520e59deedb5a8d"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"8336b79b0ca379f00eedbf476e344a427a145594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"abceb3f3_d26f26cc","updated":"2022-05-04 18:13:13.000000000","message":"Overall looks good to me, waiting for commit message missing information to be filled for +1","commit_id":"f9e4f4a92eec00ad51ff4dfe16f552488cc33fa1"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"a648ed153ea12f6bcc28fd93ee742c2c8274a6cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"489ee548_d40ad657","updated":"2022-05-11 14:07:50.000000000","message":"Code seems fine to me.  Just waiting for John\u0027s comments to be addressed","commit_id":"cba93071f2a60aca36b847987c07d7712cdeafae"}],"sysinv/sysinv/sysinv/sysinv/agent/manager.py":[{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"ec0b27a148082fdada4ffc60ec1ba3615a41e351","unresolved":true,"context_lines":[{"line_number":1216,"context_line":"                filesystems.append(data)"},{"line_number":1217,"context_line":""},{"line_number":1218,"context_line":"            if utils.is_filesystem_supported(constants.FILESYSTEM_NAME_LOG,"},{"line_number":1219,"context_line":"                                            self._ihost_personality):"},{"line_number":1220,"context_line":"                log_lv_size \u003d utils.get_current_fs_size(\"log\")"},{"line_number":1221,"context_line":"                data \u003d {"},{"line_number":1222,"context_line":"                    \u0027name\u0027: constants.FILESYSTEM_NAME_LOG,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c1c23fa_97eb19d4","line":1219,"updated":"2022-04-27 20:54:08.000000000","message":"nit: wrong indentation","commit_id":"5c6a3320590d6af1c11eaf2d5520e59deedb5a8d"},{"author":{"_account_id":34215,"name":"Heron Vieira","email":"heron.vieira@windriver.com","username":"hvieira"},"change_message_id":"bf04a382e2b70bf15960f308eadabe09e1fdd4fe","unresolved":false,"context_lines":[{"line_number":1216,"context_line":"                filesystems.append(data)"},{"line_number":1217,"context_line":""},{"line_number":1218,"context_line":"            if utils.is_filesystem_supported(constants.FILESYSTEM_NAME_LOG,"},{"line_number":1219,"context_line":"                                            self._ihost_personality):"},{"line_number":1220,"context_line":"                log_lv_size \u003d utils.get_current_fs_size(\"log\")"},{"line_number":1221,"context_line":"                data \u003d {"},{"line_number":1222,"context_line":"                    \u0027name\u0027: constants.FILESYSTEM_NAME_LOG,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f078b2cf_92d1c604","line":1219,"in_reply_to":"5c1c23fa_97eb19d4","updated":"2022-04-29 19:19:55.000000000","message":"Thanks for pointing this out Hugo!\nFixed.","commit_id":"5c6a3320590d6af1c11eaf2d5520e59deedb5a8d"}],"sysinv/sysinv/sysinv/sysinv/puppet/storage.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"41da42011dec6a95376c6d3cf8479ea9ddd44cea","unresolved":true,"context_lines":[{"line_number":279,"context_line":"                })"},{"line_number":280,"context_line":"            elif fs.name \u003d\u003d constants.FILESYSTEM_NAME_LOG:"},{"line_number":281,"context_line":"                config.update({"},{"line_number":282,"context_line":"                    \u0027platform::filesystem::log::params::lv_size\u0027: fs.size"},{"line_number":283,"context_line":"                })"},{"line_number":284,"context_line":"        return config"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7dceecef_b033a3e6","line":282,"updated":"2022-05-11 13:20:47.000000000","message":"confirm whether a default value needs to be set for controller config/upgrade-script\n\nWhen None, it appears puppet would set the correct default value based on the corresponding puppet review","commit_id":"cba93071f2a60aca36b847987c07d7712cdeafae"},{"author":{"_account_id":34215,"name":"Heron Vieira","email":"heron.vieira@windriver.com","username":"hvieira"},"change_message_id":"9e4f46907f7122cd9df3a4887d8e9ae96cd043a1","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                })"},{"line_number":280,"context_line":"            elif fs.name \u003d\u003d constants.FILESYSTEM_NAME_LOG:"},{"line_number":281,"context_line":"                config.update({"},{"line_number":282,"context_line":"                    \u0027platform::filesystem::log::params::lv_size\u0027: fs.size"},{"line_number":283,"context_line":"                })"},{"line_number":284,"context_line":"        return config"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"51e3b49d_ba667ad9","line":282,"in_reply_to":"7dceecef_b033a3e6","updated":"2022-05-12 18:25:02.000000000","message":"As the partition already existed I see no need to set a default value. Tested the upgrade and it worked with no issues.","commit_id":"cba93071f2a60aca36b847987c07d7712cdeafae"}]}