)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"0a94ff808b351c0f7edf974a1b2567b31941919f","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      with valid value"},{"line_number":22,"context_line":"      --\u003e parameter added in service-parameter table"},{"line_number":23,"context_line":"      --\u003e coredump.conf updated with new value"},{"line_number":24,"context_line":"      https://paste.opendev.org/show/bKnQF6xqUL4qlPZkckLw/"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"PASS: TC2"},{"line_number":27,"context_line":"      modify new parameters in the service-parameter table"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"e0037e7b_5b60e104","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":58},"updated":"2022-05-06 14:24:48.000000000","message":"I don\u0027t know if you need to include these pastes, mostly because I dont know if these get cleaned up eventually so these links will become invalid after a while.\nI think just saying the parameter was added, etc..  is good enough","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"757d146af631961f9da42b85914626b4c9d3814a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      with valid value"},{"line_number":22,"context_line":"      --\u003e parameter added in service-parameter table"},{"line_number":23,"context_line":"      --\u003e coredump.conf updated with new value"},{"line_number":24,"context_line":"      https://paste.opendev.org/show/bKnQF6xqUL4qlPZkckLw/"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"PASS: TC2"},{"line_number":27,"context_line":"      modify new parameters in the service-parameter table"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d2c697d1_f76e4127","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":58},"in_reply_to":"e0037e7b_5b60e104","updated":"2022-05-10 12:38:19.000000000","message":"Done","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"0a94ff808b351c0f7edf974a1b2567b31941919f","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"PASS: TC7"},{"line_number":65,"context_line":"      reboot host with new parameters configured"},{"line_number":66,"context_line":"      --\u003e service-parameter table keep new parameters value"},{"line_number":67,"context_line":"      --\u003e coredump.conf keep configured values"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"61aa645d_4c46ab51","line":66,"range":{"start_line":66,"start_character":34,"end_line":66,"end_character":39},"updated":"2022-05-06 14:24:48.000000000","message":"keeps","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"757d146af631961f9da42b85914626b4c9d3814a","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"PASS: TC7"},{"line_number":65,"context_line":"      reboot host with new parameters configured"},{"line_number":66,"context_line":"      --\u003e service-parameter table keep new parameters value"},{"line_number":67,"context_line":"      --\u003e coredump.conf keep configured values"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"363d5292_96cec8d8","line":66,"range":{"start_line":66,"start_character":34,"end_line":66,"end_character":39},"in_reply_to":"61aa645d_4c46ab51","updated":"2022-05-10 12:38:19.000000000","message":"Done","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"0a94ff808b351c0f7edf974a1b2567b31941919f","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      --\u003e service-parameter table keep new parameters value"},{"line_number":67,"context_line":"      --\u003e coredump.conf keep configured values"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"PENDING: upgrade with AIO-Standard"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"aad995f0_7b6ab233","line":69,"range":{"start_line":69,"start_character":10,"end_line":69,"end_character":21},"updated":"2022-05-06 14:24:48.000000000","message":"typo: installation","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"757d146af631961f9da42b85914626b4c9d3814a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      --\u003e service-parameter table keep new parameters value"},{"line_number":67,"context_line":"      --\u003e coredump.conf keep configured values"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"PENDING: upgrade with AIO-Standard"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"11b4013c_4261fa8a","line":69,"range":{"start_line":69,"start_character":10,"end_line":69,"end_character":21},"in_reply_to":"aad995f0_7b6ab233","updated":"2022-05-10 12:38:19.000000000","message":"Done","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"0a94ff808b351c0f7edf974a1b2567b31941919f","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"PENDING: upgrade with AIO-Standard"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Story: 2010026"},{"line_number":74,"context_line":"Task: 45266"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"85aa9253_86dfb442","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":34},"updated":"2022-05-06 14:24:48.000000000","message":"I think you mean AIO-SX  or AIO-DX.  I dont actually think there is  AIO-Standard (although there is Standard Duplex)","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"a71f1d15b0541138215976a77b355c0d9356c23b","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"PENDING: upgrade with AIO-Standard"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Story: 2010026"},{"line_number":74,"context_line":"Task: 45266"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ffb80ca_edbd3685","line":71,"updated":"2022-05-10 20:27:57.000000000","message":"The results for the upgrade testcase is now missing (was pending)","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b015ff681c6d489bec4ca033c0607ef02b32fcbb","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"PENDING: upgrade with AIO-Standard"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Story: 2010026"},{"line_number":74,"context_line":"Task: 45266"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"2497e0cb_b1d0ebcf","line":71,"updated":"2022-05-06 18:42:54.000000000","message":"will the coredump defaults change on the upgrade?  If so, from what values.","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6fd7b120eaf2708629885227916a2d94b31b1a41","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"PENDING: upgrade with AIO-Standard"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Story: 2010026"},{"line_number":74,"context_line":"Task: 45266"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"0cfc090c_be9ae240","line":71,"in_reply_to":"1ffb80ca_edbd3685","updated":"2022-05-11 12:58:22.000000000","message":"As this config will be driven by specifically called service-parameter command, the deferral of the upgrade testcase is ok.  There should be a Task/LP tracking the verification of this after an upgrade.","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"69a0d2379010cfb43402a987ef7a3d7e7f1f31c2","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"PENDING: upgrade with AIO-Standard"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Story: 2010026"},{"line_number":74,"context_line":"Task: 45266"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"769e9cc9_50fd4378","line":71,"in_reply_to":"2497e0cb_b1d0ebcf","updated":"2022-05-06 19:16:33.000000000","message":"No. It will be expected to have the coredump.conf from the base after upgrade.","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"757d146af631961f9da42b85914626b4c9d3814a","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PASS: ISO instalation"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"PENDING: upgrade with AIO-Standard"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Story: 2010026"},{"line_number":74,"context_line":"Task: 45266"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7eb51831_ca631eef","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":34},"in_reply_to":"85aa9253_86dfb442","updated":"2022-05-10 12:38:19.000000000","message":"Done","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"7c73a87b6b0a184e2f62d577c758aa7594483246","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9c89d85a_6955344b","updated":"2022-04-27 21:19:54.000000000","message":"Thanks, Virginia. Some questions inline.","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"209cc7f2dc3f8a0cc7e9db705b90e9b552435aec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"03db3d12_7f2d1042","updated":"2022-05-06 12:21:04.000000000","message":"Pending upgrade test","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"0a94ff808b351c0f7edf974a1b2567b31941919f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"db6e5456_aecb323e","updated":"2022-05-06 14:24:48.000000000","message":"the code seems fine to me.\nI only see small nits","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"757d146af631961f9da42b85914626b4c9d3814a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"94c11220_3275158b","updated":"2022-05-10 12:38:19.000000000","message":"upgrade test pending","commit_id":"08a5121eedc0ee0dd6d5d398af372aaf040217be"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"15c6fa35a3aa4e7a27ed2079f4dec7c9abfe7df1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a439df9f_955b085d","updated":"2022-05-11 18:19:00.000000000","message":"LGTM, Thanks","commit_id":"d1adcffbf23f16158edf3b51c2494e961048ae51"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"5040cfb5b9f7adcadd220f9815bbe3c1723ea2b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"26ada8c5_ee826e32","updated":"2022-05-10 18:40:50.000000000","message":"The upgrade test will be done separately within a specific test activity.","commit_id":"d1adcffbf23f16158edf3b51c2494e961048ae51"}],"sysinv/sysinv/sysinv/sysinv/common/service_parameter.py":[{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"7c73a87b6b0a184e2f62d577c758aa7594483246","unresolved":true,"context_lines":[{"line_number":424,"context_line":"    format1 \u003d re.search(r\"^(-*[0-9]+([\\.][0-9]+)*)([B|K|M|G|T|P|E])$\", str(param_value))"},{"line_number":425,"context_line":"    format2 \u003d re.search(r\"^(0)$\", str(param_value))"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    if (not format1) and (not format2):"},{"line_number":428,"context_line":"       raise wsme.exc.ClientSideError(\"Parameter \u0027%s\u0027 has invalid value format.\" % param_name)"},{"line_number":429,"context_line":"    else:"},{"line_number":430,"context_line":"        if format1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"118728e8_e75b0d57","line":427,"updated":"2022-04-27 21:19:54.000000000","message":"I think `if not (format1 or format2):` is more readable. WDYT?","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"4d6e01c65b57504d33045962a1d4c1f0c1734154","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    format1 \u003d re.search(r\"^(-*[0-9]+([\\.][0-9]+)*)([B|K|M|G|T|P|E])$\", str(param_value))"},{"line_number":425,"context_line":"    format2 \u003d re.search(r\"^(0)$\", str(param_value))"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    if (not format1) and (not format2):"},{"line_number":428,"context_line":"       raise wsme.exc.ClientSideError(\"Parameter \u0027%s\u0027 has invalid value format.\" % param_name)"},{"line_number":429,"context_line":"    else:"},{"line_number":430,"context_line":"        if format1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6bc0c22a_64b7916b","line":427,"in_reply_to":"118728e8_e75b0d57","updated":"2022-04-28 14:49:46.000000000","message":"Done","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"7c73a87b6b0a184e2f62d577c758aa7594483246","unresolved":true,"context_lines":[{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    if (not format1) and (not format2):"},{"line_number":428,"context_line":"       raise wsme.exc.ClientSideError(\"Parameter \u0027%s\u0027 has invalid value format.\" % param_name)"},{"line_number":429,"context_line":"    else:"},{"line_number":430,"context_line":"        if format1:"},{"line_number":431,"context_line":"            size_greatness \u003d format1.group(3)"},{"line_number":432,"context_line":"            if format1.group(2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4f8f1d3_3a1bc47b","line":429,"updated":"2022-04-27 21:19:54.000000000","message":"Since the previous condition raise an exception, this else is not needed.","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"4d6e01c65b57504d33045962a1d4c1f0c1734154","unresolved":false,"context_lines":[{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    if (not format1) and (not format2):"},{"line_number":428,"context_line":"       raise wsme.exc.ClientSideError(\"Parameter \u0027%s\u0027 has invalid value format.\" % param_name)"},{"line_number":429,"context_line":"    else:"},{"line_number":430,"context_line":"        if format1:"},{"line_number":431,"context_line":"            size_greatness \u003d format1.group(3)"},{"line_number":432,"context_line":"            if format1.group(2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba041872_25b5a4f0","line":429,"in_reply_to":"b4f8f1d3_3a1bc47b","updated":"2022-04-28 14:49:46.000000000","message":"Done","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"7c73a87b6b0a184e2f62d577c758aa7594483246","unresolved":true,"context_lines":[{"line_number":449,"context_line":"        raise wsme.exc.ClientSideError(_("},{"line_number":450,"context_line":"            \"Parameter \u0027%s\u0027 must be greater than or equal to %s.\") % (name, min_value))"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"def _validate_process_size_max(name, value):"},{"line_number":453,"context_line":"    _validate_not_empty"},{"line_number":454,"context_line":"    size_in_bytes \u003d _byte_transform(value, name)"},{"line_number":455,"context_line":"    _validate_minimum_value(name, size_in_bytes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3871121_7eff4752","line":452,"updated":"2022-04-27 21:19:54.000000000","message":"Do we need all these validate methods? They only change the third parameter on _validate_minimum_value. Why not create only 1 method with the constant as a third parameter?","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"3e0b42fd2db9fb7be0fedb89c25510570406b419","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        raise wsme.exc.ClientSideError(_("},{"line_number":450,"context_line":"            \"Parameter \u0027%s\u0027 must be greater than or equal to %s.\") % (name, min_value))"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"def _validate_process_size_max(name, value):"},{"line_number":453,"context_line":"    _validate_not_empty"},{"line_number":454,"context_line":"    size_in_bytes \u003d _byte_transform(value, name)"},{"line_number":455,"context_line":"    _validate_minimum_value(name, size_in_bytes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffdaafae_854eec09","line":452,"in_reply_to":"ec0da1f8_ffed1153","updated":"2022-04-28 15:55:38.000000000","message":"Ok, thanks for the explanation.","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"4d6e01c65b57504d33045962a1d4c1f0c1734154","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        raise wsme.exc.ClientSideError(_("},{"line_number":450,"context_line":"            \"Parameter \u0027%s\u0027 must be greater than or equal to %s.\") % (name, min_value))"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"def _validate_process_size_max(name, value):"},{"line_number":453,"context_line":"    _validate_not_empty"},{"line_number":454,"context_line":"    size_in_bytes \u003d _byte_transform(value, name)"},{"line_number":455,"context_line":"    _validate_minimum_value(name, size_in_bytes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ec0da1f8_ffed1153","line":452,"in_reply_to":"f3871121_7eff4752","updated":"2022-04-28 14:49:46.000000000","message":"The call of these methods does not pass parameters. The coredump parameter name and its value are taken from the command line. I followed the example of PLATFORM_MTCE_PARAMETER_VALIDATOR which also has several equal methods just changing the range of values.","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"e7fd790d469f2d6a328774453816dc2b3dcba091","unresolved":true,"context_lines":[{"line_number":420,"context_line":"         constants.SERVICE_PARAM_PLATFORM_AUDITD_ENABLED)))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"def _byte_transform(param_value, param_name):"},{"line_number":424,"context_line":"    format1 \u003d re.search(r\"^(-*[0-9]+([\\.][0-9]+)*)([B|K|M|G|T|P|E])$\", str(param_value))"},{"line_number":425,"context_line":"    format2 \u003d re.search(r\"^(0)$\", str(param_value))"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e3c1f806_d4d87afb","line":423,"range":{"start_line":423,"start_character":0,"end_line":423,"end_character":45},"updated":"2022-04-28 18:00:21.000000000","message":"This will work fine, though I\u0027d prefer a simpler approach, like using an integer in bytes instead of \u003cnumber\u003e\u003cunit\u003e (e.g. 5G) as it would eliminate the need of this function.","commit_id":"77d429e5d8eaa9fcc77f82379c887a8d568a44d1"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"8e9a2b9677b1901dc0b1c3f0887fee50e2330764","unresolved":false,"context_lines":[{"line_number":420,"context_line":"         constants.SERVICE_PARAM_PLATFORM_AUDITD_ENABLED)))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"def _byte_transform(param_value, param_name):"},{"line_number":424,"context_line":"    format1 \u003d re.search(r\"^(-*[0-9]+([\\.][0-9]+)*)([B|K|M|G|T|P|E])$\", str(param_value))"},{"line_number":425,"context_line":"    format2 \u003d re.search(r\"^(0)$\", str(param_value))"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f5ad2d6a_c7d4aad3","line":423,"range":{"start_line":423,"start_character":0,"end_line":423,"end_character":45},"in_reply_to":"e3c1f806_d4d87afb","updated":"2022-04-29 18:40:34.000000000","message":"I thought it best to keep the original format of the coredump.conf file as the system will continue reading the values from this file.","commit_id":"77d429e5d8eaa9fcc77f82379c887a8d568a44d1"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"0a94ff808b351c0f7edf974a1b2567b31941919f","unresolved":true,"context_lines":[{"line_number":443,"context_line":"    return size_in_bytes"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"def _validate_minimum_value(name, value, min_value):"},{"line_number":447,"context_line":"    min_value_in_bytes \u003d _byte_transform(min_value, name)"},{"line_number":448,"context_line":"    if value \u003c min_value_in_bytes:"},{"line_number":449,"context_line":"        raise wsme.exc.ClientSideError(_("}],"source_content_type":"text/x-python","patch_set":6,"id":"118228e8_c6881d2d","line":446,"range":{"start_line":446,"start_character":4,"end_line":446,"end_character":27},"updated":"2022-05-06 14:24:48.000000000","message":"Just wondering if we would also want a validation to make sure we dont pass in a value that is too big  (max  validation)","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"757d146af631961f9da42b85914626b4c9d3814a","unresolved":false,"context_lines":[{"line_number":443,"context_line":"    return size_in_bytes"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"def _validate_minimum_value(name, value, min_value):"},{"line_number":447,"context_line":"    min_value_in_bytes \u003d _byte_transform(min_value, name)"},{"line_number":448,"context_line":"    if value \u003c min_value_in_bytes:"},{"line_number":449,"context_line":"        raise wsme.exc.ClientSideError(_("}],"source_content_type":"text/x-python","patch_set":6,"id":"92487d35_a6ca7a72","line":446,"range":{"start_line":446,"start_character":4,"end_line":446,"end_character":27},"in_reply_to":"118228e8_c6881d2d","updated":"2022-05-10 12:38:19.000000000","message":"I asked this question to Matt Petters and his answer was:\n\"No, we don\u0027t need to enforce maximums, but we should enforce minimums to validate range (non-negative)\"","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"0a94ff808b351c0f7edf974a1b2567b31941919f","unresolved":true,"context_lines":[{"line_number":674,"context_line":"}"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"PLATFORM_COREDUMP_PARAMETER_RESOURCE \u003d {"},{"line_number":677,"context_line":"    constants.SERVICE_PARAM_NAME_PLATFORM_PROCESS_SIZE_MAX: \u0027platform::coredump::params::process_size_max\u0027,"},{"line_number":678,"context_line":"    constants.SERVICE_PARAM_NAME_PLATFORM_EXTERNAL_SIZE_MAX: \u0027platform::coredump::params::external_size_max\u0027,"},{"line_number":679,"context_line":"    constants.SERVICE_PARAM_NAME_PLATFORM_MAX_USE: \u0027platform::coredump::params::max_use\u0027,"},{"line_number":680,"context_line":"    constants.SERVICE_PARAM_NAME_PLATFORM_KEEP_FREE: \u0027platform::coredump::params::keep_free\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1524220d_35067ce8","line":677,"updated":"2022-05-06 14:24:48.000000000","message":"can you split these long lines (see lockout_retries  above  for how we typically do this)\nthere are 2 lines that go beyond 80 chars","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"757d146af631961f9da42b85914626b4c9d3814a","unresolved":false,"context_lines":[{"line_number":674,"context_line":"}"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"PLATFORM_COREDUMP_PARAMETER_RESOURCE \u003d {"},{"line_number":677,"context_line":"    constants.SERVICE_PARAM_NAME_PLATFORM_PROCESS_SIZE_MAX: \u0027platform::coredump::params::process_size_max\u0027,"},{"line_number":678,"context_line":"    constants.SERVICE_PARAM_NAME_PLATFORM_EXTERNAL_SIZE_MAX: \u0027platform::coredump::params::external_size_max\u0027,"},{"line_number":679,"context_line":"    constants.SERVICE_PARAM_NAME_PLATFORM_MAX_USE: \u0027platform::coredump::params::max_use\u0027,"},{"line_number":680,"context_line":"    constants.SERVICE_PARAM_NAME_PLATFORM_KEEP_FREE: \u0027platform::coredump::params::keep_free\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"aca697bc_768a69db","line":677,"in_reply_to":"1524220d_35067ce8","updated":"2022-05-10 12:38:19.000000000","message":"Done","commit_id":"98237563e95407ccc77aceaf33b04b9fc42b8652"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"7c73a87b6b0a184e2f62d577c758aa7594483246","unresolved":true,"context_lines":[{"line_number":9699,"context_line":"                config_uuid \u003d self._config_clear_reboot_required(config_uuid)"},{"line_number":9700,"context_line":"                self._config_apply_runtime_manifest(context, config_uuid, config_dict, force\u003dTrue)"},{"line_number":9701,"context_line":"            elif section \u003d\u003d constants.SERVICE_PARAM_SECTION_PLATFORM_COREDUMP:"},{"line_number":9702,"context_line":""},{"line_number":9703,"context_line":"                personalities \u003d [constants.CONTROLLER,"},{"line_number":9704,"context_line":"                                 constants.WORKER,"},{"line_number":9705,"context_line":"                                 constants.STORAGE]"}],"source_content_type":"text/x-python","patch_set":1,"id":"97e39d4d_092129d0","line":9702,"updated":"2022-04-27 21:19:54.000000000","message":"nit: remove extra line","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"4d6e01c65b57504d33045962a1d4c1f0c1734154","unresolved":false,"context_lines":[{"line_number":9699,"context_line":"                config_uuid \u003d self._config_clear_reboot_required(config_uuid)"},{"line_number":9700,"context_line":"                self._config_apply_runtime_manifest(context, config_uuid, config_dict, force\u003dTrue)"},{"line_number":9701,"context_line":"            elif section \u003d\u003d constants.SERVICE_PARAM_SECTION_PLATFORM_COREDUMP:"},{"line_number":9702,"context_line":""},{"line_number":9703,"context_line":"                personalities \u003d [constants.CONTROLLER,"},{"line_number":9704,"context_line":"                                 constants.WORKER,"},{"line_number":9705,"context_line":"                                 constants.STORAGE]"}],"source_content_type":"text/x-python","patch_set":1,"id":"d33d6d01_b853c3fd","line":9702,"in_reply_to":"97e39d4d_092129d0","updated":"2022-04-28 14:49:46.000000000","message":"Done","commit_id":"00d6485ac48b6f5de4862460326aad56ce3e8376"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"e7fd790d469f2d6a328774453816dc2b3dcba091","unresolved":true,"context_lines":[{"line_number":9720,"context_line":"                    \"classes\": [\u0027platform::coredump::runtime\u0027]"},{"line_number":9721,"context_line":"                }"},{"line_number":9722,"context_line":""},{"line_number":9723,"context_line":"                self._config_apply_runtime_manifest(context, config_uuid, config_dict, force\u003dTrue)"},{"line_number":9724,"context_line":""},{"line_number":9725,"context_line":"        # we should not set the reboot flag on operations that are not"},{"line_number":9726,"context_line":"        # reboot required. An apply of a service parameter is not reboot"}],"source_content_type":"text/x-python","patch_set":2,"id":"31996ca8_bd8338ac","line":9723,"range":{"start_line":9723,"start_character":16,"end_line":9723,"end_character":98},"updated":"2022-04-28 18:00:21.000000000","message":"Bear in mind that if this has to be configurable for each host with different values, the config_dict will have to include a \"host_uuids\" key/value pair: https://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/sysinv/conductor/manager.py#L10971\n\nAlso, if the above statement is true, there will be at most one record on the service parameters table for each \"section/name/host\"","commit_id":"77d429e5d8eaa9fcc77f82379c887a8d568a44d1"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"8e9a2b9677b1901dc0b1c3f0887fee50e2330764","unresolved":false,"context_lines":[{"line_number":9720,"context_line":"                    \"classes\": [\u0027platform::coredump::runtime\u0027]"},{"line_number":9721,"context_line":"                }"},{"line_number":9722,"context_line":""},{"line_number":9723,"context_line":"                self._config_apply_runtime_manifest(context, config_uuid, config_dict, force\u003dTrue)"},{"line_number":9724,"context_line":""},{"line_number":9725,"context_line":"        # we should not set the reboot flag on operations that are not"},{"line_number":9726,"context_line":"        # reboot required. An apply of a service parameter is not reboot"}],"source_content_type":"text/x-python","patch_set":2,"id":"43dc5ae4_1f665805","line":9723,"range":{"start_line":9723,"start_character":16,"end_line":9723,"end_character":98},"in_reply_to":"31996ca8_bd8338ac","updated":"2022-04-29 18:40:34.000000000","message":"I\u0027ve talked with Matt Peters and he said that due to reduce the scope, it was decided to implement coredump making it a global change.","commit_id":"77d429e5d8eaa9fcc77f82379c887a8d568a44d1"}],"sysinv/sysinv/sysinv/sysinv/tests/api/test_service_parameters.py":[{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"7afc3faed72eddceac9d15f758052b37a115af1b","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        response \u003d self.apply(\u0027kubernetes\u0027)"},{"line_number":383,"context_line":"        self.assertEqual(http_client.NO_CONTENT, response.status_int)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def test_coredump(self):"},{"line_number":386,"context_line":"        # test invalid value format"},{"line_number":387,"context_line":"        for param in range(11, 17):"},{"line_number":388,"context_line":"            post_object \u003d self.service_parameter_data[param]"}],"source_content_type":"text/x-python","patch_set":3,"id":"8dca19be_6399930e","line":385,"range":{"start_line":385,"start_character":8,"end_line":385,"end_character":21},"updated":"2022-05-04 14:26:23.000000000","message":"I think this test should be named test_coredump_values","commit_id":"8684b5117e718cdd0df0307d88cbb7d811083229"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"fdea221e3c16882753e2f4e9ce04a4393e0ef648","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        response \u003d self.apply(\u0027kubernetes\u0027)"},{"line_number":383,"context_line":"        self.assertEqual(http_client.NO_CONTENT, response.status_int)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def test_coredump(self):"},{"line_number":386,"context_line":"        # test invalid value format"},{"line_number":387,"context_line":"        for param in range(11, 17):"},{"line_number":388,"context_line":"            post_object \u003d self.service_parameter_data[param]"}],"source_content_type":"text/x-python","patch_set":3,"id":"a878a1cf_40ffc682","line":385,"range":{"start_line":385,"start_character":8,"end_line":385,"end_character":21},"in_reply_to":"8dca19be_6399930e","updated":"2022-05-04 16:44:36.000000000","message":"replaced by test_coredump_values_and_formats","commit_id":"8684b5117e718cdd0df0307d88cbb7d811083229"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"7afc3faed72eddceac9d15f758052b37a115af1b","unresolved":true,"context_lines":[{"line_number":409,"context_line":"                self.service_parameter_data[param][\u0027name\u0027] +"},{"line_number":410,"context_line":"                \"\u0027 must be greater than or equal to 1G.\")"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        # test valid minimmum value"},{"line_number":413,"context_line":"        for param in range(7, 11):"},{"line_number":414,"context_line":"            post_object \u003d self.service_parameter_data[param]"},{"line_number":415,"context_line":"            response \u003d self.post(post_object)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2bb1430b_f949f31b","line":412,"range":{"start_line":412,"start_character":21,"end_line":412,"end_character":29},"updated":"2022-05-04 14:26:23.000000000","message":"nit: minimum","commit_id":"8684b5117e718cdd0df0307d88cbb7d811083229"},{"author":{"_account_id":34414,"name":"Virginia Martins Perozim","email":"vmartins@windriver.com","username":"vmartins"},"change_message_id":"fdea221e3c16882753e2f4e9ce04a4393e0ef648","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                self.service_parameter_data[param][\u0027name\u0027] +"},{"line_number":410,"context_line":"                \"\u0027 must be greater than or equal to 1G.\")"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        # test valid minimmum value"},{"line_number":413,"context_line":"        for param in range(7, 11):"},{"line_number":414,"context_line":"            post_object \u003d self.service_parameter_data[param]"},{"line_number":415,"context_line":"            response \u003d self.post(post_object)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c51b4504_992d01a2","line":412,"range":{"start_line":412,"start_character":21,"end_line":412,"end_character":29},"in_reply_to":"2bb1430b_f949f31b","updated":"2022-05-04 16:44:36.000000000","message":"word removed because this test is relative to other valid values, different of minimum values.","commit_id":"8684b5117e718cdd0df0307d88cbb7d811083229"}]}