)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"47b8a582596d1166051ad5d1d1616f3b53c63a51","unresolved":true,"context_lines":[{"line_number":12,"context_line":"reporting that the application apply is complete."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This original code does not account for the pods that run jobs that go"},{"line_number":15,"context_line":"to a \u0027Completed\u0027 state and cause the apply ro be stuck and eventually"},{"line_number":16,"context_line":"timeout."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This update will now check for pods in the \u0027Completed\u0027 state and will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"141e6607_fad4a2c2","line":15,"range":{"start_line":15,"start_character":43,"end_line":15,"end_character":46},"updated":"2022-05-02 12:06:31.000000000","message":"to","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49e3e426e36b2c0035eebcde360d50257d346403","unresolved":false,"context_lines":[{"line_number":12,"context_line":"reporting that the application apply is complete."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This original code does not account for the pods that run jobs that go"},{"line_number":15,"context_line":"to a \u0027Completed\u0027 state and cause the apply ro be stuck and eventually"},{"line_number":16,"context_line":"timeout."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This update will now check for pods in the \u0027Completed\u0027 state and will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fb976080_d52e4109","line":15,"range":{"start_line":15,"start_character":43,"end_line":15,"end_character":46},"in_reply_to":"141e6607_fad4a2c2","updated":"2022-05-03 02:32:56.000000000","message":"Ack","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"47b8a582596d1166051ad5d1d1616f3b53c63a51","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Test Plan:"},{"line_number":23,"context_line":"PASS - Build/Install AIO-SX + AIO-DX"},{"line_number":24,"context_line":"PASS - Bootsrap and unlock AIO-SX + AIO-DX"},{"line_number":25,"context_line":"PASS - Test FluxCD apps with the appropriate labeling and confirm"},{"line_number":26,"context_line":"       running/completed conditions"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"55c07e40_58bb69dc","line":24,"range":{"start_line":24,"start_character":7,"end_line":24,"end_character":16},"updated":"2022-05-02 12:06:31.000000000","message":"Bootstrap","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49e3e426e36b2c0035eebcde360d50257d346403","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Test Plan:"},{"line_number":23,"context_line":"PASS - Build/Install AIO-SX + AIO-DX"},{"line_number":24,"context_line":"PASS - Bootsrap and unlock AIO-SX + AIO-DX"},{"line_number":25,"context_line":"PASS - Test FluxCD apps with the appropriate labeling and confirm"},{"line_number":26,"context_line":"       running/completed conditions"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"60e37008_c40a549f","line":24,"range":{"start_line":24,"start_character":7,"end_line":24,"end_character":16},"in_reply_to":"55c07e40_58bb69dc","updated":"2022-05-03 02:32:56.000000000","message":"Ack","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"47b8a582596d1166051ad5d1d1616f3b53c63a51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"21906a3b_d0040868","updated":"2022-05-02 12:06:31.000000000","message":"The code seems fine to me.  I only see some minor nits","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"25b94549890de17dbe1823821d0928110c3a059c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"63a754f3_56203ed9","updated":"2022-04-30 19:23:22.000000000","message":"WF-1 while final testing with latest submissions on master","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bacdf5d9b8728a5a0890a079040ebd8d504fdfd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4c8f7177_7daf61c8","updated":"2022-05-04 20:11:01.000000000","message":"Approving for now, depending on how Bob answers some of the questions we may want to go back and make things more robust.","commit_id":"39d6a873b2b240ee8d557452695dc3dc550ce019"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c212d1dd6f3754ca26fffd35a373665b666c0241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e730645_7a680b82","updated":"2022-05-04 19:01:26.000000000","message":"For what it\u0027s worth, I proposed an upstream patch that would fix the underlying helm issues last month and nobody upstream has reviewed it yet, so I\u0027m starting to wonder about the health of the helm project...","commit_id":"39d6a873b2b240ee8d557452695dc3dc550ce019"}],"sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"47b8a582596d1166051ad5d1d1616f3b53c63a51","unresolved":true,"context_lines":[{"line_number":1684,"context_line":"                        release_name)"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"                    if not helm_rel:"},{"line_number":1687,"context_line":"                        LOG.info(\"FluxCD Helm release info for {} is not available\".format(release_name))"},{"line_number":1688,"context_line":"                        continue"},{"line_number":1689,"context_line":""},{"line_number":1690,"context_line":"                    release_status, msg \u003d self._fluxcd.get_helm_release_status(helm_rel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"aabfda4e_cec7ac69","line":1687,"updated":"2022-05-02 12:06:31.000000000","message":"line width","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49e3e426e36b2c0035eebcde360d50257d346403","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"                        release_name)"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"                    if not helm_rel:"},{"line_number":1687,"context_line":"                        LOG.info(\"FluxCD Helm release info for {} is not available\".format(release_name))"},{"line_number":1688,"context_line":"                        continue"},{"line_number":1689,"context_line":""},{"line_number":1690,"context_line":"                    release_status, msg \u003d self._fluxcd.get_helm_release_status(helm_rel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"25f81c88_b5888dc4","line":1687,"in_reply_to":"aabfda4e_cec7ac69","updated":"2022-05-03 02:32:56.000000000","message":"Ack","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"47b8a582596d1166051ad5d1d1616f3b53c63a51","unresolved":true,"context_lines":[{"line_number":1703,"context_line":"                            charts.pop(release_name)"},{"line_number":1704,"context_line":"                    else:"},{"line_number":1705,"context_line":"                        # Noisy log, so make it debug only, but good for debugging apps dev."},{"line_number":1706,"context_line":"                        LOG.debug(\"Application {}: release {}: Helm release status is unknown. Checking again.\""},{"line_number":1707,"context_line":"                                  .format(app.name, release_name))"},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"                # wait a bit to check again if the charts are ready"}],"source_content_type":"text/x-python","patch_set":1,"id":"94f47b09_15fccc0f","line":1706,"range":{"start_line":1706,"start_character":95,"end_line":1706,"end_character":96},"updated":"2022-05-02 12:06:31.000000000","message":"I think this line is too wide","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49e3e426e36b2c0035eebcde360d50257d346403","unresolved":false,"context_lines":[{"line_number":1703,"context_line":"                            charts.pop(release_name)"},{"line_number":1704,"context_line":"                    else:"},{"line_number":1705,"context_line":"                        # Noisy log, so make it debug only, but good for debugging apps dev."},{"line_number":1706,"context_line":"                        LOG.debug(\"Application {}: release {}: Helm release status is unknown. Checking again.\""},{"line_number":1707,"context_line":"                                  .format(app.name, release_name))"},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"                # wait a bit to check again if the charts are ready"}],"source_content_type":"text/x-python","patch_set":1,"id":"7efeceea_bc2fbc8d","line":1706,"range":{"start_line":1706,"start_character":95,"end_line":1706,"end_character":96},"in_reply_to":"94f47b09_15fccc0f","updated":"2022-05-03 02:32:56.000000000","message":"Ack","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"47b8a582596d1166051ad5d1d1616f3b53c63a51","unresolved":true,"context_lines":[{"line_number":4549,"context_line":"            completed \u003d self.check_pod_completed(pod)"},{"line_number":4550,"context_line":"            running_and_ready \u003d self.check_pod_running_and_ready_probe(pod)"},{"line_number":4551,"context_line":""},{"line_number":4552,"context_line":"            LOG.info(\"Pod {} has been found with label {}: Completed?: {}, Running/Ready?: {}\".format("},{"line_number":4553,"context_line":"                pod.metadata.name, label_selector, completed, running_and_ready))"},{"line_number":4554,"context_line":""},{"line_number":4555,"context_line":"            if not completed and not running_and_ready:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fcc00efc_aba389dd","line":4552,"range":{"start_line":4552,"start_character":96,"end_line":4552,"end_character":98},"updated":"2022-05-02 12:06:31.000000000","message":"line width","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49e3e426e36b2c0035eebcde360d50257d346403","unresolved":false,"context_lines":[{"line_number":4549,"context_line":"            completed \u003d self.check_pod_completed(pod)"},{"line_number":4550,"context_line":"            running_and_ready \u003d self.check_pod_running_and_ready_probe(pod)"},{"line_number":4551,"context_line":""},{"line_number":4552,"context_line":"            LOG.info(\"Pod {} has been found with label {}: Completed?: {}, Running/Ready?: {}\".format("},{"line_number":4553,"context_line":"                pod.metadata.name, label_selector, completed, running_and_ready))"},{"line_number":4554,"context_line":""},{"line_number":4555,"context_line":"            if not completed and not running_and_ready:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c04515c9_867e3ae2","line":4552,"range":{"start_line":4552,"start_character":96,"end_line":4552,"end_character":98},"in_reply_to":"fcc00efc_aba389dd","updated":"2022-05-03 02:32:56.000000000","message":"Ack","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"47b8a582596d1166051ad5d1d1616f3b53c63a51","unresolved":true,"context_lines":[{"line_number":4563,"context_line":"                  associated with the status"},{"line_number":4564,"context_line":"        \"\"\""},{"line_number":4565,"context_line":"        if \"status\" in helm_release_dict and \"conditions\" in helm_release_dict[\"status\"]:"},{"line_number":4566,"context_line":"            conditions \u003d list([x for x in helm_release_dict[\u0027status\u0027][\u0027conditions\u0027] if x[\u0027type\u0027] \u003d\u003d \u0027Released\u0027])"},{"line_number":4567,"context_line":"            if not conditions:"},{"line_number":4568,"context_line":"                return self.HELM_RELEASE_STATUS_UNKNOWN, None"},{"line_number":4569,"context_line":"            return conditions[0][\u0027status\u0027], conditions[0].get(\u0027message\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e8e4b894_c8775c93","line":4566,"range":{"start_line":4566,"start_character":98,"end_line":4566,"end_character":99},"updated":"2022-05-02 12:06:31.000000000","message":"line width","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49e3e426e36b2c0035eebcde360d50257d346403","unresolved":false,"context_lines":[{"line_number":4563,"context_line":"                  associated with the status"},{"line_number":4564,"context_line":"        \"\"\""},{"line_number":4565,"context_line":"        if \"status\" in helm_release_dict and \"conditions\" in helm_release_dict[\"status\"]:"},{"line_number":4566,"context_line":"            conditions \u003d list([x for x in helm_release_dict[\u0027status\u0027][\u0027conditions\u0027] if x[\u0027type\u0027] \u003d\u003d \u0027Released\u0027])"},{"line_number":4567,"context_line":"            if not conditions:"},{"line_number":4568,"context_line":"                return self.HELM_RELEASE_STATUS_UNKNOWN, None"},{"line_number":4569,"context_line":"            return conditions[0][\u0027status\u0027], conditions[0].get(\u0027message\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e54e13fa_2b601528","line":4566,"range":{"start_line":4566,"start_character":98,"end_line":4566,"end_character":99},"in_reply_to":"e8e4b894_c8775c93","updated":"2022-05-03 02:32:56.000000000","message":"Ack","commit_id":"8f3285ffca8c6dfd9636f184d6249b1f984f9cfc"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1faf613f1cb44088dad0f3bf12ae382e55234339","unresolved":true,"context_lines":[{"line_number":628,"context_line":"                        not os.path.isfile(static_overrides_path):"},{"line_number":629,"context_line":"                    raise exception.SysinvException(_("},{"line_number":630,"context_line":"                        \"FluxCD app chart static overrides file doesn\u0027t exist \""},{"line_number":631,"context_line":"                        \"%s\" % static_overrides_path))"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"                with io.open(static_overrides_path, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":634,"context_line":"                    static_overrides_file \u003d yaml.safe_load(f) or {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"e502a589_84e7a4e2","line":631,"range":{"start_line":631,"start_character":30,"end_line":631,"end_character":54},"updated":"2022-05-04 20:05:41.000000000","message":"I don\u0027t think this change is covered in the git commit message.","commit_id":"39d6a873b2b240ee8d557452695dc3dc550ce019"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1faf613f1cb44088dad0f3bf12ae382e55234339","unresolved":true,"context_lines":[{"line_number":1687,"context_line":""},{"line_number":1688,"context_line":"                    if not helm_rel:"},{"line_number":1689,"context_line":"                        LOG.info(\"FluxCD Helm release info for {} is not \""},{"line_number":1690,"context_line":"                                 \"available\".format(release_name))"},{"line_number":1691,"context_line":"                        continue"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"                    release_status, msg \u003d self._fluxcd.get_helm_release_status(helm_rel)"}],"source_content_type":"text/x-python","patch_set":2,"id":"17399098_5284a915","line":1690,"range":{"start_line":1690,"start_character":52,"end_line":1690,"end_character":66},"updated":"2022-05-04 20:05:41.000000000","message":"should we have namespace in the log as well?  or can you not have the same release name in a different namespace?\n\nOr maybe just add the application to the log like we have it at line 1698?","commit_id":"39d6a873b2b240ee8d557452695dc3dc550ce019"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1faf613f1cb44088dad0f3bf12ae382e55234339","unresolved":true,"context_lines":[{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"                    release_status, msg \u003d self._fluxcd.get_helm_release_status(helm_rel)"},{"line_number":1694,"context_line":"                    if release_status \u003d\u003d \"False\":"},{"line_number":1695,"context_line":"                        # If the helm release failed the app must also be in a"},{"line_number":1696,"context_line":"                        # failed state"},{"line_number":1697,"context_line":"                        err_msg \u003d \":{}\".format(msg) if msg else \"\""},{"line_number":1698,"context_line":"                        LOG.exception(\"Application {}: release {}: Failed during {} {}\""},{"line_number":1699,"context_line":"                                      .format(app.name, release_name, request, err_msg))"},{"line_number":1700,"context_line":"                        return False"},{"line_number":1701,"context_line":"                    elif release_status \u003d\u003d \"True\":"},{"line_number":1702,"context_line":"                        # Special validation check needed for AIO-SX only, can"},{"line_number":1703,"context_line":"                        # go away once upstream issues are addressed. See method"}],"source_content_type":"text/x-python","patch_set":2,"id":"e972c53e_882505d1","line":1700,"range":{"start_line":1695,"start_character":0,"end_line":1700,"end_character":36},"updated":"2022-05-04 20:05:41.000000000","message":"for posterity, is this really an error if the \"request\" is to delete the app?","commit_id":"39d6a873b2b240ee8d557452695dc3dc550ce019"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1faf613f1cb44088dad0f3bf12ae382e55234339","unresolved":true,"context_lines":[{"line_number":4481,"context_line":"        conditions \u003d list([x for x in pod.status.conditions if x.type \u003d\u003d \u0027Ready\u0027])"},{"line_number":4482,"context_line":"        if not conditions:"},{"line_number":4483,"context_line":"            return False"},{"line_number":4484,"context_line":"        return conditions[0].status \u003d\u003d \u0027True\u0027"},{"line_number":4485,"context_line":""},{"line_number":4486,"context_line":"    def check_pod_completed(self, pod):"},{"line_number":4487,"context_line":"        \"\"\"Pod is of the form returned by self._kube.kube_get_pods_by_selector."}],"source_content_type":"text/x-python","patch_set":2,"id":"bf4d0cdc_c2d84e6f","line":4484,"range":{"start_line":4484,"start_character":25,"end_line":4484,"end_character":28},"updated":"2022-05-04 20:05:41.000000000","message":"are we guaranteed that the most recent probe is the first one in the list?  Or do we need to sort by lastProbeTime?","commit_id":"39d6a873b2b240ee8d557452695dc3dc550ce019"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1faf613f1cb44088dad0f3bf12ae382e55234339","unresolved":true,"context_lines":[{"line_number":4491,"context_line":"        conditions \u003d list([x for x in pod.status.conditions if x.type \u003d\u003d \u0027Ready\u0027])"},{"line_number":4492,"context_line":"        if not conditions:"},{"line_number":4493,"context_line":"            return False"},{"line_number":4494,"context_line":"        return (conditions[0].status \u003d\u003d \u0027False\u0027 and conditions[0].reason \u003d\u003d \u0027PodCompleted\u0027)"},{"line_number":4495,"context_line":""},{"line_number":4496,"context_line":"    def verify_pods_status_for_release(self, chart_obj):"},{"line_number":4497,"context_line":"        \"\"\" chart_obj has the information required to query for pods associated"}],"source_content_type":"text/x-python","patch_set":2,"id":"a4f1d1da_9e5191c9","line":4494,"range":{"start_line":4494,"start_character":16,"end_line":4494,"end_character":52},"updated":"2022-05-04 20:05:41.000000000","message":"nit: If the pod reason is PodCompleted do we even need the status check?","commit_id":"39d6a873b2b240ee8d557452695dc3dc550ce019"}]}