)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"23a9e0b3663ec4472960c1feb0d4c7ffae90ac0a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"This change adds an error message in this scenario, preventing the"},{"line_number":14,"context_line":"configuration of the tx rate parameter when the port speed is unknown."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: 1971575"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Antonio Augusto Vilas Boas Teixeira"},{"line_number":19,"context_line":"\u003cantonio.augustovilasboasteixeira@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"140845c5_d4822c78","line":16,"updated":"2022-05-09 13:16:01.000000000","message":"The bug describes other scenarios. Should this be a Partial-Bug fix?\n\ni.e. \"Create an interface using some of the VFs of the previously modified interface\" and \"Try to set \u0027max-tx-rate\u0027 to some unsupported value, e.g. for a 25Gbps NIC:\"","commit_id":"1864bea8e0777541ac27fbc5ac41685459dbb8d2"},{"author":{"_account_id":34466,"name":"Antonio Augusto Vilas Boas Teixeira","display_name":"Antonio Teixeira","email":"antonio.augustovilasboasteixeira@windriver.com","username":"aaugusto"},"change_message_id":"7cf14ad6bc8f488c0aa174832d48d9cf51d88f65","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This change adds an error message in this scenario, preventing the"},{"line_number":14,"context_line":"configuration of the tx rate parameter when the port speed is unknown."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: 1971575"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Antonio Augusto Vilas Boas Teixeira"},{"line_number":19,"context_line":"\u003cantonio.augustovilasboasteixeira@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7321ebdb_581a7146","line":16,"in_reply_to":"140845c5_d4822c78","updated":"2022-05-09 14:00:25.000000000","message":"Hi John, I think this is just an issue where the bug description I wrote maybe is not clear enough? \n\nThis should be the correct scenario:\n- There is a port where the speed cannot be determined (speed\u003dNone)\n- There is an interface using this port set to the pci-sriov class\n- Using the previous interface, creating a VF interface with max-tx-rate or modifying one to add this parameter should fail\n\nThe 25Gbps part of the description was just to exemplify why the values being set do not make sense from a physical point of view. However, it doesn\u0027t impact the scenario as the port speed would be unknown, thus any max-tx-rate limitation wouldn\u0027t make sense from a logical point of view.\n\nLet me know if this is still unclear or if it was not what you meant. Thanks!","commit_id":"1864bea8e0777541ac27fbc5ac41685459dbb8d2"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"fdb53c26f136ba20ddfd1e8882d7dc3faf8002f6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This change adds an error message in this scenario, preventing the"},{"line_number":14,"context_line":"configuration of the tx rate parameter when the port speed is unknown."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: 1971575"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Antonio Augusto Vilas Boas Teixeira"},{"line_number":19,"context_line":"\u003cantonio.augustovilasboasteixeira@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"25e59ec0_86e1d9e8","line":16,"in_reply_to":"7321ebdb_581a7146","updated":"2022-05-09 21:00:48.000000000","message":"Thanks for the clarification","commit_id":"1864bea8e0777541ac27fbc5ac41685459dbb8d2"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"fdb53c26f136ba20ddfd1e8882d7dc3faf8002f6","unresolved":true,"context_lines":[{"line_number":14,"context_line":"configuration of the tx rate parameter when the port speed is unknown."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: 1971575"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Antonio Augusto Vilas Boas Teixeira"},{"line_number":19,"context_line":"\u003cantonio.augustovilasboasteixeira@windriver.com\u003e"},{"line_number":20,"context_line":"Change-Id: I271656df1bac03f9a8f714f876baf1c742748b31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"afd5e828_fd53240c","line":17,"updated":"2022-05-09 21:00:48.000000000","message":"Has this speed check verified on virtual configuration (e.g. vbox)?","commit_id":"1864bea8e0777541ac27fbc5ac41685459dbb8d2"},{"author":{"_account_id":34466,"name":"Antonio Augusto Vilas Boas Teixeira","display_name":"Antonio Teixeira","email":"antonio.augustovilasboasteixeira@windriver.com","username":"aaugusto"},"change_message_id":"a77ddefbb18ee66342b0b4b9ef314eb5e8857b4f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"configuration of the tx rate parameter when the port speed is unknown."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: 1971575"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Antonio Augusto Vilas Boas Teixeira"},{"line_number":19,"context_line":"\u003cantonio.augustovilasboasteixeira@windriver.com\u003e"},{"line_number":20,"context_line":"Change-Id: I271656df1bac03f9a8f714f876baf1c742748b31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ae64044b_164f3ea1","line":17,"in_reply_to":"afd5e828_fd53240c","updated":"2022-05-10 12:35:34.000000000","message":"This speed check only applies to VF interfaces, so it cannot be fully tested in a vbox environment.\n\nI did however test in a vbox config just to see if the \u0027speed\u0027 parameter of the port is detected correctly there and it is. So the check for None will behave as expected in this scenario too.","commit_id":"1864bea8e0777541ac27fbc5ac41685459dbb8d2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"33360495c4b0bf24a2ec0099c02206f8a4182754","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"83bec88f_8bb77d85","updated":"2022-05-04 15:19:16.000000000","message":"Are you able to add a unit test in stx/config/sysinv/sysinv/sysinv/sysinv/tests/puppet/test_interface.py ?  We have some existing max_tx_rate tests there","commit_id":"1a79f6a70cde3a27615fea3dddb116facedfe46b"},{"author":{"_account_id":34466,"name":"Antonio Augusto Vilas Boas Teixeira","display_name":"Antonio Teixeira","email":"antonio.augustovilasboasteixeira@windriver.com","username":"aaugusto"},"change_message_id":"779b59183086c8da15d73524c5d9dc3bd5f6f3a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e711277c_d9258acf","in_reply_to":"83bec88f_8bb77d85","updated":"2022-05-05 14:49:54.000000000","message":"Done.\n\nThe tests made more sense in the context of /tests/api/test_interface.py.","commit_id":"1a79f6a70cde3a27615fea3dddb116facedfe46b"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/interface.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"4a3a253472f1ad3fce27e067424d45b1f9f7d38d","unresolved":true,"context_lines":[{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":"        ports \u003d pecan.request.dbapi.ethernet_port_get_by_interface("},{"line_number":1062,"context_line":"                                                        lower_iface[\u0027uuid\u0027])"},{"line_number":1063,"context_line":"        if ports[0][\u0027speed\u0027] is None:"},{"line_number":1064,"context_line":"            msg \u003d _(\"Port speed for %s could not be determined. \""},{"line_number":1065,"context_line":"                    \"Check if the port is cabled correctly.\" %"},{"line_number":1066,"context_line":"                    ports[0][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"867e87d2_4851b57e","line":1063,"updated":"2022-05-04 19:55:15.000000000","message":"does it need to check \u0027if ports\u0027 before dereferencing ports[0] ? it was probably short-circuited before by the \u0027if len(ports) \u003e 0\u0027 condition.","commit_id":"5813429c4deb54d768bb4e11a8fac669b57d6216"},{"author":{"_account_id":34466,"name":"Antonio Augusto Vilas Boas Teixeira","display_name":"Antonio Teixeira","email":"antonio.augustovilasboasteixeira@windriver.com","username":"aaugusto"},"change_message_id":"779b59183086c8da15d73524c5d9dc3bd5f6f3a0","unresolved":false,"context_lines":[{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":"        ports \u003d pecan.request.dbapi.ethernet_port_get_by_interface("},{"line_number":1062,"context_line":"                                                        lower_iface[\u0027uuid\u0027])"},{"line_number":1063,"context_line":"        if ports[0][\u0027speed\u0027] is None:"},{"line_number":1064,"context_line":"            msg \u003d _(\"Port speed for %s could not be determined. \""},{"line_number":1065,"context_line":"                    \"Check if the port is cabled correctly.\" %"},{"line_number":1066,"context_line":"                    ports[0][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"af6715f1_2800cdcd","line":1063,"in_reply_to":"867e87d2_4851b57e","updated":"2022-05-05 14:49:54.000000000","message":"You\u0027re absolutely correct, the way I had done it made the len(ports) test useless.\n\nMy bad. Fixed now.","commit_id":"5813429c4deb54d768bb4e11a8fac669b57d6216"}]}