)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"bc595499d7cda44e3b32385a74d755bc7a77b4d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1e9d3fcc_9516cf69","updated":"2022-05-19 22:44:03.000000000","message":"No big concerns from my POV, just minor improvements.","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e6a688b6af1d0b570add1eaa8adbdafef7d11b50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"722a66c6_8e5eedbc","updated":"2022-05-20 15:43:34.000000000","message":"Thanks, Bob. LGTM!","commit_id":"9adc444408f063bc50117f4a64fd63b25b96b1d0"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"d74339256ded47365d4379601dabed1c1491d89a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb8e8c40_3d039483","updated":"2022-05-24 19:05:53.000000000","message":"looks good.","commit_id":"4d35242a0e716028d6e937e2283c74946841a822"}],"sysinv/sysinv/sysinv/sysinv/cmd/helm.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"91405009f44e93ea0cf709dfaa98769680893ca6","unresolved":true,"context_lines":[{"line_number":10,"context_line":"\"\"\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"import sys"},{"line_number":13,"context_line":"import urllib3"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":4,"id":"01d0ff94_c18d4487","line":13,"range":{"start_line":13,"start_character":7,"end_line":13,"end_character":14},"updated":"2022-05-24 21:14:04.000000000","message":"python-requests and python-botocore implicitly pull in python-urllib3\n(verified on centos and debian)\nNormally I would request that we explicitly add this to the spec file, but I think its safe to rely on it being implicitly pulled in.","commit_id":"4d35242a0e716028d6e937e2283c74946841a822"}],"sysinv/sysinv/sysinv/sysinv/common/utils.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"bc595499d7cda44e3b32385a74d755bc7a77b4d1","unresolved":true,"context_lines":[{"line_number":2482,"context_line":"    \"\"\""},{"line_number":2483,"context_line":"    def _is_fluxcd_app_compliant(path):"},{"line_number":2484,"context_line":"        \"\"\"Check if the directory has the desired FluxCD app structure\"\"\""},{"line_number":2485,"context_line":"        mandatory_components \u003d (\"base\", \"kustomization.yaml\")"},{"line_number":2486,"context_line":"        check_mandatory \u003d all(comp in os.listdir(path)"},{"line_number":2487,"context_line":"                              for comp in mandatory_components)"},{"line_number":2488,"context_line":"        return check_mandatory"}],"source_content_type":"text/x-python","patch_set":2,"id":"a6994940_239c8601","line":2485,"updated":"2022-05-19 22:44:03.000000000","message":"I\u0027d export kustomize_base.ROOT_KUSTOMIZE_FILE to constants.py and reuse it here for consistency.","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49bb122bfd4af44bfbcd2ace553bb02d247e1ac7","unresolved":false,"context_lines":[{"line_number":2482,"context_line":"    \"\"\""},{"line_number":2483,"context_line":"    def _is_fluxcd_app_compliant(path):"},{"line_number":2484,"context_line":"        \"\"\"Check if the directory has the desired FluxCD app structure\"\"\""},{"line_number":2485,"context_line":"        mandatory_components \u003d (\"base\", \"kustomization.yaml\")"},{"line_number":2486,"context_line":"        check_mandatory \u003d all(comp in os.listdir(path)"},{"line_number":2487,"context_line":"                              for comp in mandatory_components)"},{"line_number":2488,"context_line":"        return check_mandatory"}],"source_content_type":"text/x-python","patch_set":2,"id":"c96bfc8e_7355908f","line":2485,"in_reply_to":"a6994940_239c8601","updated":"2022-05-20 15:24:46.000000000","message":"Done","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"}],"sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"bc595499d7cda44e3b32385a74d755bc7a77b4d1","unresolved":true,"context_lines":[{"line_number":4574,"context_line":"        for release in helmrelease_doc[0][\u0027releases\u0027]:"},{"line_number":4575,"context_line":"            try:"},{"line_number":4576,"context_line":"                if self._kube.get_custom_resource(\"helm.toolkit.fluxcd.io\","},{"line_number":4577,"context_line":"                        \"v2beta1\", release[\"namespace\"], \"helmreleases\","},{"line_number":4578,"context_line":"                        release[\u0027name\u0027]):"},{"line_number":4579,"context_line":""},{"line_number":4580,"context_line":"                    self._kube.delete_custom_resource(\"helm.toolkit.fluxcd.io\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a82a893_d5940b22","line":4577,"updated":"2022-05-19 22:44:03.000000000","message":"Is there any way to not hardcode this version and get it from the current version of fluxcd in use instead?","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49bb122bfd4af44bfbcd2ace553bb02d247e1ac7","unresolved":false,"context_lines":[{"line_number":4574,"context_line":"        for release in helmrelease_doc[0][\u0027releases\u0027]:"},{"line_number":4575,"context_line":"            try:"},{"line_number":4576,"context_line":"                if self._kube.get_custom_resource(\"helm.toolkit.fluxcd.io\","},{"line_number":4577,"context_line":"                        \"v2beta1\", release[\"namespace\"], \"helmreleases\","},{"line_number":4578,"context_line":"                        release[\u0027name\u0027]):"},{"line_number":4579,"context_line":""},{"line_number":4580,"context_line":"                    self._kube.delete_custom_resource(\"helm.toolkit.fluxcd.io\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df33e6b6_c2ae4d64","line":4577,"in_reply_to":"9a82a893_d5940b22","updated":"2022-05-20 15:24:46.000000000","message":"Possibly. But for this change, I\u0027d prefer to keep it simple. So centralized where this is defined in the constants so we only have one place to change. When we upgrade the FluxCD controllers, we can implelment a auto-detect function.","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"bc595499d7cda44e3b32385a74d755bc7a77b4d1","unresolved":true,"context_lines":[{"line_number":4578,"context_line":"                        release[\u0027name\u0027]):"},{"line_number":4579,"context_line":""},{"line_number":4580,"context_line":"                    self._kube.delete_custom_resource(\"helm.toolkit.fluxcd.io\","},{"line_number":4581,"context_line":"                        \"v2beta1\", release[\"namespace\"], \"helmreleases\","},{"line_number":4582,"context_line":"                        release[\u0027name\u0027])"},{"line_number":4583,"context_line":"            except Exception as e:"},{"line_number":4584,"context_line":"                LOG.error(\"Attemting to cleanup HelmRelease {}/{} \""}],"source_content_type":"text/x-python","patch_set":2,"id":"afde1388_d382042b","line":4581,"updated":"2022-05-19 22:44:03.000000000","message":"ditto","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49bb122bfd4af44bfbcd2ace553bb02d247e1ac7","unresolved":false,"context_lines":[{"line_number":4578,"context_line":"                        release[\u0027name\u0027]):"},{"line_number":4579,"context_line":""},{"line_number":4580,"context_line":"                    self._kube.delete_custom_resource(\"helm.toolkit.fluxcd.io\","},{"line_number":4581,"context_line":"                        \"v2beta1\", release[\"namespace\"], \"helmreleases\","},{"line_number":4582,"context_line":"                        release[\u0027name\u0027])"},{"line_number":4583,"context_line":"            except Exception as e:"},{"line_number":4584,"context_line":"                LOG.error(\"Attemting to cleanup HelmRelease {}/{} \""}],"source_content_type":"text/x-python","patch_set":2,"id":"a61ce8a0_a3f067ef","line":4581,"in_reply_to":"afde1388_d382042b","updated":"2022-05-20 15:24:46.000000000","message":"Done","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e6a688b6af1d0b570add1eaa8adbdafef7d11b50","unresolved":true,"context_lines":[{"line_number":565,"context_line":"            with io.open(app_images_file, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":566,"context_line":"                images_file \u003d yaml.safe_load(f)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"        helmrepo_path \u003d os.path.join(manifest, \"base\", \"helmrepository.yaml\")"},{"line_number":569,"context_line":"        root_kustomization_path \u003d os.path.join("},{"line_number":570,"context_line":"            manifest, constants.APP_ROOT_KUSTOMIZE_FILE)"},{"line_number":571,"context_line":"        for f in (helmrepo_path, root_kustomization_path):"}],"source_content_type":"text/x-python","patch_set":3,"id":"28eee190_c9c21b32","line":568,"updated":"2022-05-20 15:43:34.000000000","message":"nit: not part of your change, but if you send another PS, do you care exporting this one to constants.py as well?","commit_id":"9adc444408f063bc50117f4a64fd63b25b96b1d0"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"d7839e7242d3837662be3b962c6a03ca8fad2bf2","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            with io.open(app_images_file, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":566,"context_line":"                images_file \u003d yaml.safe_load(f)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"        helmrepo_path \u003d os.path.join(manifest, \"base\", \"helmrepository.yaml\")"},{"line_number":569,"context_line":"        root_kustomization_path \u003d os.path.join("},{"line_number":570,"context_line":"            manifest, constants.APP_ROOT_KUSTOMIZE_FILE)"},{"line_number":571,"context_line":"        for f in (helmrepo_path, root_kustomization_path):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9c31f20c_bf8d27d6","line":568,"in_reply_to":"28eee190_c9c21b32","updated":"2022-05-20 20:14:05.000000000","message":"I\u0027d like to avoid another test cycle at this point. Can handle this with another change. I think these \"base\" elements path should be refactored into a common routine, since it\u0027s used in multiple locations and duplicated.","commit_id":"9adc444408f063bc50117f4a64fd63b25b96b1d0"}],"sysinv/sysinv/sysinv/sysinv/helm/base.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"bc595499d7cda44e3b32385a74d755bc7a77b4d1","unresolved":true,"context_lines":[{"line_number":427,"context_line":"        current conditions in the platform"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        Changes include updates to manifest documents for the following schemas:"},{"line_number":430,"context_line":"        armada/Manifest/v1, armada/ChartGroup/v1, armada/Chart/v1."},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        :param operator: an instance of the FluxCDKustomizeOperator"},{"line_number":433,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"97475689_bef29f57","line":430,"updated":"2022-05-19 22:44:03.000000000","message":"armada?","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49bb122bfd4af44bfbcd2ace553bb02d247e1ac7","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        current conditions in the platform"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        Changes include updates to manifest documents for the following schemas:"},{"line_number":430,"context_line":"        armada/Manifest/v1, armada/ChartGroup/v1, armada/Chart/v1."},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        :param operator: an instance of the FluxCDKustomizeOperator"},{"line_number":433,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff8d1a39_5730b256","line":430,"in_reply_to":"97475689_bef29f57","updated":"2022-05-20 15:24:46.000000000","message":"Copy/paste error. Fixed","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"d74339256ded47365d4379601dabed1c1491d89a","unresolved":true,"context_lines":[{"line_number":426,"context_line":"        make dynamic structural changes to the application manifest based on the"},{"line_number":427,"context_line":"        current conditions in the platform"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        Changes currenty include updates to the top level kustomize manifest to"},{"line_number":430,"context_line":"        disable helm releases."},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        :param operator: an instance of the FluxCDKustomizeOperator"}],"source_content_type":"text/x-python","patch_set":4,"id":"7b63850d_e8a5f8e1","line":429,"range":{"start_line":429,"start_character":16,"end_line":429,"end_character":25},"updated":"2022-05-24 19:05:53.000000000","message":"nit: currently","commit_id":"4d35242a0e716028d6e937e2283c74946841a822"}],"sysinv/sysinv/sysinv/sysinv/helm/helm.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"81aa22dfaccfe020d6a61a94d447a67c2f004164","unresolved":true,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"                # Update manifest docs based on the plugin directives. If the"},{"line_number":1068,"context_line":"                # application does not provide a manifest operator, the"},{"line_number":1069,"context_line":"                # GenericArmadaManifestOperator is used and chart specific"},{"line_number":1070,"context_line":"                # operations can be skipped."},{"line_number":1071,"context_line":"                if kustomize_op.APP:"},{"line_number":1072,"context_line":"                    if chart_name in self.chart_operators:"}],"source_content_type":"text/x-python","patch_set":3,"id":"c9dfe983_7d88a99a","line":1069,"updated":"2022-05-20 17:01:21.000000000","message":"isn\u0027t this referece supposed to be to GenericFluxCDKustomizeOperator?","commit_id":"9adc444408f063bc50117f4a64fd63b25b96b1d0"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"d7839e7242d3837662be3b962c6a03ca8fad2bf2","unresolved":false,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"                # Update manifest docs based on the plugin directives. If the"},{"line_number":1068,"context_line":"                # application does not provide a manifest operator, the"},{"line_number":1069,"context_line":"                # GenericArmadaManifestOperator is used and chart specific"},{"line_number":1070,"context_line":"                # operations can be skipped."},{"line_number":1071,"context_line":"                if kustomize_op.APP:"},{"line_number":1072,"context_line":"                    if chart_name in self.chart_operators:"}],"source_content_type":"text/x-python","patch_set":3,"id":"2e7410be_0270e3bf","line":1069,"in_reply_to":"c9dfe983_7d88a99a","updated":"2022-05-20 20:14:05.000000000","message":"Done","commit_id":"9adc444408f063bc50117f4a64fd63b25b96b1d0"}],"sysinv/sysinv/sysinv/sysinv/helm/kustomize_base.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"bc595499d7cda44e3b32385a74d755bc7a77b4d1","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        self.kustomization_fqpn \u003d None           # Updated kustomization.yaml"},{"line_number":37,"context_line":"        self.release_cleanup_fqpn \u003d None         # Helm release cleanup data"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.kustomization_content \u003d []          # original app manifest content"},{"line_number":40,"context_line":"        self.chart_to_resource_map \u003d {}          # dict used to disable charts"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.kustomization_resources \u003d []        # kustomize resource list"}],"source_content_type":"text/x-python","patch_set":2,"id":"7347ec56_6e4fca3d","line":39,"updated":"2022-05-19 22:44:03.000000000","message":"nit: capitalize comment as in the other lines","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49bb122bfd4af44bfbcd2ace553bb02d247e1ac7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.kustomization_fqpn \u003d None           # Updated kustomization.yaml"},{"line_number":37,"context_line":"        self.release_cleanup_fqpn \u003d None         # Helm release cleanup data"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.kustomization_content \u003d []          # original app manifest content"},{"line_number":40,"context_line":"        self.chart_to_resource_map \u003d {}          # dict used to disable charts"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.kustomization_resources \u003d []        # kustomize resource list"}],"source_content_type":"text/x-python","patch_set":2,"id":"c2b7f5b9_77c8f21a","line":39,"in_reply_to":"7347ec56_6e4fca3d","updated":"2022-05-20 15:24:46.000000000","message":"Done","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"bc595499d7cda44e3b32385a74d755bc7a77b4d1","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __str__(self):"},{"line_number":51,"context_line":"        return json.dumps({"},{"line_number":52,"context_line":"            \u0027kustomization.yaml\u0027: self.kustomization_content,"},{"line_number":53,"context_line":"            \u0027chart_to_resource_map\u0027: self.chart_to_resource_map,"},{"line_number":54,"context_line":"            \u0027chart_cleanup\u0027: self.chart_cleanup,"},{"line_number":55,"context_line":"        }, indent\u003d2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"19a7db1b_6077326b","line":52,"updated":"2022-05-19 22:44:03.000000000","message":"Reuse ROOT_KUSTOMIZE_FILE","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49bb122bfd4af44bfbcd2ace553bb02d247e1ac7","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __str__(self):"},{"line_number":51,"context_line":"        return json.dumps({"},{"line_number":52,"context_line":"            \u0027kustomization.yaml\u0027: self.kustomization_content,"},{"line_number":53,"context_line":"            \u0027chart_to_resource_map\u0027: self.chart_to_resource_map,"},{"line_number":54,"context_line":"            \u0027chart_cleanup\u0027: self.chart_cleanup,"},{"line_number":55,"context_line":"        }, indent\u003d2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7031c014_9448f5eb","line":52,"in_reply_to":"19a7db1b_6077326b","updated":"2022-05-20 15:24:46.000000000","message":"Done","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28531,"name":"Kristine Bujold","email":"Kristine.Bujold@windriver.com","username":"kbujold"},"change_message_id":"74a4eaff92e1be258de89c2abd3f743da6f4c5b7","unresolved":true,"context_lines":[{"line_number":246,"context_line":"        else:"},{"line_number":247,"context_line":"            LOG.info(\"%s is not needed. All charts are enabled.\" % self.release_cleanup_fqpn)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def helm_release_resource_delete(self, chart):"},{"line_number":250,"context_line":"        \"\"\" Delete a helm release resource"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        This method will remove a chart\u0027s resource from the top level"}],"source_content_type":"text/x-python","patch_set":2,"id":"c04f8e2b_2f3acabb","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":50},"updated":"2022-05-19 18:32:08.000000000","message":"Could a chart name not exists in two different application? Should we not pass in the app_id as well?","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"c17736d0f4c196db1c33677fa0dd17479b24f0cc","unresolved":true,"context_lines":[{"line_number":246,"context_line":"        else:"},{"line_number":247,"context_line":"            LOG.info(\"%s is not needed. All charts are enabled.\" % self.release_cleanup_fqpn)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def helm_release_resource_delete(self, chart):"},{"line_number":250,"context_line":"        \"\"\" Delete a helm release resource"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        This method will remove a chart\u0027s resource from the top level"}],"source_content_type":"text/x-python","patch_set":2,"id":"7b3a7852_339cb84b","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":50},"in_reply_to":"736c2d59_70004adb","updated":"2022-05-19 18:53:25.000000000","message":"The framework passes the manifest directory to the operator\u0027s load function. So it knows which app\u0027s top-level kusomization file to update. So that will disable the appropriate helm release in the global namespace for the application.","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"49bb122bfd4af44bfbcd2ace553bb02d247e1ac7","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        else:"},{"line_number":247,"context_line":"            LOG.info(\"%s is not needed. All charts are enabled.\" % self.release_cleanup_fqpn)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def helm_release_resource_delete(self, chart):"},{"line_number":250,"context_line":"        \"\"\" Delete a helm release resource"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        This method will remove a chart\u0027s resource from the top level"}],"source_content_type":"text/x-python","patch_set":2,"id":"3e12210b_5c2df0da","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":50},"in_reply_to":"7b3a7852_339cb84b","updated":"2022-05-20 15:24:46.000000000","message":"Done","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"},{"author":{"_account_id":28531,"name":"Kristine Bujold","email":"Kristine.Bujold@windriver.com","username":"kbujold"},"change_message_id":"fdd13d9fa67c4e54e6730bfbcd38559c357f310a","unresolved":true,"context_lines":[{"line_number":246,"context_line":"        else:"},{"line_number":247,"context_line":"            LOG.info(\"%s is not needed. All charts are enabled.\" % self.release_cleanup_fqpn)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def helm_release_resource_delete(self, chart):"},{"line_number":250,"context_line":"        \"\"\" Delete a helm release resource"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        This method will remove a chart\u0027s resource from the top level"}],"source_content_type":"text/x-python","patch_set":2,"id":"736c2d59_70004adb","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":50},"in_reply_to":"c04f8e2b_2f3acabb","updated":"2022-05-19 18:33:19.000000000","message":"For example \n\n sudo -u postgres psql -U postgres -d sysinv -c \"select * from  helm_overrides where name\u003d\u0027ingress-nginx\u0027\"\nPassword:\n         created_at         |         updated_at         | deleted_at | id  |     name      |  namespace  | user_overrides | app_id | system_overrides\n----------------------------+----------------------------+------------+-----+---------------+-------------+----------------+--------+-------------------\n 2022-05-17 15:12:01.205148 | 2022-05-17 15:12:01.213671 |            |   1 | ingress-nginx | kube-system |                |      1 | {\"enabled\": true}\n 2022-05-18 17:16:00.23364  | 2022-05-18 17:16:00.240129 |            | 147 | ingress-nginx | monitor     |                |     17 | {\"enabled\": true}","commit_id":"962fbbe0ce13bd9340da2f83d0fcba3d51dd891a"}]}
