)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"8e9c75108fca09bce8576e8813b76befbfe40a1e","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    PASS: New unit tests using simplex and non-simplex simulation"},{"line_number":20,"context_line":"    PASS: Configure pci-sriov interfaces on onboard N3000 devices"},{"line_number":21,"context_line":"    PASS: Unlock and check Puppet logs for errors"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: 1976540"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I57ef19011b8f4d9a98ada4db66b5c7cfcb12de21"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"90d516c7_ed42b3c8","line":22,"updated":"2022-06-02 14:39:05.000000000","message":"simplex upgrade (backup\u0026restore) should also be confirmed with this device","commit_id":"694461dd4d51b774b5536e7905366f0d6a97d8f6"},{"author":{"_account_id":34648,"name":"Caio Bruchert","email":"caio.bruchert@windriver.com","username":"cbrucher"},"change_message_id":"39f585bdfc321f65edf68883035c8f272f161577","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    PASS: New unit tests using simplex and non-simplex simulation"},{"line_number":20,"context_line":"    PASS: Configure pci-sriov interfaces on onboard N3000 devices"},{"line_number":21,"context_line":"    PASS: Unlock and check Puppet logs for errors"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: 1976540"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I57ef19011b8f4d9a98ada4db66b5c7cfcb12de21"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c35403db_bfffc692","line":22,"in_reply_to":"90d516c7_ed42b3c8","updated":"2022-06-08 14:29:43.000000000","message":"Done","commit_id":"694461dd4d51b774b5536e7905366f0d6a97d8f6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"93eac58ce93e3716eb7cb0a06ccca4cc3fec6025","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30cc9f23_35d97aa5","updated":"2022-06-06 14:58:57.000000000","message":"Code change looks good to me.  Pending upgrade testing as requested by John","commit_id":"ef600db3fc855d2e76a1ff3de4b1375249f91855"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"0384bd3056eaeaa3582407a56cd5fb5958798350","unresolved":true,"context_lines":[{"line_number":2399,"context_line":"        \"\"\""},{"line_number":2400,"context_line":"        inic_mac_dict \u003d dict()"},{"line_number":2401,"context_line":"        for inic in inic_dict_array:"},{"line_number":2402,"context_line":"            if inic[\u0027pdevice\u0027] \u003d\u003d \u0027Device [0d58]\u0027:"},{"line_number":2403,"context_line":"                inic_mac_dict[inic[\u0027mac\u0027]] \u003d inic"},{"line_number":2404,"context_line":""},{"line_number":2405,"context_line":"        if len(inic_mac_dict) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"51719302_81caa272","line":2402,"updated":"2022-06-01 19:48:24.000000000","message":"I think we should explore a way to make use of the existing get_pci_device_id:\n\nWe do have an existing is_an_n3000_i40_device which operates on puppet\u0027s interface dict but there\u0027s an example there.\n\nhttps://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/sysinv/puppet/interface.py#L466\n\nIt would probably be possible to use the existing is_an_n3000_i40_device but the calling of _fix_db_pciaddr_for_n3000_i40 would have to be moved into the interface processing in order to get the iftype.  is_an_n3000_i40_device would then have to be moved to sysinv/common/interface.py","commit_id":"694461dd4d51b774b5536e7905366f0d6a97d8f6"},{"author":{"_account_id":34648,"name":"Caio Bruchert","email":"caio.bruchert@windriver.com","username":"cbrucher"},"change_message_id":"d67c3919807ec087927d8431ce528ea6dccd7e6a","unresolved":false,"context_lines":[{"line_number":2399,"context_line":"        \"\"\""},{"line_number":2400,"context_line":"        inic_mac_dict \u003d dict()"},{"line_number":2401,"context_line":"        for inic in inic_dict_array:"},{"line_number":2402,"context_line":"            if inic[\u0027pdevice\u0027] \u003d\u003d \u0027Device [0d58]\u0027:"},{"line_number":2403,"context_line":"                inic_mac_dict[inic[\u0027mac\u0027]] \u003d inic"},{"line_number":2404,"context_line":""},{"line_number":2405,"context_line":"        if len(inic_mac_dict) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d38486be_91a3198a","line":2402,"in_reply_to":"51719302_81caa272","updated":"2022-06-02 20:25:11.000000000","message":"Moving is_an_n3000_i40_device looks more complicated to me since it uses a context object from puppet and that\u0027s why I think that using get_pci_device_id directly is better.","commit_id":"694461dd4d51b774b5536e7905366f0d6a97d8f6"}],"sysinv/sysinv/sysinv/sysinv/tests/conductor/test_manager.py":[{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"f1836ca54923d37500e9b9804cde6d5e90d09290","unresolved":true,"context_lines":[{"line_number":2751,"context_line":"        \"\"\""},{"line_number":2752,"context_line":"        # Create compute-0 node"},{"line_number":2753,"context_line":"        config_uuid \u003d str(uuid.uuid4())"},{"line_number":2754,"context_line":"        ihost \u003d self._create_test_ihost("},{"line_number":2755,"context_line":"            hostname\u003d\u0027compute-0\u0027, mgmt_mac\u003d\u002722:44:33:55:11:77\u0027, uuid\u003dstr(uuid.uuid4()),"},{"line_number":2756,"context_line":"            personality\u003dconstants.WORKER, config_status\u003dNone, config_applied\u003dconfig_uuid,"},{"line_number":2757,"context_line":"            config_target\u003dconfig_uuid, invprovision\u003dconstants.PROVISIONED,"},{"line_number":2758,"context_line":"            administrative\u003dconstants.ADMIN_UNLOCKED, operational\u003dconstants.OPERATIONAL_ENABLED,"},{"line_number":2759,"context_line":"            availability\u003dconstants.AVAILABILITY_ONLINE,"},{"line_number":2760,"context_line":"        )"},{"line_number":2761,"context_line":""},{"line_number":2762,"context_line":"        mock_find_local_mgmt_interface_vlan_id \u003d mock.MagicMock()"},{"line_number":2763,"context_line":"        p \u003d mock.patch("},{"line_number":2764,"context_line":"            \u0027sysinv.conductor.manager.ConductorManager._find_local_mgmt_interface_vlan_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"410047e8_6276aea7","line":2761,"range":{"start_line":2754,"start_character":0,"end_line":2761,"end_character":0},"updated":"2022-06-02 11:27:56.000000000","message":"can you change to be a controller instead of a worker?","commit_id":"694461dd4d51b774b5536e7905366f0d6a97d8f6"},{"author":{"_account_id":34648,"name":"Caio Bruchert","email":"caio.bruchert@windriver.com","username":"cbrucher"},"change_message_id":"d67c3919807ec087927d8431ce528ea6dccd7e6a","unresolved":false,"context_lines":[{"line_number":2751,"context_line":"        \"\"\""},{"line_number":2752,"context_line":"        # Create compute-0 node"},{"line_number":2753,"context_line":"        config_uuid \u003d str(uuid.uuid4())"},{"line_number":2754,"context_line":"        ihost \u003d self._create_test_ihost("},{"line_number":2755,"context_line":"            hostname\u003d\u0027compute-0\u0027, mgmt_mac\u003d\u002722:44:33:55:11:77\u0027, uuid\u003dstr(uuid.uuid4()),"},{"line_number":2756,"context_line":"            personality\u003dconstants.WORKER, config_status\u003dNone, config_applied\u003dconfig_uuid,"},{"line_number":2757,"context_line":"            config_target\u003dconfig_uuid, invprovision\u003dconstants.PROVISIONED,"},{"line_number":2758,"context_line":"            administrative\u003dconstants.ADMIN_UNLOCKED, operational\u003dconstants.OPERATIONAL_ENABLED,"},{"line_number":2759,"context_line":"            availability\u003dconstants.AVAILABILITY_ONLINE,"},{"line_number":2760,"context_line":"        )"},{"line_number":2761,"context_line":""},{"line_number":2762,"context_line":"        mock_find_local_mgmt_interface_vlan_id \u003d mock.MagicMock()"},{"line_number":2763,"context_line":"        p \u003d mock.patch("},{"line_number":2764,"context_line":"            \u0027sysinv.conductor.manager.ConductorManager._find_local_mgmt_interface_vlan_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8384db3f_d2a3b73e","line":2761,"range":{"start_line":2754,"start_character":0,"end_line":2761,"end_character":0},"in_reply_to":"410047e8_6276aea7","updated":"2022-06-02 20:25:11.000000000","message":"Done","commit_id":"694461dd4d51b774b5536e7905366f0d6a97d8f6"}]}