)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"6af8d097cea90b40085642e5321b5ed3cccc3d60","unresolved":true,"context_lines":[{"line_number":16,"context_line":"more than one release using the same chart. This fix will allow"},{"line_number":17,"context_line":"fulfilling both cases."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It worths mentioning that I had to change the way some mocks were done"},{"line_number":20,"context_line":"on test_kubernetes.py and test_manager.py since they were producing"},{"line_number":21,"context_line":"false positives on kustomize_base.py#L139."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"095fae58_0371e400","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"updated":"2022-06-13 04:33:42.000000000","message":"nit: It\u0027s worth","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"6359ff2e493556d82969e10a40443e061ca3eaf7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"more than one release using the same chart. This fix will allow"},{"line_number":17,"context_line":"fulfilling both cases."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It worths mentioning that I had to change the way some mocks were done"},{"line_number":20,"context_line":"on test_kubernetes.py and test_manager.py since they were producing"},{"line_number":21,"context_line":"false positives on kustomize_base.py#L139."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"e324c57e_f2d2bbd6","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"in_reply_to":"095fae58_0371e400","updated":"2022-06-13 17:05:13.000000000","message":"Done","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ee88a013_9b54734b","updated":"2022-06-10 11:51:02.000000000","message":"Just started fluxcd work...  too many \u0027helm\u0027 and \u0027kustomize\u0027 variables and files in general.\nWe need to improve the naming somehow.\nSuggested improved naming.","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":28531,"name":"Kristine Bujold","email":"Kristine.Bujold@windriver.com","username":"kbujold"},"change_message_id":"2e5cd37f2e730faba5ecb12139ac10f44dd3bc05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"eafd3be6_1122c108","updated":"2022-06-10 13:34:39.000000000","message":"Please test that these changes works with the current WRA fluxCD tar file. The one I gave you for testing is hacked to think the system is a Subcloud. You need to also test with a non hacked tar file.\n\nOur Jenkins nightly build WRA tar files are located here (Flux and Armada)\nyow-cgts4-lx.wrs.com:/localdisk/loadbuild/jenkins/WRA_Dev_Build/latest_build/helm-charts/centos/","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"78c90e83_6c17dc46","updated":"2022-06-10 14:35:46.000000000","message":"Thanks Dan and Kristine, updates coming right up.","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"6af8d097cea90b40085642e5321b5ed3cccc3d60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3f49a352_5cd3d24d","updated":"2022-06-13 04:33:42.000000000","message":"Seem fine to me, but need an update to platform-armada-app that has a KustomizeOperator to go in at the same time as this change. It needs a lookup table to provide the helm release for the chart. Something like:\n\n modified   python-k8sapp-platform/k8sapp_platform/k8sapp_platform/helm/ceph_fs_provisioner.py\n @@ -125,7 +125,8 @@ class CephFSProvisionerHelm(base.BaseHelm):\n          # by the user\n          if not self._is_enabled(operator.APP, self.CHART,\n                                  app_constants.HELM_NS_CEPH_FS_PROVISIONER):\n -            operator.helm_release_resource_delete(self.CHART)\n +            operator.helm_release_resource_delete(\n +                operator.CHART_RELEASE_LUT[self.CHART])\n  \n      def get_overrides(self, namespace\u003dNone):\n  \n modified   python-k8sapp-platform/k8sapp_platform/k8sapp_platform/helm/ceph_pools_audit.py\n @@ -40,7 +40,8 @@ class CephPoolsAuditHelm(base.BaseHelm):\n          # by the user\n          if not self._is_enabled(operator.APP, self.CHART,\n                                  common.HELM_NS_RBD_PROVISIONER):\n -            operator.helm_release_resource_delete(self.CHART)\n +            operator.helm_release_resource_delete(\n +                operator.CHART_RELEASE_LUT[self.CHART])\n  \n      def get_namespaces(self):\n          return self.SUPPORTED_NAMESPACES\n modified   python-k8sapp-platform/k8sapp_platform/k8sapp_platform/helm/rbd_provisioner.py\n @@ -42,7 +42,8 @@ class RbdProvisionerHelm(base.BaseHelm):\n          # by the user\n          if not self._is_enabled(operator.APP, self.CHART,\n                                  common.HELM_NS_RBD_PROVISIONER):\n -            operator.helm_release_resource_delete(self.CHART)\n +            operator.helm_release_resource_delete(\n +                operator.CHART_RELEASE_LUT[self.CHART])\n  \n      def get_overrides(self, namespace\u003dNone):\n  \n modified   python-k8sapp-platform/k8sapp_platform/k8sapp_platform/kustomize/kustomize_platform.py\n @@ -16,6 +16,12 @@ class PlatformFluxCDKustomizeOperator(base.FluxCDKustomizeOperator):\n  \n      APP \u003d constants.HELM_APP_PLATFORM\n  \n +    CHART_RELEASE_LUT \u003d {\n +        CephPoolsAuditHelm.CHART: \u0027stx-ceph-pools-audit\u0027,\n +        RbdProvisionerHelm.CHART: \u0027stx-rbd-provisioner\u0027,\n +        CephFSProvisionerHelm.CHART: \u0027stx-cephfs-provisioner\u0027,\n +    }\n +\n      def platform_mode_kustomize_updates(self, dbapi, mode):\n          \"\"\" Update the top-level kustomization resource list\n\nWill bump my vote when I see a review posted.","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"ed42f84fc373f7899193b98ea018ad1866145e35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c0a0a142_2903fb1c","updated":"2022-06-12 14:09:17.000000000","message":"lgtm. Will let Thiago mark the comment \u0027ack\u0027 resolved.","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"70e505578fcf499180dd2daf1290d96141240856","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ad05a9af_e331774b","in_reply_to":"3f49a352_5cd3d24d","updated":"2022-06-13 13:20:54.000000000","message":"Agreed. I don\u0027t think it will stop working though since the releases and the charts have the same name on platform-app, but will do right away. WRA will need something similar @Kristine","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"}],"sysinv/sysinv/sysinv/sysinv/helm/base.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"bc1934f4f1fa947824d14e8de24dbdf9e5282e6e","unresolved":true,"context_lines":[{"line_number":463,"context_line":"        num_osd \u003d max(len(num_osd), 1)"},{"line_number":464,"context_line":"        max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":465,"context_line":"        return 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":469,"context_line":"class FluxCDBaseHelm(BaseHelm):"}],"source_content_type":"text/x-python","patch_set":16,"id":"8f9c1814_9ef6cd2e","line":466,"updated":"2022-06-13 17:00:34.000000000","message":"Seems fine to me. I just question is now the time you want to introduce churn as we are at the end of the stx 7.0 release cycle.","commit_id":"5c67248f40b5fb073606e1515321122f88283c08"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"6359ff2e493556d82969e10a40443e061ca3eaf7","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        num_osd \u003d max(len(num_osd), 1)"},{"line_number":464,"context_line":"        max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":465,"context_line":"        return 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":469,"context_line":"class FluxCDBaseHelm(BaseHelm):"}],"source_content_type":"text/x-python","patch_set":16,"id":"8dd88e3d_af362531","line":466,"in_reply_to":"8f9c1814_9ef6cd2e","updated":"2022-06-13 17:05:13.000000000","message":"I don\u0027t think there is churn at all since only platform-app is using that right now and the apps might choose when it would be the best for each one of them to change the plugins to inherit for this new class.","commit_id":"5c67248f40b5fb073606e1515321122f88283c08"}],"sysinv/sysinv/sysinv/sysinv/helm/kustomize_base.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"25418f7321b0492a04c272e8746c26cf8a682f33","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"                    rls_kust_namespace \u003d helm_release_kust[0].get(\"namespace\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"                namespace \u003d rls_kust_namespace or rls_namespace or self.kustomization_namespace"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"                # Save pertinent data for disabling chart resources and cleaning"},{"line_number":171,"context_line":"                # up existing helm releases after being disabled"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed89d1a5_a6514731","line":168,"updated":"2022-06-08 17:55:52.000000000","message":"We we haven\u0027t enforced any pattern with regards to namespace. I think the assumption to date is that the app should be self-container within it\u0027s own namespace. \n\nWith that said, maybe break this up into an if/elif/else with a LOG.debug() indicating which namespace we are using, will help in debug efforts.","commit_id":"89351d0c8491e9cafd6e70e181fe27f76c4f0110"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"3794c9435178e389ecaba4d331dfb71473a3f3dc","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"                    rls_kust_namespace \u003d helm_release_kust[0].get(\"namespace\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"                namespace \u003d rls_kust_namespace or rls_namespace or self.kustomization_namespace"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"                # Save pertinent data for disabling chart resources and cleaning"},{"line_number":171,"context_line":"                # up existing helm releases after being disabled"}],"source_content_type":"text/x-python","patch_set":1,"id":"f79af794_d3a80089","line":168,"in_reply_to":"72c57b06_8d8fb7b8","updated":"2022-06-08 20:10:02.000000000","message":"Done","commit_id":"89351d0c8491e9cafd6e70e181fe27f76c4f0110"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e9ec5ca51ac92b65525f5e936540fcb0aa23d361","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"                    rls_kust_namespace \u003d helm_release_kust[0].get(\"namespace\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"                namespace \u003d rls_kust_namespace or rls_namespace or self.kustomization_namespace"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"                # Save pertinent data for disabling chart resources and cleaning"},{"line_number":171,"context_line":"                # up existing helm releases after being disabled"}],"source_content_type":"text/x-python","patch_set":1,"id":"72c57b06_8d8fb7b8","line":168,"in_reply_to":"ed89d1a5_a6514731","updated":"2022-06-08 18:32:01.000000000","message":"I was thinking about big apps that might want to use more than one namespace in the future and open that possibility since, on FluxCD/Kustomize, it looks like we can define namespaces in several places. Will do.","commit_id":"89351d0c8491e9cafd6e70e181fe27f76c4f0110"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"25418f7321b0492a04c272e8746c26cf8a682f33","unresolved":true,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"                # Save pertinent data for disabling chart resources and cleaning"},{"line_number":171,"context_line":"                # up existing helm releases after being disabled"},{"line_number":172,"context_line":"                self.helmrelease_resource_map.update({"},{"line_number":173,"context_line":"                    metadata_name: {"},{"line_number":174,"context_line":"                        \u0027name\u0027: metadata_name,"},{"line_number":175,"context_line":"                        \u0027namespace\u0027: namespace,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8c49312_494528af","line":172,"updated":"2022-06-08 17:55:52.000000000","message":"Let\u0027s make sure that the metadata_name is unique and blow up if it already exists. Lots of copy/paste activities happen with new apps. We should complain on the things that we expect to be unique.","commit_id":"89351d0c8491e9cafd6e70e181fe27f76c4f0110"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"e9ec5ca51ac92b65525f5e936540fcb0aa23d361","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"                # Save pertinent data for disabling chart resources and cleaning"},{"line_number":171,"context_line":"                # up existing helm releases after being disabled"},{"line_number":172,"context_line":"                self.helmrelease_resource_map.update({"},{"line_number":173,"context_line":"                    metadata_name: {"},{"line_number":174,"context_line":"                        \u0027name\u0027: metadata_name,"},{"line_number":175,"context_line":"                        \u0027namespace\u0027: namespace,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c78f80a_de0e706a","line":172,"in_reply_to":"a8c49312_494528af","updated":"2022-06-08 18:32:01.000000000","message":"Ack","commit_id":"89351d0c8491e9cafd6e70e181fe27f76c4f0110"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        self.original_kustomization_fqpn \u003d None  # Original kustomization.yaml"},{"line_number":37,"context_line":"        self.kustomization_fqpn \u003d None           # Updated kustomization.yaml"},{"line_number":38,"context_line":"        self.release_cleanup_fqpn \u003d None         # Helm release cleanup data"},{"line_number":39,"context_line":"        self.helmrepo_path \u003d None                # Updated helmrepository.yaml"},{"line_number":40,"context_line":"        self.original_helmrepo_fqpn \u003d None       # Original helmrepository.yaml"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.kustomization_content \u003d []          # Original app manifest content"}],"source_content_type":"text/x-python","patch_set":14,"id":"fb9d2248_d1b95f19","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":34},"updated":"2022-06-10 11:51:02.000000000","message":"Do we need to expose this here since it is used only locally in one function (_override_fluxcd_app_repo_url) ? \nMaybe planning to use it later?\n\nIf wanting to expose this, do we want to guarantee this will be defined?\n\nSeeing a branch, didn\u0027t follow the logic up:\n            # Copy the manifest and metadata file to the drbd\n            if os.path.isdir(app.inst_mfile):\n                shutil.copytree(app.inst_mfile, manifest_sync_path)\n                self._override_fluxcd_app_repo_url(manifest_sync_path)\n            else:\n                shutil.copy(app.inst_mfile, manifest_sync_path)","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"70e505578fcf499180dd2daf1290d96141240856","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.original_kustomization_fqpn \u003d None  # Original kustomization.yaml"},{"line_number":37,"context_line":"        self.kustomization_fqpn \u003d None           # Updated kustomization.yaml"},{"line_number":38,"context_line":"        self.release_cleanup_fqpn \u003d None         # Helm release cleanup data"},{"line_number":39,"context_line":"        self.helmrepo_path \u003d None                # Updated helmrepository.yaml"},{"line_number":40,"context_line":"        self.original_helmrepo_fqpn \u003d None       # Original helmrepository.yaml"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.kustomization_content \u003d []          # Original app manifest content"}],"source_content_type":"text/x-python","patch_set":14,"id":"49a42af1_3897afef","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":34},"in_reply_to":"4d8a0e54_c4f02ab9","updated":"2022-06-13 13:20:54.000000000","message":"Ack","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"ed42f84fc373f7899193b98ea018ad1866145e35","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        self.original_kustomization_fqpn \u003d None  # Original kustomization.yaml"},{"line_number":37,"context_line":"        self.kustomization_fqpn \u003d None           # Updated kustomization.yaml"},{"line_number":38,"context_line":"        self.release_cleanup_fqpn \u003d None         # Helm release cleanup data"},{"line_number":39,"context_line":"        self.helmrepo_path \u003d None                # Updated helmrepository.yaml"},{"line_number":40,"context_line":"        self.original_helmrepo_fqpn \u003d None       # Original helmrepository.yaml"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.kustomization_content \u003d []          # Original app manifest content"}],"source_content_type":"text/x-python","patch_set":14,"id":"4d8a0e54_c4f02ab9","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":34},"in_reply_to":"de6743e2_201aa278","updated":"2022-06-12 14:09:17.000000000","message":"This part is in conductor:\n            # Copy the manifest and metadata file to the drbd\n            if os.path.isdir(app.inst_mfile):\n                shutil.copytree(app.inst_mfile, manifest_sync_path)\n                self._override_fluxcd_app_repo_url(manifest_sync_path)\n            else:\n                shutil.copy(app.inst_mfile, manifest_sync_path)\n\n\nI was wondering about having 2 code paths and if self.helmrepo_path is used after that by direct access.\nFirst path where _override_fluxcd_app_repo_url is called, so self.helmrepo_path is defined(not None).\nSecond path where it is not.\n\nNot holding the review for this. Just something to think about.","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        self.original_kustomization_fqpn \u003d None  # Original kustomization.yaml"},{"line_number":37,"context_line":"        self.kustomization_fqpn \u003d None           # Updated kustomization.yaml"},{"line_number":38,"context_line":"        self.release_cleanup_fqpn \u003d None         # Helm release cleanup data"},{"line_number":39,"context_line":"        self.helmrepo_path \u003d None                # Updated helmrepository.yaml"},{"line_number":40,"context_line":"        self.original_helmrepo_fqpn \u003d None       # Original helmrepository.yaml"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.kustomization_content \u003d []          # Original app manifest content"}],"source_content_type":"text/x-python","patch_set":14,"id":"de6743e2_201aa278","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":34},"in_reply_to":"fb9d2248_d1b95f19","updated":"2022-06-10 14:35:46.000000000","message":"I kinda exposed that to be used on unittests. The process on the normal workflow is only one way (make a copy and use it) while on the test case I need to revert this process on tearDown.\n\nI don\u0027t exactly understood the second part, can\u0027t see that on code, but I think the helmrepository.yaml is mandatory to be on the base folder of the manifest, so not sure if we need that logic or just explode in case it doesn\u0027t exist.","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        # For these resources, find the HelmRelease info and build a resource"},{"line_number":122,"context_line":"        # map"},{"line_number":123,"context_line":"        for resource in self.kustomization_resources:"},{"line_number":124,"context_line":"            # expect a helrelease.yaml file to be present in a helm resource"},{"line_number":125,"context_line":"            # directory"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            # is the resource a directory?"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f687426_748e6a31","line":124,"range":{"start_line":124,"start_character":23,"end_line":124,"end_character":26},"updated":"2022-06-10 11:51:02.000000000","message":"helrelease -\u003e helmrelease .\n\nAlso check if there are any other occurrences in the file.","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # For these resources, find the HelmRelease info and build a resource"},{"line_number":122,"context_line":"        # map"},{"line_number":123,"context_line":"        for resource in self.kustomization_resources:"},{"line_number":124,"context_line":"            # expect a helrelease.yaml file to be present in a helm resource"},{"line_number":125,"context_line":"            # directory"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            # is the resource a directory?"}],"source_content_type":"text/x-python","patch_set":14,"id":"6b5fab3d_0e0f2508","line":124,"range":{"start_line":124,"start_character":23,"end_line":124,"end_character":26},"in_reply_to":"7f687426_748e6a31","updated":"2022-06-10 14:35:46.000000000","message":"Done","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":true,"context_lines":[{"line_number":132,"context_line":"                continue"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"            # is a helm release present?"},{"line_number":135,"context_line":"            helm_release_fqpn \u003d os.path.join(resource_fqpn, \"helmrelease.yaml\")"},{"line_number":136,"context_line":"            helmrelease_kustomization_fqpn \u003d os.path.join(resource_fqpn, \"kustomization.yaml\")"},{"line_number":137,"context_line":"            rls_kust_namespace \u003d None"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"f16cc5bf_d0fcd7b3","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":29},"updated":"2022-06-10 11:51:02.000000000","message":"Maybe grouping variables to resource makes more sense?: resource_helmrelease_fqpn","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                continue"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"            # is a helm release present?"},{"line_number":135,"context_line":"            helm_release_fqpn \u003d os.path.join(resource_fqpn, \"helmrelease.yaml\")"},{"line_number":136,"context_line":"            helmrelease_kustomization_fqpn \u003d os.path.join(resource_fqpn, \"kustomization.yaml\")"},{"line_number":137,"context_line":"            rls_kust_namespace \u003d None"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"51ea8d32_ac5537f9","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":29},"in_reply_to":"f16cc5bf_d0fcd7b3","updated":"2022-06-10 14:35:46.000000000","message":"Done","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"            # is a helm release present?"},{"line_number":135,"context_line":"            helm_release_fqpn \u003d os.path.join(resource_fqpn, \"helmrelease.yaml\")"},{"line_number":136,"context_line":"            helmrelease_kustomization_fqpn \u003d os.path.join(resource_fqpn, \"kustomization.yaml\")"},{"line_number":137,"context_line":"            rls_kust_namespace \u003d None"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            if os.path.isfile(helm_release_fqpn):"}],"source_content_type":"text/x-python","patch_set":14,"id":"8244f922_c7c52908","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":42},"updated":"2022-06-10 11:51:02.000000000","message":"Maybe grouping variables to resource makes more sense?: resource_kustomization_fqpn","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"            # is a helm release present?"},{"line_number":135,"context_line":"            helm_release_fqpn \u003d os.path.join(resource_fqpn, \"helmrelease.yaml\")"},{"line_number":136,"context_line":"            helmrelease_kustomization_fqpn \u003d os.path.join(resource_fqpn, \"kustomization.yaml\")"},{"line_number":137,"context_line":"            rls_kust_namespace \u003d None"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            if os.path.isfile(helm_release_fqpn):"}],"source_content_type":"text/x-python","patch_set":14,"id":"14580eb9_e31d570a","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":42},"in_reply_to":"8244f922_c7c52908","updated":"2022-06-10 14:35:46.000000000","message":"Done","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":true,"context_lines":[{"line_number":134,"context_line":"            # is a helm release present?"},{"line_number":135,"context_line":"            helm_release_fqpn \u003d os.path.join(resource_fqpn, \"helmrelease.yaml\")"},{"line_number":136,"context_line":"            helmrelease_kustomization_fqpn \u003d os.path.join(resource_fqpn, \"kustomization.yaml\")"},{"line_number":137,"context_line":"            rls_kust_namespace \u003d None"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            if os.path.isfile(helm_release_fqpn):"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"c08f6030_5764336a","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":30},"updated":"2022-06-10 11:51:02.000000000","message":"resource_kustomization_namespace?","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            # is a helm release present?"},{"line_number":135,"context_line":"            helm_release_fqpn \u003d os.path.join(resource_fqpn, \"helmrelease.yaml\")"},{"line_number":136,"context_line":"            helmrelease_kustomization_fqpn \u003d os.path.join(resource_fqpn, \"kustomization.yaml\")"},{"line_number":137,"context_line":"            rls_kust_namespace \u003d None"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            if os.path.isfile(helm_release_fqpn):"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"adcca409_5f2fe4b2","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":30},"in_reply_to":"c08f6030_5764336a","updated":"2022-06-10 14:35:46.000000000","message":"Done","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":true,"context_lines":[{"line_number":139,"context_line":"            if os.path.isfile(helm_release_fqpn):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"                with io.open(helm_release_fqpn, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":142,"context_line":"                    helm_release_doc \u003d list(yaml.load_all(f,"},{"line_number":143,"context_line":"                        Loader\u003dyaml.RoundTripLoader, preserve_quotes\u003dTrue))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"                if len(helm_release_doc) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":14,"id":"f56df8ae_e9bcc789","line":142,"range":{"start_line":142,"start_character":20,"end_line":142,"end_character":36},"updated":"2022-06-10 11:51:02.000000000","message":"because helm_release_fqpn -\u003e resource_helmrelease_fqpn, resource_helmrelease_contents?","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            if os.path.isfile(helm_release_fqpn):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"                with io.open(helm_release_fqpn, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":142,"context_line":"                    helm_release_doc \u003d list(yaml.load_all(f,"},{"line_number":143,"context_line":"                        Loader\u003dyaml.RoundTripLoader, preserve_quotes\u003dTrue))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"                if len(helm_release_doc) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":14,"id":"f41aed91_5ad62cd8","line":142,"range":{"start_line":142,"start_character":20,"end_line":142,"end_character":36},"in_reply_to":"f56df8ae_e9bcc789","updated":"2022-06-10 14:35:46.000000000","message":"Done","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"                # get the HelmRelease name"},{"line_number":151,"context_line":"                try:"},{"line_number":152,"context_line":"                    metadata_name \u003d helm_release_doc[0][\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":153,"context_line":"                    rls_namespace \u003d helm_release_doc[0][\u0027metadata\u0027].get(\"namespace\")"},{"line_number":154,"context_line":"                except Exception:"},{"line_number":155,"context_line":"                    LOG.error(\"Malformed HelmRelease: Unable to retreive the \""}],"source_content_type":"text/x-python","patch_set":14,"id":"bb38a3c6_b1563646","line":152,"range":{"start_line":152,"start_character":20,"end_line":152,"end_character":33},"updated":"2022-06-10 11:51:02.000000000","message":"resource_helmrelease_metadata_name?","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"                # get the HelmRelease name"},{"line_number":151,"context_line":"                try:"},{"line_number":152,"context_line":"                    metadata_name \u003d helm_release_doc[0][\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":153,"context_line":"                    rls_namespace \u003d helm_release_doc[0][\u0027metadata\u0027].get(\"namespace\")"},{"line_number":154,"context_line":"                except Exception:"},{"line_number":155,"context_line":"                    LOG.error(\"Malformed HelmRelease: Unable to retreive the \""}],"source_content_type":"text/x-python","patch_set":14,"id":"098e914d_eb2aa755","line":152,"range":{"start_line":152,"start_character":20,"end_line":152,"end_character":33},"in_reply_to":"bb38a3c6_b1563646","updated":"2022-06-10 14:35:46.000000000","message":"Done","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":true,"context_lines":[{"line_number":150,"context_line":"                # get the HelmRelease name"},{"line_number":151,"context_line":"                try:"},{"line_number":152,"context_line":"                    metadata_name \u003d helm_release_doc[0][\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":153,"context_line":"                    rls_namespace \u003d helm_release_doc[0][\u0027metadata\u0027].get(\"namespace\")"},{"line_number":154,"context_line":"                except Exception:"},{"line_number":155,"context_line":"                    LOG.error(\"Malformed HelmRelease: Unable to retreive the \""},{"line_number":156,"context_line":"                              \"metadata name from %s\" % helm_release_fqpn)"}],"source_content_type":"text/x-python","patch_set":14,"id":"38b7d210_8e1cf950","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":33},"updated":"2022-06-10 11:51:02.000000000","message":"resource_helmrelease_namespace?","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                # get the HelmRelease name"},{"line_number":151,"context_line":"                try:"},{"line_number":152,"context_line":"                    metadata_name \u003d helm_release_doc[0][\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":153,"context_line":"                    rls_namespace \u003d helm_release_doc[0][\u0027metadata\u0027].get(\"namespace\")"},{"line_number":154,"context_line":"                except Exception:"},{"line_number":155,"context_line":"                    LOG.error(\"Malformed HelmRelease: Unable to retreive the \""},{"line_number":156,"context_line":"                              \"metadata name from %s\" % helm_release_fqpn)"}],"source_content_type":"text/x-python","patch_set":14,"id":"48d206d2_8d934e21","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":33},"in_reply_to":"38b7d210_8e1cf950","updated":"2022-06-10 14:35:46.000000000","message":"Done","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":true,"context_lines":[{"line_number":159,"context_line":"                if os.path.isfile(helmrelease_kustomization_fqpn):"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"                    with io.open(helmrelease_kustomization_fqpn, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as fk:"},{"line_number":162,"context_line":"                        helm_release_kust \u003d list(yaml.load_all(fk,"},{"line_number":163,"context_line":"                            Loader\u003dyaml.RoundTripLoader, preserve_quotes\u003dTrue))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"                    if len(helm_release_kust) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":14,"id":"6b0bb208_4185ab47","line":162,"range":{"start_line":162,"start_character":24,"end_line":162,"end_character":41},"updated":"2022-06-10 11:51:02.000000000","message":"Because helmrelease_kustomization_fqpn -\u003e resource_kustomization_fqpn, resource_kustomization_contents?","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                if os.path.isfile(helmrelease_kustomization_fqpn):"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"                    with io.open(helmrelease_kustomization_fqpn, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as fk:"},{"line_number":162,"context_line":"                        helm_release_kust \u003d list(yaml.load_all(fk,"},{"line_number":163,"context_line":"                            Loader\u003dyaml.RoundTripLoader, preserve_quotes\u003dTrue))"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"                    if len(helm_release_kust) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":14,"id":"69019453_1047eae8","line":162,"range":{"start_line":162,"start_character":24,"end_line":162,"end_character":41},"in_reply_to":"6b0bb208_4185ab47","updated":"2022-06-10 14:35:46.000000000","message":"Done","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8a43308db164b2a35a3a926bd2ae43e3fce0c640","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"                    rls_kust_namespace \u003d helm_release_kust[0].get(\"namespace\")"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"                if rls_kust_namespace:"},{"line_number":173,"context_line":"                    LOG.debug(\"Using namespace defined on the release\u0027s kustomization.yaml\")"},{"line_number":174,"context_line":"                    namespace \u003d rls_kust_namespace"},{"line_number":175,"context_line":"                elif rls_namespace:"},{"line_number":176,"context_line":"                    LOG.debug(\"Using namespace defined on the helmrelease.yaml\")"},{"line_number":177,"context_line":"                    namespace \u003d rls_namespace"},{"line_number":178,"context_line":"                else:"},{"line_number":179,"context_line":"                    LOG.debug(\"Using namespace defined on the top level kustomization.yaml\")"},{"line_number":180,"context_line":"                    namespace \u003d self.kustomization_namespace"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"                # Save pertinent data for disabling chart resources and cleaning"},{"line_number":183,"context_line":"                # up existing helm releases after being disabled"}],"source_content_type":"text/x-python","patch_set":14,"id":"4e71c036_0dcd76b2","line":180,"range":{"start_line":172,"start_character":0,"end_line":180,"end_character":60},"updated":"2022-06-10 11:51:02.000000000","message":"Double check: is this the order in which the flux will override the namespace:\nif defined use namespace from a/kustomization.yaml\nelse if defined use namespace from a/helmrelease.yaml\nelse use top level kustomization.yaml\n?\n\n-\u003e Yes. [Got the answer when I looked at the unit tests later]","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":28531,"name":"Kristine Bujold","email":"Kristine.Bujold@windriver.com","username":"kbujold"},"change_message_id":"b3677c600fa27bcc4b78032b12957c4ef8562a2a","unresolved":true,"context_lines":[{"line_number":196,"context_line":"                          \"resource {}.\".format(helm_release_fqpn,"},{"line_number":197,"context_line":"                                                resource_fqpn))"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        LOG.debug(\"helmrelease_resource_map: {}\".format(self.helmrelease_resource_map))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _override_fluxcd_app_repo_url(self, manifest):"},{"line_number":202,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"13c77a87_09293c30","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":17},"updated":"2022-06-10 13:40:02.000000000","message":"can we make this info?","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"2ee32d39d5a8e184f9016c310a3dbf8613412c56","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                          \"resource {}.\".format(helm_release_fqpn,"},{"line_number":197,"context_line":"                                                resource_fqpn))"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        LOG.debug(\"helmrelease_resource_map: {}\".format(self.helmrelease_resource_map))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _override_fluxcd_app_repo_url(self, manifest):"},{"line_number":202,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"03ecff8e_7a9653d8","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":17},"in_reply_to":"13c77a87_09293c30","updated":"2022-06-10 14:35:46.000000000","message":"Done","commit_id":"e7ad67070cbbc1f8e7c1a0884f072931c6c3e264"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"a69dd122fb1bd5dc064ef93c2659e80f9b2d5274","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                # up existing helm releases after being disabled"},{"line_number":184,"context_line":"                if resource_helmrelease_metadata_name not in self.helmrelease_resource_map:"},{"line_number":185,"context_line":"                    self.helmrelease_resource_map[resource_helmrelease_metadata_name] \u003d {"},{"line_number":186,"context_line":"                        \"name\": resource_helmrelease_metadata_name,"},{"line_number":187,"context_line":"                        \"namespace\": namespace,"},{"line_number":188,"context_line":"                        \"resource\": resource,"},{"line_number":189,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":15,"id":"27c9d41d_8c3bf4d1","line":186,"updated":"2022-06-13 13:24:57.000000000","message":"@Bob just a side note, we are using metadata.name, not spec.releaseName over here. That\u0027s mainly why platform-app is still working.","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"36fb553a23387274f07c23479aa2ca188e89c044","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                # up existing helm releases after being disabled"},{"line_number":184,"context_line":"                if resource_helmrelease_metadata_name not in self.helmrelease_resource_map:"},{"line_number":185,"context_line":"                    self.helmrelease_resource_map[resource_helmrelease_metadata_name] \u003d {"},{"line_number":186,"context_line":"                        \"name\": resource_helmrelease_metadata_name,"},{"line_number":187,"context_line":"                        \"namespace\": namespace,"},{"line_number":188,"context_line":"                        \"resource\": resource,"},{"line_number":189,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":15,"id":"a7c632f8_e7a7b3f7","line":186,"in_reply_to":"27c9d41d_8c3bf4d1","updated":"2022-06-13 14:52:23.000000000","message":"Ack","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"36fb553a23387274f07c23479aa2ca188e89c044","unresolved":true,"context_lines":[{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            LOG.info(\"%s is not needed. All charts are enabled.\" % self.release_cleanup_fqpn)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def helm_release_resource_delete(self, helmrelease_name):"},{"line_number":313,"context_line":"        \"\"\" Delete a helm release resource"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        This method will remove a chart\u0027s resource from the top level"}],"source_content_type":"text/x-python","patch_set":15,"id":"04c0f236_bc4e1509","line":312,"range":{"start_line":312,"start_character":43,"end_line":312,"end_character":59},"updated":"2022-06-13 14:52:23.000000000","message":"Based on your comment above, change this to helmrelease_metadata_name so it\u0027s clear what needs to be provided\n\nThen the platform-app KustomizeOperator should be using\n\n    CHART_RELEASE_LUT \u003d {\n        CephPoolsAuditHelm.CHART: \u0027ceph-pools-audit\u0027,\n        RbdProvisionerHelm.CHART: \u0027rbd-provisioner\u0027,\n        CephFSProvisionerHelm.CHART: \u0027cephfs-provisioner\u0027,\n    }\n\nAgreed?","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"0285bda21e846abb2315ddca42526418c563d90f","unresolved":true,"context_lines":[{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            LOG.info(\"%s is not needed. All charts are enabled.\" % self.release_cleanup_fqpn)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def helm_release_resource_delete(self, helmrelease_name):"},{"line_number":313,"context_line":"        \"\"\" Delete a helm release resource"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        This method will remove a chart\u0027s resource from the top level"}],"source_content_type":"text/x-python","patch_set":15,"id":"09570210_7427fe66","line":312,"range":{"start_line":312,"start_character":43,"end_line":312,"end_character":59},"in_reply_to":"04c0f236_bc4e1509","updated":"2022-06-13 15:03:46.000000000","message":"I\u0027m kinda inclined to take the harder path here and, instead of defining this on a LUT here, define it at each plugin. I\u0027m testing this right now, but the plan is to extend base.BaseHelm in a new FluxCDBaseHelm class with some abstract properties; and implement those properties in the platform-app plugins. I\u0027m testing it right now, will update the review shortly.","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"6b9344cd4f0f06bab06176c7469998a6f28ee0b7","unresolved":true,"context_lines":[{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            LOG.info(\"%s is not needed. All charts are enabled.\" % self.release_cleanup_fqpn)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def helm_release_resource_delete(self, helmrelease_name):"},{"line_number":313,"context_line":"        \"\"\" Delete a helm release resource"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        This method will remove a chart\u0027s resource from the top level"}],"source_content_type":"text/x-python","patch_set":15,"id":"dec54cbd_ec18c443","line":312,"range":{"start_line":312,"start_character":43,"end_line":312,"end_character":59},"in_reply_to":"09570210_7427fe66","updated":"2022-06-13 16:59:06.000000000","message":"It\u0027s up to the app designer to define how they want to use the operator. \n\nThe point of the platform KustomizeOperator was to define an example of how to use the operator as part of the helm plugin.\n\nFine if you want to hard code it for any particular app.","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"6359ff2e493556d82969e10a40443e061ca3eaf7","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            LOG.info(\"%s is not needed. All charts are enabled.\" % self.release_cleanup_fqpn)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def helm_release_resource_delete(self, helmrelease_name):"},{"line_number":313,"context_line":"        \"\"\" Delete a helm release resource"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        This method will remove a chart\u0027s resource from the top level"}],"source_content_type":"text/x-python","patch_set":15,"id":"f39cb690_b6337d21","line":312,"range":{"start_line":312,"start_character":43,"end_line":312,"end_character":59},"in_reply_to":"dec54cbd_ec18c443","updated":"2022-06-13 17:05:13.000000000","message":"Ack","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"36fb553a23387274f07c23479aa2ca188e89c044","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        The chart will also be added to a list of charts that will have their"},{"line_number":320,"context_line":"        existing helm releases cleaned up"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        :param chart: chart name to remove from the resource list"},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        removed_resource \u003d self.helmrelease_resource_map.pop(helmrelease_name, None)"}],"source_content_type":"text/x-python","patch_set":15,"id":"c09d8a71_2c4ebee5","line":322,"updated":"2022-06-13 14:52:23.000000000","message":"Update this too","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"0285bda21e846abb2315ddca42526418c563d90f","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        The chart will also be added to a list of charts that will have their"},{"line_number":320,"context_line":"        existing helm releases cleaned up"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        :param chart: chart name to remove from the resource list"},{"line_number":323,"context_line":"        \"\"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        removed_resource \u003d self.helmrelease_resource_map.pop(helmrelease_name, None)"}],"source_content_type":"text/x-python","patch_set":15,"id":"90b1a643_e3fa11a5","line":322,"in_reply_to":"c09d8a71_2c4ebee5","updated":"2022-06-13 15:03:46.000000000","message":"Done","commit_id":"ae0908faeaa9ebd0ab0b925b1dc9457ed7797fd0"}]}