)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b4de0efe956ad24d38bdefaefc6ed0e602e0d9c2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Iago Estrela \u003cIagoFilipe.EstrelaBarros@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-13 11:43:33 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move tty_dcd configuration from agent to puppet runtime manifest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tty_dcd flag is currently being configured by sysinv agent audit."},{"line_number":10,"context_line":"The API updates the database but it is not instantly configured, it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c69aba8f_9d11539c","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":12},"updated":"2022-06-15 21:18:39.000000000","message":"ttys_dcd","commit_id":"f47ca58c4812b960b6d00d05352189fa3cc8451f"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"9c04db3507d7d6f35b7d9b9122affad0537ea900","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Iago Estrela \u003cIagoFilipe.EstrelaBarros@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-13 11:43:33 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move tty_dcd configuration from agent to puppet runtime manifest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tty_dcd flag is currently being configured by sysinv agent audit."},{"line_number":10,"context_line":"The API updates the database but it is not instantly configured, it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"14958916_e486f246","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":12},"in_reply_to":"c69aba8f_9d11539c","updated":"2022-06-24 13:51:37.000000000","message":"Done","commit_id":"f47ca58c4812b960b6d00d05352189fa3cc8451f"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b4de0efe956ad24d38bdefaefc6ed0e602e0d9c2","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move tty_dcd configuration from agent to puppet runtime manifest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tty_dcd flag is currently being configured by sysinv agent audit."},{"line_number":10,"context_line":"The API updates the database but it is not instantly configured, it"},{"line_number":11,"context_line":"must wait for an audit iteration. This change modifies this behavior"},{"line_number":12,"context_line":"by running a puppet runtime manifest [1] from the API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"52a04499_70d43c55","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":11},"updated":"2022-06-15 21:18:39.000000000","message":"ttys_dcd","commit_id":"f47ca58c4812b960b6d00d05352189fa3cc8451f"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"9c04db3507d7d6f35b7d9b9122affad0537ea900","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move tty_dcd configuration from agent to puppet runtime manifest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tty_dcd flag is currently being configured by sysinv agent audit."},{"line_number":10,"context_line":"The API updates the database but it is not instantly configured, it"},{"line_number":11,"context_line":"must wait for an audit iteration. This change modifies this behavior"},{"line_number":12,"context_line":"by running a puppet runtime manifest [1] from the API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"10d067f0_05597945","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":11},"in_reply_to":"52a04499_70d43c55","updated":"2022-06-24 13:51:37.000000000","message":"Done","commit_id":"f47ca58c4812b960b6d00d05352189fa3cc8451f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"1db2cd7d0af6513e7787af53e9d2bacafcf920a2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"117a4005_6e90a003","updated":"2022-06-24 13:07:39.000000000","message":"The Depends-On stx-puppet review is currently still WIP","commit_id":"1d31a2232fbcc0e8a0a5ad0b438a846a4aca931a"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"9c04db3507d7d6f35b7d9b9122affad0537ea900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"47b1b31b_285ec7d7","in_reply_to":"117a4005_6e90a003","updated":"2022-06-24 13:51:37.000000000","message":"Done","commit_id":"1d31a2232fbcc0e8a0a5ad0b438a846a4aca931a"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"57fef1b9aadaa72d5b9c3e4fd58a1ea7570c29ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ea3b2161_7dcff287","updated":"2022-06-30 16:21:00.000000000","message":"Code looks ok to me","commit_id":"28f72983dee14cb6756f936a0a93a82d4024e67e"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"0868360a666c39d00444d6bf494215fb4aefc02d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d509cb8b_74bc14fe","updated":"2022-06-30 15:15:22.000000000","message":"The Depends-On review has recently merged:\nhttps://review.opendev.org/c/starlingx/stx-puppet/+/845174\n\nWhen CR\u0027d, this review should merge along with it.","commit_id":"28f72983dee14cb6756f936a0a93a82d4024e67e"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"c50bbc817d98851b797bf955940f130eeb876817","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"407d137a_ebbe911e","updated":"2022-06-30 12:45:03.000000000","message":"recheck","commit_id":"28f72983dee14cb6756f936a0a93a82d4024e67e"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"30221b104348a929bfb62afaefd84346d4f56dfd","unresolved":true,"context_lines":[{"line_number":11349,"context_line":""},{"line_number":11350,"context_line":"        return True"},{"line_number":11351,"context_line":""},{"line_number":11352,"context_line":"    def configure_ttys_dcd(self, context, uuid, ttys_dcd):"},{"line_number":11353,"context_line":"        \"\"\"Notify agent to configure the dcd with the supplied data."},{"line_number":11354,"context_line":""},{"line_number":11355,"context_line":"        :param context: an admin context."}],"source_content_type":"text/x-python","patch_set":2,"id":"be03d1b4_5db3e9bd","side":"PARENT","line":11352,"updated":"2022-06-10 17:44:35.000000000","message":"note, during an upgrade to N+1, the N-side may still be calling these rpcapi.  Confirm behaviour; or leave these methods in but add a note to deprecate in the next release","commit_id":"05909742578f9c725b4dd6777ed5cace2cb7485c"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"1fd4bb288d1a8df4cce8efed983335fb046fd3c4","unresolved":false,"context_lines":[{"line_number":11349,"context_line":""},{"line_number":11350,"context_line":"        return True"},{"line_number":11351,"context_line":""},{"line_number":11352,"context_line":"    def configure_ttys_dcd(self, context, uuid, ttys_dcd):"},{"line_number":11353,"context_line":"        \"\"\"Notify agent to configure the dcd with the supplied data."},{"line_number":11354,"context_line":""},{"line_number":11355,"context_line":"        :param context: an admin context."}],"source_content_type":"text/x-python","patch_set":2,"id":"ccc7242a_83d459df","side":"PARENT","line":11352,"in_reply_to":"ac2ab5da_fe59a459","updated":"2022-06-13 14:45:02.000000000","message":"Done","commit_id":"05909742578f9c725b4dd6777ed5cace2cb7485c"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"732bb00f4fd58062e62125f3c9be8c04a2694849","unresolved":true,"context_lines":[{"line_number":11349,"context_line":""},{"line_number":11350,"context_line":"        return True"},{"line_number":11351,"context_line":""},{"line_number":11352,"context_line":"    def configure_ttys_dcd(self, context, uuid, ttys_dcd):"},{"line_number":11353,"context_line":"        \"\"\"Notify agent to configure the dcd with the supplied data."},{"line_number":11354,"context_line":""},{"line_number":11355,"context_line":"        :param context: an admin context."}],"source_content_type":"text/x-python","patch_set":2,"id":"ac2ab5da_fe59a459","side":"PARENT","line":11352,"in_reply_to":"be03d1b4_5db3e9bd","updated":"2022-06-10 19:14:26.000000000","message":"I decided to keep the rpcapi as it is and the reason is: I noticed that after removing a conductor method manually in my environment the agent was still trying to call this method. I had to restart the agent in order to workaround this issue and as I didn\u0027t think about the possibility of this issue happening during an upgrade I agree with the idea of keeping it.","commit_id":"05909742578f9c725b4dd6777ed5cace2cb7485c"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"4c1121b7dfdea388aa00f686553ef242070ac52b","unresolved":true,"context_lines":[{"line_number":11349,"context_line":""},{"line_number":11350,"context_line":"        return True"},{"line_number":11351,"context_line":""},{"line_number":11352,"context_line":"    # (TODO) Deprecate"},{"line_number":11353,"context_line":"    # Reason: moving serial console configuration from agent audit"},{"line_number":11354,"context_line":"    # to puppet discards the necessity of polling the host tty_dcd"},{"line_number":11355,"context_line":"    # attribute in sysinv database through conductor API. (LP-1978009)"},{"line_number":11356,"context_line":"    def configure_ttys_dcd(self, context, uuid, ttys_dcd):"},{"line_number":11357,"context_line":"        \"\"\"Notify agent to configure the dcd with the supplied data."},{"line_number":11358,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"0cb84368_f4239e4f","line":11355,"range":{"start_line":11352,"start_character":0,"end_line":11355,"end_character":70},"updated":"2022-06-13 14:34:21.000000000","message":"comment should be moved to within the method","commit_id":"0716b2e5c621945ea95b9d8abca7cd97c6d3db57"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"33f8f8e43fefc5de9cf77843dc6395d7ff3f1010","unresolved":false,"context_lines":[{"line_number":11349,"context_line":""},{"line_number":11350,"context_line":"        return True"},{"line_number":11351,"context_line":""},{"line_number":11352,"context_line":"    # (TODO) Deprecate"},{"line_number":11353,"context_line":"    # Reason: moving serial console configuration from agent audit"},{"line_number":11354,"context_line":"    # to puppet discards the necessity of polling the host tty_dcd"},{"line_number":11355,"context_line":"    # attribute in sysinv database through conductor API. (LP-1978009)"},{"line_number":11356,"context_line":"    def configure_ttys_dcd(self, context, uuid, ttys_dcd):"},{"line_number":11357,"context_line":"        \"\"\"Notify agent to configure the dcd with the supplied data."},{"line_number":11358,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2414db7c_f35994f0","line":11355,"range":{"start_line":11352,"start_character":0,"end_line":11355,"end_character":70},"in_reply_to":"0cb84368_f4239e4f","updated":"2022-06-13 14:44:49.000000000","message":"Done","commit_id":"0716b2e5c621945ea95b9d8abca7cd97c6d3db57"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"4c1121b7dfdea388aa00f686553ef242070ac52b","unresolved":true,"context_lines":[{"line_number":11366,"context_line":"        rpcapi \u003d agent_rpcapi.AgentAPI()"},{"line_number":11367,"context_line":"        rpcapi.configure_ttys_dcd(context, uuid\u003duuid, ttys_dcd\u003dttys_dcd)"},{"line_number":11368,"context_line":""},{"line_number":11369,"context_line":"    # (TODO) Deprecate"},{"line_number":11370,"context_line":"    # Reason: moving serial console configuration from agent audit"},{"line_number":11371,"context_line":"    # to puppet discards the necessity of polling the host tty_dcd"},{"line_number":11372,"context_line":"    # attribute in sysinv database through conductor API. (LP-1978009)"},{"line_number":11373,"context_line":"    def get_host_ttys_dcd(self, context, ihost_id):"},{"line_number":11374,"context_line":"        \"\"\""},{"line_number":11375,"context_line":"        Retrieve the serial line carrier detect state for a given host"}],"source_content_type":"text/x-python","patch_set":3,"id":"3318390c_22bd78fd","line":11372,"range":{"start_line":11369,"start_character":0,"end_line":11372,"end_character":70},"updated":"2022-06-13 14:34:21.000000000","message":"comment should be moved within the specific method affected (so, its clearly separated from update_ttys_dcd()).","commit_id":"0716b2e5c621945ea95b9d8abca7cd97c6d3db57"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"33f8f8e43fefc5de9cf77843dc6395d7ff3f1010","unresolved":false,"context_lines":[{"line_number":11366,"context_line":"        rpcapi \u003d agent_rpcapi.AgentAPI()"},{"line_number":11367,"context_line":"        rpcapi.configure_ttys_dcd(context, uuid\u003duuid, ttys_dcd\u003dttys_dcd)"},{"line_number":11368,"context_line":""},{"line_number":11369,"context_line":"    # (TODO) Deprecate"},{"line_number":11370,"context_line":"    # Reason: moving serial console configuration from agent audit"},{"line_number":11371,"context_line":"    # to puppet discards the necessity of polling the host tty_dcd"},{"line_number":11372,"context_line":"    # attribute in sysinv database through conductor API. (LP-1978009)"},{"line_number":11373,"context_line":"    def get_host_ttys_dcd(self, context, ihost_id):"},{"line_number":11374,"context_line":"        \"\"\""},{"line_number":11375,"context_line":"        Retrieve the serial line carrier detect state for a given host"}],"source_content_type":"text/x-python","patch_set":3,"id":"dec23c75_979c68fc","line":11372,"range":{"start_line":11369,"start_character":0,"end_line":11372,"end_character":70},"in_reply_to":"3318390c_22bd78fd","updated":"2022-06-13 14:44:49.000000000","message":"Done","commit_id":"0716b2e5c621945ea95b9d8abca7cd97c6d3db57"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"1db2cd7d0af6513e7787af53e9d2bacafcf920a2","unresolved":true,"context_lines":[{"line_number":11515,"context_line":""},{"line_number":11516,"context_line":"    def get_host_ttys_dcd(self, context, ihost_id):"},{"line_number":11517,"context_line":"        \"\"\""},{"line_number":11518,"context_line":"        (TODO) Deprecate"},{"line_number":11519,"context_line":"        Reason: moving serial console configuration from agent audit"},{"line_number":11520,"context_line":"        to puppet discards the necessity of polling the host tty_dcd"},{"line_number":11521,"context_line":"        attribute in sysinv database through conductor API. (LP-1978009)"}],"source_content_type":"text/x-python","patch_set":5,"id":"551885b7_9db71fb0","line":11518,"range":{"start_line":11518,"start_character":15,"end_line":11518,"end_character":24},"updated":"2022-06-24 13:07:39.000000000","message":"Deprecate when supported from upgrade releases for tty_dcd have all been migrated to puppet","commit_id":"1d31a2232fbcc0e8a0a5ad0b438a846a4aca931a"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"9c04db3507d7d6f35b7d9b9122affad0537ea900","unresolved":false,"context_lines":[{"line_number":11515,"context_line":""},{"line_number":11516,"context_line":"    def get_host_ttys_dcd(self, context, ihost_id):"},{"line_number":11517,"context_line":"        \"\"\""},{"line_number":11518,"context_line":"        (TODO) Deprecate"},{"line_number":11519,"context_line":"        Reason: moving serial console configuration from agent audit"},{"line_number":11520,"context_line":"        to puppet discards the necessity of polling the host tty_dcd"},{"line_number":11521,"context_line":"        attribute in sysinv database through conductor API. (LP-1978009)"}],"source_content_type":"text/x-python","patch_set":5,"id":"db22412d_051adc99","line":11518,"range":{"start_line":11518,"start_character":15,"end_line":11518,"end_character":24},"in_reply_to":"551885b7_9db71fb0","updated":"2022-06-24 13:51:37.000000000","message":"Done","commit_id":"1d31a2232fbcc0e8a0a5ad0b438a846a4aca931a"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"0786b1e51e8e23f123ec668ad3403e47fd4aadbe","unresolved":true,"context_lines":[{"line_number":13582,"context_line":""},{"line_number":13583,"context_line":"        :param context: an admin context."},{"line_number":13584,"context_line":"        :param uuid: the host uuid"},{"line_number":13585,"context_line":"        :param ttys_dcd: the flag to enable/disable dcd"},{"line_number":13586,"context_line":"        \"\"\""},{"line_number":13587,"context_line":"        host \u003d self.dbapi.ihost_get(ihost_uuid)"},{"line_number":13588,"context_line":"        LOG.debug(\"ConductorManager.update_ttys_dcd: running manifest \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3b52754d_1722d774","line":13585,"range":{"start_line":13585,"start_character":0,"end_line":13585,"end_character":55},"updated":"2022-06-27 13:00:04.000000000","message":"ttys_dcd is not a param","commit_id":"f6e6b58cf5f32650979026a1d7ae5f8ca9b6cc26"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"b6e5dd019fb4324aa6df557d6b4f2b82fa8cd646","unresolved":false,"context_lines":[{"line_number":13582,"context_line":""},{"line_number":13583,"context_line":"        :param context: an admin context."},{"line_number":13584,"context_line":"        :param uuid: the host uuid"},{"line_number":13585,"context_line":"        :param ttys_dcd: the flag to enable/disable dcd"},{"line_number":13586,"context_line":"        \"\"\""},{"line_number":13587,"context_line":"        host \u003d self.dbapi.ihost_get(ihost_uuid)"},{"line_number":13588,"context_line":"        LOG.debug(\"ConductorManager.update_ttys_dcd: running manifest \""}],"source_content_type":"text/x-python","patch_set":6,"id":"a6d0f099_5e053233","line":13585,"range":{"start_line":13585,"start_character":0,"end_line":13585,"end_character":55},"in_reply_to":"3b52754d_1722d774","updated":"2022-06-27 13:18:57.000000000","message":"Done","commit_id":"f6e6b58cf5f32650979026a1d7ae5f8ca9b6cc26"}],"sysinv/sysinv/sysinv/sysinv/conductor/rpcapi.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"30221b104348a929bfb62afaefd84346d4f56dfd","unresolved":true,"context_lines":[{"line_number":1241,"context_line":"                                       ihost_uuid\u003dihost_uuid,"},{"line_number":1242,"context_line":"                                       ibm_msg_dict\u003dibm_msg_dict))"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"    def update_ttys_dcd(self, context, ihost_uuid):"},{"line_number":1245,"context_line":"        \"\"\"Synchronously, have a conductor configure the dcd."},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"        Does the following tasks:"}],"source_content_type":"text/x-python","patch_set":2,"id":"964a5865_8b477c52","line":1244,"updated":"2022-06-10 17:44:35.000000000","message":"as noted, the old api may need to be kept for a release until fully deprecated in order to support compatibility during upgrades.  An upgrade should be performed to confirm the audit behaves as expected.","commit_id":"19a1237ebdd89c8e99c721e4dfa57850b5db2e17"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"1fd4bb288d1a8df4cce8efed983335fb046fd3c4","unresolved":false,"context_lines":[{"line_number":1241,"context_line":"                                       ihost_uuid\u003dihost_uuid,"},{"line_number":1242,"context_line":"                                       ibm_msg_dict\u003dibm_msg_dict))"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"    def update_ttys_dcd(self, context, ihost_uuid):"},{"line_number":1245,"context_line":"        \"\"\"Synchronously, have a conductor configure the dcd."},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"        Does the following tasks:"}],"source_content_type":"text/x-python","patch_set":2,"id":"0d59c2a6_c7a0d2d7","line":1244,"in_reply_to":"6e6034ac_542f7e42","updated":"2022-06-13 14:45:02.000000000","message":"Done","commit_id":"19a1237ebdd89c8e99c721e4dfa57850b5db2e17"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"732bb00f4fd58062e62125f3c9be8c04a2694849","unresolved":true,"context_lines":[{"line_number":1241,"context_line":"                                       ihost_uuid\u003dihost_uuid,"},{"line_number":1242,"context_line":"                                       ibm_msg_dict\u003dibm_msg_dict))"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"    def update_ttys_dcd(self, context, ihost_uuid):"},{"line_number":1245,"context_line":"        \"\"\"Synchronously, have a conductor configure the dcd."},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"        Does the following tasks:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6e6034ac_542f7e42","line":1244,"in_reply_to":"964a5865_8b477c52","updated":"2022-06-10 19:14:26.000000000","message":"ditto","commit_id":"19a1237ebdd89c8e99c721e4dfa57850b5db2e17"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"0786b1e51e8e23f123ec668ad3403e47fd4aadbe","unresolved":true,"context_lines":[{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"        :param context: request context."},{"line_number":1295,"context_line":"        :param uuid: the host uuid"},{"line_number":1296,"context_line":"        :param ttys_dcd: the flag to enable/disable dcd"},{"line_number":1297,"context_line":"        \"\"\""},{"line_number":1298,"context_line":"        return self.call(context,"},{"line_number":1299,"context_line":"                         self.make_msg(\u0027update_ttys_dcd\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"50e82dd2_4b421366","line":1296,"range":{"start_line":1296,"start_character":0,"end_line":1296,"end_character":55},"updated":"2022-06-27 13:00:04.000000000","message":"ttys_dcd is not a param","commit_id":"f6e6b58cf5f32650979026a1d7ae5f8ca9b6cc26"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"b6e5dd019fb4324aa6df557d6b4f2b82fa8cd646","unresolved":false,"context_lines":[{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"        :param context: request context."},{"line_number":1295,"context_line":"        :param uuid: the host uuid"},{"line_number":1296,"context_line":"        :param ttys_dcd: the flag to enable/disable dcd"},{"line_number":1297,"context_line":"        \"\"\""},{"line_number":1298,"context_line":"        return self.call(context,"},{"line_number":1299,"context_line":"                         self.make_msg(\u0027update_ttys_dcd\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ae3a1b5b_bfd0efaf","line":1296,"range":{"start_line":1296,"start_character":0,"end_line":1296,"end_character":55},"in_reply_to":"50e82dd2_4b421366","updated":"2022-06-27 13:18:57.000000000","message":"Done","commit_id":"f6e6b58cf5f32650979026a1d7ae5f8ca9b6cc26"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"3ace07d2d5f9697841727beabf724b4b4d072bf3","unresolved":true,"context_lines":[{"line_number":1292,"context_line":"        - conductor triggers runtime manifest configuring tty"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"        :param context: request context."},{"line_number":1295,"context_line":"        :param uuid: the host uuid."},{"line_number":1296,"context_line":"        \"\"\""},{"line_number":1297,"context_line":"        return self.call(context,"},{"line_number":1298,"context_line":"                         self.make_msg(\u0027update_ttys_dcd\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"4df4ef35_b9464395","line":1295,"range":{"start_line":1295,"start_character":15,"end_line":1295,"end_character":19},"updated":"2022-06-27 15:57:38.000000000","message":"its actually named ihost_uuid (same comment for the other file)","commit_id":"c8b1c229a2fd418ff6e4aa9a91efaab364f4d87c"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"31318b23264bc53ff472ef429d46eec806b7c24f","unresolved":false,"context_lines":[{"line_number":1292,"context_line":"        - conductor triggers runtime manifest configuring tty"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"        :param context: request context."},{"line_number":1295,"context_line":"        :param uuid: the host uuid."},{"line_number":1296,"context_line":"        \"\"\""},{"line_number":1297,"context_line":"        return self.call(context,"},{"line_number":1298,"context_line":"                         self.make_msg(\u0027update_ttys_dcd\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"2c141e89_6d604bf7","line":1295,"range":{"start_line":1295,"start_character":15,"end_line":1295,"end_character":19},"in_reply_to":"4df4ef35_b9464395","updated":"2022-06-27 16:47:28.000000000","message":"Done","commit_id":"c8b1c229a2fd418ff6e4aa9a91efaab364f4d87c"}]}