)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33560,"name":"Alexandre Horst","email":"alexandre.horst@encora.com","username":"ahorst"},"change_message_id":"1fb235500d19884feddacd5656e370a8225ad55c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Thiago Antonio Miranda \u003ctmarques@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-21 08:39:10 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default behavior to 1 platform core utilization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2010087"},{"line_number":10,"context_line":"Task: 45593"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"27b2da90_bde4979d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"updated":"2022-06-21 14:17:59.000000000","message":"You need to fill the commit message with TEST PLAN and a DESCRIPTION of this change.\n\nhttps://docs.starlingx.io/developer_resources/code-submission-guide.html","commit_id":"557a6d42ab3ca0377f284b5a9a25f986c92487e9"},{"author":{"_account_id":34479,"name":"Bruno Costa","email":"bdacosta@windriver.com","username":"bdacosta"},"change_message_id":"ffa4176fff66483b597a986f2f1ed8e4e26851f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Thiago Antonio Miranda \u003ctmarques@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-21 08:39:10 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default behavior to 1 platform core utilization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2010087"},{"line_number":10,"context_line":"Task: 45593"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"34b09d44_b693aaa2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"in_reply_to":"27b2da90_bde4979d","updated":"2022-08-18 12:51:22.000000000","message":"Done","commit_id":"557a6d42ab3ca0377f284b5a9a25f986c92487e9"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"44cdbb9cd62fa057100a98be6f975305c22c0400","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default behavior of the platform core utilization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change default behavior to set the platform core utilization to 1"},{"line_number":10,"context_line":"physical core when HyperThreading is enable and to 2 when it\u0027s disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TEST PLAN:"},{"line_number":13,"context_line":"PASS: AIO: SX|DX: manually replaced these files into a Debian installation"},{"line_number":14,"context_line":"and no crashes happened."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0ceaab2a_957933f3","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":0},"updated":"2022-11-10 21:23:54.000000000","message":"This doesnt appear to align with the implementation:\n- WORKER nodes remain as before, logical cpus \u003d 2 with hyperthreading otherwise 1.\n- AIO - 2 cpus with HT, or 1 cpu without HT. (vs 4 cpus with HT before this change).\n\nThis is is only modifying the default allocation of platform cores in the case of AIO, not WORKER nodes.  In the AIO case, should clearly indicate the change from previous default allocation.","commit_id":"68dc1bd41ad9714a359bfeb2da61e78704ff452f"},{"author":{"_account_id":34219,"name":"Guilherme Batista Leite","email":"guilhermebatista.leite@windriver.com"},"change_message_id":"22aa973b04647765c6d865b2b75bc6bccc9825ad","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default behavior of the platform core utilization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change default behavior to set the platform core utilization to 1"},{"line_number":10,"context_line":"physical core when HyperThreading is enable and to 2 when it\u0027s disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TEST PLAN:"},{"line_number":13,"context_line":"PASS: AIO: SX|DX: manually replaced these files into a Debian installation"},{"line_number":14,"context_line":"and no crashes happened."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"cfe3c606_e36d8f95","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"0ceaab2a_957933f3","updated":"2022-11-11 11:20:26.000000000","message":"Dear Mr. Kung,\nYou are right. Worker is not expected to have any changes (1 full core allocation - 1 Platform Function without HT or 2 with HT). In case of AIO, current behavior is to have 2 physical cores no matter if it is HT or not, hence 4 Logical cores HT or 2 without HT. The new behavior is expected to be 2 logical cores in any case (1 physical core with HT vs 2 physical cores without HT).","commit_id":"68dc1bd41ad9714a359bfeb2da61e78704ff452f"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"dbd65c269ec0e3b31cc5bc4c58b3a7c8d5b12c2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default behavior of the platform core utilization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change default behavior to set the platform core utilization to 1"},{"line_number":10,"context_line":"physical core when HyperThreading is enable and to 2 when it\u0027s disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TEST PLAN:"},{"line_number":13,"context_line":"PASS: AIO: SX|DX: manually replaced these files into a Debian installation"},{"line_number":14,"context_line":"and no crashes happened."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f86bc021_3bf9e1b2","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"cfe3c606_e36d8f95","updated":"2022-11-11 17:06:18.000000000","message":"Ack","commit_id":"68dc1bd41ad9714a359bfeb2da61e78704ff452f"},{"author":{"_account_id":34219,"name":"Guilherme Batista Leite","email":"guilhermebatista.leite@windriver.com"},"change_message_id":"3c3438a4336cefb32b60043810c05b3dc0bccb00","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default behavior of the platform core utilization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change default behavior to set the platform core utilization to 1"},{"line_number":10,"context_line":"physical core when HyperThreading is enable and to 2 when it\u0027s disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TEST PLAN:"},{"line_number":13,"context_line":"PASS: AIO: SX|DX: manually replaced these files into a Debian installation"},{"line_number":14,"context_line":"and no crashes happened."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b6bce043_ba8af306","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"f86bc021_3bf9e1b2","updated":"2022-11-15 11:59:51.000000000","message":"Commit message updated","commit_id":"68dc1bd41ad9714a359bfeb2da61e78704ff452f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"acd5a0aa0c8fb4d03ae21b2da1b8cf0414f08bb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d2b0f7ec_0a201258","updated":"2022-11-09 16:36:51.000000000","message":"Ready to merge","commit_id":"68dc1bd41ad9714a359bfeb2da61e78704ff452f"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"e3057435e2df8eaa0d08d5201299741a13ed7016","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec753e2c_9229d682","updated":"2022-11-10 21:47:16.000000000","message":"Removing vote until John\u0027s comments are addressed","commit_id":"68dc1bd41ad9714a359bfeb2da61e78704ff452f"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"dbd65c269ec0e3b31cc5bc4c58b3a7c8d5b12c2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"473c3a7a_5123e6d1","updated":"2022-11-11 17:06:18.000000000","message":"I updated the tests plan and the change comment declaring that changes are applied only in AIO.\nWe ran all tests with HT enabled what described in tests plan.","commit_id":"b63f812bf78a99135db427295e9f6a4dda0e3925"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"44cdbb9cd62fa057100a98be6f975305c22c0400","unresolved":true,"context_lines":[{"line_number":3407,"context_line":"        # Limiting to 2 logical cores with HyperThreading enabled or disabled."},{"line_number":3408,"context_line":"        cpus \u003d 0"},{"line_number":3409,"context_line":"        if cutils.host_has_function(ihost, constants.WORKER) and node \u003d\u003d 0:"},{"line_number":3410,"context_line":"            cpus \u003d 1 if not hyperthreading else 2"},{"line_number":3411,"context_line":"            if cutils.host_has_function(ihost, constants.CONTROLLER):"},{"line_number":3412,"context_line":"                cpus \u003d 2"},{"line_number":3413,"context_line":"        return cpus"}],"source_content_type":"text/x-python","patch_set":4,"id":"0fd416bb_44a55b80","line":3410,"updated":"2022-11-10 21:23:54.000000000","message":"AIO-DX host-swact, host-lock, host-unlock should be verified with hyperthreading (as has been reduced from 4 to 2 in the AIO HT case).","commit_id":"68dc1bd41ad9714a359bfeb2da61e78704ff452f"},{"author":{"_account_id":34225,"name":"Thiago Antonio Miranda","email":"tmarques@windriver.com","username":"tmarques"},"change_message_id":"dbd65c269ec0e3b31cc5bc4c58b3a7c8d5b12c2f","unresolved":false,"context_lines":[{"line_number":3407,"context_line":"        # Limiting to 2 logical cores with HyperThreading enabled or disabled."},{"line_number":3408,"context_line":"        cpus \u003d 0"},{"line_number":3409,"context_line":"        if cutils.host_has_function(ihost, constants.WORKER) and node \u003d\u003d 0:"},{"line_number":3410,"context_line":"            cpus \u003d 1 if not hyperthreading else 2"},{"line_number":3411,"context_line":"            if cutils.host_has_function(ihost, constants.CONTROLLER):"},{"line_number":3412,"context_line":"                cpus \u003d 2"},{"line_number":3413,"context_line":"        return cpus"}],"source_content_type":"text/x-python","patch_set":4,"id":"e5941577_4a47ced3","line":3410,"in_reply_to":"0fd416bb_44a55b80","updated":"2022-11-11 17:06:18.000000000","message":"Ack","commit_id":"68dc1bd41ad9714a359bfeb2da61e78704ff452f"},{"author":{"_account_id":34219,"name":"Guilherme Batista Leite","email":"guilhermebatista.leite@windriver.com"},"change_message_id":"3c3438a4336cefb32b60043810c05b3dc0bccb00","unresolved":true,"context_lines":[{"line_number":3407,"context_line":"        # Limiting to 2 logical cores with HyperThreading enabled or disabled."},{"line_number":3408,"context_line":"        cpus \u003d 0"},{"line_number":3409,"context_line":"        if cutils.host_has_function(ihost, constants.WORKER) and node \u003d\u003d 0:"},{"line_number":3410,"context_line":"            cpus \u003d 1 if not hyperthreading else 2"},{"line_number":3411,"context_line":"            if cutils.host_has_function(ihost, constants.CONTROLLER):"},{"line_number":3412,"context_line":"                cpus \u003d 2"},{"line_number":3413,"context_line":"        return cpus"}],"source_content_type":"text/x-python","patch_set":4,"id":"822042fd_3c8790cd","line":3410,"in_reply_to":"e5941577_4a47ced3","updated":"2022-11-15 11:59:51.000000000","message":"Test Plan updated to reflect AIO-DX test cases performed: swact, host-lock, host-unlock.","commit_id":"68dc1bd41ad9714a359bfeb2da61e78704ff452f"}]}
