)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"2fc5eb0a706bd706c9e564a2163785c8f8cc04ec","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Closes-Bug: 1979689"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one excpetion from _upload_file() mether to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":17,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"67bc76e2_1fe06091","line":14,"range":{"start_line":14,"start_character":78,"end_line":14,"end_character":85},"updated":"2022-06-27 16:06:00.000000000","message":"typo?","commit_id":"4ef56002e11ddae855c561d6b842bf61fcf04be4"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"2b24586d42cae98ad1cda011c63e84e74c360ce9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Closes-Bug: 1979689"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one excpetion from _upload_file() mether to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":17,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"56abe8f8_8fefb47b","line":14,"range":{"start_line":14,"start_character":78,"end_line":14,"end_character":85},"in_reply_to":"67bc76e2_1fe06091","updated":"2022-06-28 13:03:34.000000000","message":"Done","commit_id":"4ef56002e11ddae855c561d6b842bf61fcf04be4"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"862f02fdfd5b155a7f0ad3fe2988ade601d154db","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Closes-Bug: 1979689"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one excpetion from _upload_file() method to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":17,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"22dad369_39ab0be5","line":14,"range":{"start_line":14,"start_character":48,"end_line":14,"end_character":58},"updated":"2022-06-28 14:19:44.000000000","message":"typo: exception","commit_id":"c59238e1dc247ab04aa097efd7d824d60d14b966"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"0ab32e639ca8361e233baa7a02fbbfa405b9f6da","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Closes-Bug: 1979689"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one excpetion from _upload_file() method to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":17,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2a590ad1_3ee4c07c","line":14,"range":{"start_line":14,"start_character":48,"end_line":14,"end_character":58},"in_reply_to":"22dad369_39ab0be5","updated":"2022-06-30 20:03:32.000000000","message":"Done","commit_id":"c59238e1dc247ab04aa097efd7d824d60d14b966"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"862f02fdfd5b155a7f0ad3fe2988ade601d154db","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one excpetion from _upload_file() method to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":17,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"48cec796_8e43d515","line":15,"updated":"2022-06-28 14:19:44.000000000","message":"Test plan should also include\n\u0027system load-import bootimage.iso bootimage.sig\u0027 successfully and verified via \u0027system load-list\u0027.\n\nOn a SystemController:\n\u0027system load-import --os-region-name SystemController load-import\u0027 and the load is also populated in /opt/dc-vault/loads","commit_id":"c59238e1dc247ab04aa097efd7d824d60d14b966"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b7ccf853c31a1f010275d0d19854b3f34de203c3","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one excpetion from _upload_file() method to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":17,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"75e796ea_16ac17e0","line":15,"in_reply_to":"48cec796_8e43d515","updated":"2022-06-30 12:22:47.000000000","message":"CR can be updated when success case load-import test is confirmed.","commit_id":"c59238e1dc247ab04aa097efd7d824d60d14b966"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"45fae7770d53f1cef520090782a6d0e9fa3b6c7d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one excpetion from _upload_file() method to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":17,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7cc23776_889aa141","line":15,"in_reply_to":"75e796ea_16ac17e0","updated":"2022-07-05 14:32:08.000000000","message":"Done","commit_id":"c59238e1dc247ab04aa097efd7d824d60d14b966"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"0f1f47666f6437b6a79486021932c23155a64626","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-29 15:19:58 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Populate more specific load import error messages to client side"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Details: Raise each exception from_upload_file() method and populate it to client side error messages."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f033e203_573db34d","line":7,"updated":"2022-06-30 15:18:00.000000000","message":"The first line should have the maximum of 50 characters and the subsequent lines 72:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"f6548acdc49338aa3e728e8802f09ebb63707598"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"0ab32e639ca8361e233baa7a02fbbfa405b9f6da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-29 15:19:58 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Populate more specific load import error messages to client side"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Details: Raise each exception from_upload_file() method and populate it to client side error messages."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f4273de4_f9566c7e","line":7,"in_reply_to":"f033e203_573db34d","updated":"2022-06-30 20:03:32.000000000","message":"Done","commit_id":"f6548acdc49338aa3e728e8802f09ebb63707598"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"0f1f47666f6437b6a79486021932c23155a64626","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1979689"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one exception from _upload_file() method to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"09c9fdb4_9567ebee","line":13,"updated":"2022-06-30 15:18:00.000000000","message":"Here it should specify which case that was tested including the generic log info, which will show how the added exception info appears.","commit_id":"f6548acdc49338aa3e728e8802f09ebb63707598"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"40b783a013cab495791399cddc5cef9b57ad3240","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1979689"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one exception from _upload_file() method to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"abe40b46_ba785863","line":13,"in_reply_to":"09c9fdb4_9567ebee","updated":"2022-06-30 20:03:45.000000000","message":"Ack","commit_id":"f6548acdc49338aa3e728e8802f09ebb63707598"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"685e46838d710782553f2a83150733648941d612","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1979689"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Test Plan:"},{"line_number":14,"context_line":"PASS: Patch local duplex system and trigger one exception from _upload_file() method to verify the error message is populated"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"10668b83_b3a0cf27","line":13,"in_reply_to":"abe40b46_ba785863","updated":"2022-07-05 13:27:58.000000000","message":"As discussed, I updated to commit messages to clarify the code change behavior.","commit_id":"f6548acdc49338aa3e728e8802f09ebb63707598"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"00786b662bc6d59e60a161920acee0c3958b977d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"Closes-Bug: 1979689"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test Plan:"},{"line_number":16,"context_line":"PASS: Patch local duplex system and trigger one exception from _upload_file() method to verify the error message is populated"},{"line_number":17,"context_line":"PASS: Run \u0027system load-import bootimage.iso bootimage.sig\u0027 successfull and verfy in \u0027system load-list\u0027 with sufficient /scrach diskspace"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ce830796_6729cfd7","line":16,"updated":"2022-07-05 15:12:09.000000000","message":"Exceeding max length, same line below","commit_id":"157b5a6c9741d2a8c2b5ca13696234ced738c1e3"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"184c09e1cb4f69f223b84d7fffd02512b4ce1f1a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Closes-Bug: 1979689"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test Plan:"},{"line_number":16,"context_line":"PASS: Patch local duplex system and trigger one exception from _upload_file() method to verify the error message is populated"},{"line_number":17,"context_line":"PASS: Run \u0027system load-import bootimage.iso bootimage.sig\u0027 successfull and verfy in \u0027system load-list\u0027 with sufficient /scrach diskspace"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"46aafc0f_1c0d9d85","line":16,"in_reply_to":"ce830796_6729cfd7","updated":"2022-07-05 15:44:12.000000000","message":"Done","commit_id":"157b5a6c9741d2a8c2b5ca13696234ced738c1e3"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b868d11a088ce8c2754d42347ee232bbdf652386","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Test Plan:"},{"line_number":16,"context_line":"PASS: Patch local duplex system and trigger one exception from _upload_file()"},{"line_number":17,"context_line":"      method to verify the error message is populated"},{"line_number":18,"context_line":"PASS: Run \u0027system load-import bootimage.iso bootimage.sig\u0027 successfull and"},{"line_number":19,"context_line":"      verfy in \u0027system load-list\u0027 with sufficient /scrach diskspace"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":22,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"e5abfbc3_e2d08b85","line":19,"range":{"start_line":18,"start_character":59,"end_line":19,"end_character":11},"updated":"2022-07-05 20:59:42.000000000","message":"typos: successful and verify","commit_id":"8c83361af346b60766d71d8cd37d32a5efc42119"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"359d900f4cfb49497f9b3b4e21c073fb360b14a2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Test Plan:"},{"line_number":16,"context_line":"PASS: Patch local duplex system and trigger one exception from _upload_file()"},{"line_number":17,"context_line":"      method to verify the error message is populated"},{"line_number":18,"context_line":"PASS: Run \u0027system load-import bootimage.iso bootimage.sig\u0027 successfull and"},{"line_number":19,"context_line":"      verfy in \u0027system load-list\u0027 with sufficient /scrach diskspace"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":22,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"48154324_bee87e01","line":19,"range":{"start_line":18,"start_character":59,"end_line":19,"end_character":11},"in_reply_to":"aa975341_c35b761a","updated":"2022-07-05 21:03:59.000000000","message":"Done","commit_id":"8c83361af346b60766d71d8cd37d32a5efc42119"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"1e8ed29aabe35ec5d1e84c8cf416ebc55ae06d0a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Test Plan:"},{"line_number":16,"context_line":"PASS: Patch local duplex system and trigger one exception from _upload_file()"},{"line_number":17,"context_line":"      method to verify the error message is populated"},{"line_number":18,"context_line":"PASS: Run \u0027system load-import bootimage.iso bootimage.sig\u0027 successfull and"},{"line_number":19,"context_line":"      verfy in \u0027system load-list\u0027 with sufficient /scrach diskspace"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Signed-off-by: Junfeng (Shawn) Li \u003cjunfeng.li@windriver.com\u003e"},{"line_number":22,"context_line":"Change-Id: I4cbf0ce3f0f9036e41d65d7c19a84d92f768ae32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"aa975341_c35b761a","line":19,"range":{"start_line":18,"start_character":59,"end_line":19,"end_character":11},"in_reply_to":"e5abfbc3_e2d08b85","updated":"2022-07-05 21:00:11.000000000","message":"successfully and verify...","commit_id":"8c83361af346b60766d71d8cd37d32a5efc42119"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"87be199138beb55e146b16d375c33b49b15ca452","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"be554210_2e1f46aa","updated":"2022-07-05 17:10:14.000000000","message":"Recheck","commit_id":"2a02e974ba995ff2329038b6320a62305614064f"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"b6b4771a92c17bad19cc83541a676cc2fcb2280d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5fa491ce_448b5f11","updated":"2022-07-05 17:23:38.000000000","message":"recheck","commit_id":"2a02e974ba995ff2329038b6320a62305614064f"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/load.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"2fc5eb0a706bd706c9e564a2163785c8f8cc04ec","unresolved":true,"context_lines":[{"line_number":269,"context_line":"                              os.path.basename(file_item.filename))"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"            if source_file is None:"},{"line_number":272,"context_line":"                raise wsme.exc.ClientSideError(_(\"Failed to upload load file %s, invalid file object\""},{"line_number":273,"context_line":"                          % staging_file))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            if hasattr(source_file, \u0027fileno\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"55afa6ae_dce7e0a7","line":272,"range":{"start_line":272,"start_character":47,"end_line":272,"end_character":101},"updated":"2022-06-27 16:06:00.000000000","message":"nit: line over length (tox enforcement isnt enable yet though)","commit_id":"4ef56002e11ddae855c561d6b842bf61fcf04be4"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"2b24586d42cae98ad1cda011c63e84e74c360ce9","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                              os.path.basename(file_item.filename))"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"            if source_file is None:"},{"line_number":272,"context_line":"                raise wsme.exc.ClientSideError(_(\"Failed to upload load file %s, invalid file object\""},{"line_number":273,"context_line":"                          % staging_file))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            if hasattr(source_file, \u0027fileno\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"00df876e_75735108","line":272,"range":{"start_line":272,"start_character":47,"end_line":272,"end_character":101},"in_reply_to":"55afa6ae_dce7e0a7","updated":"2022-06-28 13:03:34.000000000","message":"Done","commit_id":"4ef56002e11ddae855c561d6b842bf61fcf04be4"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"2fc5eb0a706bd706c9e564a2163785c8f8cc04ec","unresolved":true,"context_lines":[{"line_number":372,"context_line":"                    if file_location:"},{"line_number":373,"context_line":"                        load_files.update({file: file_location})"},{"line_number":374,"context_line":"        except subprocess.CalledProcessError as ex:"},{"line_number":375,"context_line":"            raise wsme.exc.ClientSideError(str(ex))"},{"line_number":376,"context_line":"        except Exception as ex:"},{"line_number":377,"context_line":"            raise wsme.exc.ClientSideError(_(\"Failed to save file %s to disk. Error: %s\""},{"line_number":378,"context_line":"                                                            \" Please check sysinv logs for\""}],"source_content_type":"text/x-python","patch_set":1,"id":"851da728_f900f0db","line":375,"range":{"start_line":375,"start_character":43,"end_line":375,"end_character":50},"updated":"2022-06-27 16:06:00.000000000","message":"how verbose will this customer visible error be?\nConsider LOG.error() if too verbose and only raise the summary.  \n\nSimilar for the str(e) in Exception case below.\n\n(The LP is for more details logs in some cases though, such as when insufficient /scratch space as update above).","commit_id":"4ef56002e11ddae855c561d6b842bf61fcf04be4"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"0ab32e639ca8361e233baa7a02fbbfa405b9f6da","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                    if file_location:"},{"line_number":373,"context_line":"                        load_files.update({file: file_location})"},{"line_number":374,"context_line":"        except subprocess.CalledProcessError as ex:"},{"line_number":375,"context_line":"            raise wsme.exc.ClientSideError(str(ex))"},{"line_number":376,"context_line":"        except Exception as ex:"},{"line_number":377,"context_line":"            raise wsme.exc.ClientSideError(_(\"Failed to save file %s to disk. Error: %s\""},{"line_number":378,"context_line":"                                                            \" Please check sysinv logs for\""}],"source_content_type":"text/x-python","patch_set":1,"id":"8317f845_db32396e","line":375,"range":{"start_line":375,"start_character":43,"end_line":375,"end_character":50},"in_reply_to":"3cb5b789_c521bec8","updated":"2022-06-30 20:03:32.000000000","message":"This additional exception info is the one that was used in LOG.error or LOG.exception before this fix. The info is identical but it is displayed differently (log vs. exception)","commit_id":"4ef56002e11ddae855c561d6b842bf61fcf04be4"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"2b24586d42cae98ad1cda011c63e84e74c360ce9","unresolved":true,"context_lines":[{"line_number":372,"context_line":"                    if file_location:"},{"line_number":373,"context_line":"                        load_files.update({file: file_location})"},{"line_number":374,"context_line":"        except subprocess.CalledProcessError as ex:"},{"line_number":375,"context_line":"            raise wsme.exc.ClientSideError(str(ex))"},{"line_number":376,"context_line":"        except Exception as ex:"},{"line_number":377,"context_line":"            raise wsme.exc.ClientSideError(_(\"Failed to save file %s to disk. Error: %s\""},{"line_number":378,"context_line":"                                                            \" Please check sysinv logs for\""}],"source_content_type":"text/x-python","patch_set":1,"id":"a394456a_cc17dc60","line":375,"range":{"start_line":375,"start_character":43,"end_line":375,"end_character":50},"in_reply_to":"851da728_f900f0db","updated":"2022-06-28 13:03:34.000000000","message":"Both str(ex) will be populated by the exceptions from update() method. The idea is to change from logging the specific exceptions in update() and throw generic exceptions in calling method to only throw specific exceptions in calling method.","commit_id":"4ef56002e11ddae855c561d6b842bf61fcf04be4"},{"author":{"_account_id":32870,"name":"Adriano Oliveira","email":"adriano.oliveira@windriver.com","username":"aoliveir"},"change_message_id":"0f1f47666f6437b6a79486021932c23155a64626","unresolved":true,"context_lines":[{"line_number":372,"context_line":"                    if file_location:"},{"line_number":373,"context_line":"                        load_files.update({file: file_location})"},{"line_number":374,"context_line":"        except subprocess.CalledProcessError as ex:"},{"line_number":375,"context_line":"            raise wsme.exc.ClientSideError(str(ex))"},{"line_number":376,"context_line":"        except Exception as ex:"},{"line_number":377,"context_line":"            raise wsme.exc.ClientSideError(_(\"Failed to save file %s to disk. Error: %s\""},{"line_number":378,"context_line":"                                                            \" Please check sysinv logs for\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3cb5b789_c521bec8","line":375,"range":{"start_line":375,"start_character":43,"end_line":375,"end_character":50},"in_reply_to":"a394456a_cc17dc60","updated":"2022-06-30 15:18:00.000000000","message":"I think the concern here is the additional exception info added and if it was too verbose. I think it will make it clearer if add this info to the test section on the commit message.","commit_id":"4ef56002e11ddae855c561d6b842bf61fcf04be4"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"5fd774c3e7624be0e38299cc3aa4cf4c868f54d3","unresolved":true,"context_lines":[{"line_number":269,"context_line":"                              os.path.basename(file_item.filename))"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"            if source_file is None:"},{"line_number":272,"context_line":"                raise wsme.exc.ClientSideError(_(\"Failed to upload load file %s,\\"},{"line_number":273,"context_line":"                                                 invalid file object\" % staging_file))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            if hasattr(source_file, \u0027fileno\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"c1b540c3_22d7d243","line":272,"range":{"start_line":272,"start_character":80,"end_line":272,"end_character":81},"updated":"2022-07-05 17:47:23.000000000","message":"\"\\\" may not be required within ()","commit_id":"2a02e974ba995ff2329038b6320a62305614064f"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"763235aa3c6f20a48240af906d02d426a557c931","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                              os.path.basename(file_item.filename))"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"            if source_file is None:"},{"line_number":272,"context_line":"                raise wsme.exc.ClientSideError(_(\"Failed to upload load file %s,\\"},{"line_number":273,"context_line":"                                                 invalid file object\" % staging_file))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            if hasattr(source_file, \u0027fileno\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"049a444b_70792d3e","line":272,"range":{"start_line":272,"start_character":80,"end_line":272,"end_character":81},"in_reply_to":"c1b540c3_22d7d243","updated":"2022-07-05 19:48:24.000000000","message":"We still need \"\\\" because it is inside double quote(\")","commit_id":"2a02e974ba995ff2329038b6320a62305614064f"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"5fd774c3e7624be0e38299cc3aa4cf4c868f54d3","unresolved":true,"context_lines":[{"line_number":375,"context_line":"            raise wsme.exc.ClientSideError(str(ex))"},{"line_number":376,"context_line":"        except Exception as ex:"},{"line_number":377,"context_line":"            raise wsme.exc.ClientSideError(_(\"Failed to save file %s to disk. Error: %s\""},{"line_number":378,"context_line":"                                                            \" Please check sysinv logs for\""},{"line_number":379,"context_line":"                                                            \" details.\" % (file_item.filename, str(ex))))"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        LOG.info(\"Load files: %s saved to disk.\" % load_files)"}],"source_content_type":"text/x-python","patch_set":10,"id":"6548f25c_cdfaf307","line":378,"range":{"start_line":378,"start_character":45,"end_line":378,"end_character":60},"updated":"2022-07-05 17:47:23.000000000","message":"indentation could be aligned with parenthesis, ditto for line below.\n\ntox should detect whether indentation is acceptable.","commit_id":"2a02e974ba995ff2329038b6320a62305614064f"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"763235aa3c6f20a48240af906d02d426a557c931","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            raise wsme.exc.ClientSideError(str(ex))"},{"line_number":376,"context_line":"        except Exception as ex:"},{"line_number":377,"context_line":"            raise wsme.exc.ClientSideError(_(\"Failed to save file %s to disk. Error: %s\""},{"line_number":378,"context_line":"                                                            \" Please check sysinv logs for\""},{"line_number":379,"context_line":"                                                            \" details.\" % (file_item.filename, str(ex))))"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        LOG.info(\"Load files: %s saved to disk.\" % load_files)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ace007c_64f586e7","line":378,"range":{"start_line":378,"start_character":45,"end_line":378,"end_character":60},"in_reply_to":"6548f25c_cdfaf307","updated":"2022-07-05 19:48:24.000000000","message":"Done","commit_id":"2a02e974ba995ff2329038b6320a62305614064f"}]}