)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c753b61f9b1e65bdbf7c4b16b156d56c97db9e7f","unresolved":true,"context_lines":[{"line_number":31,"context_line":"      - host: ttys_dcd"},{"line_number":32,"context_line":"      - memory: hugepages_configured, vm_pending_as_percentage,"},{"line_number":33,"context_line":"                vm_hugepages_use_1G"},{"line_number":34,"context_line":"      - sensor: suppress"},{"line_number":35,"context_line":"      - sensorgroup: suppress"},{"line_number":36,"context_line":"PASS: run AIO-SX upgrade successfully"},{"line_number":37,"context_line":"PASS: all of the above on Debian (except upgrade)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"78955fd1_11217f43","line":34,"updated":"2022-07-14 14:55:53.000000000","message":"should be able to verify that the sensor could be suppressed or unsuppressed","commit_id":"5aa3d323c0ff5c3402f396690456a976585e83ef"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"751bad0bfe68ff1da88ba468364953f42feae0d7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      - host: ttys_dcd"},{"line_number":32,"context_line":"      - memory: hugepages_configured, vm_pending_as_percentage,"},{"line_number":33,"context_line":"                vm_hugepages_use_1G"},{"line_number":34,"context_line":"      - sensor: suppress"},{"line_number":35,"context_line":"      - sensorgroup: suppress"},{"line_number":36,"context_line":"PASS: run AIO-SX upgrade successfully"},{"line_number":37,"context_line":"PASS: all of the above on Debian (except upgrade)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"2307d197_a1eead0e","line":34,"in_reply_to":"78955fd1_11217f43","updated":"2022-07-14 21:35:28.000000000","message":"I did, saw the log messages on sysinv.log and hwmond.log, I\u0027ll update the Test Plan","commit_id":"5aa3d323c0ff5c3402f396690456a976585e83ef"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"53cc21f2b67bbfab2c1638846912382e28e667ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7d08515e_4326914f","updated":"2022-07-15 15:37:44.000000000","message":"Please review, I\u0027m marking with WF-1 because of the dependency of this change with DM","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"73ff58ca2c52b9f3863e65c45837457c5adf8928","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"005c2985_f827e8e5","updated":"2022-07-25 13:30:57.000000000","message":"Removing WF-1","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"57a90d53911739e4cce2e0e856579319b32f0dfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"68aec550_398605cc","updated":"2022-07-21 16:25:23.000000000","message":"Thanks Heitor","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"4459492d0897d1a9d594583c4df4d9a4e25532cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f90dbe1b_772377f3","updated":"2022-07-25 13:31:56.000000000","message":"recheck","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/memory.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"65380713e54b0a9a35489f06c34f8cb1d950bd78","unresolved":true,"context_lines":[{"line_number":426,"context_line":"                vswitch_hugepages_size_mib \u003d p[\u0027value\u0027]"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/vm_pending_as_percentage\u0027:"},{"line_number":429,"context_line":"                vm_pending_as_percentage \u003d rpc_port.fields[\u0027vm_pending_as_percentage\u0027](p[\u0027value\u0027])"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        if vm_pending_as_percentage is None:"},{"line_number":432,"context_line":"            vm_pending_as_percentage \u003d rpc_port[\"vm_pending_as_percentage\"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"dca0dcda_fd22ab84","line":429,"range":{"start_line":429,"start_character":86,"end_line":429,"end_character":98},"updated":"2022-07-21 14:05:13.000000000","message":"I am unclear about this syntax\nDoes vm_pending_as_percentage correspond to a method that you are invoking, and passing in p[\u0027value\u0027]  ?","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"73ff58ca2c52b9f3863e65c45837457c5adf8928","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                vswitch_hugepages_size_mib \u003d p[\u0027value\u0027]"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/vm_pending_as_percentage\u0027:"},{"line_number":429,"context_line":"                vm_pending_as_percentage \u003d rpc_port.fields[\u0027vm_pending_as_percentage\u0027](p[\u0027value\u0027])"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        if vm_pending_as_percentage is None:"},{"line_number":432,"context_line":"            vm_pending_as_percentage \u003d rpc_port[\"vm_pending_as_percentage\"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"402c324a_f0544f43","line":429,"range":{"start_line":429,"start_character":86,"end_line":429,"end_character":98},"in_reply_to":"525599a9_eccc2008","updated":"2022-07-25 13:30:57.000000000","message":"Done","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"afe864b5b73ae0d599013294fa85dd570b9c5992","unresolved":true,"context_lines":[{"line_number":426,"context_line":"                vswitch_hugepages_size_mib \u003d p[\u0027value\u0027]"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/vm_pending_as_percentage\u0027:"},{"line_number":429,"context_line":"                vm_pending_as_percentage \u003d rpc_port.fields[\u0027vm_pending_as_percentage\u0027](p[\u0027value\u0027])"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        if vm_pending_as_percentage is None:"},{"line_number":432,"context_line":"            vm_pending_as_percentage \u003d rpc_port[\"vm_pending_as_percentage\"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"525599a9_eccc2008","line":429,"range":{"start_line":429,"start_character":86,"end_line":429,"end_character":98},"in_reply_to":"dca0dcda_fd22ab84","updated":"2022-07-21 15:12:33.000000000","message":"rpc_port.fields[\u0027vm_pending_as_percentage\u0027] is a method (bool_or_none) used to parse the vm_pending_as_percentage attribute value from the objects.memory.Memory class: https://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/sysinv/objects/memory.py#L42 (this commit changes this line from str_to_none to bool_to_none)\n\nThe goal of this call is to parse the value from the patch to the same type and using the same function as the object retrieved from the database on line #393:\n\nrpc_port \u003d objects.memory.get_by_uuid(\n                       pecan.request.context, memory_uuid)\n                       \nIf we don\u0027t convert it to the same type, the vm_pending_as_percentage variable may assume different types depending on the result of the \"if\" on line #431 (boolean type if None, string type if not None) and this breaks the following comparisons using the variable.","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/sensorgroup.py":[{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"a62dfc8c162070329187caa426d472d34e8ffc7e","unresolved":true,"context_lines":[{"line_number":513,"context_line":"                raise wsme.exc.ClientSideError(_(\"Invalid suppress value, \""},{"line_number":514,"context_line":"                                               \"select \u0027True\u0027 or \u0027False\u0027\"))"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        self._semantic_modifiable_fields(patch_obj)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        if not pecan.request.user_agent.startswith(\u0027hwmon\u0027):"},{"line_number":519,"context_line":"            hwmon_sensorgroup \u003d cutils.removekeys_nonhwmon("}],"source_content_type":"text/x-python","patch_set":14,"id":"b5a0afc9_f742e44b","line":516,"range":{"start_line":516,"start_character":0,"end_line":516,"end_character":51},"updated":"2022-07-19 19:31:46.000000000","message":"The \u0027force_action\u0027 will be always False in this func. Are we going to change the logic regarding the \u0027force_action\u0027?","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"c2efcf012dcc1dc6e6b926846f886f50689def97","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                raise wsme.exc.ClientSideError(_(\"Invalid suppress value, \""},{"line_number":514,"context_line":"                                               \"select \u0027True\u0027 or \u0027False\u0027\"))"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        self._semantic_modifiable_fields(patch_obj)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        if not pecan.request.user_agent.startswith(\u0027hwmon\u0027):"},{"line_number":519,"context_line":"            hwmon_sensorgroup \u003d cutils.removekeys_nonhwmon("}],"source_content_type":"text/x-python","patch_set":14,"id":"b754cb46_b57f898c","line":516,"range":{"start_line":516,"start_character":0,"end_line":516,"end_character":51},"in_reply_to":"3205dc59_69a74128","updated":"2022-07-21 13:21:22.000000000","message":"Ack","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"b155f79268830c29bb2d65fd74f6a43f494340ac","unresolved":true,"context_lines":[{"line_number":513,"context_line":"                raise wsme.exc.ClientSideError(_(\"Invalid suppress value, \""},{"line_number":514,"context_line":"                                               \"select \u0027True\u0027 or \u0027False\u0027\"))"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        self._semantic_modifiable_fields(patch_obj)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        if not pecan.request.user_agent.startswith(\u0027hwmon\u0027):"},{"line_number":519,"context_line":"            hwmon_sensorgroup \u003d cutils.removekeys_nonhwmon("}],"source_content_type":"text/x-python","patch_set":14,"id":"3205dc59_69a74128","line":516,"range":{"start_line":516,"start_character":0,"end_line":516,"end_character":51},"in_reply_to":"b5a0afc9_f742e44b","updated":"2022-07-21 13:19:29.000000000","message":"In this commit we\u0027re basically not allowing this \"force_action\" value on sysinv anymore, since the field will only assume boolean values from now on, and on metal repo (hwmon) there aren\u0027t references to force_action anymore as well (only in  comments such https://opendev.org/starlingx/metal/src/commit/240773cf5d14dd681ece41398f612c16ab088300/mtce/src/hwmon/hwmonHttp.h#L60, so seems like it is safe to leave the logic as it is now, thanks for the review.","commit_id":"ebd16cc31b096b41e3e08d1bb1a2f4cbd93f7774"}],"sysinv/sysinv/sysinv/sysinv/puppet/platform.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"3e2472aa1b186a93952aae66a77f1fcca006f434","unresolved":true,"context_lines":[{"line_number":908,"context_line":"    def _get_ttys_dcd_config(self, host):"},{"line_number":909,"context_line":"        return {"},{"line_number":910,"context_line":"            \"platform::tty::params::enabled\":"},{"line_number":911,"context_line":"                str(host.ttys_dcd) in [\u0027True\u0027, \u0027true\u0027],"},{"line_number":912,"context_line":"            \"platform::tty::params::active_device\":"},{"line_number":913,"context_line":"                host.console.split(\u0027,\u0027)[0]"},{"line_number":914,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":13,"id":"1328275d_0e53410f","line":911,"updated":"2022-07-14 14:58:03.000000000","message":"host.ttys_dcd should be a bool with this commit","commit_id":"5aa3d323c0ff5c3402f396690456a976585e83ef"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"751bad0bfe68ff1da88ba468364953f42feae0d7","unresolved":false,"context_lines":[{"line_number":908,"context_line":"    def _get_ttys_dcd_config(self, host):"},{"line_number":909,"context_line":"        return {"},{"line_number":910,"context_line":"            \"platform::tty::params::enabled\":"},{"line_number":911,"context_line":"                str(host.ttys_dcd) in [\u0027True\u0027, \u0027true\u0027],"},{"line_number":912,"context_line":"            \"platform::tty::params::active_device\":"},{"line_number":913,"context_line":"                host.console.split(\u0027,\u0027)[0]"},{"line_number":914,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a26e031_d6ac7c74","line":911,"in_reply_to":"1328275d_0e53410f","updated":"2022-07-14 21:35:28.000000000","message":"Done","commit_id":"5aa3d323c0ff5c3402f396690456a976585e83ef"}],"sysinv/sysinv/sysinv/sysinv/tests/db/utils.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c753b61f9b1e65bdbf7c4b16b156d56c97db9e7f","unresolved":true,"context_lines":[{"line_number":157,"context_line":"            \u0027install_output\u0027: kw.get(\u0027install_output\u0027, \u0027text\u0027),"},{"line_number":158,"context_line":"            \u0027console\u0027: kw.get(\u0027console\u0027, \u0027ttyS0,115200\u0027),"},{"line_number":159,"context_line":"            \u0027tboot\u0027: kw.get(\u0027tboot\u0027, \u0027\u0027),"},{"line_number":160,"context_line":"            \u0027ttys_dcd\u0027: kw.get(\u0027ttys_dcd\u0027, False),"},{"line_number":161,"context_line":"            \u0027updated_at\u0027: None,"},{"line_number":162,"context_line":"            \u0027created_at\u0027: None,"},{"line_number":163,"context_line":"            \u0027install_state\u0027: kw.get(\u0027install_state\u0027, None),"}],"source_content_type":"text/x-python","patch_set":13,"id":"0da7ef1a_9c46f975","line":160,"updated":"2022-07-14 14:55:53.000000000","message":"sysinv/puppet/platform.conf could also be simplified as it should be a boolean","commit_id":"5aa3d323c0ff5c3402f396690456a976585e83ef"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"751bad0bfe68ff1da88ba468364953f42feae0d7","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \u0027install_output\u0027: kw.get(\u0027install_output\u0027, \u0027text\u0027),"},{"line_number":158,"context_line":"            \u0027console\u0027: kw.get(\u0027console\u0027, \u0027ttyS0,115200\u0027),"},{"line_number":159,"context_line":"            \u0027tboot\u0027: kw.get(\u0027tboot\u0027, \u0027\u0027),"},{"line_number":160,"context_line":"            \u0027ttys_dcd\u0027: kw.get(\u0027ttys_dcd\u0027, False),"},{"line_number":161,"context_line":"            \u0027updated_at\u0027: None,"},{"line_number":162,"context_line":"            \u0027created_at\u0027: None,"},{"line_number":163,"context_line":"            \u0027install_state\u0027: kw.get(\u0027install_state\u0027, None),"}],"source_content_type":"text/x-python","patch_set":13,"id":"8601dc3b_6bcaaf20","line":160,"in_reply_to":"0da7ef1a_9c46f975","updated":"2022-07-14 21:35:28.000000000","message":"Done","commit_id":"5aa3d323c0ff5c3402f396690456a976585e83ef"}]}