)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"4fd301971379b2a8161382523d0b3fd12d25d3cf","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Block the addition of ssl_ca certificates with same subject name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test Plan:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Attempted to install another certificate with same subject, and"},{"line_number":14,"context_line":"      verified that it fails with an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3adf6c73_d9b0608d","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"updated":"2022-07-25 14:29:58.000000000","message":"As discussed, please add test cases similar to the below:\n\nPASS: Verified that a new column subject shows up for command\n      system certificate-list","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"4fd301971379b2a8161382523d0b3fd12d25d3cf","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Block the addition of ssl_ca certificates with same subject name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test Plan:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Attempted to install another certificate with same subject, and"},{"line_number":14,"context_line":"      verified that it fails with an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"0768419a_b92101d4","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"updated":"2022-07-25 14:29:58.000000000","message":"As discussed, please add test cases similar to the below:\n\nPASS: Verified that when there is a subject name clash the command\n      system certificate-install returns an error and the certificate that has the same subject","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"15c38f7b8333e3b1a3a9412c6cdbf1cf8cbb6d98","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Block the addition of ssl_ca certificates with same subject name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test Plan:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Attempted to install another certificate with same subject, and"},{"line_number":14,"context_line":"      verified that it fails with an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7c0161fb_b64d4353","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"updated":"2022-07-25 14:31:09.000000000","message":"Please add a test case similar to the below:\n\nPASS: Verified that the system shows an error when the subject field is emtpy for ssa_ca","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"82ddd017a448102736ed6fede47380e053a9d61f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Block the addition of ssl_ca certificates with same subject name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test Plan:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Attempted to install another certificate with same subject, and"},{"line_number":14,"context_line":"      verified that it fails with an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9e9c46a1_3108559a","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"in_reply_to":"0768419a_b92101d4","updated":"2022-07-26 17:06:40.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9f9fa84118516a0f175c6095edf58425bed7c505","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Block the addition of ssl_ca certificates with same subject name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test Plan:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Attempted to install another certificate with same subject, and"},{"line_number":14,"context_line":"      verified that it fails with an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"a33b5497_ebdc799c","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"in_reply_to":"3adf6c73_d9b0608d","updated":"2022-07-26 20:10:34.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"82ddd017a448102736ed6fede47380e053a9d61f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Block the addition of ssl_ca certificates with same subject name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Test Plan:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Attempted to install another certificate with same subject, and"},{"line_number":14,"context_line":"      verified that it fails with an error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7ee5572c_d219f0d9","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"in_reply_to":"7c0161fb_b64d4353","updated":"2022-07-26 17:06:40.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"4fd301971379b2a8161382523d0b3fd12d25d3cf","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Attempted to install another certificate with same subject, and"},{"line_number":14,"context_line":"      verified that it fails with an error."},{"line_number":15,"context_line":"PASS: Generate and install a full iso and verified that columns subject"},{"line_number":16,"context_line":"      and hash_subject were added to certificate table."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-bug: 1981100"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"817118e6_afe8875c","line":15,"updated":"2022-07-25 14:29:58.000000000","message":"As discussed, please add test cases similar to the below:\n\nPASS: Verified that a new column subject shows up as a return to\n      a successful system certificate-install command","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9f9fa84118516a0f175c6095edf58425bed7c505","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PASS: Attempted to install another certificate with same subject, and"},{"line_number":14,"context_line":"      verified that it fails with an error."},{"line_number":15,"context_line":"PASS: Generate and install a full iso and verified that columns subject"},{"line_number":16,"context_line":"      and hash_subject were added to certificate table."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-bug: 1981100"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9d7b9cd7_63b16a53","line":15,"in_reply_to":"817118e6_afe8875c","updated":"2022-07-26 20:10:34.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"49e3637266f6bd124b58ef49b04bb52a7f14d6b9","unresolved":true,"context_lines":[{"line_number":16,"context_line":"      and hash_subject were added to certificate table."},{"line_number":17,"context_line":"PASS: Verified that when there is a subject name clash the command"},{"line_number":18,"context_line":"PASS: Verified that the system shows an error when the subject field is"},{"line_number":19,"context_line":"      emtpy for ssa_ca"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-bug: 1981100"},{"line_number":22,"context_line":"Signed-off-by: Karla Felix \u003ckarla.karolinenogueirafelix@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3634557b_a7388e73","line":19,"range":{"start_line":19,"start_character":16,"end_line":19,"end_character":22},"updated":"2022-07-26 17:57:12.000000000","message":"a ssl_ca certificate.","commit_id":"e2d6a3ed053e1292526289ce3984a49560872b58"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9f9fa84118516a0f175c6095edf58425bed7c505","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      and hash_subject were added to certificate table."},{"line_number":17,"context_line":"PASS: Verified that when there is a subject name clash the command"},{"line_number":18,"context_line":"PASS: Verified that the system shows an error when the subject field is"},{"line_number":19,"context_line":"      emtpy for ssa_ca"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-bug: 1981100"},{"line_number":22,"context_line":"Signed-off-by: Karla Felix \u003ckarla.karolinenogueirafelix@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"640940fa_fd61eca7","line":19,"range":{"start_line":19,"start_character":16,"end_line":19,"end_character":22},"in_reply_to":"3634557b_a7388e73","updated":"2022-07-26 20:10:34.000000000","message":"Done","commit_id":"e2d6a3ed053e1292526289ce3984a49560872b58"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"4ea6d9cf2117c8a0c6f796edd14e2121a5d62fbd","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      verified that it fails with an error."},{"line_number":15,"context_line":"PASS: Generate and install a full iso and verified that columns subject"},{"line_number":16,"context_line":"      and hash_subject were added to certificate table."},{"line_number":17,"context_line":"PASS: Verified that when there is a subject name clash the command"},{"line_number":18,"context_line":"      system certificate-install returns an error and the certificate"},{"line_number":19,"context_line":"      that has the same subject"},{"line_number":20,"context_line":"PASS: Verified that the system shows an error when the subject field is"},{"line_number":21,"context_line":"      emtpy for ssl_ca"},{"line_number":22,"context_line":"PASS: Verified that a new column subject shows up for command"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"7af21eb6_ae192bcb","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":31},"updated":"2022-08-01 15:55:23.000000000","message":"I think we might have an issue with this change with the bootstrap playbook, in cases where the user tries to re-run the playbook.\nI\u0027m not sure about that one though","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"803ad59bde596a8b00ffdf3dfee102b0e7dc65b1","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      verified that it fails with an error."},{"line_number":15,"context_line":"PASS: Generate and install a full iso and verified that columns subject"},{"line_number":16,"context_line":"      and hash_subject were added to certificate table."},{"line_number":17,"context_line":"PASS: Verified that when there is a subject name clash the command"},{"line_number":18,"context_line":"      system certificate-install returns an error and the certificate"},{"line_number":19,"context_line":"      that has the same subject"},{"line_number":20,"context_line":"PASS: Verified that the system shows an error when the subject field is"},{"line_number":21,"context_line":"      emtpy for ssl_ca"},{"line_number":22,"context_line":"PASS: Verified that a new column subject shows up for command"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"a2a73b4b_efac04bb","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":31},"in_reply_to":"7af21eb6_ae192bcb","updated":"2022-08-02 14:29:13.000000000","message":"I have confirmed this issue","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9a5fbee9bb89a18db8bd5d5a07302d926d512ee8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      verified that it fails with an error."},{"line_number":15,"context_line":"PASS: Generate and install a full iso and verified that columns subject"},{"line_number":16,"context_line":"      and hash_subject were added to certificate table."},{"line_number":17,"context_line":"PASS: Verified that when there is a subject name clash the command"},{"line_number":18,"context_line":"      system certificate-install returns an error and the certificate"},{"line_number":19,"context_line":"      that has the same subject"},{"line_number":20,"context_line":"PASS: Verified that the system shows an error when the subject field is"},{"line_number":21,"context_line":"      emtpy for ssl_ca"},{"line_number":22,"context_line":"PASS: Verified that a new column subject shows up for command"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"313020b5_380f32a6","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":31},"in_reply_to":"83a7e23f_c3ce11b1","updated":"2022-08-10 14:50:08.000000000","message":"Done","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"ec737c9f417e76deac479760eee6c8544903c752","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      verified that it fails with an error."},{"line_number":15,"context_line":"PASS: Generate and install a full iso and verified that columns subject"},{"line_number":16,"context_line":"      and hash_subject were added to certificate table."},{"line_number":17,"context_line":"PASS: Verified that when there is a subject name clash the command"},{"line_number":18,"context_line":"      system certificate-install returns an error and the certificate"},{"line_number":19,"context_line":"      that has the same subject"},{"line_number":20,"context_line":"PASS: Verified that the system shows an error when the subject field is"},{"line_number":21,"context_line":"      emtpy for ssl_ca"},{"line_number":22,"context_line":"PASS: Verified that a new column subject shows up for command"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"d4d4a57f_59438171","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":31},"in_reply_to":"a2a73b4b_efac04bb","updated":"2022-08-02 15:16:05.000000000","message":"Yes, I opened a review with a possible solution to this issue, it still need testing but I will post the link here: https://review.opendev.org/c/starlingx/ansible-playbooks/+/851894","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"2913d82cd06845ed6f271365d1cc613966dcdd2a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      verified that it fails with an error."},{"line_number":15,"context_line":"PASS: Generate and install a full iso and verified that columns subject"},{"line_number":16,"context_line":"      and hash_subject were added to certificate table."},{"line_number":17,"context_line":"PASS: Verified that when there is a subject name clash the command"},{"line_number":18,"context_line":"      system certificate-install returns an error and the certificate"},{"line_number":19,"context_line":"      that has the same subject"},{"line_number":20,"context_line":"PASS: Verified that the system shows an error when the subject field is"},{"line_number":21,"context_line":"      emtpy for ssl_ca"},{"line_number":22,"context_line":"PASS: Verified that a new column subject shows up for command"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"83a7e23f_c3ce11b1","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":31},"in_reply_to":"d4d4a57f_59438171","updated":"2022-08-02 19:49:10.000000000","message":"nit: It\u0027s good practice to also link the related reviews by using the same subject for both","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"4ea6d9cf2117c8a0c6f796edd14e2121a5d62fbd","unresolved":true,"context_lines":[{"line_number":19,"context_line":"      that has the same subject"},{"line_number":20,"context_line":"PASS: Verified that the system shows an error when the subject field is"},{"line_number":21,"context_line":"      emtpy for ssl_ca"},{"line_number":22,"context_line":"PASS: Verified that a new column subject shows up for command"},{"line_number":23,"context_line":"      system certificate-list"},{"line_number":24,"context_line":"PASS: Verified that a new column subject shows up as a return to"},{"line_number":25,"context_line":"      a successful system certificate-install command"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-bug: 1981100"},{"line_number":28,"context_line":"Signed-off-by: Karla Felix \u003ckarla.karolinenogueirafelix@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"0d0cde04_f06dc854","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":53},"updated":"2022-08-01 15:55:23.000000000","message":"I don\u0027t see the code for this in the review. I think you might have forgot to push changes for cgtsclient shell","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"c11c6290e25498cd09c9c98ef500f9d5a23dc013","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      that has the same subject"},{"line_number":20,"context_line":"PASS: Verified that the system shows an error when the subject field is"},{"line_number":21,"context_line":"      emtpy for ssl_ca"},{"line_number":22,"context_line":"PASS: Verified that a new column subject shows up for command"},{"line_number":23,"context_line":"      system certificate-list"},{"line_number":24,"context_line":"PASS: Verified that a new column subject shows up as a return to"},{"line_number":25,"context_line":"      a successful system certificate-install command"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-bug: 1981100"},{"line_number":28,"context_line":"Signed-off-by: Karla Felix \u003ckarla.karolinenogueirafelix@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1a6fcdc8_3a017447","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":53},"in_reply_to":"0d0cde04_f06dc854","updated":"2022-08-02 15:16:28.000000000","message":"Done","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"2913d82cd06845ed6f271365d1cc613966dcdd2a","unresolved":true,"context_lines":[{"line_number":24,"context_line":"PASS: Verified that a new column subject shows up as a return to"},{"line_number":25,"context_line":"      a successful system certificate-install command"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/ansible-playbooks/+/851894"},{"line_number":28,"context_line":"Closes-bug: 1981100"},{"line_number":29,"context_line":"Signed-off-by: Karla Felix \u003ckarla.karolinenogueirafelix@windriver.com\u003e"},{"line_number":30,"context_line":"Change-Id: I7ce11cc5dab6f686d360d01594ba100d07d2c2db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"622e7663_9d0331ad","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":77},"updated":"2022-08-02 19:49:10.000000000","message":"nit: using same topic allows for better linking of stories","commit_id":"e2689d1a6acee9cf36412f27888183bba5ee7f26"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"16c1193c335718eb394598cd08ff623fb137ba38","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PASS: Verified that a new column subject shows up as a return to"},{"line_number":25,"context_line":"      a successful system certificate-install command"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Depends-on: https://review.opendev.org/c/starlingx/ansible-playbooks/+/851894"},{"line_number":28,"context_line":"Closes-bug: 1981100"},{"line_number":29,"context_line":"Signed-off-by: Karla Felix \u003ckarla.karolinenogueirafelix@windriver.com\u003e"},{"line_number":30,"context_line":"Change-Id: I7ce11cc5dab6f686d360d01594ba100d07d2c2db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3b749d4c_4a482baa","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":77},"in_reply_to":"622e7663_9d0331ad","updated":"2022-08-04 15:10:21.000000000","message":"Done","commit_id":"e2689d1a6acee9cf36412f27888183bba5ee7f26"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"333fafd3ecfc3292784fdea9efcdf8a0a2d92d9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4522d468_0ff506eb","updated":"2022-07-21 19:39:35.000000000","message":"You should WIP this review since you don\u0027t have PASSED Tests (Assuming you are still testing).","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"834efb307409a9cbd9b4c3fb2f75100d6ccdb6ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b526d86a_956b9d1a","updated":"2022-07-26 17:59:13.000000000","message":"code seems fine.\n","commit_id":"35c3ce2eca59271d92ab709e4369cc620aede825"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"17f70c5b54b9c918d22460dd4fa915d6bd2bc202","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"32598b23_2d6a054f","updated":"2022-08-12 13:01:33.000000000","message":"I am adding Yuxing to make him aware, in case the addition of those new fields to the certificate API has any impact on gophercloud\n\nie:\nhttps://github.com/Wind-River/gophercloud/blob/starlingx/starlingx/inventory/v1/certificates/results.go#L75","commit_id":"7bd617b2fbbb11ac30e4037be818d1093113e5be"}],"sysinv/cgts-client/cgts-client/cgtsclient/v1/certificate_shell.py":[{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"2913d82cd06845ed6f271365d1cc613966dcdd2a","unresolved":true,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    cc.certificate.certificate_uninstall(args.certificate_uuid)"},{"line_number":144,"context_line":"    print(\u0027Uninstalled certificate: %s\u0027 % (args.certificate_uuid))"},{"line_number":145,"context_line":"                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              "}],"source_content_type":"text/x-python","patch_set":21,"id":"93bc7ef0_2f7cf644","line":145,"range":{"start_line":145,"start_character":100,"end_line":145,"end_character":510},"updated":"2022-08-02 19:49:10.000000000","message":"nit: odd extra lines","commit_id":"e2689d1a6acee9cf36412f27888183bba5ee7f26"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"16c1193c335718eb394598cd08ff623fb137ba38","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    cc.certificate.certificate_uninstall(args.certificate_uuid)"},{"line_number":144,"context_line":"    print(\u0027Uninstalled certificate: %s\u0027 % (args.certificate_uuid))"},{"line_number":145,"context_line":"                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              "}],"source_content_type":"text/x-python","patch_set":21,"id":"f01e5dc3_95eb7ac2","line":145,"range":{"start_line":145,"start_character":100,"end_line":145,"end_character":510},"in_reply_to":"93bc7ef0_2f7cf644","updated":"2022-08-04 15:10:21.000000000","message":"Done","commit_id":"e2689d1a6acee9cf36412f27888183bba5ee7f26"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b41cc958cd44f974751bf71622558039fe2ff9d7","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    fields \u003d [\u0027uuid\u0027, \u0027certtype\u0027, \u0027expiry_date\u0027, \u0027subject\u0027]"},{"line_number":52,"context_line":"    field_labels \u003d fields"},{"line_number":53,"context_line":"    for certificate in certificates:"},{"line_number":54,"context_line":"        if len(certificate.subject) \u003e\u003d 20:"},{"line_number":55,"context_line":"            certificate.subject \u003d certificate.subject[:20] + \"...\""},{"line_number":56,"context_line":"    utils.print_list(certificates, fields, field_labels, sortby\u003d0)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"885c56e1_638ccfda","line":54,"range":{"start_line":54,"start_character":37,"end_line":54,"end_character":38},"updated":"2022-08-09 14:31:11.000000000","message":"isnt this only required if \u0027\u003e20\u0027 ?","commit_id":"5fd7a09443198f6670e83cfdc613e4be1b8c15ad"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9a5fbee9bb89a18db8bd5d5a07302d926d512ee8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    fields \u003d [\u0027uuid\u0027, \u0027certtype\u0027, \u0027expiry_date\u0027, \u0027subject\u0027]"},{"line_number":52,"context_line":"    field_labels \u003d fields"},{"line_number":53,"context_line":"    for certificate in certificates:"},{"line_number":54,"context_line":"        if len(certificate.subject) \u003e\u003d 20:"},{"line_number":55,"context_line":"            certificate.subject \u003d certificate.subject[:20] + \"...\""},{"line_number":56,"context_line":"    utils.print_list(certificates, fields, field_labels, sortby\u003d0)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"c9d73e95_86320ead","line":54,"range":{"start_line":54,"start_character":37,"end_line":54,"end_character":38},"in_reply_to":"885c56e1_638ccfda","updated":"2022-08-10 14:50:08.000000000","message":"Done","commit_id":"5fd7a09443198f6670e83cfdc613e4be1b8c15ad"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/certificate.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"333fafd3ecfc3292784fdea9efcdf8a0a2d92d9b","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    \"Represents the subject of the certificate\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    hash_subject \u003d wtypes.text"},{"line_number":111,"context_line":"    \"Representes the hash of the certificate\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def __init__(self, **kwargs):"},{"line_number":114,"context_line":"        self.fields \u003d list(objects.certificate.fields.keys())"}],"source_content_type":"text/x-python","patch_set":8,"id":"11519a00_6aa75d80","line":111,"range":{"start_line":111,"start_character":5,"end_line":111,"end_character":44},"updated":"2022-07-21 19:39:35.000000000","message":"\"Represents the hash of the certificate\u0027s subject\"","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"93b6963e0dcb51fa840ddfcdce396b442fa5bf66","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    \"Represents the subject of the certificate\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    hash_subject \u003d wtypes.text"},{"line_number":111,"context_line":"    \"Representes the hash of the certificate\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def __init__(self, **kwargs):"},{"line_number":114,"context_line":"        self.fields \u003d list(objects.certificate.fields.keys())"}],"source_content_type":"text/x-python","patch_set":8,"id":"8c274a85_883cb975","line":111,"range":{"start_line":111,"start_character":5,"end_line":111,"end_character":44},"in_reply_to":"11519a00_6aa75d80","updated":"2022-07-22 21:04:02.000000000","message":"Done","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"333fafd3ecfc3292784fdea9efcdf8a0a2d92d9b","unresolved":true,"context_lines":[{"line_number":445,"context_line":"            # check to see if the installed cert exist in sysinv"},{"line_number":446,"context_line":"            uuid \u003d None"},{"line_number":447,"context_line":"            for certificate in certificates:"},{"line_number":448,"context_line":"                if str(inv_cert.get(\u0027hash_subject\u0027)) \u003d\u003d certificate.hash_subject:"},{"line_number":449,"context_line":"                        error \u003d \"ERROR: karla : Could not add: certificate with same subject already exist!\""},{"line_number":450,"context_line":"                        LOG.warn(error)"},{"line_number":451,"context_line":"                        return dict(success\u003d\"\", error\u003derror, body\u003d\"\","},{"line_number":452,"context_line":"                                certificates\u003dcertificate_dicts)"},{"line_number":453,"context_line":"                if mode \u003d\u003d constants.CERT_MODE_SSL_CA:"},{"line_number":454,"context_line":"                    if inv_cert.get(\u0027signature\u0027) \u003d\u003d certificate.signature:"},{"line_number":455,"context_line":"                        uuid \u003d certificate.uuid"}],"source_content_type":"text/x-python","patch_set":8,"id":"a818e683_0a738340","line":452,"range":{"start_line":448,"start_character":0,"end_line":452,"end_character":63},"updated":"2022-07-21 19:39:35.000000000","message":"Blocking here is too late, the certificates already get installed on Line 409 by config_certificate(). The blocking should be done under condition \"mode \u003d\u003d constants.CERT_MODE_SSL_CA\" on Line 390.","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"93b6963e0dcb51fa840ddfcdce396b442fa5bf66","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            # check to see if the installed cert exist in sysinv"},{"line_number":446,"context_line":"            uuid \u003d None"},{"line_number":447,"context_line":"            for certificate in certificates:"},{"line_number":448,"context_line":"                if str(inv_cert.get(\u0027hash_subject\u0027)) \u003d\u003d certificate.hash_subject:"},{"line_number":449,"context_line":"                        error \u003d \"ERROR: karla : Could not add: certificate with same subject already exist!\""},{"line_number":450,"context_line":"                        LOG.warn(error)"},{"line_number":451,"context_line":"                        return dict(success\u003d\"\", error\u003derror, body\u003d\"\","},{"line_number":452,"context_line":"                                certificates\u003dcertificate_dicts)"},{"line_number":453,"context_line":"                if mode \u003d\u003d constants.CERT_MODE_SSL_CA:"},{"line_number":454,"context_line":"                    if inv_cert.get(\u0027signature\u0027) \u003d\u003d certificate.signature:"},{"line_number":455,"context_line":"                        uuid \u003d certificate.uuid"}],"source_content_type":"text/x-python","patch_set":8,"id":"77edd591_fc471891","line":452,"range":{"start_line":448,"start_character":0,"end_line":452,"end_character":63},"in_reply_to":"a818e683_0a738340","updated":"2022-07-22 21:04:02.000000000","message":"Done","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"2c6459d5eae3643ed481596ad9c19be86283d866","unresolved":true,"context_lines":[{"line_number":332,"context_line":"        hash_issuers \u003d []"},{"line_number":333,"context_line":"        cert_validity_error \u003d None"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        certificates \u003d pecan.request.dbapi.certificate_get_list()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        for index, cert in enumerate(certs):"},{"line_number":338,"context_line":"            msg \u003d self._check_cert_validity(cert)"}],"source_content_type":"text/x-python","patch_set":10,"id":"385e4a4e_cd0090e3","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":20},"updated":"2022-07-22 22:53:56.000000000","message":"For better readability I would like to have this variable to be called existing_certificates","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"82ddd017a448102736ed6fede47380e053a9d61f","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        hash_issuers \u003d []"},{"line_number":333,"context_line":"        cert_validity_error \u003d None"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        certificates \u003d pecan.request.dbapi.certificate_get_list()"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        for index, cert in enumerate(certs):"},{"line_number":338,"context_line":"            msg \u003d self._check_cert_validity(cert)"}],"source_content_type":"text/x-python","patch_set":10,"id":"437e8910_12ba567e","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":20},"in_reply_to":"385e4a4e_cd0090e3","updated":"2022-07-26 17:06:40.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"26a3668da45e76be0cbe8b06b74d96b414b45e93","unresolved":true,"context_lines":[{"line_number":395,"context_line":"                    msg \u003d \"Cannot install non-CA type certificate as SSL \" \\"},{"line_number":396,"context_line":"                          \"CA certificate\""},{"line_number":397,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":398,"context_line":"            "},{"line_number":399,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"            for certificate in certificates:"},{"line_number":401,"context_line":"                if  hash_subject \u003d\u003d int(certificate.hash_subject):"}],"source_content_type":"text/x-python","patch_set":10,"id":"086830c3_ab2e9394","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":12},"updated":"2022-07-22 21:38:26.000000000","message":"There seems to be some empty indents here.","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"09b16f3fcfafb7c1ba92fe12d3e57f7f924f6b3f","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                    msg \u003d \"Cannot install non-CA type certificate as SSL \" \\"},{"line_number":396,"context_line":"                          \"CA certificate\""},{"line_number":397,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":398,"context_line":"            "},{"line_number":399,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"            for certificate in certificates:"},{"line_number":401,"context_line":"                if  hash_subject \u003d\u003d int(certificate.hash_subject):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fb9e9dab_6ad704b0","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":12},"in_reply_to":"086830c3_ab2e9394","updated":"2022-07-26 17:07:47.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"2c6459d5eae3643ed481596ad9c19be86283d866","unresolved":true,"context_lines":[{"line_number":397,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":398,"context_line":"            "},{"line_number":399,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"            for certificate in certificates:"},{"line_number":401,"context_line":"                if  hash_subject \u003d\u003d int(certificate.hash_subject):"},{"line_number":402,"context_line":"                    msg \u003d \"Cannot install certificate with same subject\""},{"line_number":403,"context_line":"                    LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"78400b34_7a3b4d45","line":400,"range":{"start_line":400,"start_character":16,"end_line":400,"end_character":27},"updated":"2022-07-22 22:53:56.000000000","message":"Similar to my other comment, It would help for readability if this variable is called existing_certificate","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"82ddd017a448102736ed6fede47380e053a9d61f","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":398,"context_line":"            "},{"line_number":399,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"            for certificate in certificates:"},{"line_number":401,"context_line":"                if  hash_subject \u003d\u003d int(certificate.hash_subject):"},{"line_number":402,"context_line":"                    msg \u003d \"Cannot install certificate with same subject\""},{"line_number":403,"context_line":"                    LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"e50c03c1_2d32d1d5","line":400,"range":{"start_line":400,"start_character":16,"end_line":400,"end_character":27},"in_reply_to":"78400b34_7a3b4d45","updated":"2022-07-26 17:06:40.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"26a3668da45e76be0cbe8b06b74d96b414b45e93","unresolved":true,"context_lines":[{"line_number":399,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"            for certificate in certificates:"},{"line_number":401,"context_line":"                if  hash_subject \u003d\u003d int(certificate.hash_subject):"},{"line_number":402,"context_line":"                    msg \u003d \"Cannot install certificate with same subject\""},{"line_number":403,"context_line":"                    LOG.error(msg)"},{"line_number":404,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"2b9146f9_c88b5a07","line":402,"range":{"start_line":402,"start_character":27,"end_line":402,"end_character":71},"updated":"2022-07-22 21:38:26.000000000","message":"We\u0027d need to add more info the error message that will be displayed to user. I\u0027d like to include some thing like \"Please uninstall the following CA certs that have the same subject first\", and followed by a list of the existing certs that have the same subject.","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"09b16f3fcfafb7c1ba92fe12d3e57f7f924f6b3f","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"            for certificate in certificates:"},{"line_number":401,"context_line":"                if  hash_subject \u003d\u003d int(certificate.hash_subject):"},{"line_number":402,"context_line":"                    msg \u003d \"Cannot install certificate with same subject\""},{"line_number":403,"context_line":"                    LOG.error(msg)"},{"line_number":404,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"667be7d4_9a3a47c8","line":402,"range":{"start_line":402,"start_character":27,"end_line":402,"end_character":71},"in_reply_to":"2b9146f9_c88b5a07","updated":"2022-07-26 17:07:47.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"cbc3a606bb6d79bf44b3f5328f7146baf4089edf","unresolved":true,"context_lines":[{"line_number":402,"context_line":"                    msg \u003d \"Cannot install certificate with same subject\\n\" \\"},{"line_number":403,"context_line":"                          \"Please uninstall the following CA certs that have the same subject first\\n\" \\"},{"line_number":404,"context_line":"                          \"Certificate UUID\\n\" \\"},{"line_number":405,"context_line":"                          \"%s\" % (certificate.uuid)"},{"line_number":406,"context_line":"                    LOG.error(msg)"},{"line_number":407,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"383e7472_f2f07c2a","line":405,"updated":"2022-07-26 17:55:23.000000000","message":"The above works. But if there are multiple subject duplicated CA certs, the installation will failed again on the next one. Suggest finish the whole loop and use a flag to decide to return with error or not. Also save all subject duplicated certs\u0027 UUID in a list and return to user as error with all of them. This way user knows all the duplicate certs in one single install attempt.","commit_id":"e2d6a3ed053e1292526289ce3984a49560872b58"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9f9fa84118516a0f175c6095edf58425bed7c505","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                    msg \u003d \"Cannot install certificate with same subject\\n\" \\"},{"line_number":403,"context_line":"                          \"Please uninstall the following CA certs that have the same subject first\\n\" \\"},{"line_number":404,"context_line":"                          \"Certificate UUID\\n\" \\"},{"line_number":405,"context_line":"                          \"%s\" % (certificate.uuid)"},{"line_number":406,"context_line":"                    LOG.error(msg)"},{"line_number":407,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"46ecf673_8aac2576","line":405,"in_reply_to":"383e7472_f2f07c2a","updated":"2022-07-26 20:10:34.000000000","message":"Done","commit_id":"e2d6a3ed053e1292526289ce3984a49560872b58"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"be06a8cd8816612b3f01e42e65a7d60ac5c797c4","unresolved":true,"context_lines":[{"line_number":397,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":398,"context_line":"                if cert.subject:"},{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid for certificate in existing_certificates "},{"line_number":401,"context_line":"                                        if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":402,"context_line":"                    if duplicate_certificates:"},{"line_number":403,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"2ae223e7_1dc34c62","line":400,"range":{"start_line":400,"start_character":103,"end_line":400,"end_character":104},"updated":"2022-07-26 21:06:20.000000000","message":"Getting closer ... remove this extra space.","commit_id":"3538753a260cbea15f9ff4c200f7c4d1bb3119f2"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"24b5dcdc3ddda9cf6a6bf8abd4c0a6f7acc0b03b","unresolved":true,"context_lines":[{"line_number":397,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":398,"context_line":"                if cert.subject:"},{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid for certificate in existing_certificates "},{"line_number":401,"context_line":"                                        if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":402,"context_line":"                    if duplicate_certificates:"},{"line_number":403,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"2b4e4d9a_6278c100","line":400,"range":{"start_line":400,"start_character":103,"end_line":400,"end_character":104},"in_reply_to":"2ae223e7_1dc34c62","updated":"2022-07-26 21:07:56.000000000","message":"This is causing Zuul failure.","commit_id":"3538753a260cbea15f9ff4c200f7c4d1bb3119f2"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"ff4a468a417dc47338cdd0c29ddc4023b9076675","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":398,"context_line":"                if cert.subject:"},{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid for certificate in existing_certificates "},{"line_number":401,"context_line":"                                        if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":402,"context_line":"                    if duplicate_certificates:"},{"line_number":403,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"}],"source_content_type":"text/x-python","patch_set":15,"id":"70fd912c_42cf4ba3","line":400,"range":{"start_line":400,"start_character":103,"end_line":400,"end_character":104},"in_reply_to":"2b4e4d9a_6278c100","updated":"2022-07-26 21:41:29.000000000","message":"Done","commit_id":"3538753a260cbea15f9ff4c200f7c4d1bb3119f2"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"f885ae625c324130cc1a923c68237b24e9f3af12","unresolved":true,"context_lines":[{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid"},{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":403,"context_line":"                    if duplicate_certificates:"},{"line_number":404,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":405,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"}],"source_content_type":"text/x-python","patch_set":17,"id":"9cd595c8_ec688a28","line":402,"range":{"start_line":402,"start_character":67,"end_line":402,"end_character":91},"updated":"2022-07-28 12:36:05.000000000","message":"on an upgrade; the prior release certificates would not have this field (i.e. None)?  In such case, the int() operation will raise an exception; and thus prevent the installation of new certificates","commit_id":"24f01a70541f23722ff09ed464dc48df91aee3c4"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"f59ebb5326b968b1dfec1b2227a7728407f88564","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid"},{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":403,"context_line":"                    if duplicate_certificates:"},{"line_number":404,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":405,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"}],"source_content_type":"text/x-python","patch_set":17,"id":"1fe1a589_aa5998e6","line":402,"range":{"start_line":402,"start_character":67,"end_line":402,"end_character":91},"in_reply_to":"5e6e071d_846c6312","updated":"2022-07-29 16:54:11.000000000","message":"Yes, it will catch the duplicate subject, it will not break with certificates with no hash_subject.","commit_id":"24f01a70541f23722ff09ed464dc48df91aee3c4"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"c003cf79a3e395283e0c4c971afe433146089af6","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid"},{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":403,"context_line":"                    if duplicate_certificates:"},{"line_number":404,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":405,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"}],"source_content_type":"text/x-python","patch_set":17,"id":"5e6e071d_846c6312","line":402,"range":{"start_line":402,"start_character":67,"end_line":402,"end_character":91},"in_reply_to":"75100a88_a48efeca","updated":"2022-07-29 13:32:07.000000000","message":"Just to double check, if there are multiple certs with no hash_subject (from upgrade) and a cert with same hash_subject in the system, will this code catch the subject duplicated cert? Will the loop break out earlier when it finds the first cert with no hash_subject?","commit_id":"24f01a70541f23722ff09ed464dc48df91aee3c4"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"59b15fb227efc2e6a504775628c77502e2182706","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid"},{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":403,"context_line":"                    if duplicate_certificates:"},{"line_number":404,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":405,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"}],"source_content_type":"text/x-python","patch_set":17,"id":"a7ed26dc_76293258","line":402,"range":{"start_line":402,"start_character":67,"end_line":402,"end_character":91},"in_reply_to":"81d21891_8b718a1c","updated":"2022-07-28 21:00:27.000000000","message":"It is, I tested with certs with no subject or hash_subject","commit_id":"24f01a70541f23722ff09ed464dc48df91aee3c4"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"01f514ca6decd5fa410b95bf741e16ff3e11f0ff","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid"},{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":403,"context_line":"                    if duplicate_certificates:"},{"line_number":404,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":405,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"}],"source_content_type":"text/x-python","patch_set":17,"id":"db8316be_6a27ad2b","line":402,"range":{"start_line":402,"start_character":67,"end_line":402,"end_character":91},"in_reply_to":"9cd595c8_ec688a28","updated":"2022-07-28 16:30:37.000000000","message":"Done","commit_id":"24f01a70541f23722ff09ed464dc48df91aee3c4"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"7116655c077e6bb733f19a6c2ba43217a22a3503","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid"},{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":403,"context_line":"                    if duplicate_certificates:"},{"line_number":404,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":405,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"}],"source_content_type":"text/x-python","patch_set":17,"id":"75100a88_a48efeca","line":402,"range":{"start_line":402,"start_character":67,"end_line":402,"end_character":91},"in_reply_to":"a7ed26dc_76293258","updated":"2022-07-28 21:09:41.000000000","message":"ok, sounds like this was tested with certs with no hash_subject already installed into the sysinv database (which would be the case on an upgrade to this release).","commit_id":"24f01a70541f23722ff09ed464dc48df91aee3c4"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"7c6b6654e9a6e7ac2c9e1b4fa54b9eb8392413d3","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":400,"context_line":"                    duplicate_certificates \u003d [certificate.uuid"},{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":403,"context_line":"                    if duplicate_certificates:"},{"line_number":404,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":405,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"}],"source_content_type":"text/x-python","patch_set":17,"id":"81d21891_8b718a1c","line":402,"range":{"start_line":402,"start_character":67,"end_line":402,"end_character":91},"in_reply_to":"db8316be_6a27ad2b","updated":"2022-07-28 19:01:27.000000000","message":"please confirm the short circuit is working as expected","commit_id":"24f01a70541f23722ff09ed464dc48df91aee3c4"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"4ea6d9cf2117c8a0c6f796edd14e2121a5d62fbd","unresolved":true,"context_lines":[{"line_number":403,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":404,"context_line":"                    if duplicate_certificates:"},{"line_number":405,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":406,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"},{"line_number":407,"context_line":"                            \"the same subject first\""},{"line_number":408,"context_line":"                        for uuid in duplicate_certificates:"},{"line_number":409,"context_line":"                            msg.append(\"\\nUUID : %s\" % uuid)"}],"source_content_type":"text/x-python","patch_set":18,"id":"d4b13ebd_ee1f9f52","line":406,"range":{"start_line":406,"start_character":80,"end_line":406,"end_character":83},"updated":"2022-08-01 15:55:23.000000000","message":"this probably needs a space between \u0027have\u0027 and \u0027the\u0027","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"c11c6290e25498cd09c9c98ef500f9d5a23dc013","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":404,"context_line":"                    if duplicate_certificates:"},{"line_number":405,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":406,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"},{"line_number":407,"context_line":"                            \"the same subject first\""},{"line_number":408,"context_line":"                        for uuid in duplicate_certificates:"},{"line_number":409,"context_line":"                            msg.append(\"\\nUUID : %s\" % uuid)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3b4cdbc4_dda9a363","line":406,"range":{"start_line":406,"start_character":80,"end_line":406,"end_character":83},"in_reply_to":"d4b13ebd_ee1f9f52","updated":"2022-08-02 15:16:28.000000000","message":"Done","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"4ea6d9cf2117c8a0c6f796edd14e2121a5d62fbd","unresolved":true,"context_lines":[{"line_number":406,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"},{"line_number":407,"context_line":"                            \"the same subject first\""},{"line_number":408,"context_line":"                        for uuid in duplicate_certificates:"},{"line_number":409,"context_line":"                            msg.append(\"\\nUUID : %s\" % uuid)"},{"line_number":410,"context_line":"                        LOG.error(msg)"},{"line_number":411,"context_line":"                        return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":412,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"10cdff1e_ba39c2cf","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":38},"updated":"2022-08-01 15:55:23.000000000","message":"I think this should change to \u0027msg +\u003d \u0027","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"c11c6290e25498cd09c9c98ef500f9d5a23dc013","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"},{"line_number":407,"context_line":"                            \"the same subject first\""},{"line_number":408,"context_line":"                        for uuid in duplicate_certificates:"},{"line_number":409,"context_line":"                            msg.append(\"\\nUUID : %s\" % uuid)"},{"line_number":410,"context_line":"                        LOG.error(msg)"},{"line_number":411,"context_line":"                        return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":412,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"01ee2b2b_26dcc058","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":38},"in_reply_to":"10cdff1e_ba39c2cf","updated":"2022-08-02 15:16:28.000000000","message":"Done","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"c62cb36d6e27ba37d3cfd9c6f4076071fbd7757e","unresolved":true,"context_lines":[{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if certificate.hash_subject"},{"line_number":403,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":404,"context_line":"                    if duplicate_certificates:"},{"line_number":405,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":406,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"},{"line_number":407,"context_line":"                            \"the same subject first\""},{"line_number":408,"context_line":"                        for uuid in duplicate_certificates:"},{"line_number":409,"context_line":"                            msg.append(\"\\nUUID : %s\" % uuid)"},{"line_number":410,"context_line":"                        LOG.error(msg)"},{"line_number":411,"context_line":"                        return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":412,"context_line":"                else:"},{"line_number":413,"context_line":"                    msg \u003d \"Cannot install CA certificate without subject\""},{"line_number":414,"context_line":"                    LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":18,"id":"d478b32d_5cbb5a42","line":411,"range":{"start_line":404,"start_character":20,"end_line":411,"end_character":58},"updated":"2022-07-29 16:06:53.000000000","message":"Does this also reject an updated certificate?","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"c11c6290e25498cd09c9c98ef500f9d5a23dc013","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if certificate.hash_subject"},{"line_number":403,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":404,"context_line":"                    if duplicate_certificates:"},{"line_number":405,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":406,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"},{"line_number":407,"context_line":"                            \"the same subject first\""},{"line_number":408,"context_line":"                        for uuid in duplicate_certificates:"},{"line_number":409,"context_line":"                            msg.append(\"\\nUUID : %s\" % uuid)"},{"line_number":410,"context_line":"                        LOG.error(msg)"},{"line_number":411,"context_line":"                        return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":412,"context_line":"                else:"},{"line_number":413,"context_line":"                    msg \u003d \"Cannot install CA certificate without subject\""},{"line_number":414,"context_line":"                    LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":18,"id":"b3ba2dcf_f189d00b","line":411,"range":{"start_line":404,"start_character":20,"end_line":411,"end_character":58},"in_reply_to":"9de7df09_cad28cb9","updated":"2022-08-02 15:16:28.000000000","message":"Done","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"f59ebb5326b968b1dfec1b2227a7728407f88564","unresolved":true,"context_lines":[{"line_number":401,"context_line":"                                            for certificate in existing_certificates"},{"line_number":402,"context_line":"                                            if certificate.hash_subject"},{"line_number":403,"context_line":"                                            if hash_subject \u003d\u003d int(certificate.hash_subject)]"},{"line_number":404,"context_line":"                    if duplicate_certificates:"},{"line_number":405,"context_line":"                        msg \u003d \"Cannot install certificate with same subject\" \\"},{"line_number":406,"context_line":"                            \"\\nPlease uninstall the following CA certs that have\" \\"},{"line_number":407,"context_line":"                            \"the same subject first\""},{"line_number":408,"context_line":"                        for uuid in duplicate_certificates:"},{"line_number":409,"context_line":"                            msg.append(\"\\nUUID : %s\" % uuid)"},{"line_number":410,"context_line":"                        LOG.error(msg)"},{"line_number":411,"context_line":"                        return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":412,"context_line":"                else:"},{"line_number":413,"context_line":"                    msg \u003d \"Cannot install CA certificate without subject\""},{"line_number":414,"context_line":"                    LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9de7df09_cad28cb9","line":411,"range":{"start_line":404,"start_character":20,"end_line":411,"end_character":58},"in_reply_to":"d478b32d_5cbb5a42","updated":"2022-07-29 16:54:11.000000000","message":"This change is only to ssl_ca certs and ssl_ca certs don\u0027t support update.","commit_id":"73cf67b041775538ca918257070a25a216157a69"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"7ef7dcf164a85460658e330b3c804a9d55500efe","unresolved":true,"context_lines":[{"line_number":410,"context_line":"                        LOG.error(msg)"},{"line_number":411,"context_line":"                        return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":412,"context_line":"                else:"},{"line_number":413,"context_line":"                    msg \u003d \"Cannot install CA certificate without subject\""},{"line_number":414,"context_line":"                    LOG.error(msg)"},{"line_number":415,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"6c69817b_7f56837a","line":413,"updated":"2022-08-11 18:00:40.000000000","message":"will this change require any automation test update for integration? (i.e. do current lab certificates already have this field).","commit_id":"7bd617b2fbbb11ac30e4037be818d1093113e5be"},{"author":{"_account_id":31292,"name":"ayyappa","email":"ayyappa.mantri@windriver.com","username":"amantri"},"change_message_id":"e779db9e16f044761a653d24816bf14b79ced2be","unresolved":true,"context_lines":[{"line_number":410,"context_line":"                        LOG.error(msg)"},{"line_number":411,"context_line":"                        return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":412,"context_line":"                else:"},{"line_number":413,"context_line":"                    msg \u003d \"Cannot install CA certificate without subject\""},{"line_number":414,"context_line":"                    LOG.error(msg)"},{"line_number":415,"context_line":"                    return dict(success\u003d\"\", error\u003dmsg)"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ef929644_600bfa44","line":413,"in_reply_to":"6c69817b_7f56837a","updated":"2022-08-11 20:01:16.000000000","message":"No changes required in automation tests, mostly the installed certs has subjects and also we reply on the command output return code for pass/fail.","commit_id":"7bd617b2fbbb11ac30e4037be818d1093113e5be"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"2c6459d5eae3643ed481596ad9c19be86283d866","unresolved":true,"context_lines":[{"line_number":12977,"context_line":"            # check if the cert is a CA cert"},{"line_number":12978,"context_line":"            is_ca \u003d cutils.is_ca_cert(cert)"},{"line_number":12979,"context_line":""},{"line_number":12980,"context_line":"            #add hash_subject to hash_subject"},{"line_number":12981,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":12982,"context_line":""},{"line_number":12983,"context_line":"            signature \u003d mode + \u0027_\u0027 + str(cert.serial_number)"}],"source_content_type":"text/x-python","patch_set":10,"id":"80919bbc_15a76c37","line":12980,"updated":"2022-07-22 22:53:56.000000000","message":"With your latest refactoring I\u0027m not sure this change here is necessary. Please double check","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"834efb307409a9cbd9b4c3fb2f75100d6ccdb6ef","unresolved":true,"context_lines":[{"line_number":12977,"context_line":"            # check if the cert is a CA cert"},{"line_number":12978,"context_line":"            is_ca \u003d cutils.is_ca_cert(cert)"},{"line_number":12979,"context_line":""},{"line_number":12980,"context_line":"            #add hash_subject to hash_subject"},{"line_number":12981,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":12982,"context_line":""},{"line_number":12983,"context_line":"            signature \u003d mode + \u0027_\u0027 + str(cert.serial_number)"}],"source_content_type":"text/x-python","patch_set":10,"id":"57eea748_f1ac6cbe","line":12980,"in_reply_to":"17a15903_d6ca14d6","updated":"2022-07-26 17:59:13.000000000","message":"is that comment accurate.  You may be OK with just removing the comment altogether if you like.","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9f9fa84118516a0f175c6095edf58425bed7c505","unresolved":false,"context_lines":[{"line_number":12977,"context_line":"            # check if the cert is a CA cert"},{"line_number":12978,"context_line":"            is_ca \u003d cutils.is_ca_cert(cert)"},{"line_number":12979,"context_line":""},{"line_number":12980,"context_line":"            #add hash_subject to hash_subject"},{"line_number":12981,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":12982,"context_line":""},{"line_number":12983,"context_line":"            signature \u003d mode + \u0027_\u0027 + str(cert.serial_number)"}],"source_content_type":"text/x-python","patch_set":10,"id":"f6e84afb_ff9e90e1","line":12980,"in_reply_to":"57eea748_f1ac6cbe","updated":"2022-07-26 20:10:34.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"82ddd017a448102736ed6fede47380e053a9d61f","unresolved":true,"context_lines":[{"line_number":12977,"context_line":"            # check if the cert is a CA cert"},{"line_number":12978,"context_line":"            is_ca \u003d cutils.is_ca_cert(cert)"},{"line_number":12979,"context_line":""},{"line_number":12980,"context_line":"            #add hash_subject to hash_subject"},{"line_number":12981,"context_line":"            hash_subject \u003d cutils.get_cert_subject_hash(cert)"},{"line_number":12982,"context_line":""},{"line_number":12983,"context_line":"            signature \u003d mode + \u0027_\u0027 + str(cert.serial_number)"}],"source_content_type":"text/x-python","patch_set":10,"id":"17a15903_d6ca14d6","line":12980,"in_reply_to":"80919bbc_15a76c37","updated":"2022-07-26 17:06:40.000000000","message":"It still necessary to maintain this line.","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b41cc958cd44f974751bf71622558039fe2ff9d7","unresolved":true,"context_lines":[{"line_number":12993,"context_line":"                             \u0027is_ca\u0027: is_ca,"},{"line_number":12994,"context_line":"                             \u0027public_bytes\u0027: public_bytes,"},{"line_number":12995,"context_line":"                             \u0027signature\u0027: signature,"},{"line_number":12996,"context_line":"                             \u0027hash_subject\u0027: hash_subject})"},{"line_number":12997,"context_line":""},{"line_number":12998,"context_line":"        return cert_list, private_bytes"},{"line_number":12999,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"2c6a583c_131c67b3","line":12996,"updated":"2022-08-09 14:31:11.000000000","message":"\u0027subject\u0027 field is not populated in this case?","commit_id":"5fd7a09443198f6670e83cfdc613e4be1b8c15ad"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9a5fbee9bb89a18db8bd5d5a07302d926d512ee8","unresolved":true,"context_lines":[{"line_number":12993,"context_line":"                             \u0027is_ca\u0027: is_ca,"},{"line_number":12994,"context_line":"                             \u0027public_bytes\u0027: public_bytes,"},{"line_number":12995,"context_line":"                             \u0027signature\u0027: signature,"},{"line_number":12996,"context_line":"                             \u0027hash_subject\u0027: hash_subject})"},{"line_number":12997,"context_line":""},{"line_number":12998,"context_line":"        return cert_list, private_bytes"},{"line_number":12999,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"2cd1e8cb_7a358392","line":12996,"in_reply_to":"2c6a583c_131c67b3","updated":"2022-08-10 14:50:08.000000000","message":"Subject is populated in line 13333 of certificate.py, because all certificates already have this data, hash_subject need to be generated by a function to be shown.","commit_id":"5fd7a09443198f6670e83cfdc613e4be1b8c15ad"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"0333c69cd6fc49e596826b6d11ba0757a9bbaa04","unresolved":false,"context_lines":[{"line_number":12993,"context_line":"                             \u0027is_ca\u0027: is_ca,"},{"line_number":12994,"context_line":"                             \u0027public_bytes\u0027: public_bytes,"},{"line_number":12995,"context_line":"                             \u0027signature\u0027: signature,"},{"line_number":12996,"context_line":"                             \u0027hash_subject\u0027: hash_subject})"},{"line_number":12997,"context_line":""},{"line_number":12998,"context_line":"        return cert_list, private_bytes"},{"line_number":12999,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9fbced00_94c23874","line":12996,"in_reply_to":"2cd1e8cb_7a358392","updated":"2022-08-10 16:14:00.000000000","message":"Done","commit_id":"5fd7a09443198f6670e83cfdc613e4be1b8c15ad"}],"sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/064_certificate.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"6090f3d9b29cd54298efc893e8bdb70c161fbf3a","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        Column(\u0027expiry_date\u0027, DateTime),"},{"line_number":37,"context_line":"        Column(\u0027capabilities\u0027, Text),"},{"line_number":38,"context_line":"        Column(\u0027subject\u0027, Text),"},{"line_number":39,"context_line":"        Column(\u0027hash_subject\u0027, Text),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        mysql_engine\u003dENGINE,"},{"line_number":42,"context_line":"        mysql_charset\u003dCHARSET,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9eeebc3c_1f16f03d","line":39,"updated":"2022-07-21 18:15:17.000000000","message":"Karla, we dont modify an existing migration step.\nthe database might be at a higher value than version 64, so this would not be invoked in that scenario.\nYou should add a new migration entry and have that add these additional columns","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"93b6963e0dcb51fa840ddfcdce396b442fa5bf66","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        Column(\u0027expiry_date\u0027, DateTime),"},{"line_number":37,"context_line":"        Column(\u0027capabilities\u0027, Text),"},{"line_number":38,"context_line":"        Column(\u0027subject\u0027, Text),"},{"line_number":39,"context_line":"        Column(\u0027hash_subject\u0027, Text),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        mysql_engine\u003dENGINE,"},{"line_number":42,"context_line":"        mysql_charset\u003dCHARSET,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5bc6e85f_a702b78d","line":39,"in_reply_to":"9eeebc3c_1f16f03d","updated":"2022-07-22 21:04:02.000000000","message":"Done","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"}],"sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/125_certificate_add_new_columns.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"26a3668da45e76be0cbe8b06b74d96b414b45e93","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from sqlalchemy import Column"},{"line_number":9,"context_line":"from sqlalchemy import MetaData"},{"line_number":10,"context_line":"from sqlalchemy import Table"},{"line_number":11,"context_line":"from sqlalchemy import String"},{"line_number":12,"context_line":"from sqlalchemy import Integer"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"def upgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":10,"id":"04862385_e93e2a12","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":30},"updated":"2022-07-22 21:38:26.000000000","message":"Import should be in alphebetical order.","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"e7a2c0c6f940df1218b0e2d499850083b4c762ba","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from sqlalchemy import Column"},{"line_number":9,"context_line":"from sqlalchemy import MetaData"},{"line_number":10,"context_line":"from sqlalchemy import Table"},{"line_number":11,"context_line":"from sqlalchemy import String"},{"line_number":12,"context_line":"from sqlalchemy import Integer"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"def upgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":10,"id":"a9aafd55_1dc8830b","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":30},"in_reply_to":"04862385_e93e2a12","updated":"2022-07-26 17:50:48.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"cbc3a606bb6d79bf44b3f5328f7146baf4089edf","unresolved":true,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from sqlalchemy import Column"},{"line_number":9,"context_line":"from sqlalchemy import MetaData"},{"line_number":10,"context_line":"from sqlalchemy import Table"},{"line_number":11,"context_line":"from sqlalchemy import String"},{"line_number":12,"context_line":"from sqlalchemy import Integer"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"def upgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":11,"id":"722c7d6f_f666a4ec","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":30},"updated":"2022-07-26 17:55:23.000000000","message":"Still not in alphabetical order.","commit_id":"e2d6a3ed053e1292526289ce3984a49560872b58"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9f9fa84118516a0f175c6095edf58425bed7c505","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"from sqlalchemy import Column"},{"line_number":9,"context_line":"from sqlalchemy import MetaData"},{"line_number":10,"context_line":"from sqlalchemy import Table"},{"line_number":11,"context_line":"from sqlalchemy import String"},{"line_number":12,"context_line":"from sqlalchemy import Integer"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"def upgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":11,"id":"11484776_78c0e744","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":30},"in_reply_to":"722c7d6f_f666a4ec","updated":"2022-07-26 20:10:34.000000000","message":"Done","commit_id":"e2d6a3ed053e1292526289ce3984a49560872b58"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b41cc958cd44f974751bf71622558039fe2ff9d7","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    col_subject \u003d Column(\u0027subject\u0027, String(255), nullable\u003dTrue)"},{"line_number":22,"context_line":"    col_subject.create(certificate)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    col_hash_subject \u003d Column(\u0027hash_subject\u0027, String(255), nullable\u003dTrue)"},{"line_number":25,"context_line":"    col_hash_subject.create(certificate)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5faadaaa_b0108ca6","line":24,"updated":"2022-08-09 14:31:11.000000000","message":"what is the expected max size of hash_subject ?","commit_id":"5fd7a09443198f6670e83cfdc613e4be1b8c15ad"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"9a5fbee9bb89a18db8bd5d5a07302d926d512ee8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    col_subject \u003d Column(\u0027subject\u0027, String(255), nullable\u003dTrue)"},{"line_number":22,"context_line":"    col_subject.create(certificate)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    col_hash_subject \u003d Column(\u0027hash_subject\u0027, String(255), nullable\u003dTrue)"},{"line_number":25,"context_line":"    col_hash_subject.create(certificate)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"eec470f8_f3f28d9d","line":24,"in_reply_to":"5faadaaa_b0108ca6","updated":"2022-08-10 14:50:08.000000000","message":"Done","commit_id":"5fd7a09443198f6670e83cfdc613e4be1b8c15ad"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"4d4e9c9323705e5e0167a5939c0ae8a85819f880","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    col_subject \u003d Column(\u0027subject\u0027, String(255), nullable\u003dTrue)"},{"line_number":22,"context_line":"    col_subject.create(certificate)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    col_hash_subject \u003d Column(\u0027hash_subject\u0027, String(255), nullable\u003dTrue)"},{"line_number":25,"context_line":"    col_hash_subject.create(certificate)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"85f81b84_092a011b","line":24,"in_reply_to":"eec470f8_f3f28d9d","updated":"2022-08-10 16:08:48.000000000","message":"The hash_subject is an integer representation of the first four bytes of the MD5 digest of the DER representation of the name. So I think a 255 string field should be always enough.","commit_id":"5fd7a09443198f6670e83cfdc613e4be1b8c15ad"}],"sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/models.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"333fafd3ecfc3292784fdea9efcdf8a0a2d92d9b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2013-2021 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"abf2c3bc_474ba874","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":25},"updated":"2022-07-21 19:39:35.000000000","message":"2013-2022","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"93b6963e0dcb51fa840ddfcdce396b442fa5bf66","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2013-2021 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"7b4d4a43_2b20fe3c","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":25},"in_reply_to":"abf2c3bc_474ba874","updated":"2022-07-22 21:04:02.000000000","message":"Done","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"}],"sysinv/sysinv/sysinv/sysinv/objects/certificate.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"333fafd3ecfc3292784fdea9efcdf8a0a2d92d9b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"490ac322_63789a4f","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"updated":"2022-07-21 19:39:35.000000000","message":"2018-2022","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"93b6963e0dcb51fa840ddfcdce396b442fa5bf66","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"d95c4935_f5b3a4cf","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"in_reply_to":"490ac322_63789a4f","updated":"2022-07-22 21:04:02.000000000","message":"Done","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"333fafd3ecfc3292784fdea9efcdf8a0a2d92d9b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"# coding\u003dutf-8"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from wsgiref.simple_server import WSGIRequestHandler"},{"line_number":11,"context_line":"from sysinv.db import api as db_api"},{"line_number":12,"context_line":"from sysinv.objects import base"},{"line_number":13,"context_line":"from sysinv.objects import utils"}],"source_content_type":"text/x-python","patch_set":8,"id":"541fcbae_c1028af1","line":10,"updated":"2022-07-21 19:39:35.000000000","message":"Why we need to import this module?","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"93b6963e0dcb51fa840ddfcdce396b442fa5bf66","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# coding\u003dutf-8"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from wsgiref.simple_server import WSGIRequestHandler"},{"line_number":11,"context_line":"from sysinv.db import api as db_api"},{"line_number":12,"context_line":"from sysinv.objects import base"},{"line_number":13,"context_line":"from sysinv.objects import utils"}],"source_content_type":"text/x-python","patch_set":8,"id":"0467329e_31bfe2a6","line":10,"in_reply_to":"541fcbae_c1028af1","updated":"2022-07-22 21:04:02.000000000","message":"Done","commit_id":"f24f803ee47b04bda48876d4274445db7269b311"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"2c6459d5eae3643ed481596ad9c19be86283d866","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"00446261_dc4fc1d1","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-07-22 22:53:56.000000000","message":"2018-2022","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"},{"author":{"_account_id":34446,"name":"Karla Felix","display_name":"Karla Felix","email":"karla.karolinenogueirafelix@windriver.com","username":"kkarolin"},"change_message_id":"82ddd017a448102736ed6fede47380e053a9d61f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"c113299e_27ea0819","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"00446261_dc4fc1d1","updated":"2022-07-26 17:06:40.000000000","message":"Done","commit_id":"316d365c1e4c43ecffe1619d11f47a891b629aa7"}]}