)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"db675dac42283ede33d10fe0461b14c91ba389b2","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"PENDING:"},{"line_number":17,"context_line":"CentOS -\u003e CentOS upgrade:"},{"line_number":18,"context_line":"- 22.06 -\u003e 22.12"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Story: 2009303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"595dbf02_1669f1ba","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":25},"updated":"2022-08-04 19:19:46.000000000","message":"Please specify what types of deployment you tested the upgrade (i.e. AIO-SX, AIO-DX, ...)","commit_id":"426f636c3dcdbb782e6ba072b9e84098bf9230b3"},{"author":{"_account_id":33684,"name":"Luis Eduardo Bonatti","email":"LuizEduardo.Bonatti@windriver.com","username":"lbonatti"},"change_message_id":"d4bf2cf51ce9ebb384f6849fd6a3d490f7fe1833","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"PENDING:"},{"line_number":17,"context_line":"CentOS -\u003e CentOS upgrade:"},{"line_number":18,"context_line":"- 22.06 -\u003e 22.12"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Story: 2009303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"63955ae5_97ccb5e6","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":25},"in_reply_to":"595dbf02_1669f1ba","updated":"2022-08-04 19:22:20.000000000","message":"Done","commit_id":"426f636c3dcdbb782e6ba072b9e84098bf9230b3"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"a33b295d8da8a482cd9b3dc18e8e583337f7a6de","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Armada folder missing inside /opt/platform"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The armada folder do not exist inside the /opt/plaform"},{"line_number":10,"context_line":"when the host do not have any armada application"},{"line_number":11,"context_line":"raising an error when armada migration config is"},{"line_number":12,"context_line":"triggered on 22.06 -\u003e 22.12 upgrade"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"8598493a_dc38fddc","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":54},"updated":"2022-08-08 16:06:23.000000000","message":"platform","commit_id":"f2ee842323c8055b17d88ce7607cbc69f17b74ac"},{"author":{"_account_id":33684,"name":"Luis Eduardo Bonatti","email":"LuizEduardo.Bonatti@windriver.com","username":"lbonatti"},"change_message_id":"38e8bb58656586f79f6c3df1314c0cb46f97d70a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Armada folder missing inside /opt/platform"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The armada folder do not exist inside the /opt/plaform"},{"line_number":10,"context_line":"when the host do not have any armada application"},{"line_number":11,"context_line":"raising an error when armada migration config is"},{"line_number":12,"context_line":"triggered on 22.06 -\u003e 22.12 upgrade"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"65acae00_dd1e64fd","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":54},"in_reply_to":"8598493a_dc38fddc","updated":"2022-08-08 16:24:13.000000000","message":"Done","commit_id":"f2ee842323c8055b17d88ce7607cbc69f17b74ac"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c4a7f0f6eedd43757300fd965964b0170d7bdc50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"93bb026f_e1c28337","updated":"2022-08-09 11:44:35.000000000","message":"lgtm","commit_id":"4363c9964b1b976d669204f224bb61395f83638a"}],"controllerconfig/controllerconfig/controllerconfig/upgrades/controller.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"75f3c4d0c65285dc1b912211c53128c63149193e","unresolved":true,"context_lines":[{"line_number":310,"context_line":"    LOG.info(\"Migrating armada config\")"},{"line_number":311,"context_line":"    devnull \u003d open(os.devnull, \u0027w\u0027)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    # Check if the folder exist before migration"},{"line_number":314,"context_line":"    if not os.path.exists(os.path.join(PLATFORM_PATH, \"armada\")):"},{"line_number":315,"context_line":"        return"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"68a99e25_be161bc1","line":313,"updated":"2022-08-04 18:34:44.000000000","message":"I\u0027d do that before L310 to avoid opening an fd for devnull.","commit_id":"170c949a623d1071c9a78951d3b8b3a231e7900b"},{"author":{"_account_id":33684,"name":"Luis Eduardo Bonatti","email":"LuizEduardo.Bonatti@windriver.com","username":"lbonatti"},"change_message_id":"7c0fd6ea30aa6ce87d02faaff60c1b0cb133cd92","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    LOG.info(\"Migrating armada config\")"},{"line_number":311,"context_line":"    devnull \u003d open(os.devnull, \u0027w\u0027)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    # Check if the folder exist before migration"},{"line_number":314,"context_line":"    if not os.path.exists(os.path.join(PLATFORM_PATH, \"armada\")):"},{"line_number":315,"context_line":"        return"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"96c74949_d23bac85","line":313,"in_reply_to":"68a99e25_be161bc1","updated":"2022-08-04 19:06:27.000000000","message":"Thank you for the feedback!","commit_id":"170c949a623d1071c9a78951d3b8b3a231e7900b"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"75f3c4d0c65285dc1b912211c53128c63149193e","unresolved":true,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    # Check if the folder exist before migration"},{"line_number":314,"context_line":"    if not os.path.exists(os.path.join(PLATFORM_PATH, \"armada\")):"},{"line_number":315,"context_line":"        return"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    # Copy the entire armada.cfg directory to pick up any changes made"},{"line_number":318,"context_line":"    # after the data was migrated (i.e. updates to the controller-1 load)."}],"source_content_type":"text/x-python","patch_set":2,"id":"e998121b_b22df602","line":315,"updated":"2022-08-04 18:34:44.000000000","message":"Please add a debug log here saying that this migration was avoided because the directory doesn\u0027t exist","commit_id":"170c949a623d1071c9a78951d3b8b3a231e7900b"},{"author":{"_account_id":33684,"name":"Luis Eduardo Bonatti","email":"LuizEduardo.Bonatti@windriver.com","username":"lbonatti"},"change_message_id":"7c0fd6ea30aa6ce87d02faaff60c1b0cb133cd92","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    # Check if the folder exist before migration"},{"line_number":314,"context_line":"    if not os.path.exists(os.path.join(PLATFORM_PATH, \"armada\")):"},{"line_number":315,"context_line":"        return"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    # Copy the entire armada.cfg directory to pick up any changes made"},{"line_number":318,"context_line":"    # after the data was migrated (i.e. updates to the controller-1 load)."}],"source_content_type":"text/x-python","patch_set":2,"id":"17019557_1534fb50","line":315,"in_reply_to":"e998121b_b22df602","updated":"2022-08-04 19:06:27.000000000","message":"Done","commit_id":"170c949a623d1071c9a78951d3b8b3a231e7900b"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"32eef925dc05c192b92c8174d91add73db837e7c","unresolved":true,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    # Check if the folder exist before migration"},{"line_number":311,"context_line":"    if not os.path.exists(os.path.join(PLATFORM_PATH, \"armada\")):"},{"line_number":312,"context_line":"        LOG.debug(\"Avoiding armada migration, the directory doesn\u0027t exist\")"},{"line_number":313,"context_line":"        return"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    LOG.info(\"Migrating armada config\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1861c5b2_d16a3b16","line":312,"range":{"start_line":312,"start_character":19,"end_line":312,"end_character":27},"updated":"2022-08-04 19:55:50.000000000","message":"nit: I\u0027d use \"skipping\" instead, but not big deal","commit_id":"5fee3bcb3e0e1ee5bd70d5ae4ed6a93408d5dc01"},{"author":{"_account_id":33684,"name":"Luis Eduardo Bonatti","email":"LuizEduardo.Bonatti@windriver.com","username":"lbonatti"},"change_message_id":"6fa6030a3d6f08e8bb8d375b658f870cfb3b8546","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    # Check if the folder exist before migration"},{"line_number":311,"context_line":"    if not os.path.exists(os.path.join(PLATFORM_PATH, \"armada\")):"},{"line_number":312,"context_line":"        LOG.debug(\"Avoiding armada migration, the directory doesn\u0027t exist\")"},{"line_number":313,"context_line":"        return"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    LOG.info(\"Migrating armada config\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"768bf69e_cc00061f","line":312,"range":{"start_line":312,"start_character":19,"end_line":312,"end_character":27},"in_reply_to":"1861c5b2_d16a3b16","updated":"2022-08-04 19:58:51.000000000","message":"Yeah, I think is better too.","commit_id":"5fee3bcb3e0e1ee5bd70d5ae4ed6a93408d5dc01"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"a33b295d8da8a482cd9b3dc18e8e583337f7a6de","unresolved":true,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    # Check if the folder exist before migration"},{"line_number":311,"context_line":"    if not os.path.exists(os.path.join(PLATFORM_PATH, \"armada\")):"},{"line_number":312,"context_line":"        LOG.debug(\"Skipping armada migration, the directory doesn\u0027t exist\")"},{"line_number":313,"context_line":"        return"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    LOG.info(\"Migrating armada config\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"73edeb25_adaa5278","line":312,"range":{"start_line":312,"start_character":12,"end_line":312,"end_character":17},"updated":"2022-08-08 16:06:23.000000000","message":"I think this probably can be \u0027info\u0027 instead of \u0027debug\u0027\n(after all, we log \u0027info\u0027 on line 315 when the directory does exist)","commit_id":"f2ee842323c8055b17d88ce7607cbc69f17b74ac"},{"author":{"_account_id":33684,"name":"Luis Eduardo Bonatti","email":"LuizEduardo.Bonatti@windriver.com","username":"lbonatti"},"change_message_id":"38e8bb58656586f79f6c3df1314c0cb46f97d70a","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    # Check if the folder exist before migration"},{"line_number":311,"context_line":"    if not os.path.exists(os.path.join(PLATFORM_PATH, \"armada\")):"},{"line_number":312,"context_line":"        LOG.debug(\"Skipping armada migration, the directory doesn\u0027t exist\")"},{"line_number":313,"context_line":"        return"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    LOG.info(\"Migrating armada config\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"e8860fae_670b0d1b","line":312,"range":{"start_line":312,"start_character":12,"end_line":312,"end_character":17},"in_reply_to":"73edeb25_adaa5278","updated":"2022-08-08 16:24:13.000000000","message":"Done","commit_id":"f2ee842323c8055b17d88ce7607cbc69f17b74ac"}]}