)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"a6e234c4d3a29a676f52775dd57bc135544319e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e64cb4df_307bb1e9","updated":"2022-08-05 16:23:40.000000000","message":"I think it looks ok, but agree with Teresa this is ideal candidate for unit tests","commit_id":"5a717507bc368954c879a128fda12558de1b993b"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"b923d182642fa53ee7b25501e8f47556b2cff026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bac998fd_af332b23","updated":"2022-08-05 14:31:26.000000000","message":"Please add some tox tests for these new naming rules.","commit_id":"5a717507bc368954c879a128fda12558de1b993b"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/interface.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"679cf5068a33de1954fc81bd0b7395235f1a5bfd","unresolved":true,"context_lines":[{"line_number":768,"context_line":"    vlan_id \u003d None"},{"line_number":769,"context_line":"    if iftype \u003d\u003d constants.INTERFACE_TYPE_VLAN:"},{"line_number":770,"context_line":"        vlan_id \u003d interface[\u0027vlan_id\u0027]"},{"line_number":771,"context_line":"    invalidChars_vlan \u003d set(string.punctuation.replace(\"_\", \"\"))"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    if vlan_id is not None:"},{"line_number":774,"context_line":"        # Allow VLAN interfaces to have \".\" in the name"},{"line_number":775,"context_line":"        invalidChars_vlan.remove(\".\")"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    if any(char in invalidChars_vlan for char in ifname) and (vlan_id is not None):"},{"line_number":778,"context_line":"        msg \u003d _(\"Cannot use special characters in vlan interface name.\")"},{"line_number":779,"context_line":"        raise wsme.exc.ClientSideError(msg)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    # Check for invalid characters in other if names"},{"line_number":782,"context_line":"    invalidChars \u003d set(string.punctuation)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ee07051_9afbb100","line":779,"range":{"start_line":771,"start_character":0,"end_line":779,"end_character":43},"updated":"2022-08-10 17:09:36.000000000","message":"as a nit,  since none of the validation occurs unless vlan_is is not None,  a lot of this could have been moved under \nif vlan_id is not None:","commit_id":"95de6d1eb1b900406e6930d5415d0f437c7f0952"}]}