)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6b9ee846826109ad1b4780d5eaf2d785bbbafd45","unresolved":true,"context_lines":[{"line_number":21,"context_line":"end of the process"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Note:"},{"line_number":24,"context_line":"1 the password sychnoization between keyring and keystone"},{"line_number":25,"context_line":"is not included in this review."},{"line_number":26,"context_line":"2 the unit tests will be delivered by another task in this"},{"line_number":27,"context_line":"story."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"0370af85_74f21abb","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":29},"updated":"2022-09-08 20:38:46.000000000","message":"nit: synchronization","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"bc87fe63b83748262da37629354338d977acfc7d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"end of the process"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Note:"},{"line_number":24,"context_line":"1 the password sychnoization between keyring and keystone"},{"line_number":25,"context_line":"is not included in this review."},{"line_number":26,"context_line":"2 the unit tests will be delivered by another task in this"},{"line_number":27,"context_line":"story."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"4d25b6fa_d088ab07","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":29},"in_reply_to":"0370af85_74f21abb","updated":"2022-09-09 14:30:39.000000000","message":"Ack","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"40418cd3f7296c2ede0eb12afbff026abe9e3676","unresolved":true,"context_lines":[{"line_number":23,"context_line":"1 the password synchronization between keyring and keystone"},{"line_number":24,"context_line":"is not included in this review."},{"line_number":25,"context_line":"2. the update of the secure static hieradata is not included"},{"line_number":26,"context_line":"in this change due to upgrade concerns, users need to update"},{"line_number":27,"context_line":"the hieradata manually."},{"line_number":28,"context_line":"3. the unit tests will be delivered by another task in this"},{"line_number":29,"context_line":"story."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"f6181b6a_e0231436","line":26,"range":{"start_line":26,"start_character":40,"end_line":26,"end_character":46},"updated":"2022-09-14 12:18:02.000000000","message":"restore playbook ?","commit_id":"0411772587b223bda38dca628d456db6d0bd6f13"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"46356e0eb7396950b5af9238597f6b0aa6342c2f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"1 the password synchronization between keyring and keystone"},{"line_number":24,"context_line":"is not included in this review."},{"line_number":25,"context_line":"2. the update of the secure static hieradata is not included"},{"line_number":26,"context_line":"in this change due to upgrade concerns, users need to update"},{"line_number":27,"context_line":"the hieradata manually."},{"line_number":28,"context_line":"3. the unit tests will be delivered by another task in this"},{"line_number":29,"context_line":"story."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"96a06575_f33a94b6","line":26,"range":{"start_line":26,"start_character":40,"end_line":26,"end_character":46},"in_reply_to":"dfc0a876_c9b6fc90","updated":"2022-09-14 19:52:38.000000000","message":"ok, this update will be done by the rehome playbook","commit_id":"0411772587b223bda38dca628d456db6d0bd6f13"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"5bd13c93b8f0dec19aa2ee882cfae99ba0732ed8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"1 the password synchronization between keyring and keystone"},{"line_number":24,"context_line":"is not included in this review."},{"line_number":25,"context_line":"2. the update of the secure static hieradata is not included"},{"line_number":26,"context_line":"in this change due to upgrade concerns, users need to update"},{"line_number":27,"context_line":"the hieradata manually."},{"line_number":28,"context_line":"3. the unit tests will be delivered by another task in this"},{"line_number":29,"context_line":"story."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"dfc0a876_c9b6fc90","line":26,"range":{"start_line":26,"start_character":40,"end_line":26,"end_character":46},"in_reply_to":"f6181b6a_e0231436","updated":"2022-09-14 12:26:01.000000000","message":"The subcloud_rehome playbook is currently in charge of that: https://opendev.org/starlingx/ansible-playbooks/src/branch/master/playbookconfig/src/playbooks/roles/rehome-subcloud/update-keystone-data/tasks/migrate_keystone_passwords.yml#L44-L82, we will need to update this task for some missing users(e.g vim, mtce etc.) if we want to rehome a subcloud w/o lock and unlock. Further, if there\u0027s another task need to do so, should be able to do it accordingly.","commit_id":"0411772587b223bda38dca628d456db6d0bd6f13"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"7aa5e1054b1ee4a36972bbfce597c6dc90820c33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ce730d7d_617957aa","updated":"2022-09-01 21:31:09.000000000","message":"recheck","commit_id":"a9d0458e0f2bf0e121b48eeed0950fe7f2ccd26a"}],"sysinv/sysinv/sysinv/sysinv/conductor/keystone_listener.py":[{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"ece780c5ad2ea5b4e483bfd958b2ae137d6244e2","unresolved":true,"context_lines":[{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class NotificationEndpoint(object):"},{"line_number":25,"context_line":"    \"\"\"Task which exposes the API for consuming priority based notifications."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    The Oslo notification framework delivers notifications based on priority to"}],"source_content_type":"text/x-python","patch_set":17,"id":"85609161_5d1bb433","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":35},"updated":"2022-09-14 18:08:57.000000000","message":"this is bad example to break a well designed \"observer pattern\" into a function pointer based callback distributor.\nany changes to one of the observer\u0027s interface require changes to all other observers.","commit_id":"0411772587b223bda38dca628d456db6d0bd6f13"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"171283f4fb9ccc97b2ca7da17d89f38af7d928f2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class NotificationEndpoint(object):"},{"line_number":25,"context_line":"    \"\"\"Task which exposes the API for consuming priority based notifications."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    The Oslo notification framework delivers notifications based on priority to"}],"source_content_type":"text/x-python","patch_set":17,"id":"c9c05bdf_efcaf1de","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":35},"in_reply_to":"85609161_5d1bb433","updated":"2022-09-14 19:28:40.000000000","message":"Ack","commit_id":"0411772587b223bda38dca628d456db6d0bd6f13"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6b9ee846826109ad1b4780d5eaf2d785bbbafd45","unresolved":true,"context_lines":[{"line_number":194,"context_line":"LOCK_APP_AUTO_MANAGE \u003d \u0027AppAutoManageLock\u0027"},{"line_number":195,"context_line":"LOCK_RUNTIME_CONFIG_CHECK \u003d \u0027runtime_config_check\u0027"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"# Keystone users which password change monitored by keystone listener."},{"line_number":198,"context_line":"# TODO(yuxing): there are still several keystone users are not covered by this"},{"line_number":199,"context_line":"# dictionary, e.g. dcorch,dcdbsync, smapi and sysinv etc. Need to consider to"},{"line_number":200,"context_line":"# create puppet class to reload the related service in case their passwords"}],"source_content_type":"text/x-python","patch_set":10,"id":"750b3d18_9583df96","line":197,"range":{"start_line":197,"start_character":17,"end_line":197,"end_character":23},"updated":"2022-09-08 20:38:46.000000000","message":"nit: which are","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"bc87fe63b83748262da37629354338d977acfc7d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"LOCK_APP_AUTO_MANAGE \u003d \u0027AppAutoManageLock\u0027"},{"line_number":195,"context_line":"LOCK_RUNTIME_CONFIG_CHECK \u003d \u0027runtime_config_check\u0027"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"# Keystone users which password change monitored by keystone listener."},{"line_number":198,"context_line":"# TODO(yuxing): there are still several keystone users are not covered by this"},{"line_number":199,"context_line":"# dictionary, e.g. dcorch,dcdbsync, smapi and sysinv etc. Need to consider to"},{"line_number":200,"context_line":"# create puppet class to reload the related service in case their passwords"}],"source_content_type":"text/x-python","patch_set":10,"id":"f67632b1_a5dfc3fb","line":197,"range":{"start_line":197,"start_character":17,"end_line":197,"end_character":23},"in_reply_to":"750b3d18_9583df96","updated":"2022-09-09 14:30:39.000000000","message":"Ack","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6b9ee846826109ad1b4780d5eaf2d785bbbafd45","unresolved":true,"context_lines":[{"line_number":10848,"context_line":""},{"line_number":10849,"context_line":"    @retry(retry_on_result\u003dlambda x: x is False, wait_fixed\u003d5000,"},{"line_number":10850,"context_line":"           stop_max_attempt_number\u003d5)"},{"line_number":10851,"context_line":"    def _clear_config_out_of_date_alarm(self, entity_instance_id):"},{"line_number":10852,"context_line":"        \"\"\"Apply a new config may result a temporary faliur to clear the"},{"line_number":10853,"context_line":""},{"line_number":10854,"context_line":"        config-out-of-date alarm, retry it until success"}],"source_content_type":"text/x-python","patch_set":10,"id":"e1130b06_f19f2439","line":10851,"updated":"2022-09-08 20:38:46.000000000","message":"Are the retries required because of nonresponsive fm-api? How many retries were observed to be required?","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"48dde439aa733fb12c800ac4183c84ff94c6210f","unresolved":false,"context_lines":[{"line_number":10848,"context_line":""},{"line_number":10849,"context_line":"    @retry(retry_on_result\u003dlambda x: x is False, wait_fixed\u003d5000,"},{"line_number":10850,"context_line":"           stop_max_attempt_number\u003d5)"},{"line_number":10851,"context_line":"    def _clear_config_out_of_date_alarm(self, entity_instance_id):"},{"line_number":10852,"context_line":"        \"\"\"Apply a new config may result a temporary faliur to clear the"},{"line_number":10853,"context_line":""},{"line_number":10854,"context_line":"        config-out-of-date alarm, retry it until success"}],"source_content_type":"text/x-python","patch_set":10,"id":"43a370d1_99055b89","line":10851,"in_reply_to":"d1e2a6b2_f943b2e9","updated":"2022-09-12 20:29:45.000000000","message":"Done","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"006dd01f452d868665523a16c8891612f2070285","unresolved":true,"context_lines":[{"line_number":10848,"context_line":""},{"line_number":10849,"context_line":"    @retry(retry_on_result\u003dlambda x: x is False, wait_fixed\u003d5000,"},{"line_number":10850,"context_line":"           stop_max_attempt_number\u003d5)"},{"line_number":10851,"context_line":"    def _clear_config_out_of_date_alarm(self, entity_instance_id):"},{"line_number":10852,"context_line":"        \"\"\"Apply a new config may result a temporary faliur to clear the"},{"line_number":10853,"context_line":""},{"line_number":10854,"context_line":"        config-out-of-date alarm, retry it until success"}],"source_content_type":"text/x-python","patch_set":10,"id":"d1e2a6b2_f943b2e9","line":10851,"in_reply_to":"e1130b06_f19f2439","updated":"2022-09-09 14:31:23.000000000","message":"Yes, during the updating of the fm user password. The fm-api may not responsive in a short while. During my test, max 2 times retry can clean this alarm.","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":32841,"name":"Reinildes Oliveira","display_name":"Rei Oliveira","email":"Reinildes.JoseMateusOliveira@windriver.com","username":"rjosemat"},"change_message_id":"e7fef344387fb555c1ba2fe6c3cc7d477cf29b37","unresolved":true,"context_lines":[{"line_number":10849,"context_line":"    @retry(retry_on_result\u003dlambda x: x is False, wait_fixed\u003d5000,"},{"line_number":10850,"context_line":"           stop_max_attempt_number\u003d5)"},{"line_number":10851,"context_line":"    def _clear_config_out_of_date_alarm(self, entity_instance_id):"},{"line_number":10852,"context_line":"        \"\"\"Apply a new config may result a temporary faliur to clear the"},{"line_number":10853,"context_line":""},{"line_number":10854,"context_line":"        config-out-of-date alarm, retry it until success"},{"line_number":10855,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"36dbbb4c_e6a04183","line":10852,"range":{"start_line":10852,"start_character":53,"end_line":10852,"end_character":59},"updated":"2022-09-07 17:16:49.000000000","message":"failure","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"37bf8fba04d339ea4ffa432e49541bf5ecf3ac31","unresolved":true,"context_lines":[{"line_number":10849,"context_line":"    @retry(retry_on_result\u003dlambda x: x is False, wait_fixed\u003d5000,"},{"line_number":10850,"context_line":"           stop_max_attempt_number\u003d5)"},{"line_number":10851,"context_line":"    def _clear_config_out_of_date_alarm(self, entity_instance_id):"},{"line_number":10852,"context_line":"        \"\"\"Apply a new config may result a temporary faliur to clear the"},{"line_number":10853,"context_line":""},{"line_number":10854,"context_line":"        config-out-of-date alarm, retry it until success"},{"line_number":10855,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"94ecdb76_75eccb8b","line":10852,"range":{"start_line":10852,"start_character":53,"end_line":10852,"end_character":59},"in_reply_to":"36dbbb4c_e6a04183","updated":"2022-09-07 19:15:58.000000000","message":"Ack","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"1811305a1f708107ec52751643a32a27c7e8ba9a","unresolved":false,"context_lines":[{"line_number":10849,"context_line":"    @retry(retry_on_result\u003dlambda x: x is False, wait_fixed\u003d5000,"},{"line_number":10850,"context_line":"           stop_max_attempt_number\u003d5)"},{"line_number":10851,"context_line":"    def _clear_config_out_of_date_alarm(self, entity_instance_id):"},{"line_number":10852,"context_line":"        \"\"\"Apply a new config may result a temporary faliur to clear the"},{"line_number":10853,"context_line":""},{"line_number":10854,"context_line":"        config-out-of-date alarm, retry it until success"},{"line_number":10855,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f1f0708_9b72ad0d","line":10852,"range":{"start_line":10852,"start_character":53,"end_line":10852,"end_character":59},"in_reply_to":"94ecdb76_75eccb8b","updated":"2022-09-08 20:27:02.000000000","message":"Done","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ea5d85a6ca9d3957509f11c44e61d9d4cff91036","unresolved":true,"context_lines":[{"line_number":1758,"context_line":"        admin_context \u003d ctx.RequestContext(\u0027admin\u0027, \u0027admin\u0027, is_admin\u003dTrue)"},{"line_number":1759,"context_line":"        personalities \u003d [constants.CONTROLLER]"},{"line_number":1760,"context_line":"        config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":1761,"context_line":"        if context.user not in KEYSTONE_USER_PASSWORD_UPDATE:"},{"line_number":1762,"context_line":"            # The password update of this user is note expected, do nothing"},{"line_number":1763,"context_line":"            return"},{"line_number":1764,"context_line":"        config_dict \u003d {"},{"line_number":1765,"context_line":"            \"personalities\": personalities,"},{"line_number":1766,"context_line":"            \"classes\": [KEYSTONE_USER_PASSWORD_UPDATE[username]],"}],"source_content_type":"text/x-python","patch_set":11,"id":"01480667_154e1b01","line":1763,"range":{"start_line":1761,"start_character":0,"end_line":1763,"end_character":18},"updated":"2022-09-08 19:31:45.000000000","message":"nit, this doesn\u0027t seem to be necessary, because the listener already check if the user in the event matches what the callback endpoint expects.","commit_id":"200cf231a330a8fb3f6b7c003c0a638917504621"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"1811305a1f708107ec52751643a32a27c7e8ba9a","unresolved":false,"context_lines":[{"line_number":1758,"context_line":"        admin_context \u003d ctx.RequestContext(\u0027admin\u0027, \u0027admin\u0027, is_admin\u003dTrue)"},{"line_number":1759,"context_line":"        personalities \u003d [constants.CONTROLLER]"},{"line_number":1760,"context_line":"        config_uuid \u003d self._config_update_hosts(context, personalities)"},{"line_number":1761,"context_line":"        if context.user not in KEYSTONE_USER_PASSWORD_UPDATE:"},{"line_number":1762,"context_line":"            # The password update of this user is note expected, do nothing"},{"line_number":1763,"context_line":"            return"},{"line_number":1764,"context_line":"        config_dict \u003d {"},{"line_number":1765,"context_line":"            \"personalities\": personalities,"},{"line_number":1766,"context_line":"            \"classes\": [KEYSTONE_USER_PASSWORD_UPDATE[username]],"}],"source_content_type":"text/x-python","patch_set":11,"id":"78cf1e96_a3aed179","line":1763,"range":{"start_line":1761,"start_character":0,"end_line":1763,"end_character":18},"in_reply_to":"01480667_154e1b01","updated":"2022-09-08 20:27:02.000000000","message":"Done.","commit_id":"200cf231a330a8fb3f6b7c003c0a638917504621"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ea5d85a6ca9d3957509f11c44e61d9d4cff91036","unresolved":true,"context_lines":[{"line_number":1766,"context_line":"            \"classes\": [KEYSTONE_USER_PASSWORD_UPDATE[username]],"},{"line_number":1767,"context_line":"        }"},{"line_number":1768,"context_line":"        self._config_apply_runtime_manifest("},{"line_number":1769,"context_line":"            admin_context, config_uuid, config_dict)"},{"line_number":1770,"context_line":""},{"line_number":1771,"context_line":"    def update_remotelogging_config(self, context):"},{"line_number":1772,"context_line":"        \"\"\"Update the remotelogging configuration\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"74766d2a_0ca0e5d0","line":1769,"range":{"start_line":1769,"start_character":12,"end_line":1769,"end_character":25},"updated":"2022-09-08 19:31:45.000000000","message":"Can the context passed in be used (instead of get another one)?","commit_id":"200cf231a330a8fb3f6b7c003c0a638917504621"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"1811305a1f708107ec52751643a32a27c7e8ba9a","unresolved":false,"context_lines":[{"line_number":1766,"context_line":"            \"classes\": [KEYSTONE_USER_PASSWORD_UPDATE[username]],"},{"line_number":1767,"context_line":"        }"},{"line_number":1768,"context_line":"        self._config_apply_runtime_manifest("},{"line_number":1769,"context_line":"            admin_context, config_uuid, config_dict)"},{"line_number":1770,"context_line":""},{"line_number":1771,"context_line":"    def update_remotelogging_config(self, context):"},{"line_number":1772,"context_line":"        \"\"\"Update the remotelogging configuration\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"134ed57d_ef7de21e","line":1769,"range":{"start_line":1769,"start_character":12,"end_line":1769,"end_character":25},"in_reply_to":"74766d2a_0ca0e5d0","updated":"2022-09-08 20:27:02.000000000","message":"Done","commit_id":"200cf231a330a8fb3f6b7c003c0a638917504621"}],"sysinv/sysinv/sysinv/sysinv/puppet/certalarm.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6b9ee846826109ad1b4780d5eaf2d785bbbafd45","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    DC_SERVICE_NAME \u003d \u0027dcmanager\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def get_secure_static_config(self):"},{"line_number":17,"context_line":"        sysinv_kspass \u003d self._get_service_password(self.SYSINV_SERVICE_NAME)"},{"line_number":18,"context_line":"        dc_kspass \u003d self._get_service_password(self.DC_SERVICE_NAME)"},{"line_number":19,"context_line":"        return {"},{"line_number":20,"context_line":"            \u0027sysinv::certalarm::local_keystone_password\u0027: sysinv_kspass,"},{"line_number":21,"context_line":"            \u0027sysinv::certalarm::dc_keystone_password\u0027: dc_kspass,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5e2f23c2_3401f059","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":68},"updated":"2022-09-08 20:38:46.000000000","message":"these are no longer considered static config?","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"8bf94c69bc793133740717c4ac3232231d392589","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    DC_SERVICE_NAME \u003d \u0027dcmanager\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def get_secure_static_config(self):"},{"line_number":17,"context_line":"        sysinv_kspass \u003d self._get_service_password(self.SYSINV_SERVICE_NAME)"},{"line_number":18,"context_line":"        dc_kspass \u003d self._get_service_password(self.DC_SERVICE_NAME)"},{"line_number":19,"context_line":"        return {"},{"line_number":20,"context_line":"            \u0027sysinv::certalarm::local_keystone_password\u0027: sysinv_kspass,"},{"line_number":21,"context_line":"            \u0027sysinv::certalarm::dc_keystone_password\u0027: dc_kspass,"}],"source_content_type":"text/x-python","patch_set":10,"id":"99686155_8781bfa1","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":68},"in_reply_to":"11fb6a87_a2be1df8","updated":"2022-09-13 22:29:05.000000000","message":"Removed the change of the hieradata in this commit, these passwords need to be manually updated(e.g. updated by ansible playbook during subcloud rehoming)","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"03ba59841b04865c35b274dae769ce416f069b00","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    DC_SERVICE_NAME \u003d \u0027dcmanager\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def get_secure_static_config(self):"},{"line_number":17,"context_line":"        sysinv_kspass \u003d self._get_service_password(self.SYSINV_SERVICE_NAME)"},{"line_number":18,"context_line":"        dc_kspass \u003d self._get_service_password(self.DC_SERVICE_NAME)"},{"line_number":19,"context_line":"        return {"},{"line_number":20,"context_line":"            \u0027sysinv::certalarm::local_keystone_password\u0027: sysinv_kspass,"},{"line_number":21,"context_line":"            \u0027sysinv::certalarm::dc_keystone_password\u0027: dc_kspass,"}],"source_content_type":"text/x-python","patch_set":10,"id":"af2b5b41_8240db23","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":68},"in_reply_to":"595a81ef_25927ddc","updated":"2022-09-12 16:16:45.000000000","message":"I saw there\u0027s a comment in: https://opendev.org/starlingx/config/src/branch/master/controllerconfig/controllerconfig/controllerconfig/upgrades/controller.py#L796-L800\nThis section of code looks fine with this commit, and it claims can be remove after stx6.0. Other than that, is there any consideration during migrating the secure_system_config of upgrade?","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"bc87fe63b83748262da37629354338d977acfc7d","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    DC_SERVICE_NAME \u003d \u0027dcmanager\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def get_secure_static_config(self):"},{"line_number":17,"context_line":"        sysinv_kspass \u003d self._get_service_password(self.SYSINV_SERVICE_NAME)"},{"line_number":18,"context_line":"        dc_kspass \u003d self._get_service_password(self.DC_SERVICE_NAME)"},{"line_number":19,"context_line":"        return {"},{"line_number":20,"context_line":"            \u0027sysinv::certalarm::local_keystone_password\u0027: sysinv_kspass,"},{"line_number":21,"context_line":"            \u0027sysinv::certalarm::dc_keystone_password\u0027: dc_kspass,"}],"source_content_type":"text/x-python","patch_set":10,"id":"88dd0011_7750b8c5","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":68},"in_reply_to":"5e2f23c2_3401f059","updated":"2022-09-09 14:30:39.000000000","message":"With the change during migrating a subcloud, I don\u0027t think they are static any longer. Adding them to the secure system config. Is there any other change expected regarding this?","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"16027cefbc0e6a114540db7fb460441de550fff3","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    DC_SERVICE_NAME \u003d \u0027dcmanager\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def get_secure_static_config(self):"},{"line_number":17,"context_line":"        sysinv_kspass \u003d self._get_service_password(self.SYSINV_SERVICE_NAME)"},{"line_number":18,"context_line":"        dc_kspass \u003d self._get_service_password(self.DC_SERVICE_NAME)"},{"line_number":19,"context_line":"        return {"},{"line_number":20,"context_line":"            \u0027sysinv::certalarm::local_keystone_password\u0027: sysinv_kspass,"},{"line_number":21,"context_line":"            \u0027sysinv::certalarm::dc_keystone_password\u0027: dc_kspass,"}],"source_content_type":"text/x-python","patch_set":10,"id":"e1fabeb2_1e607a0a","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":68},"in_reply_to":"88dd0011_7750b8c5","updated":"2022-09-12 14:25:54.000000000","message":"we should have a plan to remove them from the static config (taking into account upgrades implications in config/controllerconfig); since they can now be system configurable.","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"c93c18d3187d5d8829979148811616370ecc2a34","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    DC_SERVICE_NAME \u003d \u0027dcmanager\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def get_secure_static_config(self):"},{"line_number":17,"context_line":"        sysinv_kspass \u003d self._get_service_password(self.SYSINV_SERVICE_NAME)"},{"line_number":18,"context_line":"        dc_kspass \u003d self._get_service_password(self.DC_SERVICE_NAME)"},{"line_number":19,"context_line":"        return {"},{"line_number":20,"context_line":"            \u0027sysinv::certalarm::local_keystone_password\u0027: sysinv_kspass,"},{"line_number":21,"context_line":"            \u0027sysinv::certalarm::dc_keystone_password\u0027: dc_kspass,"}],"source_content_type":"text/x-python","patch_set":10,"id":"11fb6a87_a2be1df8","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":68},"in_reply_to":"af2b5b41_8240db23","updated":"2022-09-12 16:50:09.000000000","message":"I will set my vote as -1 until we figure out if get_secure_static_config  needs to be updated (to an empty method), now that the contents are duplicated in get_secure_system_config\n\nThe hiera for both files will be imported, so presumably last file loaded will have its values used.\n\nCan Bin confirm if we expect or require the two files to have duplicated entries?","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"ab14dc5dfa1b1015dd350ece83ba8f6361778dd9","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    DC_SERVICE_NAME \u003d \u0027dcmanager\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def get_secure_static_config(self):"},{"line_number":17,"context_line":"        sysinv_kspass \u003d self._get_service_password(self.SYSINV_SERVICE_NAME)"},{"line_number":18,"context_line":"        dc_kspass \u003d self._get_service_password(self.DC_SERVICE_NAME)"},{"line_number":19,"context_line":"        return {"},{"line_number":20,"context_line":"            \u0027sysinv::certalarm::local_keystone_password\u0027: sysinv_kspass,"},{"line_number":21,"context_line":"            \u0027sysinv::certalarm::dc_keystone_password\u0027: dc_kspass,"}],"source_content_type":"text/x-python","patch_set":10,"id":"595a81ef_25927ddc","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":68},"in_reply_to":"e1fabeb2_1e607a0a","updated":"2022-09-12 16:04:40.000000000","message":"John,  does this mean that section above needs to have those values removed  (in addition to upgrade concerns)","commit_id":"740dbd6608a8dea8f27fb775d4c2c302441a3e5d"}],"sysinv/sysinv/sysinv/sysinv/tests/conductor/test_manager.py":[{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"ece780c5ad2ea5b4e483bfd958b2ae137d6244e2","unresolved":true,"context_lines":[{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"    def _clear_alarm(self, fm_id, fm_instance):"},{"line_number":1660,"context_line":"        self.alarm_raised \u003d False"},{"line_number":1661,"context_line":"        return True"},{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"    def _get_faults_by_id(self, alarm_id):"},{"line_number":1664,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":17,"id":"07a4c63c_6d1226a4","line":1661,"range":{"start_line":1661,"start_character":8,"end_line":1661,"end_character":19},"updated":"2022-09-14 18:08:57.000000000","message":"can you add a description of why is this added?","commit_id":"0411772587b223bda38dca628d456db6d0bd6f13"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"171283f4fb9ccc97b2ca7da17d89f38af7d928f2","unresolved":false,"context_lines":[{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"    def _clear_alarm(self, fm_id, fm_instance):"},{"line_number":1660,"context_line":"        self.alarm_raised \u003d False"},{"line_number":1661,"context_line":"        return True"},{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"    def _get_faults_by_id(self, alarm_id):"},{"line_number":1664,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":17,"id":"e3ae50a4_12d3bc15","line":1661,"range":{"start_line":1661,"start_character":8,"end_line":1661,"end_character":19},"in_reply_to":"07a4c63c_6d1226a4","updated":"2022-09-14 19:28:40.000000000","message":"Done","commit_id":"0411772587b223bda38dca628d456db6d0bd6f13"}]}